Re: [Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2014-01-04 Thread Luiz Capitulino
On Mon, 16 Dec 2013 16:17:05 +0400 Vladimir Davydov vdavy...@parallels.com wrote: From: Glauber Costa glom...@openvz.org During the past weeks, it became clear to us that the shrinker interface we have right now works very well for some particular types of users, but not that well for

Re: [Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2014-01-04 Thread Luiz Capitulino
On Fri, 20 Dec 2013 18:31:02 +0400 Glauber Costa glom...@gmail.com wrote: I have the exact problem described above for a project I'm working on and this solution seems to solve it well. However, I had a few issues while trying to use this interface. I'll comment on them below, but

Re: [Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2014-01-04 Thread Luiz Capitulino
On Fri, 20 Dec 2013 10:03:32 -0500 Luiz Capitulino lcapitul...@redhat.com wrote: The answer for all of your questions above can be summarized by noting that for the lack of other users (at the time), this patch does the bare minimum for memcg needs. I agree, for instance, that it would

Re: [Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2014-01-04 Thread Luiz Capitulino
On Fri, 20 Dec 2013 20:46:05 +0400 Glauber Costa glom...@gmail.com wrote: On Fri, Dec 20, 2013 at 8:44 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 20 Dec 2013 10:03:32 -0500 Luiz Capitulino lcapitul...@redhat.com wrote: The answer for all of your questions above can be

Re: [Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2014-01-04 Thread Luiz Capitulino
On Fri, 20 Dec 2013 20:58:52 +0400 Glauber Costa glom...@gmail.com wrote: On Fri, Dec 20, 2013 at 8:53 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 20 Dec 2013 20:46:05 +0400 Glauber Costa glom...@gmail.com wrote: On Fri, Dec 20, 2013 at 8:44 PM, Luiz Capitulino

Re: [Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2013-12-20 Thread Glauber Costa
I have the exact problem described above for a project I'm working on and this solution seems to solve it well. However, I had a few issues while trying to use this interface. I'll comment on them below, but please take this more as advice seeking than patch review. This patch extends that

Re: [Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2013-12-20 Thread Glauber Costa
One correction: int vmpressure_register_kernel_event(struct cgroup_subsys_state *css, - void (*fn)(void)) +void (*fn)(void *data, int level), void *data) { - struct vmpressure *vmpr = css_to_vmpressure(css); +

Re: [Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2013-12-20 Thread Vladimir Davydov
On 12/20/2013 06:31 PM, Glauber Costa wrote: I have the exact problem described above for a project I'm working on and this solution seems to solve it well. However, I had a few issues while trying to use this interface. I'll comment on them below, but please take this more as advice seeking

Re: [Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2013-12-20 Thread Glauber Costa
On Fri, Dec 20, 2013 at 8:44 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 20 Dec 2013 10:03:32 -0500 Luiz Capitulino lcapitul...@redhat.com wrote: The answer for all of your questions above can be summarized by noting that for the lack of other users (at the time), this patch

Re: [Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2013-12-20 Thread Glauber Costa
On Fri, Dec 20, 2013 at 8:53 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 20 Dec 2013 20:46:05 +0400 Glauber Costa glom...@gmail.com wrote: On Fri, Dec 20, 2013 at 8:44 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 20 Dec 2013 10:03:32 -0500 Luiz Capitulino

[Devel] [PATCH v14 16/18] vmpressure: in-kernel notifications

2013-12-16 Thread Vladimir Davydov
From: Glauber Costa glom...@openvz.org During the past weeks, it became clear to us that the shrinker interface we have right now works very well for some particular types of users, but not that well for others. The latter are usually people interested in one-shot notifications, that were forced