Re: [Devel] [PATCH v5 6/6] allow for distro-specific fix ups at creation time.

2013-05-19 Thread Kir Kolyshkin
On 05/17/2013 11:54 PM, Glauber Costa wrote: +{ +char buf[STR_SIZE]; + +/* Distributions that don't need the fixup will can stop right here */ +if (!actions || !actions-ct_fixup) +return 0; + +if (snprintf(buf, sizeof(buf), %s/%s, root, /etc/rc3.d/S00vz-fixups.sh) 0)

Re: [Devel] [PATCH v5 6/6] allow for distro-specific fix ups at creation time.

2013-05-18 Thread Glauber Costa
+{ +char buf[STR_SIZE]; + +/* Distributions that don't need the fixup will can stop right here */ +if (!actions || !actions-ct_fixup) +return 0; + +if (snprintf(buf, sizeof(buf), %s/%s, root, /etc/rc3.d/S00vz-fixups.sh) 0) Again and again :( How this snprintf

[Devel] [PATCH v5 6/6] allow for distro-specific fix ups at creation time.

2013-05-17 Thread Glauber Costa
From: Glauber Costa glom...@parallels.com We will need that infrastucture when running with Linux upstream, since some support is very unlikely to ever land in the Kernel. We need to do things like account for the fact that udev may kick in and destroy all the setup we have done for /dev. Since

Re: [Devel] [PATCH v5 6/6] allow for distro-specific fix ups at creation time.

2013-05-17 Thread Kir Kolyshkin
PLease see inline. On 05/17/2013 09:26 AM, Glauber Costa wrote: From: Glauber Costa glom...@parallels.com We will need that infrastucture when running with Linux upstream, since some support is very unlikely to ever land in the Kernel. We need to do things like account for the fact that udev