[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-14 Thread Alexey Dobriyan
On Mon, Apr 13, 2009 at 11:39:51AM -0700, Linus Torvalds wrote: On Mon, 13 Apr 2009, Alexey Dobriyan wrote: Well, in OpenVZ everything is in kernel/cpt/ and prefixed with cpt_ and rst_. So? We're not merging OpenVZ code _either_. This is to give example of other prefixes: cpt_

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-14 Thread Alexey Dobriyan
On Tue, Apr 14, 2009 at 12:26:50AM -0400, Oren Laadan wrote: Alexey Dobriyan wrote: On Thu, Apr 09, 2009 at 10:07:11PM -0700, Dave Hansen wrote: I'm curious how you see these fitting in with the work that we've been doing with Oren. Do you mean to just start a discussion or are you

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-14 Thread Alexey Dobriyan
On Tue, Apr 14, 2009 at 01:46:36AM -0400, Oren Laadan wrote: Some meta comments about this patch set: * Patches 1-9 are cleanups, unrelated to checkpoint/restart. They deserve a separate thread. They will be sent separatedly. * You barely take locks or reference counts to objects that you

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-14 Thread Linus Torvalds
On Tue, 14 Apr 2009, Alexey Dobriyan wrote: We're not merging OpenVZ code _either_. This is to give example of other prefixes: cpt_ and rst_ Are they fine? Do you secretly work for IBM? IBM has a well-known disdain for vowels, and basically refuses to use them for mnemonics (they

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-14 Thread Randy Dunlap
Linus Torvalds wrote: On Tue, 14 Apr 2009, Alexey Dobriyan wrote: We're not merging OpenVZ code _either_. This is to give example of other prefixes: cpt_ and rst_ Are they fine? http://www.rfc-editor.org/rfc/rfc5513.txt Do you secretly work for IBM? IBM has a well-known disdain for

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-14 Thread Linus Torvalds
On Tue, 14 Apr 2009, Randy Dunlap wrote: So let's call it checkpoint and restore. Ok? restart ? Even better (and proving my point that trying to use contractions like rst can be misleading, although I agree with Ingo that the most common mistake would be reset)

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-14 Thread Oren Laadan
Alexey Dobriyan wrote: On Tue, Apr 14, 2009 at 02:08:21PM -0400, Oren Laadan wrote: Alexey Dobriyan wrote: On Tue, Apr 14, 2009 at 12:26:50AM -0400, Oren Laadan wrote: Alexey Dobriyan wrote: On Thu, Apr 09, 2009 at 10:07:11PM -0700, Dave Hansen wrote: I'm curious how you see these fitting

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-14 Thread Alexey Dobriyan
On Tue, Apr 14, 2009 at 03:31:55PM -0400, Oren Laadan wrote: Alexey Dobriyan wrote: On Tue, Apr 14, 2009 at 02:08:21PM -0400, Oren Laadan wrote: Alexey Dobriyan wrote: On Tue, Apr 14, 2009 at 12:26:50AM -0400, Oren Laadan wrote: Alexey Dobriyan wrote: On Thu, Apr 09, 2009 at

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-14 Thread Alexey Dobriyan
* not having CAP_SYS_ADMIN on restart(2) Surely you have read already on the containers mailing list that for the *time being* we attempt to get as far as possible without requiring root privileges, to identify security hot-spots. More or less everything is hotspot. Going back to

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-14 Thread Serge E. Hallyn
Quoting Alexey Dobriyan (adobri...@gmail.com): * not having CAP_SYS_ADMIN on restart(2) Surely you have read already on the containers mailing list that for the *time being* we attempt to get as far as possible without requiring root privileges, to identify security hot-spots.

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Alexey Dobriyan
On Fri, Apr 10, 2009 at 08:06:55AM -0700, Linus Torvalds wrote: On Fri, 10 Apr 2009, Alexey Dobriyan wrote: This is to show how we see C/R and to provoke discussion on number of important issues (mounts, ...). My only initial reaction is that I absolutely hate the naming (not to say I

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Alexey Dobriyan
On Thu, Apr 09, 2009 at 10:07:11PM -0700, Dave Hansen wrote: I'm curious how you see these fitting in with the work that we've been doing with Oren. Do you mean to just start a discussion or are you really proposing these as an alternative to what Oren has been posting? Yes, this is posted as

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Dave Hansen
On Mon, 2009-04-13 at 13:14 +0400, Alexey Dobriyan wrote: [1] Do I inderstand correctly that cookie for shared object is an address on kernel stack? This is obviously unreliable, if yes :-) int objref; ... /* adding 'file' to the hash will keep a reference to

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Dave Hansen
On Mon, 2009-04-13 at 13:14 +0400, Alexey Dobriyan wrote: On Thu, Apr 09, 2009 at 10:07:11PM -0700, Dave Hansen wrote: I'm curious how you see these fitting in with the work that we've been doing with Oren. Do you mean to just start a discussion or are you really proposing these as an

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Linus Torvalds
On Mon, 13 Apr 2009, Alexey Dobriyan wrote: Well, in OpenVZ everything is in kernel/cpt/ and prefixed with cpt_ and rst_. So? We're not merging OpenVZ code _either_. And I think cr_ is super nice prefix: it's short, it's C-like, it reminds about restart part It does no such thing.

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Ingo Molnar
* Linus Torvalds torva...@linux-foundation.org wrote: On Mon, 13 Apr 2009, Alexey Dobriyan wrote: Well, in OpenVZ everything is in kernel/cpt/ and prefixed with cpt_ and rst_. So? We're not merging OpenVZ code _either_. And I think cr_ is super nice prefix: it's short, it's

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Oren Laadan
Alexey Dobriyan wrote: On Thu, Apr 09, 2009 at 10:07:11PM -0700, Dave Hansen wrote: I'm curious how you see these fitting in with the work that we've been doing with Oren. Do you mean to just start a discussion or are you really proposing these as an alternative to what Oren has been

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Oren Laadan
Some meta comments about this patch set: * Patches 1-9 are cleanups, unrelated to checkpoint/restart. They deserve a separate thread. * You barely take locks or reference counts to objects that you later refer to. What if something really bad happens ? * (contd) If you don't take locks, then

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-10 Thread Ingo Molnar
* Alexey Dobriyan adobri...@gmail.com wrote: This is to show how we see C/R and to provoke discussion on number of important issues (mounts, ...). This is small part of long-awaited to be cleanuped code. It's able to restore busyloop on i386 and x86_64 and restore i386 busyloop on

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-10 Thread Alexey Dobriyan
On Fri, Apr 10, 2009 at 10:28:15AM +0200, Ingo Molnar wrote: * Alexey Dobriyan adobri...@gmail.com wrote: This is to show how we see C/R and to provoke discussion on number of important issues (mounts, ...). This is small part of long-awaited to be cleanuped code. It's able to

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-10 Thread Linus Torvalds
On Fri, 10 Apr 2009, Alexey Dobriyan wrote: This is to show how we see C/R and to provoke discussion on number of important issues (mounts, ...). My only initial reaction is that I absolutely hate the naming (not to say I love the code - just to say that I didn't even look at it, because I

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-09 Thread Alexey Dobriyan
On Fri, Apr 10, 2009 at 06:32:07AM +0400, Alexey Dobriyan wrote: This is to show how we see C/R and to provoke discussion on number of important issues (mounts, ...). This is small part of long-awaited to be cleanuped code. It's able to restore busyloop on i386 and x86_64 and restore i386

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-09 Thread Dave Hansen
Hey Alexey, I'm curious how you see these fitting in with the work that we've been doing with Oren. Do you mean to just start a discussion or are you really proposing these as an alternative to what Oren has been posting? -- Dave ___ Containers