[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-23 Thread Andrea Righi
On Wed, Feb 23, 2011 at 01:49:10PM +0900, KAMEZAWA Hiroyuki wrote: On Wed, 23 Feb 2011 00:37:18 +0100 Andrea Righi ari...@develer.com wrote: On Tue, Feb 22, 2011 at 06:06:30PM -0500, Vivek Goyal wrote: On Wed, Feb 23, 2011 at 12:01:47AM +0100, Andrea Righi wrote: On Tue, Feb 22, 2011

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-23 Thread KAMEZAWA Hiroyuki
On Wed, 23 Feb 2011 09:59:11 +0100 Andrea Righi ari...@develer.com wrote: I wonder I can make pc-mem_cgroup to be pc-memid(16bit), then, == static inline struct mem_cgroup *get_memcg_from_pc(struct page_cgroup *pc) { struct cgroup_subsys_state *css =

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Jonathan Corbet
On Tue, 22 Feb 2011 18:12:54 +0100 Andrea Righi ari...@develer.com wrote: The page_cgroup infrastructure, currently available only for the memory cgroup controller, can be used to store the owner of each page and opportunely track the writeback IO. This information is encoded in the upper

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Vivek Goyal
On Tue, Feb 22, 2011 at 06:12:54PM +0100, Andrea Righi wrote: The page_cgroup infrastructure, currently available only for the memory cgroup controller, can be used to store the owner of each page and opportunely track the writeback IO. This information is encoded in the upper 16-bits of the

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Vivek Goyal
On Tue, Feb 22, 2011 at 01:01:45PM -0700, Jonathan Corbet wrote: On Tue, 22 Feb 2011 18:12:54 +0100 Andrea Righi ari...@develer.com wrote: The page_cgroup infrastructure, currently available only for the memory cgroup controller, can be used to store the owner of each page and

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 01:01:45PM -0700, Jonathan Corbet wrote: On Tue, 22 Feb 2011 18:12:54 +0100 Andrea Righi ari...@develer.com wrote: The page_cgroup infrastructure, currently available only for the memory cgroup controller, can be used to store the owner of each page and

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 04:22:53PM -0500, Vivek Goyal wrote: On Tue, Feb 22, 2011 at 06:12:54PM +0100, Andrea Righi wrote: The page_cgroup infrastructure, currently available only for the memory cgroup controller, can be used to store the owner of each page and opportunely track the

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Jonathan Corbet
On Wed, 23 Feb 2011 00:01:47 +0100 Andrea Righi ari...@develer.com wrote: My immediate observation is that you're not really tracking the owner here - you're tracking an opaque 16-bit token known only to the block controller in a field which - if changed by anybody other than the block

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 04:27:29PM -0700, Jonathan Corbet wrote: On Wed, 23 Feb 2011 00:01:47 +0100 Andrea Righi ari...@develer.com wrote: My immediate observation is that you're not really tracking the owner here - you're tracking an opaque 16-bit token known only to the block

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 06:06:30PM -0500, Vivek Goyal wrote: On Wed, Feb 23, 2011 at 12:01:47AM +0100, Andrea Righi wrote: On Tue, Feb 22, 2011 at 01:01:45PM -0700, Jonathan Corbet wrote: On Tue, 22 Feb 2011 18:12:54 +0100 Andrea Righi ari...@develer.com wrote: The page_cgroup

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread KAMEZAWA Hiroyuki
On Wed, 23 Feb 2011 00:37:18 +0100 Andrea Righi ari...@develer.com wrote: On Tue, Feb 22, 2011 at 06:06:30PM -0500, Vivek Goyal wrote: On Wed, Feb 23, 2011 at 12:01:47AM +0100, Andrea Righi wrote: On Tue, Feb 22, 2011 at 01:01:45PM -0700, Jonathan Corbet wrote: On Tue, 22 Feb 2011