[Devel] Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device

2007-09-26 Thread Eric W. Biederman
David Miller [EMAIL PROTECTED] writes: I've put these patches into the just-rebased net-2.6.24 tree. I made a minor modification to the second patch, the out_free_netdev: code in loopback_init() ended like this: out_free_netdev: free_netdev(dev); goto out; return err;

[Devel] Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device

2007-09-18 Thread Peter Waskiewicz
This would be a good opportunity to remove the single-allocated queue struct in netdevice (at the bottom) that we had to put in to accomodate the static loopback. Now we can set it back to a zero element list, and have alloc_netdev_mq() just allocate the number of queues requested, not num_queues

[Devel] Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device

2007-09-17 Thread Stephen Hemminger
On Mon, 17 Sep 2007 15:45:11 +0200 [EMAIL PROTECTED] wrote: From: Daniel Lezcano [EMAIL PROTECTED] Doing this makes loopback.c a better example of how to do a simple network device, and it removes the special case single static allocation of a struct net_device, hopefully making

[Devel] Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device

2007-09-17 Thread Daniel Lezcano
Stephen Hemminger wrote: On Mon, 17 Sep 2007 15:45:11 +0200 [EMAIL PROTECTED] wrote: From: Daniel Lezcano [EMAIL PROTECTED] Doing this makes loopback.c a better example of how to do a simple network device, and it removes the special case single static allocation of a struct net_device,

[Devel] Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device

2007-09-17 Thread David Miller
From: Peter Waskiewicz [EMAIL PROTECTED] Date: Mon, 17 Sep 2007 12:12:24 -0700 This would be a good opportunity to remove the single-allocated queue struct in netdevice (at the bottom) that we had to put in to accomodate the static loopback. Now we can set it back to a zero element list, and

[Devel] Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device

2007-09-17 Thread Eric W. Biederman
David Miller [EMAIL PROTECTED] writes: From: Peter Waskiewicz [EMAIL PROTECTED] Date: Mon, 17 Sep 2007 12:12:24 -0700 This would be a good opportunity to remove the single-allocated queue struct in netdevice (at the bottom) that we had to put in to accomodate the static loopback. Now we