[Devel] Re: [RFC] [PATCH 2/2] cgroups: make procs file writable

2010-06-03 Thread Oleg Nesterov
On 06/03, Ben Blum wrote: On Mon, May 31, 2010 at 07:52:42PM +0200, Oleg Nesterov wrote: OK, the caller has a reference to the argument, leader, + leader = leader-group_leader; But why it is safe to use leader-group_leader if we race with exec? This line means let's try to find

[Devel] Re: [RFC] [PATCH 2/2] cgroups: make procs file writable

2010-06-03 Thread Oleg Nesterov
On 06/03, Ben Blum wrote: On Wed, Jun 02, 2010 at 10:58:55PM +0200, Oleg Nesterov wrote: Hmm. The usage of -thread_group in -can_attach() methods doesn't look safe to me... but currently bool threadgroup is always false. I recall putting a rcu_read_lock() around that part and being assured