[Devel] [PATCH] Fix race between proc_get_inode() and remove_proc_entry()

2007-03-07 Thread Alexey Dobriyan
proc_lookup remove_proc_entry === = lock_kernel(); spin_lock(proc_subdir_lock); [find PDE with refcount 0] spin_unlock(proc_subdir_lock); spin_lock(proc_subdir_lock);

[Devel] Re: [RFC][PATCH 0/7] Resource controllers based on process containers

2007-03-07 Thread Kirill Korotaev
Pavel Emelianov wrote: Balbir Singh wrote: Pavel Emelianov wrote: This patchset adds RSS, accounting and control and limiting the number of tasks and files within container. Based on top of Paul Menage's container subsystem v7 RSS controller includes per-container RSS accounter, reclamation

[Devel] Re: [ckrm-tech] [PATCH 2/7] containers (V7): Cpusets hooked into containers

2007-03-07 Thread Paul Menage
On 3/7/07, Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: It makes sense in the first cpuset patch (cpusets_using_containers.patch), but should be removed in the second cpuset patch (multiuser_container.patch). In the 2nd patch, we use this comparison: if (task_cs(p) != cs)

[Devel] Re: [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Srivatsa Vaddagiri
On Wed, Mar 07, 2007 at 11:00:31PM +0530, Srivatsa Vaddagiri wrote: So we got several choices here. 1. Introduce the container abstraction as is in your patches 2. Extend nsproxy somehow to represent hierarchies 3. Let individual resource controllers that -actually- support hierarchical

[Devel] Re: [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Paul Menage
On 3/7/07, Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: - when you do sys_unshare() or a clone that creates new namespaces, then the task (or its child) will get a new nsproxy that has the rcfs subsystem state associated with the old nsproxy, and one or more namespace pointers cloned to

[Devel] Re: [ckrm-tech] [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Srivatsa Vaddagiri
On Wed, Mar 07, 2007 at 09:29:12AM -0800, Paul Menage wrote: That seems bad. With the current way you're doing it, if I mount hierarchies A and B on /mnt/A and /mnt/B, then initially all tasks are in /mnt/A/tasks and /mnt/B/tasks. If I then create /mnt/A/foo and move a process into it, that

[Devel] Re: [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Paul Menage
On 3/7/07, Serge E. Hallyn [EMAIL PROTECTED] wrote: Quoting Srivatsa Vaddagiri ([EMAIL PROTECTED]): On Tue, Mar 06, 2007 at 06:32:07PM -0800, Paul Menage wrote: I'm not really sure that I see the value of having this be part of nsproxy rather than the previous independent container (and

Re: [Devel] [PATCH 4/4] Use task_pgrp() in autofs/autofs4

2007-03-07 Thread Eric W. Biederman
[EMAIL PROTECTED] writes: | | | I have largely given up on review this patch set until that is fixed. | | I am sending out the patches with the noise cancelled :-) Would like | to send them out to akpm in a few days. | | Unfortunately I won't have a chance to do anything until

[Devel] Re: [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Sam Vilain
Paul Menage wrote: But namespace has well-established historical semantics too - a way of changing the mappings of local names to global objects. This doesn't describe things liek resource controllers, cpusets, resource monitoring, etc. Trying to extend the well-known term namespace to refer

[Devel] Re: [ckrm-tech] [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Eric W. Biederman
Paul Menage [EMAIL PROTECTED] writes: On 3/7/07, Sam Vilain [EMAIL PROTECTED] wrote: But namespace has well-established historical semantics too - a way of changing the mappings of local * to global objects. This accurately describes things liek resource controllers, cpusets, resource

[Devel] Re: [ckrm-tech] [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Paul Menage
On 3/7/07, Eric W. Biederman [EMAIL PROTECTED] wrote: Pretty much. For most of the other cases I think we are safe referring to them as resource controls or resource limits.I know that roughly covers what cpusets and beancounters and ckrm currently do. Plus resource monitoring (which may

[Devel] Re: [ckrm-tech] [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Paul Menage
On 3/7/07, Sam Vilain [EMAIL PROTECTED] wrote: Sorry, I didn't realise I was talking with somebody qualified enough to speak on behalf of the Generally Established Principles of Computer Science. I made sure to check http://en.wikipedia.org/wiki/Namespace

[Devel] Re: [PATCH 1/2] rcfs core patch

2007-03-07 Thread Eric W. Biederman
Srivatsa Vaddagiri [EMAIL PROTECTED] writes: Heavily based on Paul Menage's (inturn cpuset) work. The big difference is that the patch uses task-nsproxy to group tasks for resource control purpose (instead of task-containers). The patch retains the same user interface as Paul Menage's

[Devel] Re: [ckrm-tech] [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Sam Vilain
Paul Menage wrote: I made sure to check [...]wikipedia.org[...] when this argument started ... :-) Wikipedia?! That's not a referen[...] oh bugger it. I've vented enough today and we're on the same page now I think. This is the classic terminology problem between substance and

[Devel] Re: [ckrm-tech] [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Matt Helsley
On Thu, 2007-03-08 at 16:32 +1300, Sam Vilain wrote: snip Kirill, 06032418:36+03: I propose to use namespace naming. 1. This is already used in fs. 2. This is what IMHO suites at least OpenVZ/Eric 3. it has good acronym ns. Right. So, now I'll also throw into the mix: -

[Devel] Re: [ckrm-tech] [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Eric W. Biederman
Sam Vilain [EMAIL PROTECTED] writes: And do we bother changing IPC namespaces or let that one slide? ipc namespaces works (if you worry about tiny details like we put the resource limits for the sysv ipc objects inside the namespace). Probably the most instructive example of this is that you

[Devel] Re: [ckrm-tech] [PATCH 0/2] resource control file system - aka containers on top of nsproxy!

2007-03-07 Thread Eric W. Biederman
Matt Helsley [EMAIL PROTECTED] writes: On Thu, 2007-03-08 at 16:32 +-1300, Sam Vilain wrote: +ADw-snip+AD4 +AD4 Kirill, 06032418:36+-03: +AD4 +AD4 I propose to use +ACI-namespace+ACI naming. +AD4 +AD4 1. This is already used in fs. +AD4 +AD4 2. This is what IMHO suites at least