[Devel] Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: snip +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document what the test is

[Devel] [PATCH] Don't create tunnels with '%' in name.

Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can receive a pre-defined name for a device from the userspace. Since these drivers call the register_netdevice() after this (rtnl_lock is held), the device's name may contain a '%' character. Not sure how bad is this to have a device with

[Devel] Re: [PATCH] Don't limit the number of tunnels with generic name explicitly.

Pavel Emelyanov wrote: Patrick McHardy wrote: Pavel Emelyanov wrote: Patrick McHardy wrote: It would be nicer to replace the entire hand-made name allocation to remove the 100 device limit. Actually, I thought the same, but fixing % in names looks like a BUG-fix for 2.6.25, while removing

[Devel] Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

Nadia Derbey wrote: Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: snip +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might