[Devel] Re: [PATCH 2/3] i/o bandwidth controller infrastructure

2008-06-22 Thread Andrea Righi
Carl Henrik Lunde wrote: Did you consider using token bucket instead of this (leaky bucket?)? I've attached a patch which implements token bucket. Although not as precise as the leaky bucket the performance is better at high bandwidth streaming loads. The leaky bucket stops at around 53

[Devel] Re: v2.6.26-rc7/cgroups: circular locking dependency

2008-06-22 Thread KOSAKI Motohiro
CC'ed Paul Jackson it seems typical ABBA deadlock. I think cpuset use cgrou_lock() by mistake. IMHO, cpuset_handle_cpuhp() sholdn't use cgroup_lock() and shouldn't call rebuild_sched_domains(). - #1 (cgroup_mutex){--..}: [c015a435] __lock_acquire+0xf45/0x1040 [c015a5c8]

[Devel] Re: v2.6.26-rc7/cgroups: circular locking dependency

2008-06-22 Thread Peter Zijlstra
On Mon, 2008-06-23 at 00:34 +0900, KOSAKI Motohiro wrote: CC'ed Paul Jackson it seems typical ABBA deadlock. I think cpuset use cgrou_lock() by mistake. IMHO, cpuset_handle_cpuhp() sholdn't use cgroup_lock() and shouldn't call rebuild_sched_domains(). Looks like Max forgot to test with

[Devel] Re: [PATCH 1/3] i/o bandwidth controller documentation

2008-06-22 Thread Randy Dunlap
--- Original Message --- Thanks Randy, I've applied all your fixes to my local documentation, next patchset version will include them. A few small comments below. +WARNING: per-block device limiting rules always refer to the dev_t device +number. If a block device is unplugged (i.e. a

[Devel] Re: [RFC][v2][patch 0/12][CFQ-cgroup]Yet another I/O bandwidth controlling subsystem for CGroups based on CFQ

2008-06-22 Thread Andrea Righi
Satoshi UCHIDA wrote: Hi, Andrea. Thanks for bug reports. I fix this problem. This problem causes by miss of trace for children groups. Please adopt and test this patch. OK, I can confirm the fix resolves the problem. Tested-by: Andrea Righi [EMAIL PROTECTED] If OK, this amendment

[Devel] Re: [RFC][PATCH][cryo] Save/restore state of unnamed pipes

2008-06-22 Thread Oren Laadan
[EMAIL PROTECTED] wrote: From fd13986de32af31621b1badbcf7bfb5626648e0e Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu [EMAIL PROTECTED] Date: Mon, 16 Jun 2008 18:41:05 -0700 Subject: [PATCH] Save/restore state of unnamed pipes Design: Current Linux kernels provide ability to

[Devel] Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory support.

2008-06-22 Thread Tejun Heo
Hello, Index: linux-mm/fs/sysfs/file.c === --- linux-mm.orig/fs/sysfs/file.c +++ linux-mm/fs/sysfs/file.c @@ -460,9 +460,9 @@ void sysfs_notify(struct kobject *k, cha mutex_lock(sysfs_mutex); if (sd dir) -

[Devel] Re: [PATCH 07/11] sysfs: Implement sysfs_delete_link and sysfs_rename_link

2008-06-22 Thread Tejun Heo
Benjamin Thery wrote: sysfs: Implement sysfs_delete_link and sysfs_rename_link When removing a symlink sysfs_remove_link does not provide enough information to figure out which tagged directory the symlink falls in. So I need sysfs_delete_link which is passed the target of the symlink to

[Devel] Re: [PATCH 09/11] sysfs: add sysfs_ns_exit routine

2008-06-22 Thread Tejun Heo
Benjamin Thery wrote: Add sysfs routine sysfs_ns_exit() to allow a namespace to go away while sysfs is still mounted. The exiting namespace calls this routine and pass it a callback to be called for every sysfs superblocks present. The callback contains the necessary code to clean the

[Devel] Re: [PATCH 10/11] netns: Enable tagging for net_class directories in sysfs

2008-06-22 Thread Tejun Heo
Benjamin Thery wrote: --- linux-mm.orig/fs/sysfs/mount.c +++ linux-mm/fs/sysfs/mount.c @@ -16,6 +16,8 @@ #include linux/mount.h #include linux/pagemap.h #include linux/init.h +#include linux/nsproxy.h +#include net/net_namespace.h #include sysfs.h @@ -78,6 +80,7 @@ static int

[Devel] Re: [PATCH 11/11] sysfs: user namespaces: fix bug with clone(CLONE_NEWUSER) with fairsched

2008-06-22 Thread Tejun Heo
Benjamin Thery wrote: Mark the /sys/kernel/uids directory to be tagged so that processes in different user namespaces can remount /sys and see their own uid listings. Without this patch, having CONFIG_FAIR_SCHED=y makes user namespaces unusable, because when you clone(CLONE_NEWUSER) it