[Devel] Re: Progress of containers at 2.6.32/33?

2010-02-23 Thread Daniel Lezcano
Eric W. Biederman wrote: 2.6.32 is likely to be used widely so I expect everyone's out of tree patches to be updated. As a metric to figuring out which things have worked and which things have not I would like ask all of those who are maintaining out of tree container patches to give some

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread jamal
On Mon, 2010-02-22 at 15:17 -0800, Eric W. Biederman wrote: What I am thinking is: ip ns name route add blah is: fd = open(/var/run/netns/name); sys_setns(fd); /* Like unshare but takes an existing namespace */ /* Then the rest of the existing ip command */ The other two below make some

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread Eric W. Biederman
jamal h...@cyberus.ca writes: On Mon, 2010-02-22 at 15:17 -0800, Eric W. Biederman wrote: What I am thinking is: ip ns name route add blah is: fd = open(/var/run/netns/name); sys_setns(fd); /* Like unshare but takes an existing namespace */ /* Then the rest of the existing ip command */

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread jamal
Added Daniel to the discussion.. On Tue, 2010-02-23 at 06:07 -0800, Eric W. Biederman wrote: jamal h...@cyberus.ca writes: Does the point after sys_setns(fd) allow me to do io inside ns name? Can i do open() and get a fd from ns name? Yes. My intention is that current-nsproxy-net_ns be

[Devel] Re: [RFC] [PATCH 0/2] memcg: per cgroup dirty limit

2010-02-23 Thread Vivek Goyal
On Tue, Feb 23, 2010 at 09:07:04AM +0900, KAMEZAWA Hiroyuki wrote: On Mon, 22 Feb 2010 12:58:33 -0500 Vivek Goyal vgo...@redhat.com wrote: On Mon, Feb 22, 2010 at 11:06:40PM +0530, Balbir Singh wrote: * Vivek Goyal vgo...@redhat.com [2010-02-22 09:27:45]: May be we can

[Devel] Re: [PATCH 2/5] C/R: Basic support for network namespaces and devices (v4)

2010-02-23 Thread Dan Smith
SH the above two hunks change the flow in checkpoint_container(), but SH they don't seem to actually add anything. And I don't see (with a SH quick browse) any later patch in this series changing this either. SH Is this just noise? Ah, yeah, I think that's left over from a previous version where

[Devel] Re: [PATCH 2/5] C/R: Basic support for network namespaces and devices (v4)

2010-02-23 Thread Serge E. Hallyn
Quoting Dan Smith (da...@us.ibm.com): SH the above two hunks change the flow in checkpoint_container(), but SH they don't seem to actually add anything. And I don't see (with a SH quick browse) any later patch in this series changing this either. SH Is this just noise? Ah, yeah, I think

[Devel] Re: [PATCH 2/5] C/R: Basic support for network namespaces and devices (v4)

2010-02-23 Thread Dan Smith
SH But there is no guarantee that the checkpointer is in the netns SH which we would call the 'top level' netns. Which means that, at SH restart, whether or not the devices which are in what we call the SH top level netns are in fact inherited or not, will depend on SH conditions of the

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread Eric W. Biederman
jamal h...@cyberus.ca writes: Added Daniel to the discussion.. On Tue, 2010-02-23 at 06:07 -0800, Eric W. Biederman wrote: jamal h...@cyberus.ca writes: Does the point after sys_setns(fd) allow me to do io inside ns name? Can i do open() and get a fd from ns name? Yes. My intention

[Devel] Re: [PATCH 2/2] memcg: dirty pages instrumentation

2010-02-23 Thread Vivek Goyal
On Tue, Feb 23, 2010 at 10:40:40AM +0100, Andrea Righi wrote: On Mon, Feb 22, 2010 at 11:52:15AM -0500, Vivek Goyal wrote: unsigned long determine_dirtyable_memory(void) { - unsigned long x; - - x = global_page_state(NR_FREE_PAGES) + global_reclaimable_pages(); - + unsigned

[Devel] Re: [RFC] [PATCH 0/2] memcg: per cgroup dirty limit

2010-02-23 Thread Vivek Goyal
On Tue, Feb 23, 2010 at 10:55:55AM +0100, Andrea Righi wrote: On Mon, Feb 22, 2010 at 01:29:34PM -0500, Vivek Goyal wrote: I would't like to add many different interfaces to do the same thing. I'd prefer to choose just one interface and always use it. We just have to define which is the

[Devel] [PATCH] RFC containerized syslog and iptable log dispatching (working stage)

2010-02-23 Thread Jean-Marc Pigeon
Capability to redirect iptable log, in the right containerized syslog_ns, is now fully working. Tried my best to have a very minimal foot-print. BEWARE: patch not done for IPV6 (I can't test it), you are welcome to do it. Signed-off-by: Jean-Marc Pigeon

[Devel] Re: [PATCH 2/2] memcg: dirty pages instrumentation

2010-02-23 Thread Vivek Goyal
On Sun, Feb 21, 2010 at 04:18:45PM +0100, Andrea Righi wrote: [..] diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 0b19943..c9ff1cd 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -137,10 +137,11 @@ static struct prop_descriptor vm_dirties; */ static int

[Devel] Re: [PATCH 2/2] memcg: dirty pages instrumentation

2010-02-23 Thread David Rientjes
On Tue, 23 Feb 2010, Vivek Goyal wrote: Because you have modified dirtyable_memory() and made it per cgroup, I think it automatically takes care of the cases of per cgroup dirty ratio, I mentioned in my previous mail. So we will use system wide dirty ratio to calculate the allowed

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread jamal
On Tue, 2010-02-23 at 12:00 -0800, Eric W. Biederman wrote: That point of the mount to hold a persistent reference to the namespace without using a process. The point of the of the to be written set_ns call is to change the default network namespace of the process such that all future

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread Matt Helsley
On Tue, Feb 23, 2010 at 12:00:55PM -0800, Eric W. Biederman wrote: jamal h...@cyberus.ca writes: Added Daniel to the discussion.. On Tue, 2010-02-23 at 06:07 -0800, Eric W. Biederman wrote: jamal h...@cyberus.ca writes: Does the point after sys_setns(fd) allow me to do io inside

[Devel] Re: [PATCH 1/2] memcg: dirty pages accounting and limiting infrastructure

2010-02-23 Thread KAMEZAWA Hiroyuki
On Tue, 23 Feb 2010 10:28:53 +0100 Andrea Righi ari...@develer.com wrote: On Mon, Feb 22, 2010 at 09:44:42PM +0530, Balbir Singh wrote: [snip] +void mem_cgroup_charge_dirty(struct page *page, + enum zone_stat_item idx, int charge) +{ + struct mem_cgroup *mem; +

[Devel] Re: [RFC] [PATCH 0/2] memcg: per cgroup dirty limit

2010-02-23 Thread KAMEZAWA Hiroyuki
On Tue, 23 Feb 2010 10:12:01 -0500 Vivek Goyal vgo...@redhat.com wrote: On Tue, Feb 23, 2010 at 09:07:04AM +0900, KAMEZAWA Hiroyuki wrote: On Mon, 22 Feb 2010 12:58:33 -0500 Vivek Goyal vgo...@redhat.com wrote: On Mon, Feb 22, 2010 at 11:06:40PM +0530, Balbir Singh wrote: * Vivek

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread Eric W. Biederman
Matt Helsley matth...@us.ibm.com writes: On Tue, Feb 23, 2010 at 12:00:55PM -0800, Eric W. Biederman wrote: jamal h...@cyberus.ca writes: Added Daniel to the discussion.. On Tue, 2010-02-23 at 06:07 -0800, Eric W. Biederman wrote: jamal h...@cyberus.ca writes: Does the point

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread Serge E. Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): Matt Helsley matth...@us.ibm.com writes: On Tue, Feb 23, 2010 at 12:00:55PM -0800, Eric W. Biederman wrote: jamal h...@cyberus.ca writes: Added Daniel to the discussion.. On Tue, 2010-02-23 at 06:07 -0800, Eric W. Biederman

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread Eric W. Biederman
jamal h...@cyberus.ca writes: On Tue, 2010-02-23 at 12:00 -0800, Eric W. Biederman wrote: That point of the mount to hold a persistent reference to the namespace without using a process. The point of the of the to be written set_ns call is to change the default network namespace of the

[Devel] [PATCH -mm] cgroups: fix failure path in cgroup_write_event_control()

2010-02-23 Thread Li Zefan
How to reproduce: # mount -t cgroup -o memory xxx /cgroup # mkdir /cgroup/tmp # ./cgroup_event_listener /cgroup/tmp/cgroup.event_control abc ^C # rmdir /cgroup/tmp # cat /proc/cgroups | grep memory memory 2 2 1 (should be 2 1 1) # umount /cgroup (failed!)

[Devel] Re: [PATCH v2 -mmotm 3/4] cgroups: Add simple listener of cgroup events to documentation

2010-02-23 Thread Li Zefan
+ ret = dprintf(event_control, %d %d %s, efd, cfd, argv[2]); I found it won't return negative value for invalid input, though errno is set properly. try: # ./cgroup_event_listner /cgroup/cgroup.procs abc while strace shows write() does return -1: # strace ./cgroup_event_listner

[Devel] Re: [PATCH v2 -mmotm 1/4] cgroups: Fix race between userspace and kernelspace

2010-02-23 Thread Balbir Singh
* Kirill A. Shutemov kir...@shutemov.name [2010-02-22 17:43:39]: eventfd are used to notify about two types of event: - control file-specific, like crossing memory threshold; - cgroup removing. To understand what really happen, userspace can check if the cgroup still exists. To avoid