[Devel] Re: [PATCH] Clear the objhash before completing restart, but delay free (v2)

2010-11-01 Thread Oren Laadan
Dan, Does this patch solve the performance problem in freeing all the objhash entries upfront (e.g. before letting userspace resume) ? If so, is there still a performance hit for doing the 'clear' portion early before resuming the tasks ? How much does it depend on the complexity of the

[Devel] Re: [PATCH 0/6] Relink unlinked files for checkpoint/restart support

2010-11-01 Thread Oren Laadan
Matt, This is v2, right ? If so, is there a changelog ? Oren. On 09/23/2010 05:53 PM, Matt Helsley wrote: This series enables the relinking of unlinked files for the purpose of enabling checkpoint/restart of tasks with open unlinked files. It relies on Namhyung Kim's sys-wrapper patches to

[Devel] Re: [PATCH] Clear the objhash before completing restart, but delay free (v2)

2010-11-01 Thread Dan Smith
OL Does this patch solve the performance problem in freeing all OL the objhash entries upfront (e.g. before letting userspace OL resume) ? OL If so, is there still a performance hit for doing the 'clear' OL portion early before resuming the tasks ? How much does it OL depend on the complexity

[Devel] Re: [PATCH] Clear the objhash before completing restart, but delay free (v2)

2010-11-01 Thread Oren Laadan
On 11/01/2010 01:01 PM, Dan Smith wrote: OL Does this patch solve the performance problem in freeing all OL the objhash entries upfront (e.g. before letting userspace OL resume) ? OL If so, is there still a performance hit for doing the 'clear' OL portion early before resuming the tasks ?

[Devel] Re: [PATCH 5/8] checkpoint/restart of anonymous hugetlb mappings

2010-11-01 Thread Oren Laadan
On 09/17/2010 04:23 PM, Nathan Lynch wrote: On Thu, 2010-09-16 at 20:44 -0400, Oren Laadan wrote: On 09/14/2010 04:02 PM, Nathan Lynch wrote: Support checkpoint and restore of both private and shared hugepage-backed mappings established via mmap(MAP_HUGETLB). Introduce APIs for checkpoint

[Devel] Re: [PATCH 0/8] checkpoint/restart: sysvshm fixes and hugetlb support

2010-11-01 Thread Oren Laadan
On 10/06/2010 03:43 PM, Nathan Lynch wrote: On Thu, 2010-09-16 at 20:37 -0400, Oren Laadan wrote: Hi Nathan, Thanks for the patch series. For starters, I'll pull patches 1-3 for ckpt-v22-dev. I'll wait for reviews for the others. Well, reviews haven't exactly been pouring in, but I'm

[Devel] Re: [RFC][PATCH][cr]: Mark ghost tasks as detached earlier

2010-11-01 Thread Oren Laadan
On 10/30/2010 03:01 AM, Sukadev Bhattiprolu wrote: From ce9dd2fc7332597d46872f3f8c52ac0806f381d1 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 29 Oct 2010 23:16:10 -0700 Subject: [PATCH 1/1] Mark ghost task as detached earlier During restart() of

[Devel] Re: [PATCH] Clear the objhash before completing restart, but delay free (v2)

2010-11-01 Thread Dan Smith
OL So to be clear: is there a performance issue due to moving the OL cleanup - some or all - to before allowing tasks to resume ? OL (This is what I understood over IRC). Not that I have been able to measure, no. -- Dan Smith IBM Linux Technology Center email: da...@us.ibm.com

[Devel] Re: [PATCH v4 03/11] memcg: create extensible page stat update routines

2010-11-01 Thread Ciju Rajan K
Greg Thelen wrote: Ciju Rajan K c...@linux.vnet.ibm.com writes: Greg Thelen wrote: Replace usage of the mem_cgroup_update_file_mapped() memcg statistic update routine with two new routines: * mem_cgroup_inc_page_stat() * mem_cgroup_dec_page_stat() As before, only the file_mapped

[Devel] Re: [PATCH 0/6] Relink unlinked files for checkpoint/restart support

2010-11-01 Thread Matt Helsley
On Mon, Nov 01, 2010 at 12:38:23PM -0400, Oren Laadan wrote: Matt, This is v2, right ? Nope. I'm still getting ready to post v2. Cheers, -Matt ___ Containers mailing list contain...@lists.linux-foundation.org

[Devel] Re: [PATCH 3/3] net - removing superfluous rcu_read_lock_held check

2010-11-01 Thread Paul Moore
On Mon, 2010-11-01 at 20:15 +0100, Jiri Olsa wrote: hi, the rcu_dereference_check is defined as #define rcu_dereference_check(p, c) \ __rcu_dereference_check((p), rcu_read_lock_held() || (c), __rcu) so the caller does not need to specify rcu_read_lock_held() condition.

[Devel] Re: [PATCH] cgroup: Avoid a memset by using vzalloc

2010-11-01 Thread Paul Menage
On Sat, Oct 30, 2010 at 2:35 PM, Jesper Juhl j...@chaosbits.net wrote: Hi, We can avoid doing a memset in swap_cgroup_swapon() by using vzalloc(). Signed-off-by: Jesper Juhl j...@chaosbits.net Acked-by: Paul Menage men...@google.com ___ Containers

[Devel] Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.

2010-11-01 Thread Minchan Kim
On Tue, Nov 2, 2010 at 4:35 AM, Jesper Juhl j...@chaosbits.net wrote: Hi (please CC me on replies), In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then followed by memset() to zero the memory. This can be more efficiently achieved by using kzalloc() and vzalloc().

[Devel] Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.

2010-11-01 Thread Minchan Kim
On Tue, Nov 2, 2010 at 4:59 AM, Jesper Juhl j...@chaosbits.net wrote: On Mon, 1 Nov 2010, Johannes Weiner wrote: On Mon, Nov 01, 2010 at 08:40:56PM +0100, Jesper Juhl wrote: Hi (please CC me on replies), Apologies to those who receive this multiple times. I screwed up the To: field in

[Devel] Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.

2010-11-01 Thread Balbir Singh
* Jesper Juhl j...@chaosbits.net [2010-11-01 20:40:56]: Hi (please CC me on replies), Apologies to those who receive this multiple times. I screwed up the To: field in my original mail :-( In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then followed by memset()