[Devel] Re: [PATCH 00/10] memcg: Kernel Memory Accounting.

2012-02-28 Thread Glauber Costa
Hi, On 02/27/2012 07:58 PM, Suleiman Souhlal wrote: This patch series introduces kernel memory accounting to memcg. It currently only accounts for slab. It's very similar to the patchset I sent back in October, but with a number of fixes and improvements. There is also overlap with Glauber's

[Devel] Re: [PATCH 01/10] memcg: Kernel memory accounting infrastructure.

2012-02-28 Thread Glauber Costa
On 02/27/2012 07:58 PM, Suleiman Souhlal wrote: Enabled with CONFIG_CGROUP_MEM_RES_CTLR_KMEM. Adds the following files: - memory.kmem.independent_kmem_limit - memory.kmem.usage_in_bytes - memory.kmem.limit_in_bytes Signed-off-by: Suleiman Souhlalsulei...@google.com ---

[Devel] Re: [PATCH 01/10] memcg: Kernel memory accounting infrastructure.

2012-02-28 Thread Glauber Costa
On 02/27/2012 07:58 PM, Suleiman Souhlal wrote: Enabled with CONFIG_CGROUP_MEM_RES_CTLR_KMEM. Adds the following files: - memory.kmem.independent_kmem_limit - memory.kmem.usage_in_bytes - memory.kmem.limit_in_bytes Signed-off-by: Suleiman Souhlalsulei...@google.com ---

[Devel] Re: [PATCH 05/10] memcg: Slab accounting.

2012-02-28 Thread Glauber Costa
On 02/27/2012 07:58 PM, Suleiman Souhlal wrote: Introduce per-cgroup kmem_caches for memcg slab accounting, that get created the first time we do an allocation of that type in the cgroup. If we are not permitted to sleep in that allocation, the cache gets created asynchronously. And then we

[Devel] Re: [PATCH 07/10] memcg: Stop res_counter underflows.

2012-02-28 Thread Glauber Costa
On 02/27/2012 07:58 PM, Suleiman Souhlal wrote: From: Hugh Dickinshu...@google.com If __mem_cgroup_try_charge() goes the bypass route in charging slab (typically when the task has been OOM-killed), that later results in res_counter_uncharge_locked() underflows - a stream of warnings from

[Devel] Re: [PATCH 08/10] memcg: Add CONFIG_CGROUP_MEM_RES_CTLR_KMEM_ACCT_ROOT.

2012-02-28 Thread Glauber Costa
On 02/27/2012 07:58 PM, Suleiman Souhlal wrote: This config option dictates whether or not kernel memory in the root cgroup should be accounted. This may be useful in an environment where everything is supposed to be in a cgroup and accounted for. Large amounts of kernel memory in the root

[Devel] Re: [PATCH 02/10] memcg: Uncharge all kmem when deleting a cgroup.

2012-02-28 Thread Glauber Costa
On 02/27/2012 07:58 PM, Suleiman Souhlal wrote: A later patch will also use this to move the accounting to the root cgroup. Suleiman, Did you do any measurements to figure out how long does it take, average, for dangling caches to go away ? Under memory pressure, let's say

[Devel] Re: [PATCH 0/7] memcg kernel memory tracking

2012-02-28 Thread Glauber Costa
On 02/23/2012 04:18 PM, Ying Han wrote: On Tue, Feb 21, 2012 at 3:34 AM, Glauber Costaglom...@parallels.com wrote: This is a first structured approach to tracking general kernel memory within the memory controller. Please tell me what you think. As previously proposed, one has the option of

[Devel] Re: [PATCH 08/10] memcg: Add CONFIG_CGROUP_MEM_RES_CTLR_KMEM_ACCT_ROOT.

2012-02-28 Thread KAMEZAWA Hiroyuki
On Tue, 28 Feb 2012 15:36:27 -0800 Suleiman Souhlal sulei...@google.com wrote: On Tue, Feb 28, 2012 at 5:34 AM, Glauber Costa glom...@parallels.com wrote: On 02/27/2012 07:58 PM, Suleiman Souhlal wrote: This config option dictates whether or not kernel memory in the root cgroup should be

[Devel] Re: [PATCH 04/10] memcg: Introduce __GFP_NOACCOUNT.

2012-02-28 Thread KAMEZAWA Hiroyuki
On Mon, 27 Feb 2012 14:58:47 -0800 Suleiman Souhlal ssouh...@freebsd.org wrote: This is used to indicate that we don't want an allocation to be accounted to the current cgroup. Signed-off-by: Suleiman Souhlal sulei...@google.com I don't like this. Please add ___GFP_ACCOUNT account this

[Devel] Re: [PATCH 03/10] memcg: Reclaim when more than one page needed.

2012-02-28 Thread KAMEZAWA Hiroyuki
On Mon, 27 Feb 2012 14:58:46 -0800 Suleiman Souhlal ssouh...@freebsd.org wrote: From: Hugh Dickins hu...@google.com mem_cgroup_do_charge() was written before slab accounting, and expects three cases: being called for 1 page, being called for a stock of 32 pages, or being called for a

[Devel] Re: [PATCH 02/10] memcg: Uncharge all kmem when deleting a cgroup.

2012-02-28 Thread KAMEZAWA Hiroyuki
On Mon, 27 Feb 2012 14:58:45 -0800 Suleiman Souhlal ssouh...@freebsd.org wrote: A later patch will also use this to move the accounting to the root cgroup. Signed-off-by: Suleiman Souhlal sulei...@google.com --- mm/memcontrol.c | 30 +- 1 files changed, 29