Re: [Devel] [PATCH] kio_pcs: Compact the logs and make eyes happy
On 11/30/2018 05:57 PM, Pavel Butsykin wrote: > Hmm, __kfuse_trace() duplicates message to debugfs trace, without '\n' Yes, and AFAIS most of the existing messages already come w/o it. > this messages will look weird. We need to fix __kfuse_trace() by adding > concatenation '\n' (or even drop duplication messages to debugsfs/dmesg, > as not a very useful thing). > > On 30.11.2018 17:35, Pavel Butsykin wrote: >> Would you like to fix all FUSE_KTRACE's in the kernel? I see a few more >> FUSE_KTRACE with '\n'. >> >> On 30.11.2018 17:23, Pavel Emelianov wrote: >>> After a recent (b)log (re)work it was noticed that some extra \n-s crept >>> into the classical log files. Indeed, the pstorage TRACE() call appends a >>> \n at the end of each message and so does the kernel code. >>> >>> Sorry for inconvenience. >>> >>> https://pmc.acronis.com/browse/VSTOR-18383 >>> >>> Signed-off-by: Pavel Emelyanov >>> >>> --- >>> >>> diff --git a/fs/fuse/kio/pcs/pcs_map.c b/fs/fuse/kio/pcs/pcs_map.c >>> index 4596454..34fa88c 100644 >>> --- a/fs/fuse/kio/pcs/pcs_map.c >>> +++ b/fs/fuse/kio/pcs/pcs_map.c >>> @@ -1946,7 +1946,7 @@ static int pcs_cslist_submit_read(struct >>> pcs_int_request *ireq, struct pcs_cs_li >>> WRITE_ONCE(csl->read_index, i); >>> WRITE_ONCE(csl->select_stamp, jiffies); >>> >>> - FUSE_KTRACE(ireq->cc->fc, "Selected read map " MAP_FMT " to CS" >>> NODE_FMT "; is_seq=%d\n", MAP_ARGS(ireq->iochunk.map), >>> + FUSE_KTRACE(ireq->cc->fc, "Selected read map " MAP_FMT " to CS" >>> NODE_FMT "; is_seq=%d", MAP_ARGS(ireq->iochunk.map), >>> NODE_ARGS(csl->cs[i].cslink.cs->id), is_seq); >>> pcs_flow_bind_cs(ireq->iochunk.flow, csl->cs[i].cslink.cs); >>> } >>> >> >> ___ >> Devel mailing list >> Devel@openvz.org >> https://lists.openvz.org/mailman/listinfo/devel >> ___ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel
Re: [Devel] [PATCH] kio_pcs: Compact the logs and make eyes happy
Would you like to fix all FUSE_KTRACE's in the kernel? I see a few more FUSE_KTRACE with '\n'. On 30.11.2018 17:23, Pavel Emelianov wrote: > After a recent (b)log (re)work it was noticed that some extra \n-s crept > into the classical log files. Indeed, the pstorage TRACE() call appends a > \n at the end of each message and so does the kernel code. > > Sorry for inconvenience. > > https://pmc.acronis.com/browse/VSTOR-18383 > > Signed-off-by: Pavel Emelyanov > > --- > > diff --git a/fs/fuse/kio/pcs/pcs_map.c b/fs/fuse/kio/pcs/pcs_map.c > index 4596454..34fa88c 100644 > --- a/fs/fuse/kio/pcs/pcs_map.c > +++ b/fs/fuse/kio/pcs/pcs_map.c > @@ -1946,7 +1946,7 @@ static int pcs_cslist_submit_read(struct > pcs_int_request *ireq, struct pcs_cs_li > WRITE_ONCE(csl->read_index, i); > WRITE_ONCE(csl->select_stamp, jiffies); > > - FUSE_KTRACE(ireq->cc->fc, "Selected read map " MAP_FMT " to CS" > NODE_FMT "; is_seq=%d\n", MAP_ARGS(ireq->iochunk.map), > + FUSE_KTRACE(ireq->cc->fc, "Selected read map " MAP_FMT " to CS" > NODE_FMT "; is_seq=%d", MAP_ARGS(ireq->iochunk.map), > NODE_ARGS(csl->cs[i].cslink.cs->id), is_seq); > pcs_flow_bind_cs(ireq->iochunk.flow, csl->cs[i].cslink.cs); > } > ___ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel
[Devel] [PATCH] kio_pcs: Compact the logs and make eyes happy
After a recent (b)log (re)work it was noticed that some extra \n-s crept into the classical log files. Indeed, the pstorage TRACE() call appends a \n at the end of each message and so does the kernel code. Sorry for inconvenience. https://pmc.acronis.com/browse/VSTOR-18383 Signed-off-by: Pavel Emelyanov --- diff --git a/fs/fuse/kio/pcs/pcs_map.c b/fs/fuse/kio/pcs/pcs_map.c index 4596454..34fa88c 100644 --- a/fs/fuse/kio/pcs/pcs_map.c +++ b/fs/fuse/kio/pcs/pcs_map.c @@ -1946,7 +1946,7 @@ static int pcs_cslist_submit_read(struct pcs_int_request *ireq, struct pcs_cs_li WRITE_ONCE(csl->read_index, i); WRITE_ONCE(csl->select_stamp, jiffies); - FUSE_KTRACE(ireq->cc->fc, "Selected read map " MAP_FMT " to CS" NODE_FMT "; is_seq=%d\n", MAP_ARGS(ireq->iochunk.map), + FUSE_KTRACE(ireq->cc->fc, "Selected read map " MAP_FMT " to CS" NODE_FMT "; is_seq=%d", MAP_ARGS(ireq->iochunk.map), NODE_ARGS(csl->cs[i].cslink.cs->id), is_seq); pcs_flow_bind_cs(ireq->iochunk.flow, csl->cs[i].cslink.cs); } ___ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel
