[Devel] Re: [RFC][v8][PATCH 0/10] Implement clone3() system call

2009-10-22 Thread Sukadev Bhattiprolu
even for a short lived process that they wait()s on and thus ensure that pid is not in use. Anyway, is RESERVED_PIDS meant for initial kernel-threads/daemons - if so would it be ok enforce it only in init_pid_ns ? Sukadev ___ Containers mailing list

[Devel] Re: [RFC][v8][PATCH 0/10] Implement clone3() system call

2009-10-23 Thread Sukadev Bhattiprolu
matters at this date, but we have it. Well, since it is not security or other critical restriction, can we allow set_pidmap() a free hand - even in init-pid-ns ? It could prevent a simple subtree C/R of one of the early daemons for debug for instance. Sukadev

[Devel] Re: [RFC][v8][PATCH 0/10] Implement clone3() system call

2009-10-23 Thread Sukadev Bhattiprolu
Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | Eric W. Biederman [ebied...@xmission.com] wrote: | | Anyway, is RESERVED_PIDS meant for initial kernel-threads/daemons - if so | | would it be ok enforce it only in init_pid_ns ? | | | | It is mean for initial user space daemons, things

[Devel] Re: [RFC][v8][PATCH 0/10] Implement clone3() system call

2009-10-23 Thread Sukadev Bhattiprolu
Eric W. Biederman [ebied...@xmission.com] wrote: | +static int set_pidmap(struct pid_namespace *pid_ns, int target) | +{ | + if (!target) | + return alloc_pidmap(pid_ns); BTW, we need this now that the RESERVED_PIDS check is is conditional on -last_pid. But this makes

[Devel] [v9][PATCH 0/9] Implement clone3() system call

2009-10-24 Thread Sukadev Bhattiprolu
implementation for additional clone-flags is best implemented as a separate patchset (PATCH 8/9 identifies some TODOs) Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com ___ Containers mailing list contain...@lists.linux-foundation.org https

[Devel] [v9][PATCH 1/9] Factor out code to allocate pidmap page

2009-10-24 Thread Sukadev Bhattiprolu
place. Even so, moving this code out into a separate function simplifies alloc_pidmap(). Changelog[v2]: - (Matt Helsley, Dave Hansen) Have alloc_pidmap_page() return -ENOMEM on error instead of -1. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked

[Devel] [v9][PATCH 3/9] Define set_pidmap() function

2009-10-24 Thread Sukadev Bhattiprolu
. Changelog[v2]: - (Serge Hallyn) Check for 'pid 0' in set_pidmap().(Code actually checks for 'pid = 0' for completeness). Signed-off-by: Sukadev Bhattiprolu suka...@us.ibm.com --- kernel/pid.c | 40 1 files changed, 32 insertions(+), 8

[Devel] [v9][PATCH 2/9] Have alloc_pidmap() return actual error code

2009-10-24 Thread Sukadev Bhattiprolu
or in use. Rather than have callers assume -ENOMEM, have alloc_pidmap() return the actual error. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked-by: Serge Hallyn se...@us.ibm.com Reviewed-by: Oren Laadan or...@cs.columbia.edu --- kernel/fork.c |5 +++-- kernel/pid.c | 14

[Devel] [v9][PATCH 4/9] Add target_pids parameter to alloc_pid()

2009-10-24 Thread Sukadev Bhattiprolu
Subject: [v9][PATCH 4/9] Add target_pids parameter to alloc_pid() This parameter is currently NULL, but will be used in a follow-on patch. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked-by: Serge Hallyn se...@us.ibm.com Reviewed-by: Oren Laadan or...@cs.columbia.edu

[Devel] [v9][PATCH 5/9] Add target_pids parameter to copy_process()

2009-10-24 Thread Sukadev Bhattiprolu
Subject: [v9][PATCH 5/9] Add target_pids parameter to copy_process() Add a 'target_pids' parameter to copy_process(). The new parameter will be used in a follow-on patch when clone_with_pids() is implemented. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked-by: Serge Hallyn

[Devel] [v9][PATCH 6/9] Check invalid clone flags

2009-10-24 Thread Sukadev Bhattiprolu
]: - Include the unused clone-flag (CLONE_UNUSED) to VALID_CLONE_FLAGS to avoid breaking any applications that may have set it. IOW, this patch/check only applies to clone-flags bits 33 and higher. Changelog[v8]: - New patch in set Signed-off-by: Sukadev Bhattiprolu suka

[Devel] [v9][PATCH 7/9] Define do_fork_with_pids()

2009-10-24 Thread Sukadev Bhattiprolu
]: - To facilitate moving architecture-inpdendent code to kernel/fork.c pass in 'struct target_pid_set __user *' to do_fork_with_pids() rather than 'pid_t *' (next patch moves the arch-independent code to kernel/fork.c) Signed-off-by: Sukadev Bhattiprolu suka

[Devel] [v9][PATCH 8/9] Define clone3() syscall

2009-10-24 Thread Sukadev Bhattiprolu
() Changelog[v1]: - Fixed some compile errors (had fixed these errors earlier in my git tree but had not refreshed patches before emailing them) Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/x86/include/asm/syscalls.h|2 + arch/x86/include/asm

[Devel] [v9][PATCH 9/9] Document clone3() syscall

2009-10-24 Thread Sukadev Bhattiprolu
() - Add notes to say that we return -EINVAL if invalid clone flags are specified or if the reserved fields are not 0. Changelog[v7]: - Rename clone_with_pids() to clone2() - Changes to reflect new prototype of clone2() (using clone_struct). Signed-off-by: Sukadev

[Devel] Re: [PATCH 01/17] ckpt_write_err: use single format with %(T) style tokens

2009-10-30 Thread Sukadev Bhattiprolu
se...@us.ibm.com [se...@us.ibm.com] wrote: | From: Serge E. Hallyn se...@us.ibm.com | | Matt Helsley originally suggested this to avoid having two | format strings. This is not bisect-safe and therefore not | even compile-tested. Every call to ckpt_write_err must be | updated to use a single

[Devel] [v10][PATCH] Implement clone_with_pids() syscall

2009-11-01 Thread Sukadev Bhattiprolu
: While this patchset enables support for more clone-flags, actual implementation for additional clone-flags is best implemented as a separate patchset (PATCH 8/9 identifies some TODOs) Signed-off-by: Sukadev Bhattiprolu suka...@us.ibm.com

[Devel] [v10][PATCH 1/9] Factor out code to allocate pidmap page

2009-11-01 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@us.ibm.com Date: Tue, 20 Oct 2009 21:27:39 -0700 Subject: [v10][PATCH 1/9] Factor out code to allocate pidmap page To simplify alloc_pidmap(), move code to allocate a pid map page to a separate function. Changelog[v3]: - Earlier version of patchset

[Devel] [v10][PATCH 2/9] Have alloc_pidmap() return actual error code

2009-11-01 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@us.ibm.com Date: Tue, 20 Oct 2009 21:29:03 -0700 Subject: [v10][PATCH 2/9] Have alloc_pidmap() return actual error code alloc_pidmap() can fail either because all pid numbers are in use or because memory allocation failed. With support for setting a specific

[Devel] [v10][PATCH 3/9] Define set_pidmap() function

2009-11-01 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu s...@suka.(none) Date: Thu, 22 Oct 2009 16:57:28 -0700 Subject: [v10][PATCH 3/9] Define set_pidmap() function Define a set_pidmap() interface which is like alloc_pidmap() only that caller specifies the pid number to be assigned. Changelog[v9]: - Completely

[Devel] [v10][PATCH 5/9] Add target_pids parameter to copy_process()

2009-11-01 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@us.ibm.com Date: Tue, 20 Oct 2009 21:51:45 -0700 Subject: [v10][PATCH 5/9] Add target_pids parameter to copy_process() Add a 'target_pids' parameter to copy_process(). The new parameter will be used in a follow-on patch when clone_with_pids() is implemented

[Devel] [v10][PATCH 4/9] Add target_pids parameter to alloc_pid()

2009-11-01 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@us.ibm.com Date: Tue, 20 Oct 2009 21:35:07 -0700 Subject: [v10][PATCH 4/9] Add target_pids parameter to alloc_pid() This parameter is currently NULL, but will be used in a follow-on patch. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked

[Devel] [v10][PATCH 7/9] Define do_fork_with_pids()

2009-11-01 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@us.ibm.com Date: Tue, 20 Oct 2009 21:53:39 -0700 Subject: [v10][PATCH 7/9] Define do_fork_with_pids() do_fork_with_pids() is same as do_fork(), except that it takes an additional, 'pid_set', parameter. This parameter, currently unused, specifies the set

[Devel] [v10][PATCH 6/9] Check invalid clone flags

2009-11-01 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@us.ibm.com Date: Tue, 20 Oct 2009 21:52:40 -0700 Subject: [v10][PATCH 6/9] Check invalid clone flags As pointed out by Oren Laadan, we want to ensure that unused bits in the clone-flags remain unused and available for future. To ensure this, define a mask

[Devel] [v10][PATCH 9/9] Document clone_with_pids() syscall

2009-11-01 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu s...@suka.(none) Date: Sun, 25 Oct 2009 20:20:00 -0700 Subject: [v10][PATCH 9/9] Document clone_with_pids() syscall This gives a brief overview of the clone_with_pids() system call. We should eventually describe more details in existing clone(2) man page or in a new

[Devel] [v10][PATCH 8/9] Define clone_with_pids() syscall

2009-11-01 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu s...@suka.(none) Date: Tue, 20 Oct 2009 22:04:57 -0700 Subject: [v10][PATCH 8/9] Define clone_with_pids() syscall Container restart requires that a task have the same pid it had when it was checkpointed. When containers are nested the tasks within the containers exist

[Devel] Re: [v10][PATCH] Implement clone_with_pids() syscall

2009-11-02 Thread Sukadev Bhattiprolu
, then eclone(), clonex() or even clone_extended() are about as descriptive as clone3() IMHO. Given the discussion about ckpt v. checkpoint, I would like to go with a descriptive name. Sukadev ___ Containers mailing list contain...@lists.linux-foundation.org

[Devel] Re: [v10][PATCH 8/9] Define clone_with_pids() syscall

2009-11-02 Thread Sukadev Bhattiprolu
; }; sys_clone_with_pids(u32 flags_low, struct clone_args *cargs, u32 nr_pids, u32 clone_args_size) Sukadev ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: [v10][PATCH 8/9] Define clone_with_pids() syscall

2009-11-03 Thread Sukadev Bhattiprolu
Dave Hansen [d...@linux.vnet.ibm.com] wrote: | On Sun, 2009-11-01 at 12:45 -0800, Sukadev Bhattiprolu wrote: | +int sys_clone_with_pids(struct pt_regs *regs) | +{ | ... | + rc = copy_from_user(kcs, ucs, sizeof(kcs)); | + if (rc) | + return -EFAULT

[Devel] Re: [v10][PATCH 8/9] Define clone_with_pids() syscall

2009-11-03 Thread Sukadev Bhattiprolu
is the updated patch addressing your comment and Oren's comment about making 'clone_args_size' a parameter. There are corresponding minor changes to the Documentation patch which I will post later. --- From 3779f8bc34189fcc32df1c78504bd42ec2dfc566 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu s

[Devel] Re: [v11][PATCH 8/9] Define clone_with_pids() syscall

2009-11-07 Thread Sukadev Bhattiprolu
Serge E. Hallyn [se...@us.ibm.com] wrote: | Quoting Sukadev Bhattiprolu (suka...@us.ibm.com): | + stack_size = (unsigned long)kca.child_stack_size; | + child_stack = (unsigned long)kca.child_stack_base + stack_size; | + | + if (!child_stack) | + child_stack = regs-sp; | | I'm

[Devel] [v12][PATCH 1/9] Factor out code to allocate pidmap page

2009-11-10 Thread Sukadev Bhattiprolu
place. Even so, moving this code out into a separate function simplifies alloc_pidmap(). Changelog[v2]: - (Matt Helsley, Dave Hansen) Have alloc_pidmap_page() return -ENOMEM on error instead of -1. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked

[Devel] [v12][PATCH 4/9] Add target_pids parameter to alloc_pid()

2009-11-10 Thread Sukadev Bhattiprolu
Subject: [v12][PATCH 4/9] Add target_pids parameter to alloc_pid() This parameter is currently NULL, but will be used in a follow-on patch. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked-by: Serge Hallyn se...@us.ibm.com Reviewed-by: Oren Laadan or...@cs.columbia.edu

[Devel] [v12][PATCH 7/9] Define do_fork_with_pids()

2009-11-10 Thread Sukadev Bhattiprolu
]: - To facilitate moving architecture-inpdendent code to kernel/fork.c pass in 'struct target_pid_set __user *' to do_fork_with_pids() rather than 'pid_t *' (next patch moves the arch-independent code to kernel/fork.c) Signed-off-by: Sukadev Bhattiprolu suka

[Devel] [v12][PATCH 5/9] Add target_pids parameter to copy_process()

2009-11-10 Thread Sukadev Bhattiprolu
Subject: [v12][PATCH 5/9] Add target_pids parameter to copy_process() Add a 'target_pids' parameter to copy_process(). The new parameter will be used in a follow-on patch when eclone() is implemented. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked-by: Serge Hallyn se

[Devel] [v12][PATCH 9/9] Document eclone() syscall

2009-11-10 Thread Sukadev Bhattiprolu
clone_struct). Signed-off-by: Sukadev Bhattiprolu suka...@vnet.linux.ibm.com Acked-by: Oren Laadan or...@cs.columbia.edu --- Documentation/eclone | 345 ++ 1 files changed, 345 insertions(+), 0 deletions(-) create mode 100644 Documentation/eclone diff --git

[Devel] [v12][PATCH 6/9] Check invalid clone flags

2009-11-10 Thread Sukadev Bhattiprolu
]: - Include the unused clone-flag (CLONE_UNUSED) to VALID_CLONE_FLAGS to avoid breaking any applications that may have set it. IOW, this patch/check only applies to clone-flags bits 33 and higher. Changelog[v8]: - New patch in set Signed-off-by: Sukadev Bhattiprolu suka

[Devel] [v12][PATCH 8/9] Define eclone() syscall

2009-11-10 Thread Sukadev Bhattiprolu
) into kernel/fork.c and simplify sys_clone_with_pids() Changelog[v1]: - Fixed some compile errors (had fixed these errors earlier in my git tree but had not refreshed patches before emailing them) Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked-by: Oren Laadan

[Devel] [v12][PATCH 0/9] Implement eclone() syscall

2009-11-10 Thread Sukadev Bhattiprolu
as a separate patchset (PATCH 8/9 identifies some TODOs) Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: [v12][PATCH 0/9] Implement eclone() syscall

2009-11-11 Thread Sukadev Bhattiprolu
Cc: LKML Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | | Based on discussions on containers mailing list and IRC, we settled on | the name eclone(). Please let me know of a better name or if there are | other comments on the patchset. | | --- | | Subject: [v12][PATCH 0/9] Implement

[Devel] Re: [v12][PATCH 1/9] Factor out code to allocate pidmap page

2009-11-11 Thread Sukadev Bhattiprolu
Cc LKML Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | | Subject: [v12][PATCH 1/9] Factor out code to allocate pidmap page | | To simplify alloc_pidmap(), move code to allocate a pid map page to a | separate function. | | Changelog[v3]: | - Earlier version of patchset called

[Devel] Re: [v12][PATCH 3/9] Define set_pidmap() function

2009-11-11 Thread Sukadev Bhattiprolu
Cc: LKML Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | | Subject: [v12][PATCH 3/9] Define set_pidmap() function | | Define a set_pidmap() interface which is like alloc_pidmap() only that | caller specifies the pid number to be assigned. | | Changelog[v9]: | - Completely

[Devel] Re: [v12][PATCH 7/9] Define do_fork_with_pids()

2009-11-11 Thread Sukadev Bhattiprolu
cc: lkml Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | | Subject: [v12][PATCH 7/9] Define do_fork_with_pids() | | do_fork_with_pids() is same as do_fork(), except that it takes an | additional, 'pid_set', parameter. This parameter, currently unused, | specifies the set of target

[Devel] Re: [v12][PATCH 4/9] Add target_pids parameter to alloc_pid()

2009-11-11 Thread Sukadev Bhattiprolu
Cc: LKML Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | | Subject: [v12][PATCH 4/9] Add target_pids parameter to alloc_pid() | | This parameter is currently NULL, but will be used in a follow-on patch. | | Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com | Acked

[Devel] Re: [v12][PATCH 5/9] Add target_pids parameter to copy_process()

2009-11-11 Thread Sukadev Bhattiprolu
CC: LKML Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | | Subject: [v12][PATCH 5/9] Add target_pids parameter to copy_process() | | Add a 'target_pids' parameter to copy_process(). The new parameter will be | used in a follow-on patch when eclone() is implemented. | | Signed-off

[Devel] Re: [v12][PATCH 6/9] Check invalid clone flags

2009-11-11 Thread Sukadev Bhattiprolu
Cc: LKML Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | | Subject: [v12][PATCH 6/9] Check invalid clone flags | | As pointed out by Oren Laadan, we want to ensure that unused bits in the | clone-flags remain unused and available for future. To ensure this, define | a mask of clone

[Devel] Re: [v12][PATCH 8/9] Define eclone() syscall

2009-11-11 Thread Sukadev Bhattiprolu
cc: lkml Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | | Subject: [v12][PATCH 8/9] Define eclone() syscall | | Container restart requires that a task have the same pid it had when it was | checkpointed. When containers are nested the tasks within the containers | exist in multiple

[Devel] Re: [v12][PATCH 9/9] Document eclone() syscall

2009-11-11 Thread Sukadev Bhattiprolu
CC: LKML Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | | Subject: [v12][PATCH 9/9] Document eclone() syscall | | This gives a brief overview of the eclone() system call. We should | eventually describe more details in existing clone(2) man page or in | a new man page

[Devel] Re: [v12][PATCH 8/9] Define eclone() syscall

2009-11-12 Thread Sukadev Bhattiprolu
(Trimmed Cc to Containers list). Updated patch to ignore -child_stack_size on architectures that don't need it. --- From e1e9b0b6eb511058961c1fb526f44b597790bfd7 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu s...@suka.(none) Date: Tue, 20 Oct 2009 22:04:57 -0700 Subject: [v13][PATCH 8/9

[Devel] Re: [v12][PATCH 9/9] Document eclone() syscall

2009-11-12 Thread Sukadev Bhattiprolu
(Trimmed Cc to Containers list) Updated patch to ignore 'child_stack_size' on architectures that don't need it (see changelog v13). --- From f87cceae72c2032d67e7855953c0f702957f723a Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@us.ibm.com Date: Thu, 12 Nov 2009 15:00:38 -0800

[Devel] [PATCH] devpts_get_tty() should validate inode

2009-11-17 Thread Sukadev Bhattiprolu
program (see below) to reproduce a crash on recent kernels. This crash is a regression introduced by the commit: commit 527b3e4773628b30d03323a2cb5fb0d84441990f Author: Sukadev Bhattiprolu suka...@us.ibm.com Date: Mon Oct 13 10:43:08 2008 +0100 To fix, ensure

[Devel] Re: [v12][PATCH 0/9] Implement eclone() syscall

2009-11-19 Thread Sukadev Bhattiprolu
Arnd Bergmann [a...@arndb.de] wrote: | On Wednesday 11 November 2009, Sukadev Bhattiprolu wrote: | Based on these requirements and constraints, we explored a couple of system | call interfaces (in earlier versions of this patchset). Based on input from | Arnd Bergmann and others, the new

[Devel] Re: [RFC][PATCH] clone_with_pids()^w eclone() for x86_64

2009-11-19 Thread Sukadev Bhattiprolu
) to the clobbered list, but is the missing the fourth, %edi. Sukadev | 3. r10 and r11 should be listed as clobbered. | | 4. I fail to see the magic that puts the subthread function pointer in the |stack. | | 5. Maybe rdi should contain the subthread argument before calling the subthread

[Devel] [v13][PATCH 00/12] Implement eclone() system call

2009-11-24 Thread Sukadev Bhattiprolu
implementation for additional clone-flags is best implemented as a separate patchset (PATCH 8/9 identifies some TODOs) Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com ___ Containers mailing list contain...@lists.linux-foundation.org https

[Devel] [v13][PATCH 04/12] Add target_pids parameter to alloc_pid()

2009-11-24 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 04/12] Add target_pids parameter to alloc_pid() This parameter is currently NULL, but will be used in a follow-on patch. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked-by: Serge Hallyn se

[Devel] [v13][PATCH 05/12] Add target_pids parameter to copy_process()

2009-11-24 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 05/12] Add target_pids parameter to copy_process() Add a 'target_pids' parameter to copy_process(). The new parameter will be used in a follow-on patch when eclone() is implemented. Signed-off-by: Sukadev Bhattiprolu

[Devel] [v13][PATCH 03/12] Define set_pidmap() function

2009-11-24 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 03/12] Define set_pidmap() function Define a set_pidmap() interface which is like alloc_pidmap() only that caller specifies the pid number to be assigned. Changelog[v13]: - Don't let do_alloc_pidmap return 0

[Devel] [v13][PATCH 06/12] Check invalid clone flags

2009-11-24 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 06/12] Check invalid clone flags As pointed out by Oren Laadan, we want to ensure that unused bits in the clone-flags remain unused and available for future. To ensure this, define a mask of clone-flags and check the flags

[Devel] [v13][PATCH 07/12] Define do_fork_with_pids()

2009-11-24 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 07/12] Define do_fork_with_pids() do_fork_with_pids() is same as do_fork(), except that it takes an additional, 'pid_set', parameter. This parameter, currently unused, specifies the set of target pids of the process

[Devel] [v13][PATCH 08/12] Implement sys_eclone for x86

2009-11-24 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 08/12] Implement sys_eclone for x86 Container restart requires that a task have the same pid it had when it was checkpointed. When containers are nested the tasks within the containers exist in multiple pid namespaces

[Devel] [v13][PATCH 01/12] Factor out code to allocate pidmap page

2009-11-24 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 01/12] Factor out code to allocate pidmap page To simplify alloc_pidmap(), move code to allocate a pid map page to a separate function. Changelog[v3]: - Earlier version of patchset called alloc_pidmap_page() from

[Devel] [v13][PATCH 10/12] Implement sys_eclone for s390

2009-11-24 Thread Sukadev Bhattiprolu
From: Serge E. Hallyn se...@us.ibm.com Subject: [v13][PATCH 10/12] Implement sys_eclone for s390 Implement the s390 hook for sys_eclone(). Changelog: Nov 24: Removed user-space code from commit log. See user-cr git tree. Nov 17: remove redundant flags_high check Nov 13:

[Devel] [v13][PATCH 11/12] Implement sys_eclone for powerpc

2009-11-24 Thread Sukadev Bhattiprolu
From: Nathan Lynch n...@pobox.com Subject: [v13][PATCH 11/12] Implement sys_eclone for powerpc Wired up for both ppc32 and ppc64, but tested only with the latter. Changelog: Nov 17: (serge) remove redundant flags_high check, and don't fold it into flags. Signed-off-by:

[Devel] [v13][PATCH 09/12] Implement sys_eclone for x86_64

2009-11-24 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 09/12] Implement sys_eclone for x86_64 Implement sys_eclone() system call for x86_64. This is based on earlier code from Dave Hansen. Modified to share code between x86 and x86_64 kernels. Signed-off-by: Sukadev

[Devel] [v13][PATCH 12/12] Document sys_eclone

2009-11-24 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 12/12] Document sys_eclone This gives a brief overview of the eclone() system call. We should eventually describe more details in existing clone(2) man page or in a new man page. Changelog[v13]: - [Nathan Lynch

[Devel] [v13][PATCH 02/12] Have alloc_pidmap() return actual error code

2009-11-24 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 02/12] Have alloc_pidmap() return actual error code alloc_pidmap() can fail either because all pid numbers are in use or because memory allocation failed. With support for setting a specific pid number, alloc_pidmap

[Devel] [v13][PATCH 00/12] Implement eclone() system call

2009-11-25 Thread Sukadev Bhattiprolu
enables support for more clone-flags, actual implementation for additional clone-flags is best implemented as a separate patchset (PATCH 8/9 identifies some TODOs) Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com ___ Containers

[Devel] [v13][PATCH 01/12] Factor out code to allocate pidmap page

2009-11-25 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 01/12] Factor out code to allocate pidmap page To simplify alloc_pidmap(), move code to allocate a pid map page to a separate function. Changelog[v3]: - Earlier version of patchset called alloc_pidmap_page() from

[Devel] [v13][PATCH 02/12] Have alloc_pidmap() return actual error code

2009-11-25 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 02/12] Have alloc_pidmap() return actual error code alloc_pidmap() can fail either because all pid numbers are in use or because memory allocation failed. With support for setting a specific pid number, alloc_pidmap

[Devel] [v13][PATCH 03/12] Define set_pidmap() function

2009-11-25 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 03/12] Define set_pidmap() function Define a set_pidmap() interface which is like alloc_pidmap() only that caller specifies the pid number to be assigned. Changelog[v13]: - Don't let do_alloc_pidmap return 0

[Devel] [v13][PATCH 04/12] Add target_pids parameter to alloc_pid()

2009-11-25 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 04/12] Add target_pids parameter to alloc_pid() This parameter is currently NULL, but will be used in a follow-on patch. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked-by: Serge Hallyn se

[Devel] [v13][PATCH 05/12] Add target_pids parameter to copy_process()

2009-11-25 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 05/12] Add target_pids parameter to copy_process() Add a 'target_pids' parameter to copy_process(). The new parameter will be used in a follow-on patch when eclone() is implemented. Signed-off-by: Sukadev Bhattiprolu

[Devel] [v13][PATCH 06/12] Check invalid clone flags

2009-11-25 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 06/12] Check invalid clone flags As pointed out by Oren Laadan, we want to ensure that unused bits in the clone-flags remain unused and available for future. To ensure this, define a mask of clone-flags and check the flags

[Devel] [v13][PATCH 07/12] Define do_fork_with_pids()

2009-11-25 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 07/12] Define do_fork_with_pids() do_fork_with_pids() is same as do_fork(), except that it takes an additional, 'pid_set', parameter. This parameter, currently unused, specifies the set of target pids of the process

[Devel] [v13][PATCH 08/12] Implement sys_eclone for x86

2009-11-25 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 08/12] Implement sys_eclone for x86 Container restart requires that a task have the same pid it had when it was checkpointed. When containers are nested the tasks within the containers exist in multiple pid namespaces

[Devel] [v13][PATCH 09/12] Implement sys_eclone for x86_64

2009-11-25 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 09/12] Implement sys_eclone for x86_64 Implement sys_eclone() system call for x86_64. This is based on earlier code from Dave Hansen. Modified to share code between x86 and x86_64 kernels. Signed-off-by: Sukadev

[Devel] [v13][PATCH 10/12] Implement sys_eclone for s390

2009-11-25 Thread Sukadev Bhattiprolu
From: Serge E. Hallyn se...@us.ibm.com Subject: [v13][PATCH 10/12] Implement sys_eclone for s390 Implement the s390 hook for sys_eclone(). Changelog: Nov 24: Removed user-space code from commit log. See user-cr git tree. Nov 17: remove redundant flags_high check Nov 13:

[Devel] [v13][PATCH 11/12] Implement sys_eclone for powerpc

2009-11-25 Thread Sukadev Bhattiprolu
From: Nathan Lynch n...@pobox.com Subject: [v13][PATCH 11/12] Implement sys_eclone for powerpc Wired up for both ppc32 and ppc64, but tested only with the latter. Changelog: Nov 17: (serge) remove redundant flags_high check, and don't fold it into flags. Signed-off-by:

[Devel] [v13][PATCH 12/12] Document sys_eclone

2009-11-25 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Subject: [v13][PATCH 12/12] Document sys_eclone This gives a brief overview of the eclone() system call. We should eventually describe more details in existing clone(2) man page or in a new man page. Changelog[v13]: - [Nathan Lynch

[Devel] [PATCH][cr-tests] Have ps list all threads in application

2009-12-10 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 8 Dec 2009 23:13:05 +0530 Subject: [PATCH 1/4] Have ps list all threads in application Have ps list all threads in application Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- process-tree/run-pthread1.sh | 14

[Devel] [PATCH][cr-tests] Have threads wait in pthread_cond_wait()

2009-12-10 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Wed, 9 Dec 2009 10:09:08 +0530 Subject: [PATCH] Have threads wait in pthread_cond_wait() Rather than sleep() have the threads wait in pthread_cond_wait() for the checkpoint and ensure they are properly signalled after restart. Also add

[Devel] [PATCH][cr-tests] Ensure pthread stack attributes are restored

2009-12-10 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Wed, 9 Dec 2009 18:31:47 +0530 Subject: [PATCH] Ensure pthread stack attributes are restored Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- process-tree/Makefile|2 +- process-tree/pthread2.c | 244

[Devel] [PATCH] /cgroup/pid may already exist

2009-12-10 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 11 Dec 2009 09:36:05 +0530 Subject: [PATCH] /cgroup/pid may already exist If the process is created with -g, the /cgroup/pid directory would be created automatically. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com

[Devel] Re: [PATCH][cr-tests] Ensure pthread stack attributes are restored

2009-12-11 Thread Sukadev Bhattiprolu
Serge E. Hallyn [se...@us.ibm.com] wrote: | Quoting Sukadev Bhattiprolu (suka...@linux.vnet.ibm.com): | +++ b/process-tree/run-pthread2.sh | @@ -0,0 +1,206 @@ | +#!/bin/bash | + | +source ../common.sh | + | +#dir=`mktemp -p . -d -t cr_pthread2_XXX` || (echo mktemp failed; exit 1

[Devel] [PATCH][cr-tests] pthread3: Ensure thread state is consistent across C/R

2010-01-08 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 8 Jan 2010 11:30:23 -0800 Subject: [PATCH] pthread3: Ensure thread state is consistent across C/R Specifically, this test ensures that concurrency, thread-specific-info and scheduling parameters are consistent across checkpoint

[Devel] [PATCH][cr-tests] pthread4: Ensure mutexes are consistent across C/R

2010-01-08 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 8 Jan 2010 10:56:38 -0800 Subject: [PATCH] pthread4: Ensure mutexes are consistent across C/R Pthread mutex (not) held at checkpoint must continue to be (not) held after restart. Signed-off-by: Sukadev Bhattiprolu suka

[Devel] [PATCH][cr-test]: filelock1: Test restore of adivsory locks during restart

2010-01-20 Thread Sukadev Bhattiprolu
-files: error out on file locks and leases --- From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 15 Jan 2010 15:33:55 -0800 Subject: [PATCH] filelock1: Test restore of adivsory locks during restart Test that any byte-range locks held by a process at the time of checkpoint are restored

[Devel] [PATCH][cr-test]: fileio1 - Keep logfile open

2010-01-20 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Wed, 20 Jan 2010 14:31:14 -0800 Subject: [PATCH]: fileio1 - Keep logfile open In an attempt to close any as-yet uncheckpointable files that are open, the test case closes all files. But in the process even the log file (which

[Devel] Re: [PATCH linux-cr] x86-32 and ia32 eclone, checkpoint, restart fixes

2010-01-22 Thread Sukadev Bhattiprolu
, and in 32-bit mode on x86-64. (restart has not | yet been tested) | | Signed-off-by: Serge E. Hallyn se...@us.ibm.com Reviewed-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com ___ Containers mailing list contain...@lists.linux-foundation.org https

[Devel] [PATCH 01/11] runtests.sh: Make test bit more generic

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 22 Jan 2010 11:53:01 -0800 Subject: [PATCH 01/11] runtests.sh: Make test bit more generic Remove hardcoding of test case name so it is a bit more generic (although other test cases can't use this script as is). Signed-off

[Devel] [PATCH 02/11] Make runtests.sh a wrapper for fileio tests

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 22 Jan 2010 11:55:45 -0800 Subject: [PATCH 02/11] Make runtests.sh a wrapper for fileio tests Move runtests.sh to run-fileio1.sh and create a runtests.sh that runs both run-fileio1.sh and run-filelock1.sh. It can later be extended

[Devel] [PATCH 03/11] Check for failure while waiting for checkpoint-ready

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Mon, 25 Jan 2010 18:09:50 -0800 Subject: [PATCH 03/11] Check for failure while waiting for checkpoint-ready It is possible that an application has encountered an error before creating the checkpoint-ready file. So while polling

[Devel] [PATCH 09/11] pthread1: Don't close stderr() before opening log

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 26 Jan 2010 22:47:24 -0800 Subject: [PATCH 09/11] pthread1: Don't close stderr() before opening log If we encounter an error while opening the log file, we write to stderr. In which case, we need the 'stderr' to remain open at least

[Devel] [PATCH 05/11] Move event-notifications to libcrtest/common.c

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 26 Jan 2010 16:46:09 -0800 Subject: [PATCH 05/11] Move event-notifications to libcrtest/common.c The event notification functions using eventfd can be used by other fcntl tests (and possibly other tests). Move them out of filelock1

[Devel] [PATCH 08/11] filelock1: Extend for mandatory locks

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 26 Jan 2010 19:38:28 -0800 Subject: [PATCH 08/11] filelock1: Extend for mandatory locks Extend filelock1 to test for mandatory locks, when filelock1 is run with the -m option. Signed-off-by: Sukadev Bhattiprolu suka

[Devel] [PATCH 10/11] filelock2: Test restart of process in F_GETLK

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Wed, 27 Jan 2010 19:31:22 -0800 Subject: [PATCH 10/11] filelock2: Test restart of process in F_GETLK Checkpoint a process that is waiting on a record lock in fcntl(F_GETLK). Upon restart, ensure that it remains in fcntl(F_GETLK) and when

[Devel] [PATCH 06/11] filelease1: Test restore of file leases

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Thu, 21 Jan 2010 12:36:24 -0800 Subject: [PATCH 06/11] filelease1: Test restore of file leases Checkpoint an application that has F_RDLCK and F_WRLCK leases on files. Restart the application and ensure that the leases are restored

[Devel] [PATCH 11/11] filelease2: Test C/R during lease-break-interval

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Thu, 28 Jan 2010 23:18:50 -0800 Subject: [PATCH 11/11] filelease2: Test C/R during lease-break-interval When a process, P1 (lease-owner of a file) is notified of an impending lease-break (due to a conflicting open of the file by process

[Devel] [PATCH 04/11] Rename run-filelock1 to run-fcntltests.sh

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Mon, 25 Jan 2010 18:26:57 -0800 Subject: [PATCH 04/11] Rename run-filelock1 to run-fcntltests.sh run-filelock1 wrapper could share lot of code with other fcntl tests. Remove hardcoded names, rename it run-fcntltests.sh and pass

[Devel] [PATCH 07/11] fsetown1: Test async I/O notification after restart

2010-01-29 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Thu, 21 Jan 2010 23:07:51 -0800 Subject: [PATCH 07/11] fsetown1: Test async I/O notification after restart Checkpoint a process that is waiting for async notification of data being available on a pipe. When the process is restarted, make

[Devel] [PATCH][cr-tests]: eclone-1: Test basic functionality

2010-02-02 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Sat, 30 Jan 2010 12:49:30 -0800 Subject: [PATCH 1/6] eclone-1: Test basic functionality Verify that a child process gets the expected pid and arguments on stack when it is created with eclone() system call. NOTE: The myclone

<    3   4   5   6   7   8   9   10   11   >