From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Sat, 30 Jan 2010 12:51:23 -0800
Subject: [PATCH 2/6]: eclone-2: Fail if selected pid is in use
Ensure that eclone() system call fails with -EBUSY if selected pid is
in use.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Sat, 30 Jan 2010 12:53:04 -0800
Subject: [PATCH 3/6][cr-tests]: eclone-3: Fail if reserved fields are not 0.
To ensure future extendability, we want the unused fields to be 0.
Ensure eclone() fails if -reserved0 field is non-0.
Signed
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Feb 2010 18:10:32 -0800
Subject: [PATCH 4/6][cr-tests]: eclone-4: Fail if clone_flags_high is non-zero
To ensure future extendability, we want the unused fields to be 0. Ensure
eclone() fails if -clone_flags_high field is non-0
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Feb 2010 18:13:51 -0800
Subject: [PATCH 5/6][cr-tests]: eclone-5: nr_pids must not exceed nesting level
Verify that eclone() fails if nr_pids exceeds the current nesting level
of pid namespaces. Also verify that eclone() succeeds
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 2 Feb 2010 11:21:07 -0800
Subject: [PATCH 6/6][cr-tests]: eclone/runtests.sh: Wrapper script for eclone
tests
A simple wrapper script to run all eclone tests in this directory.
Signed-off-by: Sukadev Bhattiprolu suka
Tested the changes on x86_32 with a stub to simulate the special case for
powerpc below. Appreciate if it could be tested on other architectures
specially powerpc.
Also, can we push genstack.o into libeclone.a to simplify the Makefile ?
thanks,
Sukadev
---
From: Sukadev Bhattiprolu suka
Here is an updated patch which includes genstack.o in libeclone and
adds Serge's ack.
---
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Sat, 6 Feb 2010 10:45:10 -0800
Subject: [PATCH 1/1] Create libeclone.a
The user-api to the eclone() system call is architecture dependent.
Besides
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Sat, 30 Jan 2010 12:49:30 -0800
Subject: [PATCH 1/6] eclone-1: Test basic functionality
Verify that a child process gets the expected pid and arguments on stack
when it is created with eclone() system call.
Changelog[v2]:
- Use
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 9 Feb 2010 11:08:22 -0800
Subject: [PATCH][cr-test]: run-fcntltests.sh: Thaw and cleanup processes on
error
If the fcntl tests (filelock[12], filelease1 and fsetown1) fail during
checkpoint, the processes end up frozen and appear
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Sat, 30 Jan 2010 12:51:23 -0800
Subject: [PATCH 2/6] eclone-2: Ensure eclone() fails if selected pid is in use
Ensure that eclone() system call fails with -EBUSY if selected pid is in use.
Changelog[v2]:
- Use libeclone.a from
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Sat, 30 Jan 2010 12:53:04 -0800
Subject: [PATCH 3/6] eclone-3: Verify eclone() fails if reserved fields are not
0.
To ensure future extendability, we want the unused fields to be 0.
Ensure eclone() fails if -reserved0 field is non-0
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Feb 2010 18:10:32 -0800
Subject: [PATCH 4/6] eclone-4: Verify eclone() fails if clone_flags_high is
non-zero
To ensure future extendability, we want the unused fields to be 0. Ensure
eclone() fails if -clone_flags_high field
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Feb 2010 18:13:51 -0800
Subject: [PATCH 5/6] eclone-5: nr_pids must not exceed nesting level
Verify that eclone() fails if nr_pids exceeds the current nesting level
of pid namespaces. Also verify that eclone() succeeds in choosing
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 2 Feb 2010 11:21:07 -0800
Subject: [PATCH 6/6] eclone/runtests.sh: Wrapper script for eclone tests
A simple wrapper script to run all eclone tests in this directory.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Serge E. Hallyn [se...@us.ibm.com] wrote:
| Quoting Sukadev Bhattiprolu (suka...@linux.vnet.ibm.com):
|
| From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
| Date: Mon, 1 Feb 2010 18:13:51 -0800
| Subject: [PATCH 5/6] eclone-5: nr_pids must not exceed nesting level
|
| Verify
I got a crash in LXC after running
$ lxc-execute -n foo -f /usr/share/doc/lxc/examples/lxc-macvlan.conf
$ ps -ef
$ lxc-stop -n foo
Attached is the info that got printed on the console.
System is an x330, running RHEL5.2 with latest Checkpoint/Restart
patches (i.e
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 10 Feb 2010 20:09:17 -0800
Subject: [PATCH 1/1] lxc-ps: Nit - Avoid blank CONTAINER column
The contianer name is not printed in the lxc-ps output unless the --lxc
option is specified. But the CONTAINER column is printed (and left
Serge E. Hallyn [se...@us.ibm.com] wrote:
| Quoting Michel Normand (norm...@fr.ibm.com):
| Le jeudi 11 février 2010 à 11:08 +0100, Michel Normand a écrit :
| Le mercredi 10 février 2010 à 20:25 -0800, Sukadev Bhattiprolu a écrit :
|From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Matt Helsley [matth...@us.ibm.com] wrote:
| On Mon, Feb 15, 2010 at 04:58:13PM -0600, Serge Hallyn wrote:
| We've currently got ns_exec both in user-cr and cr_tests. Let's
| give the user-cr version all features of the cr_tests one, and
| get rid of the cr_tests one.
|
| I'm also renaming
Do we even need the -p option ? It is not used without the -v at present.
Can we drop the -p and have -v print filepos always ?
---
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Fri, 19 Feb 2010 11:19:08 -0800
Subject: [PATCH 1/1] ckptinfo: Have -v imply -p
When the -v is chosen
Following two sets of patches is an early attempt to integrate LXC and
USER-CR.
Overview:
Have USER-CR export the core checkpoint and restart functionality into a
library (/lib/libcheckpoint.a and usercr.h) and have LXC link with this
library.
TODO:
1. For now, libcheckpoint.a
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 23 Feb 2010 15:25:31 -0800
Subject: [PATCH 1/4][user-cr] Move common definitions to restart.h
To make restart() a library interface, the main() and related code in
restart.c should be moved to a separate file. To prepare
From 8a6fad2170fbbeb7a5e44c32239f9703c0b7d2f9 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 23 Feb 2010 15:33:04 -0800
Subject: [PATCH 2/4][user-cr] Rename struct args to struct restart_args
Rename struct args to struct restart_args and move to a new
From 6553b7da33f56e9cb6927e7469af22df56b7f55f Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 23 Feb 2010 15:55:34 -0800
Subject: [PATCH 3/4][user-cr] Move main() in restart.c to restart-main.c
This would enable us to put restart.o into a library.
TODO
From c4063a8976fd8eca9b8d62a12b95c3125c8471c7 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 23 Feb 2010 16:25:36 -0800
Subject: [PATCH 4/4][user-cr] Rename libeclone.a to libcheckpoint.a
Export app_restart() and usercr.h to user in a new library
From 94fe79c36ac3aed69c8d97f8e4d17c9b02961b97 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 23 Feb 2010 17:47:51 -0800
Subject: [PATCH 1/2] Rename --directory option to --statefile
[See following mail for an intro to this patch set
https
Daniel Lezcano [dlezc...@fr.ibm.com] wrote:
Cedric Le Goater wrote:
On 02/24/2010 09:41 AM, Sukadev Bhattiprolu wrote:
[See following mail for an intro to this patch set
https://lists.linux-foundation.org/pipermail/containers/2010-February/023048.html]
The --directory is misleading
the
caller knows the root of the restarted process-tree ?
- Also, like the kernel's API, how about app_checkpoint() and
app_restart() take a logfp/logfd and we send all the debugging
output to that file ?
Thanks,
Sukadev
|
| return ret;
| }
|
| --
| 1.6.6.1
))
and get the default behavior. Now they have to explicitly set to -1.
Sukadev
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Oren Laadan [or...@cs.columbia.edu] wrote:
Suka,
This is good stuff: convert restart to a library and intergate
with LXC is excellent target.
We need to give a thought to the API design and the sort of
functionality that the library will offer. I'd prefer to get
a better view of the whole
Oren Laadan [or...@cs.columbia.edu] wrote:
Sukadev Bhattiprolu wrote:
From c4063a8976fd8eca9b8d62a12b95c3125c8471c7 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 23 Feb 2010 16:25:36 -0800
Subject: [PATCH 4/4][user-cr] Rename libeclone.a
will not be able to signal any children
it created before the unshare() (bc their active pid namespaces are
different)
Sukadev
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
need a new 'struct pid' for an
existing process. I think we talked earlier of finding a way of attaching
additional pid numbers to the same struct pid.
Sukadev
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux
/13][user-cr]: checkpoint: Remove args-output
[PATCH 10/13][user-cr]: checkpoint: Remove -logfile
[PATCH 11/13][user-cr]: checkpoint: Rename struct args
[PATCH 12/13][user-cr]: Define app_checkpoint()
[PATCH 13/13] checkpoint: Use ckpt_perror()
Signed-off-by: Sukadev
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 18:24:51 -0800
Subject: [PATCH 02/13][user-cr]: restart: Rename args-logfd
User-space restart code needs at least two different log files. The restart()
system call code in the kernel writes useful messages to one
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 18:19:44 -0800
Subject: [PATCH 01/13][user-cr]: restart: Remove args-no_pidns.
args-no_pidns does not really need to be a field in the 'args' structure.
It is used to validate command line arguments and can just
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 18:45:59 -0800
Subject: [PATCH 03/13][user-cr]: restart: Remove args-logfile
The args-logfile field is used to store the the name of the logfile to
which the kernel must write its output. If we move the code that opens
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 20:04:12 -0800
Subject: [PATCH 04/13][user-cr]: restart: Use ckpt_msg() to log
Rather than implicitly redirecting messages to 'stdout' or 'stderr'
use global variables, 'global_ulogfd' and 'global_uerrfd'. That would
make
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 20:33:36 -0800
Subject: [PATCH 08/13][user-cr]: restart: Rename struct args.
Rename 'struct args' in restart.c to 'struct app_restart_args'. This
would enable us to distinguish this struct from the 'struct args
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 20:18:31 -0800
Subject: [PATCH 05/13][user-cr]: restart: Use ckpt_perror()
Remove the implicit dependency on 'stderr' and redirect messages to
global_uerrfd. This would simplify implementing command line options
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 20:24:15 -0800
Subject: [PATCH 06/13][user-cr]: restart: Remove args-input
Having both -input and -infd in 'struct args' is redundant.
The args-input field is used to store the name of the input file
(checkpoint-image
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 2 Mar 2010 09:29:55 -0800
Subject: [PATCH 07/13][user-cr]: Define app_restart()
Move the bulk of code that implements application restart into a
separate function, and make main() a wrapper to that function.
This would help export
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 3 Mar 2010 10:49:19 -0800
Subject: [PATCH 09/13][user-cr]: checkpoint: Remove args-output
'struct args' has both an 'outfd' and an 'output' field. The -output
field is only needed to parse arguments and by moving the open
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 3 Mar 2010 11:03:52 -0800
Subject: [PATCH 10/13][user-cr]: checkpoint: Remove -logfile
'struct args' has both an 'logfd' and a 'logfile' field. The -logfile
field is only needed to parse arguments and by moving the open
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 3 Mar 2010 11:24:54 -0800
Subject: [PATCH 11/13][user-cr]: checkpoint: Rename struct args
Rename 'struct args' in checkpoint.c to 'struct app_checkpoint_args'.
This would give the struct a more specific name when checkpoint/restart
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 3 Mar 2010 11:35:47 -0800
Subject: [PATCH 12/13][user-cr]: Define app_checkpoint()
Move the bulk of the code that implements application checkpoint into
a separate function, app_checkpoint() and make a main() a wrapper
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 3 Mar 2010 15:22:47 -0800
Subject: [PATCH 13/13] checkpoint: Use ckpt_perror()
Remove the implicit dependency on 'stderr' and redirect messages to
global_uerrfd. This would simplify implementing command line options
for these file
[PATCH 10/12][user-cr] restart: Move main() to restart-main.c
[PATCH 11/12][user-cr] checkpoint: Move main() to checkpoint-main.c
[PATCH 12/12][user-cr] Have app_restart() return pid
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 17:41:04 -0800
Subject: [PATCH 01/12][user-cr] restart: Mark globals as static
app_restart() will in the future be exported to other programs.
To avoid potential variable-name collisions, make the globals
in restart.c
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 17:37:39 -0800
Subject: [PATCH 02/12][user-cr] restart: Add args-send_sigint
restart command supports a command line option, --send-sigint to let
user specify whether SIGINT signal should be processed/ignored during
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 17:46:31 -0800
Subject: [PATCH 03/12][user-cr] Add app_restart_args-debug
Make 'debug' a field in struct app_restart_args so other callers of
app_restart() can also control the debug output of app_restart().
Signed-off
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 17:53:27 -0800
Subject: [PATCH 04/12][user-cr] Add app_restart_args-verbose
Make 'verbose' a field in struct app_restart_args so other callers of
app_restart() can also control the verbose output of app_restart().
Signed
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 22:33:34 -0800
Subject: [PATCH 05/12][user-cr] Add app_restart_args-ulogfd
Add a 'ulogfd' field in struct app_restart_args so other callers of
app_restart() can also choose a file descriptor for the log messages
from
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 22:36:31 -0800
Subject: [PATCH 06/12][user-cr] Add app_restart_args-uerrfd
Add a 'uerrfd' field in struct app_restart_args so other callers of
app_restart() can also choose a file descriptor for the error messages
from
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 21:15:25 -0800
Subject: [PATCH 07/12][user-cr] Define INIT_SIGNAL_ARRAY
Code to initialize the signal_array[] table will need to be shared by more
than one file. To enable this sharing with, define INIT_SIGNAL_ARRAY which
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 21:30:50 -0800
Subject: [PATCH 08/12][user-cr] Create common.h
Code in common.h can be shared by checkpoint.c and restart.c for now.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Makefile |4
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 21:51:27 -0800
Subject: [PATCH 09/12][user-cr] Create app-checkpoint.h
Create a new header file, app-checkpoint.h that can be used to export
the app_checkpoint() and app_restart() functionality to other users
(such as LXC
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 21:46:14 -0800
Subject: [PATCH 10/12][user-cr] restart: Move main() to restart-main.c
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Makefile |4 +-
restart-main.c | 351
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 22:28:34 -0800
Subject: [PATCH 11/12][user-cr] checkpoint: Move main() to checkpoint-main.c
---
Makefile |4 +-
checkpoint-main.c | 171 +
checkpoint.c
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Fri, 5 Mar 2010 10:24:53 -0800
Subject: [PATCH 12/12][user-cr] Have app_restart() return pid
On success, return the pid of a the root of the restarted process tree.
This would enable callers to manage the restarted process-tree
to /cgroup/bar
cgroup).
---
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 8 Mar 2010 12:03:46 -0800
Subject: [PATCH 1/1] Minimize unshare() calls
---
restart.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/restart.c b/restart.c
index c82de21
Serge E. Hallyn [se...@us.ibm.com] wrote:
| Quoting Sukadev Bhattiprolu (suka...@linux.vnet.ibm.com):
|
| From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
| Date: Thu, 4 Mar 2010 21:30:50 -0800
| Subject: [PATCH 08/12][user-cr] Create common.h
|
| Code in common.h can be shared
() macro defined in common.h uses the global_debug. While
there are no callers of ckpt_debug() in restart-main.c now, setting it
here may enable us just call ckpt_debug() if necessary.
Sukadev
___
Containers mailing list
contain...@lists.linux
Serge E. Hallyn [se...@us.ibm.com] wrote:
| Quoting Sukadev Bhattiprolu (suka...@linux.vnet.ibm.com):
|
| Came across this while testing LXC.
|
|
| 1. Does ckpt_remount_proc() need to unshare() ? Or can we have the
| clone() that calls __ckpt_coordinator() clone with CLONE_NEWNS
Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote:
| Serge E. Hallyn [se...@us.ibm.com] wrote:
| | Quoting Sukadev Bhattiprolu (suka...@linux.vnet.ibm.com):
| |
| | Came across this while testing LXC.
| |
| |
| | 1. Does ckpt_remount_proc() need to unshare() ? Or can we have
in checkpoint.o and restart.o. LXC links directly with these
.o files to checkpoint/restart its containers.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 17:53:27 -0800
Subject: [PATCH 02/14][user-cr] Add app_restart_args-verbose
Make 'verbose' a field in struct app_restart_args so other callers of
app_restart() can also control the verbose output of app_restart().
Signed
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 17:46:31 -0800
Subject: [PATCH 01/14][user-cr] Add app_restart_args-debug
Make 'debug' a field in struct app_restart_args so other callers of
app_restart() can also control the debug output of app_restart().
Signed-off
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 22:33:34 -0800
Subject: [PATCH 03/14][user-cr] Add app_restart_args-ulogfd
Add a 'ulogfd' field in struct app_restart_args so other callers of
app_restart() can also choose a file descriptor for the log messages
from
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 22:36:31 -0800
Subject: [PATCH 04/14][user-cr] Add app_restart_args-uerrfd
Add a 'uerrfd' field in struct app_restart_args so other callers of
app_restart() can also choose a file descriptor for the error messages
from
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 21:15:25 -0800
Subject: [PATCH 05/14][user-cr] Define INIT_SIGNAL_ARRAY
Code to initialize the signal_array[] table will need to be shared by more
than one file. To enable this sharing with, define INIT_SIGNAL_ARRAY which
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 21:30:50 -0800
Subject: [PATCH 06/14][user-cr] Create common.h
Code in common.h can be shared by checkpoint.c and restart.c for now.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Makefile |4
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 21:51:27 -0800
Subject: [PATCH 07/14][user-cr] Create app-checkpoint.h
Create a new header file, app-checkpoint.h that can be used to export
the app_checkpoint() and app_restart() functionality to other users
(such as LXC
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 4 Mar 2010 21:46:14 -0800
Subject: [PATCH 08/14][user-cr] restart: Move main() to restart-main.c
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Makefile |4 +-
restart-main.c | 350
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Fri, 5 Mar 2010 10:24:53 -0800
Subject: [PATCH 10/14][user-cr] Have app_restart() return pid
On success, return the pid of a the root of the restarted process tree.
This would enable callers to manage the restarted process-tree
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Sat, 6 Mar 2010 12:49:40 -0800
Subject: [PATCH 12/14][user-cr] app_restart(): mnt-pty implies mntns
If the mount_pty is set, mntns must be implied, otherwise the newinstance
mount of devpts will make the ptys in the original pts instance
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Sat, 6 Mar 2010 13:14:02 -0800
Subject: [PATCH 11/14][user-cr] restart: Define process_args()
Move the code that validates/processes the arguments into a separate
function.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Sat, 6 Mar 2010 13:06:35 -0800
Subject: [PATCH 13/14][user-cr] restart: Move args checking to app_restart()
parse_args() validates the specified arguments to ensure they are consistent.
Move this code into app_restart() so
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 8 Mar 2010 12:03:46 -0800
Subject: [PATCH 14/14][user-cr] Minimize unshare() calls
We currently have a few unshare() calls at different points in the
code. While these don't affect the restart application itself, the
excess calls
/~hallyn/cr_tests.git
[2]: USERCR: git://git.ncl.cs.columbia.edu/pub/git/user-cr.git
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 10 Mar 2010 22:24:17 -0800
Subject: [PATCH 3/5][lxc] lxc_checkpoint: Add --image option
The existing --directory option to lxc_checkpoint expects to save the
checkpoint state in a directory. USERCR however uses a single regular
file
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 10 Mar 2010 21:59:39 -0800
Subject: [PATCH 2/5][lxc] lxc_restart: Add --image option
The existing --directory option to lxc_restart expects the checkpoint state
to be a directory. USERCR however uses a single regular file to store
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 10 Mar 2010 22:12:34 -0800
Subject: [PATCH 1/5][lxc] Enable static linking of some lxc binaries
This is a temporary commit to statically link lxc_checkpoint, lxc_execute
and lxc_restart.
Signed-off-by: Sukadev Bhattiprolu suka
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 11 Mar 2010 20:47:56 -0800
Subject: [PATCH 4/5][lxc] Hook up lxc_restart() with app_restart()
Have lxc_restart() call app_restart() implemented in the 'restart.o' from
USER-CR git tree.
Changelog[v2]:
- Link with restart.o
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 11 Mar 2010 21:32:38 -0800
Subject: [PATCH 5/5][lxc] Hook up lxc_checkpoint() with app_checkpoint()
Have lxc_checkpoint() call app_checkpoint() implemented in checkpoint.o
in the USER-CR git tree
TODO:
- Map lxc_flags
that unlike the tid pointers above which are a few individual fields,
the pid_t array could in theory be large.
Hope that helps. Thanks the review comments.
Sukadev
___
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux
Michel Normand [norm...@fr.ibm.com] wrote:
| Le jeudi 18 mars 2010 à 23:39 -0700, Sukadev Bhattiprolu a écrit :
| 2. Build/install lxc_checkpoint and lxc_restart
|
| # Do normal LXC build/install of 0.6.5.
|
| # Then replace 'lxc-execute', 'lxc-checkpoint', 'lxc-restart
Daniel Lezcano [dlezc...@fr.ibm.com] wrote:
Sukadev Bhattiprolu wrote:
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 10 Mar 2010 21:59:39 -0800
Subject: [PATCH 2/5][lxc] lxc_restart: Add --image option
The existing --directory option to lxc_restart expects the checkpoint
Pls let me know if this will work. Will address your other comments
and repost entire patchset.
---
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 24 Mar 2010 17:26:44 -0700
Subject: [PATCH 1/1] Add --with-usercr configure option
Add a configure option, --with-usercr=dir which
Michel Normand [norm...@fr.ibm.com] wrote:
| Suka,
| I am adding my own comments, even if mail addressed to Daniel.
I did mean to CC you since you had a comment on this earlier. But even
otherwise, comments always welcome :-)
|
| Le mercredi 24 mars 2010 à 18:05 -0700, Sukadev Bhattiprolu
Daniel Lezcano [dlezc...@fr.ibm.com] wrote:
Sukadev Bhattiprolu wrote:
Pls let me know if this will work. Will address your other comments
and repost entire patchset.
---
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 24 Mar 2010 17:26:44 -0700
Subject: [PATCH 1/1] Add
?
Is there a way to specify that the restarted application belong
to a new (yet-to-be created) cgroup AND to leave the application
FROZEN after restart ? Or would we need a new command line option
and field in 'struct app_restart_args' to specify this ?
Thanks,
Sukadev
Is there a way to specify that the restarted application belong
to a new (yet-to-be created) cgroup AND to leave the application
FROZEN after restart ? Or would we need a new command line option
and field in 'struct app_restart_args' to specify this ?
This is exactly what --freezer does.
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 30 Mar 2010 18:59:10 -0700
Subject: [PATCH 1/2] Fix app_checkpoint() return code
Have app_checkpoint() return the return value from the system call
so callers find some useful information. Have main() can convert the
return value
due to --pause
$ lxc-unfreeze --name foo
$ vncviewer :1
# Should bring up the old VNC session with vi window
[1]: cr-tests: git://git.sr71.net/~hallyn/cr_tests.git
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 24 Mar 2010 17:26:44 -0700
Subject: [PATCH 1/6][lxc][v3] Add --with-libcr configure option
Add a configure option, --with-libcr=dir which would allow linking
with external (i.e USERCR) implementation of checkpoint/restart.
For now
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Thu, 11 Mar 2010 21:32:38 -0800
Subject: [PATCH 6/6][lxc][v3] Hook up lxc_checkpoint() with app_checkpoint()
Have lxc_checkpoint() call app_checkpoint() implemented in checkpoint.o
in the USER-CR git tree
TODO:
- Map lxc_flags
Michel Normand [norm...@fr.ibm.com] wrote:
| configure error because of typo below
|
Sorry, I had not committed after fixing it. Thanks for fixing it.
Did you also need the -fPIC to compile checkpoint.o ?
Thanks,
Sukadev
___
Containers mailing list
] sys_restart returns -516
What does mean -516 ? an error ?
Could it be ERESTART_RESTARTBLOCK ? Also, can you let us know what application
causes this ? Are any signals generated ?
Thanks,
Sukadev
I am running on a x86_64.
Thanks
-- Daniel
# Should bring up the old VNC session with vi window
[1]: cr-tests: git://git.sr71.net/~hallyn/cr_tests.git
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
___
Containers mailing list
contain...@lists.linux-foundation.org
https
801 - 900 of 1057 matches
Mail list logo
