Re: [Devel] [PATCH] fs/fuse: move FUSE_S_FAIL_IMMEDIATELY check before kio req send

2019-01-24 Thread Pavel Butsykin
On 24.01.2019 12:21, Kirill Tkhai wrote: > On 24.01.2019 12:17, Pavel Butsykin wrote: >> Yes, I missed this synchronization idea, the check and list_add should >> be together, will fix. > > Also, __fuse_request_send() may need to be fixed, since it does not look > as having appropriate in

Re: [Devel] [PATCH] fs/fuse: move FUSE_S_FAIL_IMMEDIATELY check before kio req send

2019-01-24 Thread Kirill Tkhai
On 24.01.2019 12:17, Pavel Butsykin wrote: > Yes, I missed this synchronization idea, the check and list_add should > be together, will fix. Also, __fuse_request_send() may need to be fixed, since it does not look as having appropriate in already existing code (I haven't checked deeply). > On

Re: [Devel] [PATCH] fs/fuse: move FUSE_S_FAIL_IMMEDIATELY check before kio req send

2019-01-24 Thread Pavel Butsykin
Yes, I missed this synchronization idea, the check and list_add should be together, will fix. On 24.01.2019 11:45, Kirill Tkhai wrote: > On 23.01.2019 20:22, Pavel Butsykin wrote: >> >> 23.01.2019 16:55, Kirill Tkhai пишет: >>> On 23.01.2019 14:49, Pavel Butsykin wrote: Fuse file with

Re: [Devel] [PATCH] fs/fuse: move FUSE_S_FAIL_IMMEDIATELY check before kio req send

2019-01-24 Thread Kirill Tkhai
On 23.01.2019 20:22, Pavel Butsykin wrote: > > 23.01.2019 16:55, Kirill Tkhai пишет: >> On 23.01.2019 14:49, Pavel Butsykin wrote: >>> Fuse file with FUSE_S_FAIL_IMMEDIATELY state should not allow to execute new >>> requests. But in case of kio requests it doesn't work because the status >>>

Re: [Devel] [PATCH] fs/fuse: move FUSE_S_FAIL_IMMEDIATELY check before kio req send

2019-01-23 Thread Pavel Butsykin
23.01.2019 16:55, Kirill Tkhai пишет: > On 23.01.2019 14:49, Pavel Butsykin wrote: >> Fuse file with FUSE_S_FAIL_IMMEDIATELY state should not allow to execute new >> requests. But in case of kio requests it doesn't work because the status >> check >> is located behind kio.op->req_send(). To fix

Re: [Devel] [PATCH] fs/fuse: move FUSE_S_FAIL_IMMEDIATELY check before kio req send

2019-01-23 Thread Alexey Kuznetsov
Ack On Wed, Jan 23, 2019 at 2:49 PM Pavel Butsykin wrote: > > Fuse file with FUSE_S_FAIL_IMMEDIATELY state should not allow to execute new > requests. But in case of kio requests it doesn't work because the status check > is located behind kio.op->req_send(). To fix this let's move the status

Re: [Devel] [PATCH] fs/fuse: move FUSE_S_FAIL_IMMEDIATELY check before kio req send

2019-01-23 Thread Kirill Tkhai
On 23.01.2019 14:49, Pavel Butsykin wrote: > Fuse file with FUSE_S_FAIL_IMMEDIATELY state should not allow to execute new > requests. But in case of kio requests it doesn't work because the status check > is located behind kio.op->req_send(). To fix this let's move the status check > before

[Devel] [PATCH] fs/fuse: move FUSE_S_FAIL_IMMEDIATELY check before kio req send

2019-01-23 Thread Pavel Butsykin
Fuse file with FUSE_S_FAIL_IMMEDIATELY state should not allow to execute new requests. But in case of kio requests it doesn't work because the status check is located behind kio.op->req_send(). To fix this let's move the status check before kio.op->req_send(). Note: We can drop hunk with