[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-27 Thread Ryo Tsuruta
Hi Andrea and Vivek, Ryo Tsuruta r...@valinux.co.jp wrote: Hi Andrea and Vivek, From: Andrea Righi righi.and...@gmail.com Subject: Re: [PATCH] io-controller: Add io group reference handling for request Date: Mon, 18 May 2009 16:39:23 +0200 On Mon, May 18, 2009 at 10:01:14AM -0400,

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-27 Thread Andrea Righi
On Wed, May 27, 2009 at 03:56:31PM +0900, Ryo Tsuruta wrote: I think that only putting the hook in try_to_unmap() doesn't work correctly, because IOs will be charged to reclaiming processes or kswapd. These IOs should be charged to processes which cause memory pressure. Consider the

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-27 Thread Vivek Goyal
On Wed, May 27, 2009 at 03:56:31PM +0900, Ryo Tsuruta wrote: Hi Andrea and Vivek, Ryo Tsuruta r...@valinux.co.jp wrote: Hi Andrea and Vivek, From: Andrea Righi righi.and...@gmail.com Subject: Re: [PATCH] io-controller: Add io group reference handling for request Date: Mon, 18 May

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-26 Thread Ryo Tsuruta
Hi Andrea and Vivek, From: Andrea Righi righi.and...@gmail.com Subject: Re: [PATCH] io-controller: Add io group reference handling for request Date: Mon, 18 May 2009 16:39:23 +0200 On Mon, May 18, 2009 at 10:01:14AM -0400, Vivek Goyal wrote: On Sun, May 17, 2009 at 12:26:06PM +0200, Andrea

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-19 Thread Ryo Tsuruta
From: Vivek Goyal vgo...@redhat.com Subject: Re: [PATCH] io-controller: Add io group reference handling for request Date: Mon, 18 May 2009 10:01:14 -0400 On Sun, May 17, 2009 at 12:26:06PM +0200, Andrea Righi wrote: On Fri, May 15, 2009 at 10:06:43AM -0400, Vivek Goyal wrote: On Fri, May

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-18 Thread Vivek Goyal
On Sun, May 17, 2009 at 12:26:06PM +0200, Andrea Righi wrote: On Fri, May 15, 2009 at 10:06:43AM -0400, Vivek Goyal wrote: On Fri, May 15, 2009 at 09:48:40AM +0200, Andrea Righi wrote: On Fri, May 15, 2009 at 01:15:24PM +0800, Gui Jianfeng wrote: Vivek Goyal wrote: ... }

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-18 Thread Andrea Righi
On Mon, May 18, 2009 at 10:01:14AM -0400, Vivek Goyal wrote: On Sun, May 17, 2009 at 12:26:06PM +0200, Andrea Righi wrote: On Fri, May 15, 2009 at 10:06:43AM -0400, Vivek Goyal wrote: On Fri, May 15, 2009 at 09:48:40AM +0200, Andrea Righi wrote: On Fri, May 15, 2009 at 01:15:24PM +0800,

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-17 Thread Andrea Righi
On Fri, May 15, 2009 at 10:06:43AM -0400, Vivek Goyal wrote: On Fri, May 15, 2009 at 09:48:40AM +0200, Andrea Righi wrote: On Fri, May 15, 2009 at 01:15:24PM +0800, Gui Jianfeng wrote: Vivek Goyal wrote: ... } @@ -1462,20 +1462,27 @@ struct io_cgroup *get_iocg_from_bio(stru

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-15 Thread Andrea Righi
On Fri, May 15, 2009 at 01:15:24PM +0800, Gui Jianfeng wrote: Vivek Goyal wrote: ... } @@ -1462,20 +1462,27 @@ struct io_cgroup *get_iocg_from_bio(stru /* * Find the io group bio belongs to. * If create is set, io group is created if it is not already present. + * If curr is

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-15 Thread Gui Jianfeng
Andrea Righi wrote: On Fri, May 15, 2009 at 01:15:24PM +0800, Gui Jianfeng wrote: Vivek Goyal wrote: ... } @@ -1462,20 +1462,27 @@ struct io_cgroup *get_iocg_from_bio(stru /* * Find the io group bio belongs to. * If create is set, io group is created if it is not already present. +

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-15 Thread Vivek Goyal
On Fri, May 15, 2009 at 03:40:05PM +0800, Gui Jianfeng wrote: Vivek Goyal wrote: ... Ok, here is the patch which gets rid of rq-iog and rq-rl fields. Good to see some code and data structures trimming. It seems to be working fine for me. o Get rid of rq-iog field and rq-rl fields.

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-15 Thread Vivek Goyal
On Fri, May 15, 2009 at 09:48:40AM +0200, Andrea Righi wrote: On Fri, May 15, 2009 at 01:15:24PM +0800, Gui Jianfeng wrote: Vivek Goyal wrote: ... } @@ -1462,20 +1462,27 @@ struct io_cgroup *get_iocg_from_bio(stru /* * Find the io group bio belongs to. * If create is set,

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-15 Thread Vivek Goyal
On Fri, May 15, 2009 at 04:16:38PM +0800, Gui Jianfeng wrote: Andrea Righi wrote: On Fri, May 15, 2009 at 01:15:24PM +0800, Gui Jianfeng wrote: Vivek Goyal wrote: ... } @@ -1462,20 +1462,27 @@ struct io_cgroup *get_iocg_from_bio(stru /* * Find the io group bio belongs to. *

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-14 Thread Gui Jianfeng
Vivek Goyal wrote: ... } @@ -1462,20 +1462,27 @@ struct io_cgroup *get_iocg_from_bio(stru /* * Find the io group bio belongs to. * If create is set, io group is created if it is not already present. + * If curr is set, io group is information is searched for current + * task and not

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-11 Thread Vivek Goyal
On Mon, May 11, 2009 at 09:33:05AM +0800, Gui Jianfeng wrote: Nauman Rafique wrote: On Fri, May 8, 2009 at 6:57 AM, Vivek Goyal vgo...@redhat.com wrote: On Fri, May 08, 2009 at 05:45:32PM +0800, Gui Jianfeng wrote: Hi Vivek, This patch adds io group reference handling when allocating

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-10 Thread Gui Jianfeng
Nauman Rafique wrote: On Fri, May 8, 2009 at 6:57 AM, Vivek Goyal vgo...@redhat.com wrote: On Fri, May 08, 2009 at 05:45:32PM +0800, Gui Jianfeng wrote: Hi Vivek, This patch adds io group reference handling when allocating and removing a request. Hi Gui, Thanks for the patch. We were

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-08 Thread Vivek Goyal
On Fri, May 08, 2009 at 05:45:32PM +0800, Gui Jianfeng wrote: Hi Vivek, This patch adds io group reference handling when allocating and removing a request. Hi Gui, Thanks for the patch. We were thinking that requests can take a reference on io queues and io queues can take a reference on

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-08 Thread Nauman Rafique
On Fri, May 8, 2009 at 6:57 AM, Vivek Goyal vgo...@redhat.com wrote: On Fri, May 08, 2009 at 05:45:32PM +0800, Gui Jianfeng wrote: Hi Vivek, This patch adds io group reference handling when allocating and removing a request. Hi Gui, Thanks for the patch. We were thinking that requests

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-08 Thread Vivek Goyal
On Fri, May 08, 2009 at 10:41:01AM -0700, Nauman Rafique wrote: On Fri, May 8, 2009 at 6:57 AM, Vivek Goyal vgo...@redhat.com wrote: On Fri, May 08, 2009 at 05:45:32PM +0800, Gui Jianfeng wrote: Hi Vivek, This patch adds io group reference handling when allocating and removing a

[Devel] Re: [PATCH] io-controller: Add io group reference handling for request

2009-05-08 Thread Nauman Rafique
On Fri, May 8, 2009 at 11:56 AM, Vivek Goyal vgo...@redhat.com wrote: On Fri, May 08, 2009 at 10:41:01AM -0700, Nauman Rafique wrote: On Fri, May 8, 2009 at 6:57 AM, Vivek Goyal vgo...@redhat.com wrote: On Fri, May 08, 2009 at 05:45:32PM +0800, Gui Jianfeng wrote: Hi Vivek, This patch