[Devel] Re: [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup

2009-09-02 Thread Ben Blum
On Thu, Aug 20, 2009 at 02:13:56PM -0700, Andrew Morton wrote: On Wed, 19 Aug 2009 19:45:11 -0700 Paul Menage men...@google.com wrote: On Wed, Aug 19, 2009 at 7:39 PM, Li Zefanl...@cn.fujitsu.com wrote: + __ __ __ __ __ __ list_for_each_entry_rcu(p, tsk-thread_group, thread_group)

[Devel] Re: [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup

2009-08-20 Thread Paul Menage
On Thu, Aug 20, 2009 at 2:13 PM, Andrew Mortona...@linux-foundation.org wrote: s/tsk-sighand/p-sighand Good catch, thanks. Fixed. I see no fix anywhere so I did this: I meant fixed in my tree to go out in the next set of patches. ---

[Devel] Re: [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup

2009-08-20 Thread Andrew Morton
On Wed, 19 Aug 2009 19:45:11 -0700 Paul Menage men...@google.com wrote: On Wed, Aug 19, 2009 at 7:39 PM, Li Zefanl...@cn.fujitsu.com wrote: + __ __ __ __ __ __ list_for_each_entry_rcu(p, tsk-thread_group, thread_group) { + __ __ __ __ __ __ __ __ __ __ if (p-sighand) { + __ __ __ __

[Devel] Re: [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup

2009-08-20 Thread Andrew Morton
On Fri, 21 Aug 2009 00:24:03 -0400 Ben Blum bb...@andrew.cmu.edu wrote: On Thu, Aug 20, 2009 at 02:13:56PM -0700, Andrew Morton wrote: On Wed, 19 Aug 2009 19:45:11 -0700 Paul Menage men...@google.com wrote: On Wed, Aug 19, 2009 at 7:39 PM, Li Zefanl...@cn.fujitsu.com wrote: +

[Devel] Re: [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup

2009-08-20 Thread Paul Menage
On Thu, Aug 20, 2009 at 9:50 PM, Andrew Mortona...@linux-foundation.org wrote: I was actually referring to the non-ascii crap in the email. 'twas Paul. Hmm, so it was. It's sad how much gmail seems like like mangling ascii patches ... Paul ___

[Devel] Re: [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup

2009-08-19 Thread Li Zefan
Paul Menage wrote: From: Ben Blum bb...@google.com Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup This patch adds an rwsem that lives in a threadgroup's sighand_struct (next to the sighand's atomic count, to piggyback on its cacheline), and two functions in

[Devel] Re: [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup

2009-08-19 Thread Paul Menage
On Wed, Aug 19, 2009 at 7:39 PM, Li Zefanl...@cn.fujitsu.com wrote: +             list_for_each_entry_rcu(p, tsk-thread_group, thread_group) { +                     if (p-sighand) { +                             sighand = tsk-sighand; s/tsk-sighand/p-sighand Good catch, thanks. Fixed. Paul