[Devel] Re: [RFC v3][PATCH 8/9] File descriprtors (dump)

2008-09-08 Thread Dave Hansen
On Sun, 2008-09-07 at 00:52 -0400, Oren Laadan wrote: + for (i = 0; i fdt-max_fds; i++) { + if (!fcheck_files(files, i) continue; if (n == max) { + spin_unlock(files-file_lock); + kfree(fdlist); +

[Devel] Re: [RFC v3][PATCH 8/9] File descriprtors (dump)

2008-09-06 Thread Oren Laadan
Dave Hansen wrote: On Thu, 2008-09-04 at 04:05 -0400, Oren Laadan wrote: +/** + * cr_scan_fds - scan file table and construct array of open fds + * @files: files_struct pointer + * @fdtable: (output) array of open fds + * @return: the number of open fds found + * + * Allocates the file

[Devel] Re: [RFC v3][PATCH 8/9] File descriprtors (dump)

2008-09-04 Thread Louis Rilling
On Thu, Sep 04, 2008 at 04:05:50AM -0400, Oren Laadan wrote: Dump the files_struct of a task with 'struct cr_hdr_files', followed by all open file descriptors. Since FDs can be shared, they are assigned a tag and registered in the object hash. For each open FD there is a 'struct

[Devel] Re: [RFC v3][PATCH 8/9] File descriprtors (dump)

2008-09-04 Thread Oren Laadan
Louis Rilling wrote: On Thu, Sep 04, 2008 at 04:05:50AM -0400, Oren Laadan wrote: Dump the files_struct of a task with 'struct cr_hdr_files', followed by all open file descriptors. Since FDs can be shared, they are assigned a tag and registered in the object hash. For each open FD there is

[Devel] Re: [RFC v3][PATCH 8/9] File descriprtors (dump)

2008-09-04 Thread Dave Hansen
On Thu, 2008-09-04 at 04:05 -0400, Oren Laadan wrote: diff --git a/include/linux/ckpt_hdr.h b/include/linux/ckpt_hdr.h index 322ade5..1ce1dbc 100644 --- a/include/linux/ckpt_hdr.h +++ b/include/linux/ckpt_hdr.h @@ -17,7 +17,7 @@ /* * To maintain compatibility between 32-bit and

[Devel] Re: [RFC v3][PATCH 8/9] File descriprtors (dump)

2008-09-04 Thread Dave Hansen
On Thu, 2008-09-04 at 04:05 -0400, Oren Laadan wrote: +/** + * cr_scan_fds - scan file table and construct array of open fds + * @files: files_struct pointer + * @fdtable: (output) array of open fds + * @return: the number of open fds found + * + * Allocates the file descriptors array