Re: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module

2014-10-06 Thread Yevgeny Zaspitsky
Usage of AuditLogDirector in VdsBrokerObjectsBuilder is an illustration for a sub-optimal design: 1. The methods it is used in them are checkTimeDrift and reportInvalidInterfacesForNetwork. Both are: public static and both should not be Best regards, Yevgeny Zaspitsky

Re: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module

2014-10-06 Thread Yevgeny Zaspitsky
Please ignore my previous-mail, that was sent accidentally. Usage of AuditLogDirector in VdsBrokerObjectsBuilder is an illustration for a sub-optimal design: 1. The methods it is used in them are checkTimeDrift and reportInvalidInterfacesForNetwork. Both are: 1. static

[ovirt-devel] CDI limited capabilities in jboss-as-7.1.1

2014-10-06 Thread Yevgeny Zaspitsky
Hi All, Recently I started using CDI (thanks to Roy Golan contribution) in bll module code and figured the limitation described in (https://issues.jboss.org/browse/AS7-4567). That was solved 1.5 years ago in jboss-as-7.2. Currently we use jboss-as-7.1.1. Is there a good reason for not moving

Re: [ovirt-devel] Packages for oVirt 3.5.0 GA

2014-10-06 Thread Alon Bar-Lev
- Original Message - > From: "Alon Bar-Lev" > To: "Sandro Bonazzola" > Cc: "Juan Hernandez" , devel@ovirt.org, "Paz Dangur" > , "Ohad Basan" > > Sent: Monday, October 6, 2014 7:48:13 PM > Subject: Re: [ovirt-devel] Packages for oVirt 3.5.0 GA > > > > - Original Message - >

Re: [ovirt-devel] Packages for oVirt 3.5.0 GA

2014-10-06 Thread Alon Bar-Lev
- Original Message - > From: "Sandro Bonazzola" > To: "Alon Bar-Lev" > Cc: "Juan Hernandez" , devel@ovirt.org, "Paz Dangur" > , "Ohad Basan" > > Sent: Monday, October 6, 2014 5:25:36 PM > Subject: Re: [ovirt-devel] Packages for oVirt 3.5.0 GA > > Il 06/10/2014 14:04, Alon Bar-Lev ha

Re: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module

2014-10-06 Thread Eli Mesika
- Original Message - > From: "Yair Zaslavsky" > To: devel@ovirt.org > Sent: Friday, October 3, 2014 8:03:44 PM > Subject: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module > > Hi all, > I just reviewed a patch regarding AuditLogDirector and I thought to myself - > why

Re: [ovirt-devel] GWT vs. Java

2014-10-06 Thread Vojtech Szocs
- Original Message - > From: "Martin Betak" > To: "Vojtech Szocs" > Cc: devel@ovirt.org, "Einav Cohen" , "Roy Golan" > > Sent: Monday, October 6, 2014 11:36:14 AM > Subject: Re: GWT vs. Java > > - Original Message - > > From: "Vojtech Szocs" > > To: devel@ovirt.org > > Cc: "

Re: [ovirt-devel] GWT vs. Java

2014-10-06 Thread Vojtech Szocs
- Original Message - > From: "Roy Golan" > To: devel@ovirt.org > Sent: Sunday, October 5, 2014 9:16:20 AM > Subject: Re: [ovirt-devel] GWT vs. Java > > On 10/03/2014 06:19 PM, Vojtech Szocs wrote: > > > > - Original Message - > >> From: "Yair Zaslavsky" > >> To: "Vojtech Szocs"

[ovirt-devel] Why are Java checkstyle checks applied to test code?

2014-10-06 Thread Vojtech Szocs
Hi guys, Alex wrote a patch with code in src/test/java containing something like: private static final String PLACE_HOLDER_STRING = "\\{(\\d+)\\}"; Checkstyle's parser choked on { and } symbols within the String constant and the whole build failed on Checkstyle "can't parse Java file" error. T

Re: [ovirt-devel] Packages for oVirt 3.5.0 GA

2014-10-06 Thread Sandro Bonazzola
Il 06/10/2014 14:04, Alon Bar-Lev ha scritto: > > > - Original Message - >> From: "Sandro Bonazzola" >> To: "Juan Hernandez" , devel@ovirt.org >> Cc: "Paz Dangur" , "Ohad Basan" >> Sent: Monday, October 6, 2014 10:33:51 AM >> Subject: [ovirt-devel] Packages for oVirt 3.5.0 GA >> >> Hi,

Re: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module

2014-10-06 Thread Yair Zaslavsky
- Original Message - > From: "Yevgeny Zaspitsky" > To: "Yair Zaslavsky" , devel@ovirt.org > Sent: Sunday, October 5, 2014 11:31:18 AM > Subject: Re: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own > module > > Hi Yair and All, > > As soon as you turned our attention to de

Re: [ovirt-devel] Packages for oVirt 3.5.0 GA

2014-10-06 Thread Alon Bar-Lev
- Original Message - > From: "Sandro Bonazzola" > To: "Juan Hernandez" , devel@ovirt.org > Cc: "Paz Dangur" , "Ohad Basan" > Sent: Monday, October 6, 2014 10:33:51 AM > Subject: [ovirt-devel] Packages for oVirt 3.5.0 GA > > Hi, this is the package list for 3.5.0 GA composition. Some pa

Re: [ovirt-devel] GWT vs. Java

2014-10-06 Thread Martin Betak
- Original Message - > From: "Vojtech Szocs" > To: devel@ovirt.org > Cc: "Einav Cohen" , "Roy Golan" , > "Martin Betak" > Sent: Friday, October 3, 2014 3:29:15 PM > Subject: GWT vs. Java > > Hi guys, > > I've had a discussion with Roy about GWT vs. Java plans, > he asked me to share th

[ovirt-devel] Packages for oVirt 3.5.0 GA

2014-10-06 Thread Sandro Bonazzola
Hi, this is the package list for 3.5.0 GA composition. Some packages are still building, other are unchanged since RC4. Please review the list and warn if any package must be rebuilt. Thanks. # From developers: # oVirt Engine: waiting on http://jenkins.ovirt.org/view/All%20Running%20jobs/job/m