Re: [ovirt-devel] [ovirt-users] [Feature review] Select network to be used for glusterfs

2015-01-15 Thread Dan Kenigsberg
On Thu, Jan 15, 2015 at 12:34:18PM +0530, Sahina Bose wrote: I've updated the feature page with the REST API and other comments. On further thought, there will be no change to Add brick API, as the engine will select the network to be used based on the networks setup for the host. If

Re: [ovirt-devel] [ovirt-users] [Feature review] Select network to be used for glusterfs

2015-01-15 Thread Sahina Bose
On 01/15/2015 02:27 PM, Dan Kenigsberg wrote: On Thu, Jan 15, 2015 at 12:34:18PM +0530, Sahina Bose wrote: I've updated the feature page with the REST API and other comments. On further thought, there will be no change to Add brick API, as the engine will select the network to be used based

Re: [ovirt-devel] [ovirt-users] [Feature review] Select network to be used for glusterfs

2015-01-13 Thread Sahina Bose
On 01/12/2015 06:21 PM, Lior Vernia wrote: Hi Sahina! :) Cool feature, and I think long-awaited by many users. I have a few comments: 1. In the Add Bricks dialog, it seems like the IP Address field is a list box - I presume the items contained there are all IP addresses configured on the

Re: [ovirt-devel] [ovirt-users] [Feature review] Select network to be used for glusterfs

2015-01-13 Thread Sahina Bose
On 01/12/2015 06:14 PM, Oved Ourfali wrote: Hi Sahina, Some comments: 1. As far as I understand, you might not have an IP available immediately after setupNetworks runs (getCapabilities should run, but it isn't run automatically, afair). 2. Perhaps you should pass not the IP but the name of

Re: [ovirt-devel] [ovirt-users] [Feature review] Select network to be used for glusterfs

2015-01-13 Thread Sahina Bose
On 01/12/2015 08:52 PM, Dan Kenigsberg wrote: On Mon, Jan 12, 2015 at 02:59:50PM +0200, Lior Vernia wrote: On 12/01/15 14:44, Oved Ourfali wrote: Hi Sahina, Some comments: 1. As far as I understand, you might not have an IP available immediately after setupNetworks runs (getCapabilities

Re: [ovirt-devel] [ovirt-users] [Feature review] Select network to be used for glusterfs

2015-01-13 Thread Lior Vernia
On 13/01/15 10:18, Sahina Bose wrote: On 01/12/2015 06:21 PM, Lior Vernia wrote: Hi Sahina! :) Cool feature, and I think long-awaited by many users. I have a few comments: 1. In the Add Bricks dialog, it seems like the IP Address field is a list box - I presume the items contained

Re: [ovirt-devel] [ovirt-users] [Feature review] Select network to be used for glusterfs

2015-01-13 Thread Dan Kenigsberg
On Tue, Jan 13, 2015 at 02:51:34PM +0200, Lior Vernia wrote: On 13/01/15 10:21, Sahina Bose wrote: On 01/12/2015 08:52 PM, Dan Kenigsberg wrote: On Mon, Jan 12, 2015 at 02:59:50PM +0200, Lior Vernia wrote: On 12/01/15 14:44, Oved Ourfali wrote: Hi Sahina, Some comments:

Re: [ovirt-devel] [ovirt-users] [Feature review] Select network to be used for glusterfs

2015-01-12 Thread Dan Kenigsberg
On Mon, Jan 12, 2015 at 02:59:50PM +0200, Lior Vernia wrote: On 12/01/15 14:44, Oved Ourfali wrote: Hi Sahina, Some comments: 1. As far as I understand, you might not have an IP available immediately after setupNetworks runs (getCapabilities should run, but it isn't run

Re: [ovirt-devel] [ovirt-users] [Feature review] Select network to be used for glusterfs

2015-01-12 Thread Lior Vernia
On 12/01/15 14:44, Oved Ourfali wrote: Hi Sahina, Some comments: 1. As far as I understand, you might not have an IP available immediately after setupNetworks runs (getCapabilities should run, but it isn't run automatically, afair). 2. Perhaps you should pass not the IP but the name

Re: [ovirt-devel] [ovirt-users] [Feature review] Select network to be used for glusterfs

2015-01-12 Thread Oved Ourfali
Hi Sahina, Some comments: 1. As far as I understand, you might not have an IP available immediately after setupNetworks runs (getCapabilities should run, but it isn't run automatically, afair). 2. Perhaps you should pass not the IP but the name of the network? IPs might change. 3. Adding to