Re: [ovirt-devel] AppErrors.properties merged together

2017-06-26 Thread Jakub Niedermertl
Hi all, thank you all who were involved in previous patch. There is a new one [1] merging AppErrors.properties of 'dal' project to 'frontend' project. I'd like to ask you again to review altered translations. Thanks Jakub [1]: https://gerrit.ovirt.org/#/c/76216 On Wed, Jun 21, 2017 at 4:13 PM,

Re: [ovirt-devel] AppErrors.properties merged together

2017-06-21 Thread Allon Mureinik
Oh, that was stupid on my side - there are indeed several (hundred) properties missing, so we can't merge this test. I wonder how we should push this forward. It isn't just a technicality of adding entries to the properties file, we need to know what the message should be (which I don't, at least

Re: [ovirt-devel] AppErrors.properties merged together

2017-06-20 Thread Allon Mureinik
On Wed, Jun 21, 2017 at 9:12 AM, Allon Mureinik wrote: > > > On Tue, Jun 13, 2017 at 2:55 PM, Vojtech Szocs wrote: > >> Hi Jakub, thanks for taking the effort to simplify AppErrors handling! >> >> The AppErrors.properties file and its localized variants should live in a >> single location, e.g.

Re: [ovirt-devel] AppErrors.properties merged together

2017-06-20 Thread Allon Mureinik
On Tue, Jun 13, 2017 at 2:55 PM, Vojtech Szocs wrote: > Hi Jakub, thanks for taking the effort to simplify AppErrors handling! > > The AppErrors.properties file and its localized variants should live in a > single location, e.g. frontend/webadmin/modules/frontend. We should avoid > having multipl

Re: [ovirt-devel] AppErrors.properties merged together

2017-06-13 Thread Vojtech Szocs
Hi Jakub, thanks for taking the effort to simplify AppErrors handling! The AppErrors.properties file and its localized variants should live in a single location, e.g. frontend/webadmin/modules/frontend. We should avoid having multiple AppErrors.properties copies spread across the codebase. The ba

[ovirt-devel] AppErrors.properties merged together

2017-06-12 Thread Jakub Niedermertl
Hi all, there is a patch [1] removing `AppErrors.properties` from webadmin project to simplify edits of AppErrors/EngineMessage. AppErrors.properties from webadmin project will be merged to AppErrors.properties in frontend project. This requires some manual resolutions of conflicts of translation