[ovirt-devel] [vdsm] merge rights on master branch

[Dan Kenigsberg]

Nir Soffer has been contributing to Vdsm for more than two years now.
Beyond his storage-related expertise, he is well-known for his thorough
code reviews and his pains when the master branch is broken. It's time
for him to take even bigger responsibility.

David, please grant Nir Soffer with merge rights on the master branch of
Vdsm.

I'll keep merging network, virt, and infra patches myself, but much less
than before. Adam keeps his merge right as before (he tends to use them
on emergencies only).

Regards,
Dan.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [vdsm] merge rights on master branch

[David Caro]

Done, let me know if you need me to add him any more permissions (vdsm
permisson groups is a bit complicated, I might have missed something)

On 11/17 12:47, Dan Kenigsberg wrote:
> Nir Soffer has been contributing to Vdsm for more than two years now.
> Beyond his storage-related expertise, he is well-known for his thorough
> code reviews and his pains when the master branch is broken. It's time
> for him to take even bigger responsibility.
> 
> David, please grant Nir Soffer with merge rights on the master branch of
> Vdsm.
> 
> I'll keep merging network, virt, and infra patches myself, but much less
> than before. Adam keeps his merge right as before (he tends to use them
> on emergencies only).
> 
> Regards,
> Dan.

-- 
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R

Tel.: +420 532 294 605
Email: dc...@redhat.com
Web: www.redhat.com
RHT Global #: 82-62605


signature.asc
Description: PGP signature
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Maintainer rights on vdsm - ovirt-3.5-gluster

[Sahina Bose]

Thanks!

On 11/16/2015 07:44 PM, David Caro wrote:

Done!

On 11/16 15:28, Dan Kenigsberg wrote:

On Wed, Apr 29, 2015 at 10:03:47AM +0200, David Caro wrote:

Done

On 04/20, Dan Kenigsberg wrote:

On Mon, Apr 20, 2015 at 03:20:18PM +0530, Sahina Bose wrote:

Hi!

On the vdsm branch "ovirt-3.5-gluster", could you provide merge rights to
Bala (barum...@redhat.com) ?

+1 from me.

ovirt-3.5-gluster needs a rebase on top of the current ovirt-3.5

Thanks. Few months have passed, and now we need Sahina herself as an
admin of the this branch. Would you please add her as well?


___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Reported-By - giving credit to our testers

[David Caro]

On 11/13 08:55, Sandro Bonazzola wrote:
> On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer  wrote:
> 
> > Hi all,
> >
> > Our QE (and sometimes our users) are working hard testing and
> > reporting bugs, but
> > their effort is never mentioned in our code.
> >
> > Looking at kernel git history, I found that they are using the
> > Reported-By header for
> > giving credit to the person reporting a bug. I suggest we adapt this
> > header.
> >
> > Here are some examples how we can use it:
> >
> > - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
> > -
> > https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd
> > -
> > https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598
> 
> 
> infra: looking at above commit messages, can we get automatically added the
> following lines?
> 
> Reviewed-on: https://gerrit.ovirt.org/46540
> on patch creation
> 
> Reviewed-by: Francesco Romani 
> on patch comment

There's no easy way to plug in extra stuff, that is done on vdsm by gerrit
itself because the project is set to 'cherry-pick', but that has consequences,
for starters, when you submit a patch, the commit that gets in is not the same
that you where reviewing (as the commit message changed) and thus you will be
forced to rebase all the patches that depended on it.

There's no built-in way either to change the commit on push (when
updating/creating the patch) without creating a new patch. That means that to
have that added, each time you send a patch a new one will be created, and each
time you add a comment for the first time to the patch, another patch will be
created too. Forcing the devel to refetch the commit each time he/she pushes.

Not sure that smoothes up the dev process...

I think that the less painful path will be to use a commit hook locally, so the
commit message is changed locally first, but that will require the dev to
install it (we can ease that with a script or similar though)


> 
> 
> 
> >
> >
> > Thanks,
> > Nir
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> >
> 
> 
> 
> -- 
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com

> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra


-- 
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R

Tel.: +420 532 294 605
Email: dc...@redhat.com
Web: www.redhat.com
RHT Global #: 82-62605


signature.asc
Description: PGP signature
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Improving our github presense

[Nir Soffer]

Hi all,

Looking in ovirt github page, there are only 2 members:
https://github.com/orgs/oVirt/people

Is is possible to add automatically all contributors to this list?

Nir
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel