Re: [ovirt-devel] [VDSM] New network test failure - ctypes.ArgumentError: argument 3: : wrong type

2016-09-20 Thread Nir Soffer
On Tue, Sep 20, 2016 at 8:18 PM, Nir Soffer wrote: > Failed only one patch when building 4, so this looks like > a random failure, but the error is disturbing. > > See > http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc24-x86_64/2255/console > > 17:00:31 >

[ovirt-devel] [VDSM] Improving vdsm logging format

2016-09-20 Thread Nir Soffer
Hi all, We are reviewing patches for improving vdsm log format. The goal is to have more standard logging format, similar to engine logs and other logs in the ovirt project, to make it easier to debug and support the system. We know that this change will break tools people wrote to parse vdsm

[ovirt-devel] [VDSM] New network test failure - ctypes.ArgumentError: argument 3: : wrong type

2016-09-20 Thread Nir Soffer
Failed only one patch when building 4, so this looks like a random failure, but the error is disturbing. See http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc24-x86_64/2255/console 17:00:31 == 17:00:31 ERROR:

Re: [ovirt-devel] Dropping rpm build from ovirt-engine check-merged.sh

2016-09-20 Thread Nir Soffer
On Tue, Sep 20, 2016 at 11:27 AM, Eyal Edri wrote: > > > On Tue, Sep 20, 2016 at 9:34 AM, Sandro Bonazzola > wrote: > >> >> >> On Mon, Sep 19, 2016 at 7:56 PM, Eyal Edri wrote: >> >>> >>> >>> On Mon, Sep 19, 2016 at 9:41 AM, Sandro

Re: [ovirt-devel] Best (and up-to-date) practices for developers?

2016-09-20 Thread Phillip Bailey
I like that idea. I would prefer having the smaller, more focused files in a directory. I would probably call it documentation or something similar, though. -Phillip Bailey On Tue, Sep 20, 2016 at 9:14 AM, Roy Golan wrote: > > > On 19 September 2016 at 15:18, Martin Betak

Re: [ovirt-devel] Best (and up-to-date) practices for developers?

2016-09-20 Thread Roy Golan
On 19 September 2016 at 15:18, Martin Betak wrote: > Yeah definitely +1. > > Even after being with the project for some time, I often wonder about > things > like in what order should fields in class be based on their function (as in > logger, static sonstants, @Injected

[ovirt-devel] Updating permissions on gerrit.ovirt.org

2016-09-20 Thread Shlomo Ben David
Hi All, On the upcoming days i'm going to update permissions on gerrit.ovirt.org server. The changes shouldn't reflect on the current state but if you'll encounter with any permission issues or other issues related to gerrit.ovirt.org server please let me or in...@ovirt.org to know and we'll

Re: [ovirt-devel] Dropping rpm build from ovirt-engine check-merged.sh

2016-09-20 Thread Eyal Edri
On Tue, Sep 20, 2016 at 9:34 AM, Sandro Bonazzola wrote: > > > On Mon, Sep 19, 2016 at 7:56 PM, Eyal Edri wrote: > >> >> >> On Mon, Sep 19, 2016 at 9:41 AM, Sandro Bonazzola >> wrote: >> >>> >>> >>> On Sun, Sep 18, 2016 at 4:18 PM,

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-20 Thread Nir Soffer
On Tue, Sep 20, 2016 at 9:45 AM, Tal Nisan wrote: > +1 from me as well +1 ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] test-repo_ovirt_experimental_master job - failed

2016-09-20 Thread Sandro Bonazzola
On Fri, Sep 9, 2016 at 1:19 PM, Yaniv Kaul wrote: > Indeed, this is the log collector. I wonder if we collect its logs... > Y. > This can't be log-collector, it can be sos vdsm plugin. That said, if we run log-collector within lago we should collect the results as job

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-20 Thread Tal Nisan
+1 from me as well On Mon, Sep 19, 2016 at 6:41 PM, Martin Perina wrote: > > > On Mon, Sep 19, 2016 at 2:12 PM, Doron Fediuck > wrote: > >> Hi All, >> >> Martin Sivak has been working on the oVirt engine since June 2013. >> His main focus over the years

Re: [ovirt-devel] Dropping rpm build from ovirt-engine check-merged.sh

2016-09-20 Thread Sandro Bonazzola
On Mon, Sep 19, 2016 at 7:56 PM, Eyal Edri wrote: > > > On Mon, Sep 19, 2016 at 9:41 AM, Sandro Bonazzola > wrote: > >> >> >> On Sun, Sep 18, 2016 at 4:18 PM, Eyal Edri wrote: >> >>> Hi, >>> >>> Following [1] I'd like to propose to