Re: [ovirt-devel] Dropping rpm build from ovirt-engine check-merged.sh

2016-09-26 Thread Vojtech Szocs 
Hi,

to me, it seems that with current CI flow, we can do following:

- in build-artifacts.sh, build UI for English (only) & all supported
  browsers (IE10+, Firefox, Chrome), by using `ovirt_build_locales 0`
  as the default fallback

  Note: this will cut down the # of permutations from 3x9 to just 3
  (currently we have 3 supported browser types, 9 supported locales).

- ensure that release builds still target all supported UI locales,
  by using `ovirt_build_locales 1` (override the default fallback)

- it would be nice if the Jenkins job for build-artifacts.sh would
  set some `RELEASE=1` flag (or similar) when doing a release build
  (is this possible with current standard CI?)

Eyal/others, does above make sense?

Also, as Nir mentioned, if `ovirt-engine` repo was configured with
Submit Type == Fast Forward Only, we could drop RPM / GWT build in
check-merged.sh (which was Eyal's original suggestion).

Regards,
Vojtech


- Original Message -
> From: "Nir Soffer" 
> To: "Eyal Edri" 
> Cc: "Juan Hernandez" , "devel" , 
> "Martin Perina" , "Tal
> Nisan" , "infra" 
> Sent: Tuesday, September 20, 2016 5:38:08 PM
> Subject: Re: Dropping rpm build from ovirt-engine check-merged.sh
> 
> On Tue, Sep 20, 2016 at 11:27 AM, Eyal Edri < ee...@redhat.com > wrote:
> 
> 
> 
> 
> 
> On Tue, Sep 20, 2016 at 9:34 AM, Sandro Bonazzola < sbona...@redhat.com >
> wrote:
> 
> 
> 
> 
> 
> On Mon, Sep 19, 2016 at 7:56 PM, Eyal Edri < ee...@redhat.com > wrote:
> 
> 
> 
> 
> 
> On Mon, Sep 19, 2016 at 9:41 AM, Sandro Bonazzola < sbona...@redhat.com >
> wrote:
> 
> 
> 
> 
> 
> On Sun, Sep 18, 2016 at 4:18 PM, Eyal Edri < ee...@redhat.com > wrote:
> 
> 
> 
> Hi,
> 
> Following [1] I'd like to propose to remove rpm building from the
> 'check-merged.sh' script from ovirt-engine (master for now).
> 
> The job [2] takes on avg 15 min while actually the rpms are built already in
> check-patch
> (with gwt draft mode if needed) and runs exactly the same build rpm command
> as check-patch [3].
> 
> So there isn't real value in running exactly the same rpm build post merge,
> and we already build full permutation mode in 'build-artifacts.sh'.
> 
> Any reason to keep it?
> We can cut down valuable time in CI if we drop it and vacant more time for
> more meaningful tests.
> 
> 
> This depends on the flow: if we make check_merge gating to the merge and to
> the build we should keep the rpm build becuase at merge a rebase is done
> automatically.
> 
> What do you mean by 'gating to the merge'? I'm not sure I understand what it
> means.
> Isn't check-patch.sh does the gating? check-merge runs post merge so its
> already too late to gate the code ...
> And I think check-merge and check-patch currently runs the same rpmbuild
> command, so I don't see how check-merged has any value over check-patch.
> 
> when merge command is issued a rebase is done as well. We still need a
> check-merged job because the code checked by check-patch is not the same
> anymore when check-merged runs.
> 
> OK, now I understand, so indeed check-merge can potentially run on different
> code than check-patch and possibly fail due to it.
> 
> If we require only fast-forward merges, there is no way to merge patch
> before a rebase. Once you rebase a patch, check-patch runs...
> 
> So check-merge may be unneeded in this case.
> 
> 
> 
> 
> 
> 
> In original desing of stdci, check-merged was supposed to become a gating
> test for build-artifacts.
> 
> We have it in our backlog, i.e installing Zuul and adding gating for the
> check-merged jobs, its mostly relevant for system jobs, but we can defiently
> do it first for simple 'check-merged.sh' jobs
> as part of standard CI.
> 
> Opened a ticket for it [1]
> 
> [1] https://ovirt-jira.atlassian.net/browse/OVIRT-734
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> If there's not gating process performed by check-merge then I agree in
> dropping rpm build.
> 
> 
> 
> 
> 
> 
> [1] https://ovirt-jira.atlassian.net/browse/OVIRT-416
> [2]
> http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-el7-x86_64/buildTimeTrend
> [3]
> rpmbuild \
> -D "_rpmdir $PWD/output" \
> -D "_topmdir $PWD/rpmbuild" \
> -D "release_suffix ${SUFFIX}" \
> -D "ovirt_build_ut $BUILD_UT" \
> -D "ovirt_build_extra_flags $EXTRA_BUILD_FLAGS" \
> -D "ovirt_build_draft 1" \
> --rebuild output/*.src.rpm
> 
> 
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
> 
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
> 
> 
> 
> --
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com
> 
> 
> 
> 
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
> 
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
> 
> 
> 
> --
> Sandro Bonazzola
> Better

Re: [ovirt-devel] virt moving to trello

2016-09-26 Thread Roy Golan 
On 23 September 2016 at 16:21, Michal Skrivanek  wrote:

> Hi all,
> we’ve decided to open up our oVirt “virt” team and improve visibility of
> what we are working on right now. Bugzilla is utterly insufficient and it
> is tricky to see high level, long term items and how they evolve.
> So from now on you can check that out on trello[1]
> There’s not much yet, but the content will improve as we gradually
> transition feature design and tracking over there.
>
> Note we are not abandoning bugzilla, we still use it for bug-level
> tracking, for smaller and targeted things. Just those bigger awesome
> upcoming items are going to be on trello board from now on.
>
> Thanks,
> michal
>
>
+1 I think it's important and useful to publish what the team is doing or
planning to do. I hope that other teams will follow.
Have you got plans to expose the link under ovirt.org?

[1] https://trello.com/b/pWlunZVR/ovirt-virt
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [ANN] oVirt 4.0.4 Final Release is now available

2016-09-26 Thread Sandro Bonazzola 
The oVirt Project is pleased to announce the availability of oVirt 4.0.4,
as of September 26th, 2016.

This release is available now for:
* Fedora 23 (tech preview)
* Red Hat Enterprise Linux 7.2 or later
* CentOS Linux (or similar) 7.2 or later

This release supports Hypervisor Hosts running:
* Red Hat Enterprise Linux 7.2 or later
* CentOS Linux (or similar) 7.2 or later
* Fedora 23 (tech preview)
* oVirt Next Generation Node 4.0

This update is the fourth in a series of stabilization updates to the 4.0
series.
4.0.4 brings 11 enhancements and 139 bugfixes, including 58 high or urgent
severity fixes, on top of oVirt 4.0 series
See the release notes [3] for installation / upgrade instructions and a
list of new features and bugs fixed.

Notes:
* A new oVirt Live ISO is available. [4]
* A new oVirt Next Generation Node will be available soon [4].
* A new oVirt Engine Appliance is available for Red Hat Enterprise Linux
and CentOS Linux (or similar)
* Mirrors[5] might need up to one day to synchronize.

Additional Resources:
* Read more about the oVirt 4.0.4 release highlights:
http://www.ovirt.org/release/4.0.4/
* Get more oVirt Project updates on Twitter: https://twitter.com/ovirt
* Check out the latest project news on the oVirt blog:
http://www.ovirt.org/blog/

[1] https://www.ovirt.org/community/
[2] https://bugzilla.redhat.com/enter_bug.cgi?classification=oVirt
[3] http://www.ovirt.org/release/4.0.4/
[4] http://resources.ovirt.org/pub/ovirt-4.0/iso/
[5] http://www.ovirt.org/Repository_mirrors#Current_mirrors


-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] network test fails again on ovirt-4.0 branch

2016-09-26 Thread Nir Soffer 
On Mon, Sep 26, 2016 at 9:16 AM, Dan Kenigsberg  wrote:
> On Sun, Sep 25, 2016 at 05:23:00PM +0300, Nir Soffer wrote:
>> Hi all,
>>
>> This test seems to fail too much. Maybe we should mark it as broken in 
>> ovirt-4.0
>> branch?
>
> Adding Petr, who can either backport an existing fix, or mark it as
> borken_on_ci.
>
> Nir, you too can check if all that is needed is to take
> https://gerrit.ovirt.org/#/q/I5a1e9b84ebb68a881bed6a0c97a23ee4c6896434
> one notch backwards (to 3.6)

Yaniv already merged the patch, so I don't have anything to test with for
3.6.

But I think we should take this backport:
https://gerrit.ovirt.org/#/c/64438

>
>>
>> I tried 2 builds in a raw and it failed in both. The patch is of
>> course not related,
>> increating ioprocess required version.
>>
>> 14:14:04 
>> ==
>> 14:14:04 FAIL: test_events_keys (netlinkTests.NetlinkEventMonitorTests)
>> 14:14:04 
>> --
>> 14:14:04 Traceback (most recent call last):
>> 14:14:04   File
>> "/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/tests/testValidation.py",
>> line 105, in wrapper
>> 14:14:04 return f(*args, **kwargs)
>> 14:14:04   File
>> "/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/tests/netlinkTests.py",
>> line 133, in test_events_keys
>> 14:14:04 % (1 + len(expected_events)))
>> 14:14:04 AssertionError: 5 expected events have not been caught (in
>> the right order)
>> 14:14:04  >> begin captured logging << 
>> 
>> 14:14:04 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link
>> add name dummy_7odCO type dummy (cwd None)
>> 14:14:04 root: DEBUG: SUCCESS:  = '';  = 0
>> 14:14:04 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip -4 addr
>> add dev dummy_7odCO 192.0.2.1/24 (cwd None)
>> 14:14:04 root: DEBUG: SUCCESS:  = '';  = 0
>> 14:14:04 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link
>> set dev dummy_7odCO up (cwd None)
>> 14:14:04 root: DEBUG: SUCCESS:  = '';  = 0
>> 14:14:04 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link
>> del dev dummy_7odCO (cwd None)
>> 14:14:04 root: DEBUG: SUCCESS:  = '';  = 0
>> 14:14:04 - >> end captured logging << 
>> -
>>
>>
>> Nir
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] network test fails again on ovirt-4.0 branch

2016-09-26 Thread Dan Kenigsberg 
On Sun, Sep 25, 2016 at 05:23:00PM +0300, Nir Soffer wrote:
> Hi all,
> 
> This test seems to fail too much. Maybe we should mark it as broken in 
> ovirt-4.0
> branch?

Adding Petr, who can either backport an existing fix, or mark it as
borken_on_ci.

Nir, you too can check if all that is needed is to take
https://gerrit.ovirt.org/#/q/I5a1e9b84ebb68a881bed6a0c97a23ee4c6896434
one notch backwards (to 3.6)

> 
> I tried 2 builds in a raw and it failed in both. The patch is of
> course not related,
> increating ioprocess required version.
> 
> 14:14:04 
> ==
> 14:14:04 FAIL: test_events_keys (netlinkTests.NetlinkEventMonitorTests)
> 14:14:04 
> --
> 14:14:04 Traceback (most recent call last):
> 14:14:04   File
> "/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/tests/testValidation.py",
> line 105, in wrapper
> 14:14:04 return f(*args, **kwargs)
> 14:14:04   File
> "/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/tests/netlinkTests.py",
> line 133, in test_events_keys
> 14:14:04 % (1 + len(expected_events)))
> 14:14:04 AssertionError: 5 expected events have not been caught (in
> the right order)
> 14:14:04  >> begin captured logging << 
> 
> 14:14:04 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link
> add name dummy_7odCO type dummy (cwd None)
> 14:14:04 root: DEBUG: SUCCESS:  = '';  = 0
> 14:14:04 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip -4 addr
> add dev dummy_7odCO 192.0.2.1/24 (cwd None)
> 14:14:04 root: DEBUG: SUCCESS:  = '';  = 0
> 14:14:04 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link
> set dev dummy_7odCO up (cwd None)
> 14:14:04 root: DEBUG: SUCCESS:  = '';  = 0
> 14:14:04 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link
> del dev dummy_7odCO (cwd None)
> 14:14:04 root: DEBUG: SUCCESS:  = '';  = 0
> 14:14:04 - >> end captured logging << 
> -
> 
> 
> Nir
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel