Re: [ovirt-devel] [QE][ACTION REQUIRED] postponing beta release due to basic sanity test failure

2014-06-28 Thread Allon Mureinik
- Original Message - From: Sandro Bonazzola sbona...@redhat.com To: devel@ovirt.org, us...@ovirt.org Sent: Friday, June 27, 2014 10:44:51 AM Subject: [ovirt-devel] [QE][ACTION REQUIRED] postponing beta release due to basic sanity test failure Hi, while performing basic sanity

Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils

2014-08-21 Thread Allon Mureinik
IMO, we have too many classes that do the same (useless) thing - org.ovirt.engine.core.utils.linq.LinqUtils and org.ovirt.engine.core.common.utils.ListUtils, which both have no place in oVirt-engine. Why not scrap both of them, upgrade commons-collections to the modern 4.0 and use

Re: [ovirt-devel] [ovirt-users] [QE][ACTION REQUIRED] oVirt 3.5.0 status - Go / No Go

2014-10-01 Thread Allon Mureinik
- Original Message - From: Sandro Bonazzola sbona...@redhat.com To: us...@ovirt.org, devel@ovirt.org Sent: Tuesday, September 30, 2014 5:46:15 PM Subject: Re: [ovirt-users] [QE][ACTION REQUIRED] oVirt 3.5.0 status - Go / No Go Il 29/09/2014 08:34, Sandro Bonazzola ha scritto:

Re: [ovirt-devel] [QE][ACTION REQUIRED] oVirt 3.5.1 RC status

2014-11-26 Thread Allon Mureinik
- Original Message - From: Sandro Bonazzola sbona...@redhat.com To: nsof...@redhat.com, Darshan Narayana Murthy dnara...@redhat.com, us...@ovirt.org, devel@ovirt.org, infra in...@ovirt.org Sent: Wednesday, November 26, 2014 10:15:11 AM Subject: [ovirt-devel] [QE][ACTION REQUIRED]

Re: [ovirt-devel] findbugs errors -- any way to prevent mad bot from rampant -1s?

2014-12-08 Thread Allon Mureinik
- Original Message - From: Greg Sheremeta gsher...@redhat.com To: in...@ovirt.org, devel@ovirt.org Cc: Eyal Edri ee...@redhat.com Sent: Tuesday, December 9, 2014 1:52:01 AM Subject: findbugs errors -- any way to prevent mad bot from rampant -1s? Hi, Is there any way to prevent

Re: [ovirt-devel] Move bugs to ON_QA based on snapshot builds?

2015-01-28 Thread Allon Mureinik
- Original Message - From: Lior Vernia lver...@redhat.com To: devel@ovirt.org, in...@ovirt.org Sent: Wednesday, January 28, 2015 10:44:44 AM Subject: Move bugs to ON_QA based on snapshot builds? Hello everyone, I wanted to suggest that we automate the change of oVirt 3.6 bug

Re: [ovirt-devel] REST api and template creation

2015-05-13 Thread Allon Mureinik
The fix looks simple enough. Amit - can you backport it please? - Original Message - From: Juan Hernández jhern...@redhat.com To: Christopher Pereira krip...@imatronix.cl, devel@ovirt.org, Allon Mureinik amure...@redhat.com, aavi...@redhat.com Sent: Monday, May 11, 2015 12:48:49 PM

Re: [ovirt-devel] Can't reach webadmin after nightly update from master

2015-04-09 Thread Allon Mureinik
the devel list is probably more appropriate for this question. Yevgeny, IIRC you handled something similar recently, no? - Original Message - From: Michael Burman mbur...@redhat.com To: in...@ovirt.org Sent: Thursday, April 9, 2015 12:05:13 PM Subject: Can't reach webadmin after

Re: [ovirt-devel] Live export/import

2015-06-21 Thread Allon Mureinik
Another way, if you have a domain to spare, would be to detach the domain containing the VM and attaching it to another setup. Otherwise, you're limited to either an export domain (which requires copying twice, as you mentioned), or some manual procedure like you suggested. - Original

Re: [ovirt-devel] Unable to import templates

2015-05-28 Thread Allon Mureinik
- Original Message - From: Christopher Pereira krip...@imatronix.cl To: devel@ovirt.org Sent: Tuesday, May 26, 2015 1:44:16 AM Subject: [ovirt-devel] Unable to import templates Hi, A user was unable to import a VM template from a gluster export storage because of various

[ovirt-devel] AppErrors cleanup

2015-07-29 Thread Allon Mureinik
Hi all, A recent bug [1] reported as part of the translation effort alerted me to the fact that we have a lot (and I mean a LOT - over 100 per file) of deprecated, unused keys in the various AppErrors files that serve no purpose and just take up space and waste translators time when they

Re: [ovirt-devel] Vdsm: extending maintainers team

2015-08-09 Thread Allon Mureinik
Congrats guys! On Sun, Aug 9, 2015 at 5:24 PM, Doron Fediuck dfedi...@redhat.com wrote: Congratulations all! On Thu, Aug 6, 2015 at 12:20 PM, Francesco Romani from...@redhat.com wrote: Thanks everyone! I'm honoured and very happy to have reached this milestone, and this is a very

Re: [ovirt-devel] Requiring Java 8 during runtime

2015-10-27 Thread Allon Mureinik
I think it's a really bad practice to have different modules in the same project with different language versions. For GWT it seems to be required, but for the rest of the backend, I think we should have one patch that moves the entire project in one go. We can have the various maintainers ack it

Re: [ovirt-devel] OVF_STORE volumes are not updated

2015-10-14 Thread Allon Mureinik
This is what we discussed on BZ#1268842, right? On Mon, Oct 5, 2015 at 11:35 AM, Christopher Pereira wrote: > Hi, > > I noticed that OVF_STORE volumes are not generated periodically as > expected [1]. > It seems like the OVF_STORE volumes are only generated when the

[ovirt-devel] Abandoning old patches

2015-09-05 Thread Allon Mureinik
Hi guys, Gerrit is our front yard, and we'd like to keep it clean, tidy, and welcoming to newcommers. We have a jenkins job waiting to act as a roomba just waiting to be switched on (thanks Eyal!). It will send out an email about patches being stale for over 300 days and will force abandon

Re: [ovirt-devel] [VDSM] Coverage reports

2015-12-02 Thread Allon Mureinik
Awesome! Infra stakeholders - any chance to have this pushed to the devel list once a month (or some other reasonable period)? On Fri, Nov 27, 2015 at 8:57 PM, Nir Soffer wrote: > Hi all, > > Thanks to Edward, we have now coverage reports in jenkins. > > The way to access

Re: [ovirt-devel] AppErrors cleanup

2015-12-13 Thread Allon Mureinik
Same has been done for AuditLogMessages.properties (vs. the AuditLogType enum). On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik <amure...@redhat.com> wrote: > Hi all, > > A recent bug [1] reported as part of the translation effort alerted me to > the fact that we have a lot

Re: [ovirt-devel] Question about https://gerrit.ovirt.org/#/c/49860/

2015-12-10 Thread Allon Mureinik
Adding devel list, which was dropped by mistake. On Thu, Dec 10, 2015 at 1:56 PM, Allon Mureinik <amure...@redhat.com> wrote: > > > On Wed, Dec 9, 2015 at 6:51 PM, Vojtech Szocs <vsz...@redhat.com> wrote: > >> Hi Allon, >> >> not sure if you saw my e

Re: [ovirt-devel] Improving our github presense

2015-11-28 Thread Allon Mureinik
More on the same topic: The engine currently has 3 open issue reports, all of them about a year and half old: https://github.com/oVirt/ovirt-engine/issues Can we close them please? On Wed, Nov 18, 2015 at 10:48 PM, David Caro wrote: > On 11/18 18:08, David Caro wrote: >> On

[ovirt-devel] Diamonds are a (Java) developer's best friends

2015-12-01 Thread Allon Mureinik
Hi team, Back in the day, somewhere between the discovery of fire and the wheel, Java 5 introduced generics. This was a great step forwards, but also created some of the most horrible boiler-plated code you could imagine: Map = new HashMap(); Java 7

Re: [ovirt-devel] DRBD Integration with oVirt

2016-06-13 Thread Allon Mureinik
wrote: > > > On 06/13/2016 09:51 AM, Allon Mureinik wrote: > >> Maybe I'm being daft, but I'm missing something basic here. >> What's the end goal? A DRBD Storage Domain in oVirt? >> >> > Hi Allon, > > A DRBD Storage Domain in oVirt is the goal, yes. >

Re: [ovirt-devel] DRBD Integration with oVirt

2016-06-13 Thread Allon Mureinik
Maybe I'm being daft, but I'm missing something basic here. What's the end goal? A DRBD Storage Domain in oVirt? On Fri, Jun 3, 2016 at 9:13 PM, Hayley Swimelar wrote: > Hello all, > > A DRBD integration into oVirt is currently being planned. > > DRBD provides replicated,

Re: [ovirt-devel] gerrit.ovirt.org migration

2016-07-10 Thread Allon Mureinik
Congrats guys, and thanks for your efforts! >From some very basic clicking around and basic reviewing it indeed seems faster, although this is a very raw first impression. -Allon On Sun, Jul 10, 2016 at 6:37 PM, Eyal Edri wrote: > Back up now. > > It is running now with 30GB

[ovirt-devel] [ATTENTION] oVirt Engine tests now use Mockito 2.6.5

2017-01-23 Thread Allon Mureinik
Good morning Engine developers, As of this morning, oVirt Engine has migrated to the next generation of Mockito, specifically, the latest available version - 2.6.5 (well, the latest version at the time this email was issued. Their z-stream are as small as a single patch, and thus REALLY fast).

Re: [ovirt-devel] Redundant stomp connection for SPM

2017-01-24 Thread Allon Mureinik
In the jsonrpc era, I can't think, offhand, about a good reason to keep these two connections. Liron - any insight? On Tue, Jan 24, 2017 at 6:18 PM, Roy Golan wrote: > +storage ping > > On 17 January 2017 at 12:19, Piotr Kliczewski > wrote: >> >>

Re: [ovirt-devel] Failure on start VM in ovirt-system-tests from patches merged to master on the 25/10/2016

2016-10-27 Thread Allon Mureinik
> [bll.jar:] > at > org.ovirt.engine.core.bll.RunVmCommand.perform(RunVmCommand.java:414) > [bll.jar:] > at > org.ovirt.engine.core.bll.RunVmCommand.executeVmCommand(RunVmCommand.java:339) > [bll.jar:] > at > org.ovirt.engine.core.bll.VmCommand

Re: [ovirt-devel] Failure on start VM in ovirt-system-tests from patches merged to master on the 25/10/2016

2016-10-26 Thread Allon Mureinik
@Infra - the last experimental job I saw was from ~17:30 local Israel time. Any idea why another one isn't being triggered (or am I just being daft)? On Wed, Oct 26, 2016 at 6:27 PM, Allon Mureinik <amure...@redhat.com> wrote: > Yipes. > [1] should fix that, waiting for the CI to

Re: [ovirt-devel] Failure on start VM in ovirt-system-tests from patches merged to master on the 25/10/2016

2016-10-27 Thread Allon Mureinik
Now I also see it in the CI. I merged the patch so we can squeeze in as many CI runs as possible before the weekend. On Thu, Oct 27, 2016 at 11:38 AM, Allon Mureinik <amure...@redhat.com> wrote: > [Adding Martin Sivak.] > > That reproduces on my setup too, but didn

Re: [ovirt-devel] Failure on start VM in ovirt-system-tests from patches merged to master on the 25/10/2016

2016-10-27 Thread Allon Mureinik
The 004 CI is now passing, and it fails on 006. I merged a patch for the failure, let's see where we get next. On Thu, Oct 27, 2016 at 3:13 PM, Allon Mureinik <amure...@redhat.com> wrote: > Now I also see it in the CI. > > I merged the patch so we can squeeze in as many CI r

Re: [ovirt-devel] Failure on start VM in ovirt-system-tests from patches merged to master on the 25/10/2016

2016-10-27 Thread Allon Mureinik
for the noise. On Thu, Oct 27, 2016 at 6:40 PM, Allon Mureinik <amure...@redhat.com> wrote: > The 004 CI is now passing, and it fails on 006. > I merged a patch for the failure, let's see where we get next. > > On Thu, Oct 27, 2016 at 3:13 PM, Allon Mureinik <amure...@redhat.com

[ovirt-devel] MockConfigRule for default values

2016-10-30 Thread Allon Mureinik
​​ Hi all, One of my long time frustrations with MockConfigRule was the bloating it caused by forcing you to mock each and every ConfigValue you may use, when more often than not you don't really care about the value but just was your test to not fail with a NullPointerException. I've recently

Re: [ovirt-devel] oVirt Engine checkstyle upgrade

2017-03-27 Thread Allon Mureinik
On Mon, Mar 27, 2017 at 3:09 PM, Allon Mureinik <amure...@redhat.com> wrote: > Indeed, Greg.thanks > > As a temporary solution, you could cherry-pick https://gerrit. > ovirt.org/#/c/74611 and work above it. > It should solve the issue (even though IMHO it isn't ready fo

[ovirt-devel] oVirt Engine checkstyle upgrade

2017-03-22 Thread Allon Mureinik
Hi all, As per [1], I've just merged a series of patches that upgrades the oVirt engine to use the latest maven-checkstyle-plugin and checkstyle packages. Please note that the newer checkstyle is a tad stricter than the old one we used to have (read: it contains several fixes for bugs where the

Re: [ovirt-devel] oVirt Engine checkstyle upgrade

2017-03-27 Thread Allon Mureinik
On Mon, Mar 27, 2017 at 8:48 PM, Vojtech Szocs <vsz...@redhat.com> wrote: > > > On Mon, Mar 27, 2017 at 2:10 PM, Allon Mureinik <amure...@redhat.com> > wrote: > >> >> >> On Mon, Mar 27, 2017 at 3:09 PM, Allon Mureinik <amure...@

Re: [ovirt-devel] Line of death for tests

2017-03-16 Thread Allon Mureinik
Issue reported on Mockito: https://github.com/mockito/mockito/issues/990 On Thu, Mar 16, 2017 at 8:36 PM, Allon Mureinik <amure...@redhat.com> wrote: > The root cause seems to be MigrateVmCommandTest and its relation to > MigrateVmCommand. > > A common misconception is

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 12-07-2017 ] [ 004_basic_sanity.live_storage_migration ]

2017-07-13 Thread Allon Mureinik
Definitely looks like it's related to that patch series. I'm on it. On Thu, Jul 13, 2017 at 11:18 AM, Evgheni Dereveanchin wrote: > Hi, we have OST failing on Master > > Test failed: [ 004_basic_sanity.live_storage_migration ] > Link to suspected patches:

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 12-07-2017 ] [ 004_basic_sanity.live_storage_migration ]

2017-07-13 Thread Allon Mureinik
On Thu, Jul 13, 2017 at 1:24 PM, Eyal Edri <ee...@redhat.com> wrote: > > > On Thu, Jul 13, 2017 at 12:50 PM, Allon Mureinik <amure...@redhat.com> > wrote: > >> https://gerrit.ovirt.org/#/c/79381/ should solve this. >> >> I'm waiting for the "regu

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 12-07-2017 ] [ 004_basic_sanity.live_storage_migration ]

2017-07-13 Thread Allon Mureinik
https://gerrit.ovirt.org/#/c/79381/ should solve this. I'm waiting for the "regular" CI to complete before merging. On Thu, Jul 13, 2017 at 11:35 AM, Allon Mureinik <amure...@redhat.com> wrote: > Definitely looks like it's related to that patch series. > > I'm on it.

Re: [ovirt-devel] [ovirt-users] Help get oVirt's add featured on Stack Overflow

2017-07-27 Thread Allon Mureinik
Spotted in the wild! [1] [1] http://imgur.com/ZVFsbPg On Mon, Jul 3, 2017 at 2:34 PM, Allon Mureinik <amure...@redhat.com> wrote: > As Nicolas stated below, and as evident by [1], ladies and gentlemen - we > are live. > > First person to share an actual screenshot of Stack O

[ovirt-devel] Help get oVirt's add featured on Stack Overflow

2017-06-29 Thread Allon Mureinik
Hi lists, Thanks to Eldan, we have a community ad for oVirt proposed on Stack Overflow [1]. Now, we need some upvotes (current threshold is 6) before SO starts serving it. Have a SO account? Want to help? Just drop by and upvote. Have a great weekend, Allon [1]

Re: [ovirt-devel] [ovirt-users] Help get oVirt's add featured on Stack Overflow

2017-07-03 Thread Allon Mureinik
://meta.stackoverflow.com/ads/display/349017 On Fri, Jun 30, 2017 at 4:30 AM, Jeff Burns <admiral...@gmail.com> wrote: > This is an excellent thing. Thanks Eldan. I've cast my vote. > > On Thu, Jun 29, 2017 at 12:38 PM <nico...@devels.es> wrote: > >> El 2017-06-29 17:27, Al

Re: [ovirt-devel] [ OST Failure Report ] [ basic_suite_master ] [004_basic_sanity.disk_operations]

2017-07-30 Thread Allon Mureinik
Benny, can you make heads or tails of this? On Sat, Jul 29, 2017 at 8:25 PM, Dusan Fodor wrote: > Hello all, > could you please take a look at this? > > Test failed: 004_basic_sanity.disk_operations > Link to all test logs: http://jenkins.ovirt.org/job/ovirt-master_change- >

[ovirt-devel] DBUnit upgrade and format change

2017-05-12 Thread Allon Mureinik
Hi all, In an attempt to make maintaining Engine's DAO tests a bit more manageable, yesterday I've merged patches to upgrade the DBUnit version we're using to the latest available version, 2.5.3 [1], and changed the format to flat-XML [2], ending up with a fixures.xml file which is almost 10K

Re: [ovirt-devel] Snapshots & clone support from datastore

2017-06-20 Thread Allon Mureinik
eepak Jagtap > *Sent:* Tuesday, June 6, 2017 3:37:03 PM > *To:* Allon Mureinik > *Cc:* devel@ovirt.org > *Subject:* Re: [ovirt-devel] Snapshots & clone support from datastore > > > Thanks Allon! > > > Best Regards, > > Deepak > --

Re: [ovirt-devel] AppErrors.properties merged together

2017-06-21 Thread Allon Mureinik
On Wed, Jun 21, 2017 at 9:12 AM, Allon Mureinik <amure...@redhat.com> wrote: > > > On Tue, Jun 13, 2017 at 2:55 PM, Vojtech Szocs <vsz...@redhat.com> wrote: > >> Hi Jakub, thanks for taking the effort to simplify AppErrors handling! >> >> The AppErrors.

Re: [ovirt-devel] AppErrors.properties merged together

2017-06-21 Thread Allon Mureinik
On Tue, Jun 13, 2017 at 2:55 PM, Vojtech Szocs wrote: > Hi Jakub, thanks for taking the effort to simplify AppErrors handling! > > The AppErrors.properties file and its localized variants should live in a > single location, e.g. frontend/webadmin/modules/frontend. We should

[ovirt-devel] [ENGINE] standardizing query creation

2017-05-26 Thread Allon Mureinik
Hi list, As you may have noticed, there's a bit of an ambiguity on how query objects are created - some have a constructor from a parameters object, some have a constructor from a parameters object and an EngineContext, and some have both. This ambiguity leads to all sorts of annoying bugs where

Re: [ovirt-devel] Snapshots & clone support from datastore

2017-06-06 Thread Allon Mureinik
Unfortunately, there's no such integration point at the moment. On Tue, Jun 6, 2017 at 5:57 AM, Deepak Jagtap wrote: > Hey Guys, > > > I am newbie to ovirt, and wanted to confirm whats the best way to leverage > snapshot, clone features > > provided by the datastore

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 2017-09-11 ]

2017-09-14 Thread Allon Mureinik
After some digging around, this patch was indeed the reason for the failure. A partial revert was posted to gerrit, and manually running OST on it shows it solves the issue. I merged the patch, and Eyal (S) will continue working on a real solution to BZ1185782 next week. On Thu, Sep 14, 2017 at

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 2017-09-07 ] [import_template_from_glance]

2017-09-11 Thread Allon Mureinik
That was more a less the my guess from the brief look I took at the stacktrace. I don't want to +2 a patch in the network area, but I'd suggest merging this patch (which seems right regardless of the recent failure), and see if it solves the OST issue. On Mon, Sep 11, 2017 at 9:47 PM, Roy Golan

Re: [ovirt-devel] URGENT! OST broken! please stop merging patches to ovirt-engine!

2017-08-30 Thread Allon Mureinik
The relevant path is most definitely the cause for Sunday's issue: 2017-08-30 04:38:52,542-04 ERROR [org.ovirt.engine.core.bll.RunVmOnceCommand] (default task-18) [5c4b4916-9832-4460-a391-cac53ef8f19a] Error during ValidateFailure.: java.lang.ClassCastException:

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt Master ] [ bootstrap.verify_add_hosts ] [ 18/10/17 ]

2017-10-19 Thread Allon Mureinik
The missing deps issue happened again this morning [1]: Traceback (most recent call last): File "/tmp/ovirt-q04eYYi5Ym/pythonlib/otopi/context.py", line 133, in _executeMethod method['method']() File "/tmp/ovirt-q04eYYi5Ym/otopi-plugins/otopi/packagers/yumpackager.py", line 256, in

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt Master ] [ bootstrap.verify_add_hosts ] [ 18/10/17 ]

2017-10-18 Thread Allon Mureinik
These patches are part of the engine backend - the failure happens WAY beforehand, they don't look related as far as I can tell. Subsequent failures of the same suite seem to have different errors, e.g.: Traceback (most recent call last): File

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 2017-11-13 ] [add_master_storage_domain]

2017-11-13 Thread Allon Mureinik
It's most definitely not THAT patch. Could be one of the earlier patches in the series, though. Looking. On Mon, Nov 13, 2017 at 10:54 AM, Barak Korren wrote: > On 13 November 2017 at 10:08, Nir Soffer wrote: > > > > > > On Mon, Nov 13, 2017 at 9:56 AM

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 2017-11-13 ] [add_master_storage_domain]

2017-11-13 Thread Allon Mureinik
Both are merged, let's see how OST fares On Mon, Nov 13, 2017 at 12:00 PM, Allon Mureinik <amure...@redhat.com> wrote: > I merged 83920 with dependencies. Perhaps gerrit doesn't handle such > chains properly (or perhaps our CI is misusing the API?). > > WRT current issues,

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 2017-11-13 ] [add_master_storage_domain]

2017-11-13 Thread Allon Mureinik
Commit 86bf82e746404145e8b97df46f514086e4f82e69 is probably the offending commit, taking a deeper look now, should have a fix within the hour On Mon, Nov 13, 2017 at 9:55 AM, Barak Korren wrote: > Test failed: [ add_master_storage_domain ] > > Link to suspected patches: > -

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 2017-11-13 ] [add_master_storage_domain]

2017-11-13 Thread Allon Mureinik
altogether - https://gerrit.ovirt.org/#/c/83987/ - should fix the OST regression you noted. I'm waiting for the CI to finish running on both and will merge. On Mon, Nov 13, 2017 at 11:26 AM, Barak Korren <bkor...@redhat.com> wrote: > On 13 November 2017 at 11:10, Allon Mureinik <amure..

Re: [ovirt-devel] failing check-patch on ovirt-engine

2017-11-13 Thread Allon Mureinik
Probably another instead of [1]. Retriggering the job should probably clear the issue up. [1] http://lists.ovirt.org/pipermail/devel/2017-November/031840.html On Sun, Nov 12, 2017 at 5:53 PM, Greg Sheremeta wrote: > Hi, > > I'm seeing a weird issue in ovirt-engine

Re: [ovirt-devel] Subject: [ OST Failure Report ] [ oVirt master ] [ 26.11.17 ] [ 001_initialize_engine ]

2017-11-27 Thread Allon Mureinik
On Mon, Nov 27, 2017 at 2:30 PM, Allon Mureinik <amure...@redhat.com> wrote: > The analysis is completely wrong. > > The offending patch is [1]. I assume the reason for the failure is that > gap between when the CI passed (Nov 21) and when it was merged (Nov 26). In > the

Re: [ovirt-devel] Subject: [ OST Failure Report ] [ oVirt master ] [ 26.11.17 ] [ 001_initialize_engine ]

2017-11-27 Thread Allon Mureinik
The analysis is completely wrong. The offending patch is [1]. I assume the reason for the failure is that gap between when the CI passed (Nov 21) and when it was merged (Nov 26). In the five days in between, other patches entered master and invalidated this CI result. To quote the job's log: """

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt 4.1 ] [ 27-11-2017] [ 001_initialize_engine.test_initialize_engine ]

2017-11-27 Thread Allon Mureinik
I doubt that patch has anything to do with ovirt-imageio not starting. Daniel/Nir - any insight? On Mon, Nov 27, 2017 at 5:11 PM, Dafna Ron wrote: > *Hi, * > > * We have a failure reported in ovirt 4.1 on ovirt-imageio not starting > and causing initialize_engine to fail I am

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 23-11-2017 ] [ 001_initialize_engine.test_initialize_engine ]

2017-11-27 Thread Allon Mureinik
nkins.ovirt.org/blue/rest/organizations/jenkins/pip >> elines/ovirt-master_change-queue-tester/runs/4153/nodes/123/ >> steps/241/log/?start=0 >> >>>> >> >>>> [2] >> >>>> http://jenkins.ovirt.org/view/Change%20queue%20jobs/job/ovir >> t-master_change-queue-test

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 23-11-2017 ] [ 001_initialize_engine.test_initialize_engine ]

2017-11-23 Thread Allon Mureinik
Daniel/Nir? On Thu, Nov 23, 2017 at 5:29 PM, Dafna Ron wrote: > Hi, > > We have a failing on test 001_initialize_engine.test_initialize_engine. > > This is failing with error Failed to start service 'ovirt-imageio-proxy > > > *Link and headline ofto suspected patches: * > > > *

Re: [ovirt-devel] ovirt.org presentation template

2017-11-23 Thread Allon Mureinik
Yup: https://www.ovirt.org/community/get-involved/resources/slide-decks/ On Thu, Nov 23, 2017 at 4:42 PM, Yaniv Kaul wrote: > Hi, > > Do we have such a template for presentation? > TIA, > Y. > > ___ > Devel mailing list >

[ovirt-devel] Jupiter isn't just a planet - it's how we test things in the Engine

2018-05-10 Thread Allon Mureinik
Hi all, Over the past couple of days I've merged a series of patches that upgrade the Engine's usage of JUnit to JUnit Jupiter 5.2 in order to make it easier to write new tests. Despite the patches being quite straight-forward, since Jupiter is **not** backwards compatible to JUnit 4, or even

[ovirt-devel] Jupiter isn't just a planet - it's how we test things in the Engine

2018-05-10 Thread Allon Mureinik
Hi all, Over the past couple of days I've merged a series of patches that upgrade the Engine's usage of JUnit to JUnit Jupiter 5.2 in order to make it easier to write new tests. Despite the patches being quite straight-forward, since Jupiter is **not** backwards compatible to JUnit 4, or even

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt Master ] [ bootstrap.verify_add_hosts ] [ 18/10/17 ]

2017-10-19 Thread Allon Mureinik
Bloody hell. The original was also completely broken, and worked by chance. Damn it. This should fix it: https://gerrit.ovirt.org/#/c/82989/ On Thu, Oct 19, 2017 at 3:49 PM, Martin Perina wrote: > So the real issue on adding a host is the same as I've today described in >

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt Master ] [ bootstrap.verify_add_hosts ] [ 18/10/17 ]

2017-10-19 Thread Allon Mureinik
Fix merged based on Alona and Martin's reviews. It seems to do the trick with my testing on my local engine, let's hope that's really it. On Thu, Oct 19, 2017 at 4:37 PM, Allon Mureinik <amure...@redhat.com> wrote: > Bloody hell. The original was also completely broken, and worked by

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt Master ] [ bootstrap.verify_add_hosts ] [ 18/10/17 ]

2017-10-19 Thread Allon Mureinik
not my finest hour. thanks, Barak, it's merged now. On Thu, Oct 19, 2017 at 6:29 PM, Barak Korren <bkor...@redhat.com> wrote: > > > On 19 October 2017 at 17:48, Allon Mureinik <amure...@redhat.com> wrote: > >> Fix merged based on Alona and Martin's reviews. >&

[ovirt-devel] Let's get oVirt in Stack Overflow's Open Source Advertising again

2018-02-22 Thread Allon Mureinik
Hi all, With Eldan's help, we have an advert for oVirt [1] suggested on Stack Overflow's traditional Open Source Advertising campaign [2]. Like always, we need the upvotes to get it up there. Want to see oVirt on Stack Overflow's sidebar again? Hope over and upvote. -Allon [1]

Re: [ovirt-devel] [ovirt-users] qemu-kvm-ev-2.9.0-16.el7_4.14.1 has been released

2018-03-12 Thread Allon Mureinik
>From oVirt's perspective - this build includes a fix that allows for live storage migration of a disk that uses iothreads. I've already posted a vdsm patch to require it, reviews are welcome: https://gerrit.ovirt.org/#/c/88770/ And thanks for the quick turnaround here, Sandro! On Fri, Mar 9,

[ovirt-devel] [ENGINE] JUnit version upgrade

2018-03-28 Thread Allon Mureinik
Hi oVirt Engine developers, I've just merged a patch to bump oVirt Engine's JUnit requirement to the latest available 5.1 GA. As a first step, I've integrated the vintage engine, which is a drop-in replacement that can run old JUnit 4 (and even JUnit 3!) tests, just with a newer runtime engine.

Re: [Engine-devel] revievers needed

2012-03-15 Thread Allon Mureinik
I'd be happy to review them, but someone else will have to +2 them. - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, March 15, 2012 12:50:31 PM Subject: [Engine-devel] revievers needed Hi, I have a big pile of

[Engine-devel] The easy way to mock Config in your unit tests

2012-05-14 Thread Allon Mureinik
-devel] The correct way to create test dependencies between +1 I like the idea, I think this would really improve our unit tests. - Original Message - From: Allon Mureinik amure...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Sunday, May 6, 2012 2:46:03 PM

Re: [Engine-devel] git-review error.

2012-05-15 Thread Allon Mureinik
Hi Sharad, I'm not too big on git-review, but AFAIK -t is used to supply a topic (see https://github.com/openstack-ci/git-review#readme). can you try with an explicit notation refs/for/master/nullpointer ? -Allon - Original Message - From: snmis...@linux.vnet.ibm.com To:

[Engine-devel] Testing queries

2012-06-11 Thread Allon Mureinik
Hi guys, following some questions from last week regarding writing unit-tests for query objects, I whipped up this quick wiki page: http://ovirt.org/wiki/Testing_Queries Enjoy, Allon ___ Engine-devel mailing list Engine-devel@ovirt.org

Re: [Engine-devel] Forking unit tests

2012-06-14 Thread Allon Mureinik
- Original Message - From: Roy Golan rgo...@redhat.com To: engine-devel@ovirt.org Sent: Wednesday, June 13, 2012 4:14:06 PM Subject: Re: [Engine-devel] Forking unit tests On 06/13/2012 03:41 PM, Laszlo Hornyak wrote: We can just move the surefire config to a higher level in the

Re: [Engine-devel] oVirt UI: Legacy UserPortal removed

2012-06-14 Thread Allon Mureinik
awesome! - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Vojtech Szocs vsz...@redhat.com, engine-devel@ovirt.org Sent: Thursday, June 14, 2012 2:29:40 PM Subject: Re: [Engine-devel] oVirt UI: Legacy UserPortal removed Hi, A visualization of how that counts

Re: [Engine-devel] Developer's All In One

2012-06-18 Thread Allon Mureinik
Cross-posting to engine-devel - Forwarded Message - From: Yeela Kaplan ykap...@redhat.com To: vdsm-de...@lists.fedorahosted.org, engine-de...@lists.fedorahosted.org Cc: Ayal Baron aba...@redhat.com Sent: Monday, June 18, 2012 2:58:55 PM Subject: Developer's All In One Enclosed

Re: [Engine-devel] Forking unit tests

2012-06-24 Thread Allon Mureinik
- Original Message - From: Allon Mureinik amure...@redhat.com To: Mike Kolesnik mkole...@redhat.com Sent: Thursday, June 14, 2012 12:12:54 PM Subject: Re: Forking unit tests - Original Message - From: Mike Kolesnik mkole...@redhat.com To: Allon Mureinik amure

Re: [Engine-devel] java 1.6 compatibility no more?

2012-07-22 Thread Allon Mureinik
- Original Message - From: Vojtech Szocs vsz...@redhat.com To: Juan Hernandez jhern...@redhat.com Cc: engine-devel@ovirt.org Sent: Thursday, July 19, 2012 2:31:40 PM Subject: Re: [Engine-devel] java 1.6 compatibility no more? Don't we need that (the source part) to avoid Java 7

Re: [Engine-devel] java 1.6 compatibility no more?

2012-07-22 Thread Allon Mureinik
- Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Juan Hernandez jhern...@redhat.com Cc: engine-devel@ovirt.org Sent: Thursday, July 19, 2012 3:04:17 PM Subject: Re: [Engine-devel] java 1.6 compatibility no more? Hi, At the moment if you update the source and

Re: [Engine-devel] java 1.6 compatibility no more?

2012-07-22 Thread Allon Mureinik
- Original Message - From: Ayal Baron aba...@redhat.com To: Itamar Heim ih...@redhat.com Cc: Juan Hernandez jhern...@redhat.com, engine-devel@ovirt.org, Allon Mureinik amure...@redhat.com Sent: Sunday, July 22, 2012 8:34:32 PM Subject: Re: [Engine-devel] java 1.6 compatibility

Re: [Engine-devel] java 1.6 compatibility no more?

2012-07-22 Thread Allon Mureinik
- Original Message - From: Itamar Heim ih...@redhat.com To: Allon Mureinik amure...@redhat.com Cc: Livnat Peer lp...@redhat.com, Juan Hernandez jhern...@redhat.com, engine-devel@ovirt.org, Michael Kublin mkub...@redhat.com Sent: Sunday, July 22, 2012 7:41:00 PM Subject: Re

[Engine-devel] No more forking in bll tests

2012-07-23 Thread Allon Mureinik
Hi guys, This morning a couple of patches were merged to remove Gluster's dependency on PowerMock (Shireesh and Selvasundaram - thanks for your commitment and involvement!). Consequentially, there is no more need to fork bll's tests, so that too was removed. Currently, bll's full build runs

Re: [Engine-devel] java 1.6 compatibility no more?

2012-07-23 Thread Allon Mureinik
- Original Message - From: Itamar Heim ih...@redhat.com To: Allon Mureinik amure...@redhat.com Cc: Livnat Peer lp...@redhat.com, Juan Hernandez jhern...@redhat.com, engine-devel@ovirt.org, Michael Kublin mkub...@redhat.com Sent: Monday, July 23, 2012 8:43:02 AM Subject: Re

Re: [Engine-devel] java 1.6 compatibility no more?

2012-07-23 Thread Allon Mureinik
- Original Message - From: Juan Hernandez jhern...@redhat.com To: Allon Mureinik amure...@redhat.com Cc: Itamar Heim ih...@redhat.com, engine-devel@ovirt.org Sent: Monday, July 23, 2012 1:22:37 PM Subject: Re: [Engine-devel] java 1.6 compatibility no more? On 07/23/2012 11:46 AM

Re: [Engine-devel] java 1.6 compatibility no more?

2012-07-23 Thread Allon Mureinik
- Original Message - From: Juan Hernandez jhern...@redhat.com To: Allon Mureinik amure...@redhat.com Cc: engine-devel@ovirt.org Sent: Monday, July 23, 2012 2:31:24 PM Subject: Re: [Engine-devel] java 1.6 compatibility no more? On 07/23/2012 01:02 PM, Allon Mureinik wrote

Re: [Engine-devel] java 1.6 compatibility no more?

2012-07-23 Thread Allon Mureinik
- Original Message - From: Itamar Heim ih...@redhat.com To: Juan Hernandez jhern...@redhat.com Cc: Allon Mureinik amure...@redhat.com, engine-devel@ovirt.org Sent: Monday, July 23, 2012 2:44:02 PM Subject: Re: [Engine-devel] java 1.6 compatibility no more? On 07/23/2012 02:31 PM

Re: [Engine-devel] Building ovirt engine instructions

2012-07-27 Thread Allon Mureinik
some trouble - Original Message - From: Allon Mureinik amure...@redhat.com To: George Costea george.cos...@netapp.com Cc: engine-devel@ovirt.org Sent: Friday, July 27, 2012 9:04:11 PM Subject: Re: [Engine-devel] Building ovirt engine instructions Just had to reinstall and reconfigure

[Engine-devel] Conformining to Java 6 using Animal Sniffer

2012-07-29 Thread Allon Mureinik
Hi guys, As you may recall, a couple of weeks ago it was decided (in this mailing list), that we want to preserve backwards compatibility to Java 6. Instead of having to install JDK 6 alongside your Java 7, you can now use Animal Sniffer[1] to verify this. Simply run mvn animal-sniffer:check

Re: [Engine-devel] Reminder - common

2012-07-31 Thread Allon Mureinik
Roy is working on a way to prevent this from happening: http://gerrit.ovirt.org/#/c/6785/ - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, July 31, 2012 10:58:37 AM Subject: [Engine-devel] Reminder - common Hi, Please do not

[Engine-devel] Serial Execution of Async Tasks

2012-08-09 Thread Allon Mureinik
Hi guys, As you may know the engine currently has the ability to fire an SPM task, and be asynchronously be woken-up when it ends. This is great, but we found the for the Live Storage Migration feature we need something a bit complex - the ability to have a series of async tasks in a single

Re: [Engine-devel] Unifying (parts of) commit templates.

2012-08-12 Thread Allon Mureinik
- Original Message - From: Livnat Peer lp...@redhat.com To: Itamar Heim ih...@redhat.com Cc: engine-devel@ovirt.org Sent: Thursday, August 9, 2012 11:54:38 AM Subject: Re: [Engine-devel] Unifying (parts of) commit templates. On 09/08/12 11:52, Itamar Heim wrote: On 08/09/2012

Re: [Engine-devel] Serial Execution of Async Tasks

2012-08-14 Thread Allon Mureinik
To: Allon Mureinik amure...@redhat.com Cc: Eli Mesika emes...@redhat.com, Liron Aravot lara...@redhat.com, Federico Simoncelli fsimo...@redhat.com, engine-devel engine-devel@ovirt.org, Eduardo Warszawski ewars...@redhat.com, Yeela Kaplan ykap...@redhat.com Sent: Sunday, August 12, 2012 9

Re: [Engine-devel] Any way to break the dao_unit_tests up?

2012-08-21 Thread Allon Mureinik
- Original Message - From: Mike Kolesnik mkole...@redhat.com To: Shireesh Anjal san...@redhat.com Cc: engine-devel@ovirt.org, infra in...@ovirt.org Sent: Tuesday, August 21, 2012 9:43:23 AM Subject: Re: [Engine-devel] Any way to break the dao_unit_tests up? - Original Message

Re: [Engine-devel] Serial Execution of Async Tasks

2012-08-22 Thread Allon Mureinik
- Original Message - From: Allon Mureinik amure...@redhat.com To: Livnat Peer lp...@redhat.com Cc: Eli Mesika emes...@redhat.com, Liron Aravot lara...@redhat.com, Federico Simoncelli fsimo...@redhat.com, engine-devel engine-devel@ovirt.org, Eduardo Warszawski ewars...@redhat.com

Re: [Engine-devel] Serial Execution of Async Tasks

2012-08-22 Thread Allon Mureinik
- Original Message - From: Maor Lipchuk mlipc...@redhat.com To: Itamar Heim ih...@redhat.com Cc: Allon Mureinik amure...@redhat.com, engine-devel engine-devel@ovirt.org, Eduardo Warszawski ewars...@redhat.com, Yeela Kaplan ykap...@redhat.com, Federico Simoncelli fsimo

Re: [Engine-devel] Serial Execution of Async Tasks

2012-08-22 Thread Allon Mureinik
...@redhat.com, Allon Mureinik amure...@redhat.com Sent: Friday, August 10, 2012 10:48:16 PM Subject: Re: [Engine-devel] Serial Execution of Async Tasks - Original Message - From: Eli Mesika emes...@redhat.com To: Allon Mureinik amure...@redhat.com Cc: Liron Aravot lara...@redhat.com

Re: [Engine-devel] Serial Execution of Async Tasks

2012-08-22 Thread Allon Mureinik
- Original Message - From: Eli Mesika emes...@redhat.com To: Allon Mureinik amure...@redhat.com Cc: Eduardo Warszawski ewars...@redhat.com, Yeela Kaplan ykap...@redhat.com, Federico Simoncelli fsimo...@redhat.com, Liron Aravot lara...@redhat.com, engine-devel engine-devel

  1   2   >