Re: [ovirt-devel] [ovirt-users] Feature Page: Mac Pool per DC

2014-04-28 Thread Martin Mucha
for optional pool definition). This is to be decided this week, after that we can discuss final design of gui. m. - Original Message - From: Genadi Chereshnya gcher...@redhat.com To: Moti Asayag masa...@redhat.com Cc: devel@ovirt.org, us...@ovirt.org, Martin Mucha mmu...@redhat.com, Martin

[ovirt-devel] Failed to execute stage 'Setup validation': Trying to upgrade from unsupported versions: 3.5

2014-06-06 Thread Martin Mucha
Hi, can somebody point me to what I'm doing wrong? create database engine owner engine template template0 encoding 'UTF8' lc_collate 'en_US.UTF-8' lc_ctype 'en_US.UTF-8'; $OVIRT_OUT/bin/engine-setup --jboss-home=${JBOSS_HOME} $OVIRT_OUT/bin/engine-setup --jboss-home=${JBOSS_HOME} gives me

Re: [ovirt-devel] Failed to execute stage 'Setup validation': Trying to upgrade from unsupported versions: 3.5

2014-06-08 Thread Martin Mucha
thanks Didi, I'll rebase mine work on top of that. I wasn't aware that this was already fixed. Mar. - Original Message - From: Yedidyah Bar David d...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Martin Mucha mmu...@redhat.com, de...@linode01.ovirt.org Sent: Sunday, June 8

[ovirt-devel] missing 'translations' in 'bundles/AuditLogMessages'

2014-07-07 Thread Martin Mucha
Hi, I've did some changes in AuditLogDirector.java, triggered by wrong behavior, when some key (AuditLogType) is not present in ResourceBundle 'bundles/AuditLogMessages', and wrote test to alert about missing translations. To be able to merge these changes, I need to supply already missing

[ovirt-devel] reporting and removing unmanaged networks after deprecating org.ovirt.engine.core.common.action.VdcActionType#SetupNetworks

2015-02-02 Thread Martin Mucha
Hi, I'd like to discuss how to properly report unmanaged networks and how to ask for their removal after org.ovirt.engine.core.common.action.VdcActionType#SetupNetworks is removed. We thought about several possibilities and so far the best one is following one. Reporting unmanaged networks

Re: [ovirt-devel] WARNING: trying to localize null, probable error. Exception is not thrown, returning 'N/A'

2015-02-20 Thread Martin Mucha
No, that warning was created by me, when altering EnumTranslator to remove few problems of it. we 'can' just remove the warning, but I do think that trying to localize null key is just wrong since we're not able to differentiate misuse, lets say when providing key from variable, and proper

Re: [ovirt-devel] Java 1.8 (was: ovirt-engine replies with 503 Service Temporarily Unavailable on fresh install)

2015-05-05 Thread Martin Mucha
if I'm not wrong, this is not strictly java 8 issue. There are also java 7 versions behaving like this (jboss did not start on fresh install, peaking cpu usage) m. - Original Message - - Original Message - From: knarra kna...@redhat.com To: devel@ovirt.org Cc: Stanislav

[ovirt-devel] cannot install host: VdsDeployBase, Error during deploy dialog: java.lang.NullPointerException

2015-06-24 Thread Martin Mucha
Hi, I have difficulties to install host. I do believe it fails due to this: 2015-06-24 08:29:26,729 ERROR [org.ovirt.engine.core.bll.hostdeploy.VdsDeployBase] (VdsDeploy) [612066b7] Error during deploy dialog: java.lang.NullPointerException at

Re: [ovirt-devel] cannot install host: VdsDeployBase, Error during deploy dialog: java.lang.NullPointerException

2015-06-24 Thread Martin Mucha
to ovirt-host-deploy-1.4.0-0.0. Oved - Original Message - From: Martin Mucha mmu...@redhat.com To: devel@ovirt.org Sent: Wednesday, June 24, 2015 9:34:50 AM Subject: [ovirt-devel] cannot install host: VdsDeployBase, Error during deploy dialog: java.lang.NullPointerException

Re: [ovirt-devel] [oVirt 3.6 Localization Question #20] Add new Label to

2015-06-23 Thread Martin Mucha
Hi, Following in UIConstants.java: @DefaultStringValue(Add new Label to) String newLabel(); and @DefaultMessage(Add Label {0} to) String label(String label); are both related to SetupHostNetworks dialog, where there's improved interface to label NICs. In upper right right corner click

[ovirt-devel] Error: VDSGenericException: VDSNetworkException: Policy reset

2015-07-03 Thread Martin Mucha
Hi, I keep seeing in engine.log (no another error anywhere else) this error. Does anyone knows what's wrong? Sometimes it takes days before it happens, sometimes if fails very frequently. 2015-07-03 09:12:40,056 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]

Re: [ovirt-devel] Error: VDSGenericException: VDSNetworkException: Policy reset

2015-07-03 Thread Martin Mucha
in the log. Thanks, Piotr [1] https://bugzilla.redhat.com/1235683 On Fri, Jul 3, 2015 at 9:17 AM, Martin Mucha mmu...@redhat.com wrote: Hi, I keep seeing in engine.log (no another error anywhere else) this error. Does anyone knows what's wrong? Sometimes it takes days before

Re: [ovirt-devel] Upgrade to wildfly problem

2015-06-29 Thread Martin Mucha
Hi, this is caused by new HostNetworkingAPI resp one its db upgrade script, not by wildfly. I wrote 'fix' script yesterday, which should fix this. However this patch did not get CR yet, and cannot be merged. But you can use it to cure your environment manually. If you do, please let me know if

Re: [ovirt-devel] Upgrade to wildfly problem

2015-06-30 Thread Martin Mucha
Thanks very much, for review. I mistakenly used BootProtocol enum instead of NetworkBootProtocol enum, and relied on ordinal values of former instead on 'intValue's of latter. updated. M. - Original Message - On 06/30/2015 08:25 AM, Martin Mucha wrote: Hi, this is caused

Re: [ovirt-devel] [oVirt 3.6 Localization Question #29] Return VM

2015-08-14 Thread Martin Mucha
not familiar with this part of system, but from looking quickly into source code: there's should be some 'side tab' in VM view in userportal, in which you can 'shutdown' it by clicking it. And If you hover your mouse over that button, there should be your text in tooltip. hope I'm right and

Re: [ovirt-devel] [oVirt 3.6 Localization Question #30] Load

2015-08-14 Thread Martin Mucha
from source code: loadVmsFromExportDomainButton.setLabel(constants.loadLabel()); so it's verb, and it's used on button invoking loading vms from export domain. M. - Original Message - Hello all, Another question is raised: File: CommonApplicationConstants Resource ID: loadLabel

Re: [ovirt-devel] Requiring Java 8 during runtime

2015-10-26 Thread Martin Mucha
not strictly related question: are we going to raise language level as well? So we can start using JDK8 features like lambdas etc? M. - Original Message - > Hello, > > As you probably know oVirt Engine 4 will use WildFly 10, and that > requires Java 8. The version of WildFly that we

[ovirt-devel] disabling maven-checkstyle-plugin

2015-09-09 Thread Martin Mucha
Hi, I want to get rid of work style: wait 10 minutes for compilation to finish, read about unused import, fix it and start over. I'm not that familiar with maven / our setup. Is there a correct way how to do that? So far what I do is using altered pom.xml so there's new profile disabling

Re: [ovirt-devel] Slides for the Java 8 presentation yesterday

2015-12-02 Thread Martin Mucha
Thanks Juan, I've read your slides and learn something new from them. And I'd like to ask one small thing about how lambdas are represented. It seems that from early draft there were 'some changes' — from inner class representation, to runtime generated inner class representation, to no classes

Re: [ovirt-devel] Slides for the Java 8 presentation yesterday

2015-12-02 Thread Martin Mucha
thank you very much for explanation. M. - Original Message - > On 12/02/2015 10:53 AM, Martin Mucha wrote: > > Thanks Juan, I've read your slides and learn something new from them. > > > > And I'd like to ask one small thing about how lambdas are represented. It >

[ovirt-devel] unable to add host ~ InitVdsOnUpCommand parameters specifies storage domain ID when creating host.

2015-12-10 Thread Martin Mucha
Hi, 'm unable to add host to engine. I have fresh engine build, cleaned host, dropped and recreated DB. I'm adding host using rest¹. Command InitVdsOnUpCommand is called during operation, having getStoragePoolId() equal to 0001-0001-0001-0001-00c1. However, there's no storage

Re: [ovirt-devel] Failing MacPoolDaoTests on master

2016-05-31 Thread Martin Mucha
I do apologize, fix patches are done and should be merged soon ... M. - Original Message - > On Tue, May 31, 2016 at 10:13 AM, Barak Korren wrote: > > On 31 May 2016 at 10:45, Roman Mohr wrote: > >> Hi, > >> > >> DAO tests are failing on master in

Re: [ovirt-devel] findbugs on network code

2016-01-15 Thread Martin Mucha
I think that's probable explanation. Another NPE can be (theoretically) here org.ovirt.engine.core.utils.customprop.DevicePropertiesUtils#getDeviceProperties when reading using null version (static analysis can probably find way into this method), but cancel is more imminent. M. - Original

Re: [ovirt-devel] Proposing Martin Betak as oVirt UI maintainer

2016-02-08 Thread Martin Mucha
- Original Message - > > > On Mon, Feb 8, 2016 at 10:28 AM, Martin Betak < mbe...@redhat.com > wrote: > > > Thanks everyone for their expressed support! > > I hope I'll be able to continue working towards improving our existing > frontend codebase and whatever may serve as the UI in

Re: [ovirt-devel] missing "jinja2"??

2016-02-05 Thread Martin Mucha
- Original Message - > > > - Original Message - > > From: "Sandro Bonazzola" <sbona...@redhat.com> > > To: "Marek Libra" <mli...@redhat.com>, "Rafael Martins" > > <rmart...@redhat.com> > > Cc:

Re: [ovirt-devel] [UI plugins] replacing RestApiSessionAcquired event

2016-01-26 Thread Martin Mucha
sorry, I made a mistake this is not a reply to this subject. M. - Original Message - > Hi, > > I got another bug about missing constructor: > > public …(P parameters, EngineContext engineContext) { > super(parameters, engineContext); > } > > so I looked into: >

[ovirt-devel] missing "jinja2"??

2016-02-03 Thread Martin Mucha
Hi, if I try to run engine now, I'm getting following, even if jinja2 is (manually) installed. How to fix that? File "/home/mmucha/build/ovirt-engine/share/ovirt-engine/services/ovirt-engine/ovirt-engine.py", line 26, in from jinja2 import Template ImportError: cannot import name

Re: [ovirt-devel] [UI plugins] replacing RestApiSessionAcquired event

2016-01-25 Thread Martin Mucha
Hi, I got another bug about missing constructor: public …(P parameters, EngineContext engineContext) { super(parameters, engineContext); } so I looked into: org.ovirt.engine.core.bll.QueriesCommandBase and it seems, that sole 'problem' is with initialization of user in @PostConstruct

Re: [ovirt-devel] removing parameterized constructors from queries.

2016-01-27 Thread Martin Mucha
hange, but as I said, getting rid of those constructors, we can probably get rid of all reflection (not in my patch) and probably also of special CDI treatment. > > [1] https://gerrit.ovirt.org/#/c/52657/ > > On Tue, Jan 26, 2016 at 11:01 AM, Martin Mucha <mmu...@redhat.com&g

Re: [ovirt-devel] Integration tests future (and very nice alternative for the DAO fixture file)

2016-04-17 Thread Martin Mucha
Having such builders would simplify our lives for sure. But I'd really try to avoid any autogeneration. I would cost lots of man hours to make it happen and result won't be good. If we agree to use this approach, and everyone write new methods as they're needed, 'some basic builders' come to

Re: [ovirt-devel] Caching of data from the database done properly

2016-07-07 Thread Martin Mucha
Hi, some of information in mail are not exactly true. Namely MacPoolPerCluster *does not do caching*, it does not even have DB layer structures it could cache. So how it works is: pool has configuration upon which it initialize itself. After that, it looks into db for all used MACs, which

Re: [ovirt-devel] Writing SQL queries in DAO code

2017-03-29 Thread Martin Mucha
Hi, I didn't want to step into this, but I was asked by dan to express my opinion about this. I'm not pushing for change (since I believe it will be blocked), I'm just trying to help us focus. We should have some questions answered prior to saying what we want to do... Current state of accessing

Re: [ovirt-devel] Writing SQL queries in DAO code

2017-03-30 Thread Martin Mucha
On Thu, Mar 30, 2017 at 9:31 AM, Eli Mesika <emes...@redhat.com> wrote: > > > On Wed, Mar 29, 2017 at 4:23 PM, Martin Mucha <mmu...@redhat.com> wrote: > >> Hi, >> >> I didn't want to step into this, but I was asked by dan to express my >> opinion

Re: [ovirt-devel] patch granularity, extracting patches

2017-06-30 Thread Martin Mucha
Hi, I think I have found a rule which applies to lot of CRs. If you submit set of small patches, you will be asked to squash them, and if you submit 'big bang' patch, you will be asked to split it. Sometimes, and that's the hardest situation, you are asked to do both :D I think you should lead