Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 14/05/2017 ] [ test-repo_ovirt_experimental_master ]

2017-05-18 Thread Yevgeny Zaspitsky
Piotr, How do you identify the connection between the 2 message, why do you think that the timeout is related to the first message you've mentioned? Regards, Yevgeny On Mon, May 15, 2017 at 12:40 PM, Piotr Kliczewski < piotr.kliczew...@gmail.com> wrote: > I agree with Nir that the above issue i

Re: [ovirt-devel] Abusing injection and DB access

2017-04-06 Thread Yevgeny Zaspitsky
On Wed, Apr 5, 2017 at 11:17 PM, Roy Golan wrote: > > > On Wed, Apr 5, 2017 at 9:06 PM Moti Asayag wrote: > >> Hi All, >> >> ATM, there are 78 occurrences of "Injector.injectMembers(new >> AuditLogableBase())" in ovirt-engine project, which their main purpose is >> to ease the resolve of the pla

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt master ] [ 5/4/2017 ] [ add_non_vm_network ]

2017-04-05 Thread Yevgeny Zaspitsky
https://gerrit.ovirt.org/#/c/74916/ has been reverted in the latest master, so I guess that caused the failure. On Wed, Apr 5, 2017 at 6:17 PM, Barak Korren wrote: > Test failed: [ add_non_vm_network ] > > Link to suspected patches: > - https://gerrit.ovirt.org/75020 > - https://gerrit.ovirt.org

Re: [ovirt-devel] Writing SQL queries in DAO code

2017-03-27 Thread Yevgeny Zaspitsky
On Mon, Mar 27, 2017 at 5:30 PM, Yevgeny Zaspitsky wrote: > > > On Mon, Mar 27, 2017 at 12:45 PM, Eli Mesika wrote: > >> >> >> On Mon, Mar 27, 2017 at 12:26 PM, Yevgeny Zaspitsky >> wrote: >> >>> > I don't think that looking

Re: [ovirt-devel] Writing SQL queries in DAO code

2017-03-27 Thread Yevgeny Zaspitsky
On Mon, Mar 27, 2017 at 12:45 PM, Eli Mesika wrote: > > > On Mon, Mar 27, 2017 at 12:26 PM, Yevgeny Zaspitsky > wrote: > >> > I don't think that looking in SQL in Java code is ​clear than looking >> in a SP code >> >> Looking in SQL isn'

Re: [ovirt-devel] Writing SQL queries in DAO code

2017-03-27 Thread Yevgeny Zaspitsky
Eli Mesika wrote: > > > On Mon, Mar 27, 2017 at 1:56 AM, Moti Asayag wrote: > >> >> >> On Sun, Mar 26, 2017 at 5:12 PM, Yevgeny Zaspitsky >> wrote: >> >>> Hi All, >>> >>> Recently I had a task of performance improvement in one o

Re: [ovirt-devel] Writing SQL queries in DAO code

2017-03-27 Thread Yevgeny Zaspitsky
ts do that? > 6. With the NamedParametersJdbcTemplate there is no use of the DbEngineDialect. What's the impact of it ? In my patches I do use it through getCustomMapSqlParameterSource. On Mon, Mar 27, 2017 at 1:56 AM, Moti Asayag wrote: > > > On Sun, Mar 26, 2017 at 5:12 PM,

[ovirt-devel] Writing SQL queries in DAO code

2017-03-26 Thread Yevgeny Zaspitsky
Hi All, Recently I had a task of performance improvement in one of our network related flows and had some hard time following our DAL code and one of the outcomes of the task was defining a couple of new quite simple, but neat queries. When I came to coding those new queries I remembered how hard

Re: [ovirt-devel] rhevm listening on ipv6 ?

2017-03-05 Thread Yevgeny Zaspitsky
Šimon, According to [1] oVirt should be accessible through IPv6 address. >From my experience engine web&rest can be accessed by using an URL with an IPv6 address in a browser. Please notice that an IPv6 literal address (not a hostname that resolves to an IPv6 address) in a valid URL should be wra

Re: [ovirt-devel] Heads-up: moving Libvirt xml creation to the engine

2017-01-04 Thread Yevgeny Zaspitsky
I agree with Piotr&Edward: - having engine uses libvirt xml would impose coupling between engine and libvirt (a cross-layers dependency), which currently does not exist. - moreover, engine would be coupled to all versions of libvirt api that it manages - currently each VDSM version kno

Re: [ovirt-devel] findBugs fails on "org.ovirt.engine.ui.uicompat.UIConstants is too big for analysis"

2016-08-16 Thread Yevgeny Zaspitsky
Looks like the problem was solved in a later patch [1]. https://gerrit.ovirt.org/62373 On Tue, Aug 16, 2016 at 8:16 PM, Yevgeny Zaspitsky wrote: > oops, the patch is that https://gerrit.ovirt.org/61891 > > On Tue, Aug 16, 2016 at 7:12 PM, Yevgeny Zaspitsky > wrote: > >&g

Re: [ovirt-devel] findBugs fails on "org.ovirt.engine.ui.uicompat.UIConstants is too big for analysis"

2016-08-16 Thread Yevgeny Zaspitsky
oops, the patch is that https://gerrit.ovirt.org/61891 On Tue, Aug 16, 2016 at 7:12 PM, Yevgeny Zaspitsky wrote: > Looks like [1] has added the very last line that was over the findBugs > limit of reasonable file size. > Since that change was merged all consequence patches get -

[ovirt-devel] findBugs fails on "org.ovirt.engine.ui.uicompat.UIConstants is too big for analysis"

2016-08-16 Thread Yevgeny Zaspitsky
Looks like [1] has added the very last line that was over the findBugs limit of reasonable file size. Since that change was merged all consequence patches get -1 from CI. We should either ignore that message in the findBugs configuration or fix that somehow. But letting CI nack the patch, then fig

Re: [ovirt-devel] Caching of data from the database done properly

2016-07-11 Thread Yevgeny Zaspitsky
On Tue, Jul 5, 2016 at 7:14 AM, Roman Mohr wrote: > On Mon, Jul 4, 2016 at 11:58 PM, Roman Mohr wrote: > > Hi Everyone, > > > > I wanted to discuss a practice which seems to be pretty common in the > > engine which I find very limiting, dangerous and for some things it > > can even be a blocker.

Re: [ovirt-devel] NPE on VdsBrokerObjectsBuilder.getSwitchType

2016-06-13 Thread Yevgeny Zaspitsky
Freddy, what vdsm version do you use? On Mon, Jun 13, 2016 at 11:33 AM, Fred Rolland wrote: > Hi, > > I am getting a NPE on master : > > 2016-06-13 11:25:34,356 WARN [org.ovirt.engine.core.vdsbroker.VdsManager] > (DefaultQuartzScheduler5) [] Failed to refresh VDS , vds = '10.35.18.204' : > 'b07

Re: [ovirt-devel] Welcome: New ovirt.org website!

2016-02-21 Thread Yevgeny Zaspitsky
Hi, I updated my feature page [1] on the legacy site last week and added the new picture file [2]. That's missing in the new site and github. Looks like source/images/wiki folder was updated on github on Jun 19th last time, which is quite long time ago... IMHO it re-synced again... [1] http://old

Re: [ovirt-devel] IPv6 support in oVirt

2016-02-17 Thread Yevgeny Zaspitsky
; information (vdsm api section) or if we want to keep the backward > compatibility we should reuse existing parameters > and prepare the code to handle both formats. > Why we are adding @dhcpv6? We do not have this setting for ipv4. > > Thanks, > Piotr > > [2] ht

[ovirt-devel] IPv6 support in oVirt

2016-02-16 Thread Yevgeny Zaspitsky
Hi All, IPv6 support is a long waited feature in oVirt and that was decided to include it in v4.0. I have updated the feature page [1] with the recent projected changes. Please take a look on the page and please send me your comments so those would be reflected in the feature implementation. Reg

Re: [ovirt-devel] [ATN] RESTAPI specification moving to a separate git repository

2016-01-20 Thread Yevgeny Zaspitsky
Juan, Well done! But, there is a mismatch between gerrit and gitub links in your e-mail. Regards, Yevgeny On Thu, Jan 7, 2016 at 5:15 PM, Juan Hernández wrote: > Hello, > > The specification of the RESTAPI (a.k.a. the model) and the tools that > process it (a.k.a. the metamodel) have been mov

Re: [ovirt-devel] SSO Setup

2015-12-01 Thread Yevgeny Zaspitsky
On Dec 1, 2015 3:47 PM, "Ravi Nori" wrote: > > Hi, > > Some of you have faced issues setting up engine after SSO patches were merged. > > Below are the issues and the proposed solutions on how to proceed. > > * Issue #1: Host name resolution. > > During setup make sure the engine FQDN that you pro

Re: [ovirt-devel] Findbugs on master patches

2015-08-12 Thread Yevgeny Zaspitsky
fied+1, whereas test were run upon patch set upload. IMHO the split between the jobs makes their behavior misleading. BTW, what was merged is patch set 2, which wasn't checked by findbugs at all. On Wed, Aug 12, 2015 at 3:42 PM, David Caro wrote: > On 08/12, Yevgeny Zaspitsky wrote: > >

Re: [ovirt-devel] Findbugs on master patches

2015-08-12 Thread Yevgeny Zaspitsky
is a misleading behavior. Regards, Yevgeny On Wed, Aug 12, 2015 at 12:12 PM, Sandro Bonazzola wrote: > > > On Tue, Aug 11, 2015 at 6:13 PM, Yevgeny Zaspitsky > wrote: > >> Hi All, >> >> Seems like recently Jenkins has stopped running findbugs check on the

[ovirt-devel] Findbugs on master patches

2015-08-11 Thread Yevgeny Zaspitsky
Hi All, Seems like recently Jenkins has stopped running findbugs check on the patches before they get merged into master. Although that could save some Jenkins resources and make the its reaction faster, that makes the integration (with master) check less effective. Was that done on purpose? Can

Re: [ovirt-devel] engine startup failure: Backend has been recursively invoked

2015-07-20 Thread Yevgeny Zaspitsky
As you might guess on your own, the update sql is a temporary measure... The engine patch was published for the problem: https://gerrit.ovirt.org/#/c/43831/ Regards, Yevgeny - Original Message - > From: "Marcin Mirecki" > To: devel@ovirt.org > Sent: Monday, July 20, 2015 2:39:37 P

Re: [ovirt-devel] Can't reach webadmin after nightly update from master

2015-04-12 Thread Yevgeny Zaspitsky
e - > From: "Yevgeny Zaspitsky" > To: "Michael Burman" > Cc: devel@ovirt.org, in...@ovirt.org, "Allon Mureinik" > Sent: Thursday, April 9, 2015 6:44:30 PM > Subject: Re: Can't reach webadmin after nightly update from master > Michael, > Co

Re: [ovirt-devel] Can't reach webadmin after nightly update from master

2015-04-09 Thread Yevgeny Zaspitsky
Michael, Could you please provide the following: + server.log file + git comit sha the ovirt-engine was bulit of Yevgeny On Apr 9, 2015 12:27 PM, Allon Mureinik wrote: > > the devel list is probably more appropriate for this question. > > Yevgeny, IIRC you handled something the devel list is p

Re: [ovirt-devel] DAO test is failing on master

2015-01-28 Thread Yevgeny Zaspitsky
On 28/01/15 11:51, Sahina Bose wrote: On 01/28/2015 02:58 PM, Sahina Bose wrote: On 01/28/2015 01:35 PM, Barak Korren wrote: Sandro, I remember vaguely that you have to use the 'postgres' user when connecting. I don't see user information in the URL, maybe it needs to be: "jdbc:postgresql

Re: [ovirt-devel] Creating a new gerrit flag

2014-12-10 Thread Yevgeny Zaspitsky
- Original Message - > From: "David Caro" > To: "Nir Soffer" > Cc: "Oved Ourfali" , devel@ovirt.org, "infra" > > Sent: Wednesday, December 10, 2014 4:59:36 PM > Subject: Re: [ovirt-devel] Creating a new gerrit flag > > On 12/10, Nir Soffer wrote: > > > > > > - Original Message -

Re: [ovirt-devel] Why are Java checkstyle checks applied to test code?

2014-10-07 Thread Yevgeny Zaspitsky
/how-to-disable-a-particular-checkstyle-rule-for-a-particular-line-of-code Best regards, Yevgeny Zaspitsky - Original Message - > From: "Vojtech Szocs" > To: devel@ovirt.org > Sent: Monday, October 6, 2014 5:25:43 PM > Subject: [ovirt-devel]

Re: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module

2014-10-06 Thread Yevgeny Zaspitsky
Usage of AuditLogDirector in VdsBrokerObjectsBuilder is an illustration for a sub-optimal design: 1. The methods it is used in them are checkTimeDrift and reportInvalidInterfacesForNetwork. Both are: public static and both should not be Best regards, Yevgeny Zaspitsky

Re: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module

2014-10-06 Thread Yevgeny Zaspitsky
st regards, ____ Yevgeny Zaspitsky Senior Software Engineer Red Hat Israel 34 Jerusalem Road, Ra'anana, Israel 43501 Tel: +972 9 7692098 Mobile: +972 52 6323656 Email: yzasp...@redhat.com IRC: yzaspits - Original Message - > From: "Yevgeny Zaspitsky" > To

[ovirt-devel] CDI limited capabilities in jboss-as-7.1.1

2014-10-06 Thread Yevgeny Zaspitsky
Hi All, Recently I started using CDI (thanks to Roy Golan contribution) in bll module code and figured the limitation described in (https://issues.jboss.org/browse/AS7-4567). That was solved 1.5 years ago in jboss-as-7.2. Currently we use jboss-as-7.1.1. Is there a good reason for not moving

Re: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module

2014-10-05 Thread Yevgeny Zaspitsky
Hi Yair and All, As soon as you turned our attention to dependencies problems in oVirt, I guess would worse to mention that vdsbroker is directly dependent on dal (very weird to me). That is because some business logic found its way into vdsbroker code and uses dal directly. Using dal should b

Re: [ovirt-devel] Management network as a role - design proposal

2014-08-21 Thread Yevgeny Zaspitsky
other than 'General'; maybe even something similar to the "Manage Network" dialog can be put within the "New Cluster" dialog in a (new) "Network" side-section? ---- Thanks, Einav - Original Message - From: "Moti Asayag" To: "Yevgeny

Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils

2014-08-21 Thread Yevgeny Zaspitsky
On 21/08/14 12:08, Yair Zaslavsky wrote: - Original Message - From: "Yevgeny Zaspitsky" To: "Moti Asayag" Cc: "Yair Zaslavsky" , "Allon Mureinik" , devel@ovirt.org Sent: Thursday, August 21, 2014 11:26:40 AM Subject: Re: [ovirt-devel] [ENGINE]

Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils

2014-08-21 Thread Yevgeny Zaspitsky
ot; > Cc: "Allon Mureinik" , devel@ovirt.org, "Yevgeny > Zaspitsky" > Sent: Thursday, August 21, 2014 11:18:53 AM > Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils > > > > - Original Message - > > From: "Yair Zaslav

Re: [ovirt-devel] Management network as a role - design proposal

2014-08-17 Thread Yevgeny Zaspitsky
On 17/08/14 12:15, Lior Vernia wrote: On 15/08/14 12:55, Dan Kenigsberg wrote: On Thu, Aug 14, 2014 at 11:52:41AM -0400, Yevgeny Zaspitsky wrote: Hi All, The proposed feature will allow defining an arbitrary network in the DC as the management network for the cluster, which in its turn

Re: [ovirt-devel] Management network as a role - design proposal

2014-08-17 Thread Yevgeny Zaspitsky
On 15/08/14 12:55, Dan Kenigsberg wrote: On Thu, Aug 14, 2014 at 11:52:41AM -0400, Yevgeny Zaspitsky wrote: Hi All, The proposed feature will allow defining an arbitrary network in the DC as the management network for the cluster, which in its turn will allow assigning different VLANs for

[ovirt-devel] Management network as a role - design proposal

2014-08-14 Thread Yevgeny Zaspitsky
/Management_Network_As_A_Role . Please take a look into the page especially into "Open issues" section. I'd like to have your opinions on that. Best regards, Yevgeny Zaspitsky ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/m

Re: [ovirt-devel] [oVirt 3.5 Localization Question #8] "moveDisplayNetworkWarning"

2014-06-22 Thread Yevgeny Zaspitsky
rds, Yevgeny On 22/06/14 12:02, Yuko Katabami wrote: On 06/22/2014 06:28 PM, Yevgeny Zaspitsky wrote: networkOperationMessage is built dynamically in the run-time (e.g. "Attach to "). The final message depends on operation type and its argument(s) (1 or 2). The possible netwo

Re: [ovirt-devel] [oVirt 3.5 Localization Question #8] "moveDisplayNetworkWarning"

2014-06-22 Thread Yevgeny Zaspitsky
networkOperationMessage is built dynamically in the run-time (e.g. "Attach to "). The final message depends on operation type and its argument(s) (1 or 2). The possible networkOperationMessage does not include '.' (dot sign) at the end so that was added in order to separate the warning from the

Re: [ovirt-devel] [oVirt 3.5 Localization Question #2] "Update display network on cluster with an active VM" (audit log)

2014-06-18 Thread Yevgeny Zaspitsky
That is the warning to the user that means that an update to the display network has been done, which means that he might expect loosing display connectivity to the VMs that were active at the time of the update action in some cases of the update. Regards, Yevgeny On 18/06/14 04:02, Yuko Kata

Re: [ovirt-devel] Implementing equals & hashCode methods

2014-05-27 Thread Yevgeny Zaspitsky
Sorry, seems like I missed NOT in (3). :-( So my opinion on the test coverage is NOT enough, which makes re-factoring dangerous. I hope that will make the question clearer. Yevgeny - Original Message - > From: "Yevgeny Zaspitsky" > To: devel@ovirt.org > Sent: Sun

Re: [ovirt-devel] Implementing equals & hashCode methods

2014-05-26 Thread Yevgeny Zaspitsky
See my comments in your mail body. - Original Message - > From: "Gilad Chaplik" > To: "Yevgeny Zaspitsky" > Cc: "Yair Zaslavsky" , devel@ovirt.org > Sent: Sunday, May 25, 2014 8:41:36 PM > Subject: Re: [ovirt-devel] Implementing equals

Re: [ovirt-devel] Implementing equals & hashCode methods

2014-05-25 Thread Yevgeny Zaspitsky
See my comments in your mail body. - Original Message - > From: "Yair Zaslavsky" > To: "Yevgeny Zaspitsky" > Cc: devel@ovirt.org > Sent: Sunday, May 25, 2014 4:09:11 PM > Subject: Re: [ovirt-devel] Implementing equals & hashCode methods > >

[ovirt-devel] Implementing equals & hashCode methods

2014-05-25 Thread Yevgeny Zaspitsky
Hi All, Recently I reviewed a patch that adds a new business entity to the engine. The entity class has the following members: * id * data center id * name * type * some other properties that do not belong to the entity key The equals & hashCode methods were implement

Re: [ovirt-devel] commons-collections v4.0

2014-05-07 Thread Yevgeny Zaspitsky
21:41 (GMT+02:00) To: Mike Kolesnik Cc: Yevgeny Zaspitsky ,devel@ovirt.org Subject: Re: [ovirt-devel] commons-collections v4.0 - Original Message - > From: "Mike Kolesnik" > To: "Alon Bar-Lev" > Cc: "Yevgeny Zaspitsky" , devel@ovirt.org > Se

Re: [ovirt-devel] Feature Page: Mac Pool per DC

2014-04-27 Thread Yevgeny Zaspitsky
Now for us...@ovirt.org indeed. - Original Message - From: "Yevgeny Zaspitsky" To: "Martin Mucha" Cc: us...@ovrit.org, devel@ovirt.org Sent: Sunday, April 27, 2014 2:29:46 PM Subject: Re: [ovirt-devel] Feature Page: Mac Pool per DC Martin, I'd like to propos

Re: [ovirt-devel] Feature Page: Mac Pool per DC

2014-04-27 Thread Yevgeny Zaspitsky
like to give a description to a range) So IMHO a satellite table with the FK to storage_pool would be a more robust design. Best regards, ________ Yevgeny Zaspitsky Senior Software Engineer Red Hat Israel - Original Message - From: "Martin Mucha" To: us...@o

[ovirt-devel] HTTP 500 on expired session request

2014-04-24 Thread Yevgeny Zaspitsky
Below is the error I get with HTTP code 500 when I sent a request from a client to REST-API that was left open and the server was restarted. Evidently the session is expired, but why do we return HTTP 500? Is this a server internal error? IMHO one of 400 codes is more appropriate for that error

Re: [ovirt-devel] commons-collections v4.0

2014-04-22 Thread Yevgeny Zaspitsky
wn dependencies could be packed in the war, can't they? Best regards, ________ Yevgeny Zaspitsky Senior Software Engineer Red Hat Israel - Original Message - From: "Alon Bar-Lev" To: "Yevgeny Zaspitsky" Cc: devel@ovirt.org Sent: Sunday, April

[ovirt-devel] commons-collections v4.0

2014-04-13 Thread Yevgeny Zaspitsky
ke clean install-dev" command for building. Please advise. Best regards, ____ Yevgeny Zaspitsky Senior Software Engineer Red Hat ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel