Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-15 Thread Francesco Romani
Simoncelli fsimo...@redhat.com, Dan Kenigsberg dan...@redhat.com Sent: Sunday, July 13, 2014 1:34:50 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls - Original Message - From: Saggi Mizrahi smizr...@redhat.com To: Nir Soffer nsof

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-15 Thread Francesco Romani
13, 2014 5:43:28 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls [...] The current patches do not change libvirt connection management this is orthogonal issue. They are only about changing the way we do sampling. As I've been saying, I think

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-15 Thread Nir Soffer
, July 15, 2014 6:50:45 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls - Original Message - From: Saggi Mizrahi smizr...@redhat.com To: Nir Soffer nsof...@redhat.com Cc: Francesco Romani from...@redhat.com, devel@ovirt.org, Michal

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-15 Thread Francesco Romani
, July 15, 2014 7:28:51 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls The current patches do not change libvirt connection management this is orthogonal issue. They are only about changing the way we do sampling. As I've been saying, I

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-13 Thread Saggi Mizrahi
, July 12, 2014 8:07:27 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls - Original Message - From: Francesco Romani from...@redhat.com To: devel@ovirt.org Cc: Nir Soffer nsof...@redhat.com, Michal Skrivanek mskri...@redhat.com

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-13 Thread Nir Soffer
13, 2014 1:03:20 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls Hi, I will find time to go in depth in both patches but I still think that this is solving the problem in the wrong place. You want to have the libvirt connection management

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-13 Thread Saggi Mizrahi
, July 13, 2014 2:34:50 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls - Original Message - From: Saggi Mizrahi smizr...@redhat.com To: Nir Soffer nsof...@redhat.com, Francesco Romani from...@redhat.com Cc: devel@ovirt.org, Michal

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-12 Thread Francesco Romani
from...@redhat.com Sent: Wednesday, July 9, 2014 4:57:53 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls So basically the current threading model is the behavior we want? If some call get stuck, stop sampling this vm. Continue when

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-09 Thread Francesco Romani
: [ovirt-devel] [VDSM][sampling] thread pool status and handling ofstuck calls This will also allow task to change the sampling policy depending on the results. If some calls always fails, maybe we can run it less often. This looks a feature worth having But lets take a note

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-09 Thread Federico Simoncelli
: [ovirt-devel] [VDSM][sampling] thread pool status and handling ofstuck calls - Original Message - From: Nir Soffer nsof...@redhat.com To: Francesco Romani from...@redhat.com Cc: devel@ovirt.org, Federico Simoncelli fsimo...@redhat.com, Michal Skrivanek mskri...@redhat.com

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-07 Thread Francesco Romani
- Original Message - From: Nir Soffer nsof...@redhat.com To: Francesco Romani from...@redhat.com Cc: devel@ovirt.org Sent: Friday, July 4, 2014 10:30:24 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling ofstuck calls Quick summary

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-07 Thread Michal Skrivanek
and handling of stuck calls - Original Message - From: Nir Soffer nsof...@redhat.com To: Francesco Romani from...@redhat.com Cc: devel@ovirt.org Sent: Friday, July 4, 2014 10:30:24 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-07 Thread Adam Litke
On 07/07/14 10:53 -0400, Nir Soffer wrote: * _sampleVmJobs uses virDomainBLockJobInfo, which needs to enter the QEMU monitor. However, this needs to run only if there are active block jobs. I don't have numbers, but I expect this sampler to be idle most of time. Adam: This is related to

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-07 Thread Nir Soffer
: [ovirt-devel] [VDSM][sampling] thread pool status and handling ofstuck calls On Jul 7, 2014, at 16:53 , Nir Soffer nsof...@redhat.com wrote: If we separate storage calls so vm sampling continue even if storage cause qemu to block - do we gain anything? I guess this vm is not useful

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-07 Thread Saggi Mizrahi
: [ovirt-devel] [VDSM][sampling] thread pool status and handling ofstuck calls - Original Message - From: Saggi Mizrahi smizr...@redhat.com To: Francesco Romani from...@redhat.com Cc: devel@ovirt.org Sent: Sunday, July 6, 2014 2:58:38 PM Subject: Re: [ovirt-devel

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-07 Thread Nir Soffer
: [ovirt-devel] [VDSM][sampling] thread pool status and handling ofstuck calls - Original Message - From: Nir Soffer nsof...@redhat.com To: Saggi Mizrahi smizr...@redhat.com Cc: Francesco Romani from...@redhat.com, devel@ovirt.org, Federico Simoncelli fsimo

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-06 Thread Saggi Mizrahi
To: devel@ovirt.org Sent: Friday, July 4, 2014 5:48:59 PM Subject: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls Hi, Nir has begun reviewing my draft patches about the thread pool and sampling refactoring (thanks!), and already suggested quite some

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-06 Thread Nir Soffer
- Original Message - From: Saggi Mizrahi smizr...@redhat.com To: Francesco Romani from...@redhat.com Cc: devel@ovirt.org Sent: Sunday, July 6, 2014 2:58:38 PM Subject: Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling ofstuck calls The more I think about

[ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-04 Thread Francesco Romani
Hi, Nir has begun reviewing my draft patches about the thread pool and sampling refactoring (thanks!), and already suggested quite some improvements which I'd like to summarize Quick links to the ongoing discussion: http://gerrit.ovirt.org/#/c/29191/8/lib/threadpool/worker.py,cm

Re: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls

2014-07-04 Thread Nir Soffer
- Original Message - From: Francesco Romani from...@redhat.com To: devel@ovirt.org Sent: Friday, July 4, 2014 5:48:59 PM Subject: [ovirt-devel] [VDSM][sampling] thread pool status and handling of stuck calls Hi, Nir has begun reviewing my draft patches about the thread pool