Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

On Tue, Aug 8, 2017 at 2:50 PM, Roy Golan wrote: > This is for 4.1 https://gerrit.ovirt.org/#/c/78916/ , track that, it should > be in. > Irit's work is about providing reconnect logic which was not implemented till now. I think that introducing ping2 won't solve the issue

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

Method with saved caller's IP address is an option, but it would require rewriting of network's connectivity check mechanism. We would need to introduce some extra IPC between supervdsm and vdsm for this IIUIC. The reason for ping2 is backward compatibility. It is undocumented, but Engine still

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

>> A ping that has no side effects and a "watchdog" mechanism to confirm >> connectivity. > > This sounds as exactly the right solution right now. Just to clarify: Removing the undocumented side effects from ping. Not introducing ping2. Martin On Tue, Aug 8, 2017 at 10:47 AM, Martin Sivak

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

But it isn't as I said already. And so we are keeping the ping code and that is why vdsm needs to solve the setupNetworks/ping bug. Martin On Tue, Aug 8, 2017 at 2:50 PM, Roy Golan wrote: > This is for 4.1 https://gerrit.ovirt.org/#/c/78916/ , track that, it should > be in. >

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

This is for 4.1 https://gerrit.ovirt.org/#/c/78916/ , track that, it should be in. On Tue, 8 Aug 2017 at 15:10 Martin Sivak wrote: > What stomp heartbeat? There is no such thing in the Python json rpc client. > > Martin > > On Tue, Aug 8, 2017 at 1:04 PM, Roy Golan

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

What stomp heartbeat? There is no such thing in the Python json rpc client. Martin On Tue, Aug 8, 2017 at 1:04 PM, Roy Golan wrote: > Why isn't the stomp heartbeat enough? > > On Tue, 8 Aug 2017 at 13:45 Martin Sivak wrote: >> >> MOM and hosted engine use

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

Why isn't the stomp heartbeat enough? On Tue, 8 Aug 2017 at 13:45 Martin Sivak wrote: > MOM and hosted engine use the ping verb to verify the connection is > still OK. The RPC client did not have any reconnect logic in the past > (and I think it still does not..). > > Martin

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

MOM and hosted engine use the ping verb to verify the connection is still OK. The RPC client did not have any reconnect logic in the past (and I think it still does not..). Martin On Tue, Aug 8, 2017 at 12:01 PM, Roy Golan wrote: > Petr, why do you need the ping verb? what

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

Petr, why do you need the ping verb? what are you after? On Tue, 8 Aug 2017 at 11:54 Martin Sivak wrote: > > The proposed solution is focused on making sure a command does one thing > and > > not two: > > A ping that has no side effects and a "watchdog" mechanism to confirm >

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

> The proposed solution is focused on making sure a command does one thing and > not two: > A ping that has no side effects and a "watchdog" mechanism to confirm > connectivity. This sounds as exactly the right solution right now. >>> Still someone could call conirmConnectivity, no? We do not

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

On Mon, Aug 7, 2017 at 5:26 PM, Roy Golan wrote: > Still someone could call conirmConnectivity, no? so the state isn't > guarded from localhost tinkering anyhow. If you really need a solution you > can acuire a token for this operation by setupNetworks, and confirm >

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

On Mon, Aug 7, 2017 at 11:06 PM, Nir Soffer wrote: > On Mon, Aug 7, 2017 at 5:28 PM Roy Golan wrote: > >> Still someone could call conirmConnectivity, no? so the state isn't >> guarded from localhost tinkering anyhow. If you really need a solution you >>

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

On Mon, Aug 7, 2017 at 5:28 PM Roy Golan wrote: > Still someone could call conirmConnectivity, no? so the state isn't > guarded from localhost tinkering anyhow. If you really need a solution you > can acuire a token for this operation by setupNetworks, and confirm >

Re: [ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

Still someone could call conirmConnectivity, no? so the state isn't guarded from localhost tinkering anyhow. If you really need a solution you can acuire a token for this operation by setupNetworks, and confirm connectivity with this token passed back. I'm not sure about the severity of the

[ovirt-devel] [proposal] deprecate VDSM ping in favor of ping2 and confirmConnectivity

Hello, current VDSM ping verb has a problem - it confirms network connectivity as a side-effect. After Engine calls setupNetwork it pings VDSM host to confirm that external network connectivity is not broken. This prohibits other users to call ping from localhost since it would confirm