Re: [ovirt-devel] Automation CI for vdsm

2016-01-31 Thread Barak Korren
On 31 January 2016 at 14:15, Eyal Edri  wrote:
> Adding lago-devel.
> Anyone from Lago project can help debug why it is taking so long to setup
> Lago (1:17 hours?)
>
Simple, Lago downloads some big images and does a full sync of some
large package repos...
Most of that should be a lot faster the 2nd time around, and also
there is some work being done to shrink down the images.

@Yaniv, you did the test on a machine that didn't run Lago before and
was in TLV while using the repo in PHX right?

-- 
Barak Korren
bkor...@redhat.com
RHEV-CI Team
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] Automation CI for vdsm

2016-01-31 Thread David Caro Estevez
I have an unstable temporary repo with el6, el7, fc22 and fc23 images that 
weight ~ 300 mb and are updated to latest packages, working on get it properly 
generated and be able to replace all the current images, that should ease the 
first init, but the reposetup is still an issue, you might consider not doing 
it if you have internet connection and don't care slowing ever run a bit (what 
it takes to download fron the repos whatever you want to install).

We are also looking int being able to generate templates locally and/or upload 
them to the repos (so you install everything you need once, and then just reuse 
the locally generated image)

David Caro

El 31/1/2016 17:54, Barak Korren  escribió:

On 31 January 2016 at 14:15, Eyal Edri  wrote:
> Adding lago-devel.
> Anyone from Lago project can help debug why it is taking so long to setup
> Lago (1:17 hours?)
>
Simple, Lago downloads some big images and does a full sync of some
large package repos...
Most of that should be a lot faster the 2nd time around, and also
there is some work being done to shrink down the images.

@Yaniv, you did the test on a machine that didn't run Lago before and
was in TLV while using the repo in PHX right?

-- 
Barak Korren
bkor...@redhat.com
RHEV-CI Team
___
Infra mailing list
in...@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Automation CI for vdsm

2016-01-31 Thread Eyal Edri
Adding lago-devel.
Anyone from Lago project can help debug why it is taking so long to setup
Lago (1:17 hours?)

Yaniv, was this run done only on CI, or someone tried to run it locally on
a baremetal server / laptop?

e.

On Tue, Dec 22, 2015 at 2:50 PM, Yaniv Bronheim  wrote:

> OK. so for now the patch [1] skips all storage and OVSNetwork tests
> Which still doesn't help much, single run takes more than 3hrs :/ (1:17hr,
> for the setup :\ the rest for the tests)
>
> The output looks pretty good though :)
>
> [1] https://gerrit.ovirt.org/#/c/48268/
>
> On Thu, Dec 17, 2015 at 12:13 PM, Petr Horacek 
> wrote:
>
>> Hi,
>>
>> OVSNetworkTest requires vdsm-hook-ovs installed (tests are not skipped
>> if the package is not installed) and openvswitch service running (not
>> started automatically). NetworkTest are not able to run together with
>> OVSNetworkTest since we are doing ugly inheritance hacking there. My
>> apologize for network tests difficulties, it will be resolved soon. If
>> you want your life easier, temporary skip OVSNetworkTest suite and it
>> should be OK.
>>
>> Best regards,
>> Petr
>>
>> 2015-12-16 17:25 GMT+01:00 Yaniv Bronheim :
>> > exactly - just posted a patch again that sings all fails as broken .
>> > we'll get the report soon and I'll publish it as well. hope the run will
>> > take less time now
>> >
>> > On Wed, Dec 16, 2015 at 6:19 PM, Nir Soffer  wrote:
>> >>
>> >> Nice, but we cannot enable this until all the tests pass or disabled.
>> >>
>> >> There is no point in broken or flaky functional tests.
>> >>
>> >> On Wed, Dec 16, 2015 at 5:34 PM, Yaniv Bronheim 
>> >> wrote:
>> >> > So its not stable. It won't block merges and at least give us report
>> >> > after
>> >> > each merge. It takes really long time to run it (because of the tests
>> >> > themselves. Lago things takes maximum 15minutes, but the run last for
>> >> > more
>> >> > than 2hrs right now and I suspect functional/storageTests.py gets
>> stuck)
>> >> >
>> >> > Bellow you can see where we stand (before I added python-rtslib
>> >> > package).
>> >> >
>> >> > Now, I still want to merge the patch
>> https://gerrit.ovirt.org/#/c/48268/
>> >> > -
>> >> > which enables this run after merges, and I still want you to consider
>> >> > the
>> >> > addition of Automation CI flag to our gerrit so that developer will
>> be
>> >> > able
>> >> > to use it as a trigger for the check-merged.sh script run, just to
>> see
>> >> > if
>> >> > their patch fixes\brakes something realted to the functional tests
>> >> >
>> >> >
>> http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1480/ -
>> >> > is
>> >> > an example of how the run looks like. I still work to improve the
>> output
>> >> >
>> >> >
>> >> > Please reply and let me know if the idea around the automation flag
>> is
>> >> > acceptable by you.. and please review the patch for comments and
>> acks.
>> >> > We can ask dcaro to add the flag until Friday, otherwise we'll need
>> to
>> >> > delay
>> >> > this effort after the holiday..
>> >> >
>> >> >
>> >> > functional.sosPluginTests.SosPluginTest
>> >> > testSosPlugin   OK
>> >> > functional.vmRecoveryTests.RecoveryTests
>> >> > test_vm_recoveryFAIL
>> >> > functional.vmQoSTests.VMQosTests
>> >> > testSmallVMBallooning   FAIL
>> >> > functional.virtTests.VirtTest
>> >> > testComplexVm   FAIL
>> >> > testHeadlessVm  OK
>> >> > testSimpleVmFAIL
>> >> > testVmDefinitionGraphics('spice')   FAIL
>> >> > testVmDefinitionGraphics('vnc') OK
>> >> > testVmDefinitionLegacyGraphics('qxl')   FAIL
>> >> > testVmDefinitionLegacyGraphics('vnc')   OK
>> >> > testVmDefinitionMultipleGraphics('spice', 'vnc')FAIL
>> >> > testVmDefinitionMultipleGraphics('vnc', 'spice')FAIL
>> >> > testVmWithCdrom('self') FAIL
>> >> > testVmWithCdrom('specParams')   FAIL
>> >> > testVmWithCdrom('vmPayload')FAIL
>> >> > testVmWithDevice('hotplugDisk') FAIL
>> >> > testVmWithDevice('hotplugNic')  FAIL
>> >> > testVmWithDevice('smartcard')   FAIL
>> >> > testVmWithDevice('virtioNic')   FAIL
>> >> > testVmWithDevice('virtioRng')   FAIL
>> >> > testVmWithSla   FAIL
>> >> > testVmWithStorage('iscsi')

Re: [ovirt-devel] Automation CI for vdsm

2015-12-17 Thread Petr Horacek
Hi,

OVSNetworkTest requires vdsm-hook-ovs installed (tests are not skipped
if the package is not installed) and openvswitch service running (not
started automatically). NetworkTest are not able to run together with
OVSNetworkTest since we are doing ugly inheritance hacking there. My
apologize for network tests difficulties, it will be resolved soon. If
you want your life easier, temporary skip OVSNetworkTest suite and it
should be OK.

Best regards,
Petr

2015-12-16 17:25 GMT+01:00 Yaniv Bronheim :
> exactly - just posted a patch again that sings all fails as broken .
> we'll get the report soon and I'll publish it as well. hope the run will
> take less time now
>
> On Wed, Dec 16, 2015 at 6:19 PM, Nir Soffer  wrote:
>>
>> Nice, but we cannot enable this until all the tests pass or disabled.
>>
>> There is no point in broken or flaky functional tests.
>>
>> On Wed, Dec 16, 2015 at 5:34 PM, Yaniv Bronheim 
>> wrote:
>> > So its not stable. It won't block merges and at least give us report
>> > after
>> > each merge. It takes really long time to run it (because of the tests
>> > themselves. Lago things takes maximum 15minutes, but the run last for
>> > more
>> > than 2hrs right now and I suspect functional/storageTests.py gets stuck)
>> >
>> > Bellow you can see where we stand (before I added python-rtslib
>> > package).
>> >
>> > Now, I still want to merge the patch https://gerrit.ovirt.org/#/c/48268/
>> > -
>> > which enables this run after merges, and I still want you to consider
>> > the
>> > addition of Automation CI flag to our gerrit so that developer will be
>> > able
>> > to use it as a trigger for the check-merged.sh script run, just to see
>> > if
>> > their patch fixes\brakes something realted to the functional tests
>> >
>> > http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1480/ -
>> > is
>> > an example of how the run looks like. I still work to improve the output
>> >
>> >
>> > Please reply and let me know if the idea around the automation flag is
>> > acceptable by you.. and please review the patch for comments and acks.
>> > We can ask dcaro to add the flag until Friday, otherwise we'll need to
>> > delay
>> > this effort after the holiday..
>> >
>> >
>> > functional.sosPluginTests.SosPluginTest
>> > testSosPlugin   OK
>> > functional.vmRecoveryTests.RecoveryTests
>> > test_vm_recoveryFAIL
>> > functional.vmQoSTests.VMQosTests
>> > testSmallVMBallooning   FAIL
>> > functional.virtTests.VirtTest
>> > testComplexVm   FAIL
>> > testHeadlessVm  OK
>> > testSimpleVmFAIL
>> > testVmDefinitionGraphics('spice')   FAIL
>> > testVmDefinitionGraphics('vnc') OK
>> > testVmDefinitionLegacyGraphics('qxl')   FAIL
>> > testVmDefinitionLegacyGraphics('vnc')   OK
>> > testVmDefinitionMultipleGraphics('spice', 'vnc')FAIL
>> > testVmDefinitionMultipleGraphics('vnc', 'spice')FAIL
>> > testVmWithCdrom('self') FAIL
>> > testVmWithCdrom('specParams')   FAIL
>> > testVmWithCdrom('vmPayload')FAIL
>> > testVmWithDevice('hotplugDisk') FAIL
>> > testVmWithDevice('hotplugNic')  FAIL
>> > testVmWithDevice('smartcard')   FAIL
>> > testVmWithDevice('virtioNic')   FAIL
>> > testVmWithDevice('virtioRng')   FAIL
>> > testVmWithSla   FAIL
>> > testVmWithStorage('iscsi')  SKIP:
>> > python-rtslib is not installed.
>> > testVmWithStorage('localfs')FAIL
>> > testVmWithStorage('nfs')FAIL
>> > functional.storageTests.StorageTest
>> > testCreatePoolErrorsOK
>> > testStorage('glusterfs', 0) ERROR
>> > testStorage('glusterfs', 3) ERROR
>> > testStorage('iscsi', 0) SKIP:
>> > python-rtslib is not installed.
>> > testStorage('iscsi', 3) SKIP:
>> > python-rtslib is not installed.
>> > testStorage('localfs', 0)   FAIL
>> > testStorage('localfs', 3)   FAIL
>> > testStorage('nfs', 0)   FAIL
>> > testStorage('nfs', 3) 

Re: [ovirt-devel] Automation CI for vdsm

2015-12-16 Thread Nir Soffer
Nice, but we cannot enable this until all the tests pass or disabled.

There is no point in broken or flaky functional tests.

On Wed, Dec 16, 2015 at 5:34 PM, Yaniv Bronheim  wrote:
> So its not stable. It won't block merges and at least give us report after
> each merge. It takes really long time to run it (because of the tests
> themselves. Lago things takes maximum 15minutes, but the run last for more
> than 2hrs right now and I suspect functional/storageTests.py gets stuck)
>
> Bellow you can see where we stand (before I added python-rtslib package).
>
> Now, I still want to merge the patch https://gerrit.ovirt.org/#/c/48268/ -
> which enables this run after merges, and I still want you to consider the
> addition of Automation CI flag to our gerrit so that developer will be able
> to use it as a trigger for the check-merged.sh script run, just to see if
> their patch fixes\brakes something realted to the functional tests
>
> http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1480/ - is
> an example of how the run looks like. I still work to improve the output
>
>
> Please reply and let me know if the idea around the automation flag is
> acceptable by you.. and please review the patch for comments and acks.
> We can ask dcaro to add the flag until Friday, otherwise we'll need to delay
> this effort after the holiday..
>
>
> functional.sosPluginTests.SosPluginTest
> testSosPlugin   OK
> functional.vmRecoveryTests.RecoveryTests
> test_vm_recoveryFAIL
> functional.vmQoSTests.VMQosTests
> testSmallVMBallooning   FAIL
> functional.virtTests.VirtTest
> testComplexVm   FAIL
> testHeadlessVm  OK
> testSimpleVmFAIL
> testVmDefinitionGraphics('spice')   FAIL
> testVmDefinitionGraphics('vnc') OK
> testVmDefinitionLegacyGraphics('qxl')   FAIL
> testVmDefinitionLegacyGraphics('vnc')   OK
> testVmDefinitionMultipleGraphics('spice', 'vnc')FAIL
> testVmDefinitionMultipleGraphics('vnc', 'spice')FAIL
> testVmWithCdrom('self') FAIL
> testVmWithCdrom('specParams')   FAIL
> testVmWithCdrom('vmPayload')FAIL
> testVmWithDevice('hotplugDisk') FAIL
> testVmWithDevice('hotplugNic')  FAIL
> testVmWithDevice('smartcard')   FAIL
> testVmWithDevice('virtioNic')   FAIL
> testVmWithDevice('virtioRng')   FAIL
> testVmWithSla   FAIL
> testVmWithStorage('iscsi')  SKIP:
> python-rtslib is not installed.
> testVmWithStorage('localfs')FAIL
> testVmWithStorage('nfs')FAIL
> functional.storageTests.StorageTest
> testCreatePoolErrorsOK
> testStorage('glusterfs', 0) ERROR
> testStorage('glusterfs', 3) ERROR
> testStorage('iscsi', 0) SKIP:
> python-rtslib is not installed.
> testStorage('iscsi', 3) SKIP:
> python-rtslib is not installed.
> testStorage('localfs', 0)   FAIL
> testStorage('localfs', 3)   FAIL
> testStorage('nfs', 0)   FAIL
> testStorage('nfs', 3)   FAIL
> functional.networkTests.NetworkTest
> testAddVlanedBridgeless ERROR
> testAddVlanedBridgeless_oneCommand  ERROR
> testAfterNetworkSetupHook   ERROR
> testBeforeNetworkSetupHook  ERROR
> testBondHwAddress(False)ERROR
> testBondHwAddress(True) ERROR
> testBrokenNetworkReplacement(False) ERROR
> testBrokenNetworkReplacement(True)  ERROR
> testDelNetworkBondAccumulation  ERROR
> testDelNetworkWithMTU(False)ERROR
> testDelNetworkWithMTU(True) ERROR
> testDelWithoutAdd   ERROR
> testDhclientLeases(4, 'default')ERROR
> 

Re: [ovirt-devel] Automation CI for vdsm

2015-12-16 Thread Yaniv Bronheim
exactly - just posted a patch again that sings all fails as broken .
we'll get the report soon and I'll publish it as well. hope the run will
take less time now

On Wed, Dec 16, 2015 at 6:19 PM, Nir Soffer  wrote:

> Nice, but we cannot enable this until all the tests pass or disabled.
>
> There is no point in broken or flaky functional tests.
>
> On Wed, Dec 16, 2015 at 5:34 PM, Yaniv Bronheim 
> wrote:
> > So its not stable. It won't block merges and at least give us report
> after
> > each merge. It takes really long time to run it (because of the tests
> > themselves. Lago things takes maximum 15minutes, but the run last for
> more
> > than 2hrs right now and I suspect functional/storageTests.py gets stuck)
> >
> > Bellow you can see where we stand (before I added python-rtslib package).
> >
> > Now, I still want to merge the patch https://gerrit.ovirt.org/#/c/48268/
> -
> > which enables this run after merges, and I still want you to consider the
> > addition of Automation CI flag to our gerrit so that developer will be
> able
> > to use it as a trigger for the check-merged.sh script run, just to see if
> > their patch fixes\brakes something realted to the functional tests
> >
> > http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1480/
> - is
> > an example of how the run looks like. I still work to improve the output
> >
> >
> > Please reply and let me know if the idea around the automation flag is
> > acceptable by you.. and please review the patch for comments and acks.
> > We can ask dcaro to add the flag until Friday, otherwise we'll need to
> delay
> > this effort after the holiday..
> >
> >
> > functional.sosPluginTests.SosPluginTest
> > testSosPlugin   OK
> > functional.vmRecoveryTests.RecoveryTests
> > test_vm_recoveryFAIL
> > functional.vmQoSTests.VMQosTests
> > testSmallVMBallooning   FAIL
> > functional.virtTests.VirtTest
> > testComplexVm   FAIL
> > testHeadlessVm  OK
> > testSimpleVmFAIL
> > testVmDefinitionGraphics('spice')   FAIL
> > testVmDefinitionGraphics('vnc') OK
> > testVmDefinitionLegacyGraphics('qxl')   FAIL
> > testVmDefinitionLegacyGraphics('vnc')   OK
> > testVmDefinitionMultipleGraphics('spice', 'vnc')FAIL
> > testVmDefinitionMultipleGraphics('vnc', 'spice')FAIL
> > testVmWithCdrom('self') FAIL
> > testVmWithCdrom('specParams')   FAIL
> > testVmWithCdrom('vmPayload')FAIL
> > testVmWithDevice('hotplugDisk') FAIL
> > testVmWithDevice('hotplugNic')  FAIL
> > testVmWithDevice('smartcard')   FAIL
> > testVmWithDevice('virtioNic')   FAIL
> > testVmWithDevice('virtioRng')   FAIL
> > testVmWithSla   FAIL
> > testVmWithStorage('iscsi')  SKIP:
> > python-rtslib is not installed.
> > testVmWithStorage('localfs')FAIL
> > testVmWithStorage('nfs')FAIL
> > functional.storageTests.StorageTest
> > testCreatePoolErrorsOK
> > testStorage('glusterfs', 0) ERROR
> > testStorage('glusterfs', 3) ERROR
> > testStorage('iscsi', 0) SKIP:
> > python-rtslib is not installed.
> > testStorage('iscsi', 3) SKIP:
> > python-rtslib is not installed.
> > testStorage('localfs', 0)   FAIL
> > testStorage('localfs', 3)   FAIL
> > testStorage('nfs', 0)   FAIL
> > testStorage('nfs', 3)   FAIL
> > functional.networkTests.NetworkTest
> > testAddVlanedBridgeless ERROR
> > testAddVlanedBridgeless_oneCommand  ERROR
> > testAfterNetworkSetupHook   ERROR
> > testBeforeNetworkSetupHook  ERROR
> > testBondHwAddress(False)ERROR
> > testBondHwAddress(True) ERROR
> > testBrokenNetworkReplacement(False) ERROR
> > testBrokenNetworkReplacement(True) 

Re: [ovirt-devel] Automation CI for vdsm

2015-12-13 Thread Piotr Kliczewski
I like the idea but I have the same feelings as Francesco. I think that we
need to make sure that functional tests for each vertical are stable before
enabling this process.

On Sun, Dec 13, 2015 at 8:34 AM, Eyal Edri  wrote:

> adding also infra team for visibility on the change in CI.
> also inline.
>
> On Fri, Dec 11, 2015 at 4:19 PM, Francesco Romani 
> wrote:
>
>> - Original Message -
>> > From: "Yaniv Bronheim" 
>> > To: devel@ovirt.org, "Francesco Romani" , "Nir
>> Soffer" , "Piotr Kliczewski"
>> > 
>> > Cc: "danken" , "David Caro" ,
>> "Eyal Edri" 
>> > Sent: Thursday, December 10, 2015 6:46:37 PM
>> > Subject: Automation CI for vdsm
>>
>> [...]
>> > We want to allow developers to trigger the script once reviews and
>> > verification are ready (last step before merge). To do so we agreed to
>> add
>> > Continues Integration flag for each vdsm patch.
>
>
> This flag will be called 'Workflow' or we can name it otherwise, we just
> need to choose what makes sense.
> David/Yaniv - Please correct me if I'm wrong.
>
>
>> Once this flag will be
>> > signed with +1 it will trigger Jenkins CI to run the check-merged script
>> > (adding new button to gerrit is not an option - you can image that flag
>> as
>> > a trigger button), on success Jenkins CI flag will turn to +2. on fail
>> > we'll get -1 and once new patchset is ready the developer will remove
>> the
>> > +1 and add it back to the Continues Integration flag to re-trigger the
>> job.
>> >
>> > Please ack the process before we move on with that
>>
>> Sounds good, even though I'm a little scared (just gut feeling, no
>> evidence
>> whatsoever) that this could add even more complexity and fragility to the
>> jenkins
>> fleet.
>>
>> In the long run, when this is reliable, it will help greatly.
>> In the short term, I'm scared because this can lead to false positives
>> and bogus
>> failures.
>>
>> Let me stress I don't have concrete item to share or specific flaws.
>>
>> As action item on me, I will find some time next week to check virt
>> functional tests,
>> to see if they need some fixes, work reliably and so forth
>>
>> > The patch for those scripts still under review and testing -
>> > https://gerrit.ovirt.org/#/c/48268
>>
>> Will review asap.
>>
>> --
>> Francesco Romani
>> RedHat Engineering Virtualization R & D
>> Phone: 8261328
>> IRC: fromani
>>
>
>
>
> --
> Eyal Edri
> Supervisor, RHEV CI
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Automation CI for vdsm

2015-12-12 Thread Eyal Edri
adding also infra team for visibility on the change in CI.
also inline.

On Fri, Dec 11, 2015 at 4:19 PM, Francesco Romani 
wrote:

> - Original Message -
> > From: "Yaniv Bronheim" 
> > To: devel@ovirt.org, "Francesco Romani" , "Nir
> Soffer" , "Piotr Kliczewski"
> > 
> > Cc: "danken" , "David Caro" ,
> "Eyal Edri" 
> > Sent: Thursday, December 10, 2015 6:46:37 PM
> > Subject: Automation CI for vdsm
>
> [...]
> > We want to allow developers to trigger the script once reviews and
> > verification are ready (last step before merge). To do so we agreed to
> add
> > Continues Integration flag for each vdsm patch.


This flag will be called 'Workflow' or we can name it otherwise, we just
need to choose what makes sense.
David/Yaniv - Please correct me if I'm wrong.


> Once this flag will be
> > signed with +1 it will trigger Jenkins CI to run the check-merged script
> > (adding new button to gerrit is not an option - you can image that flag
> as
> > a trigger button), on success Jenkins CI flag will turn to +2. on fail
> > we'll get -1 and once new patchset is ready the developer will remove the
> > +1 and add it back to the Continues Integration flag to re-trigger the
> job.
> >
> > Please ack the process before we move on with that
>
> Sounds good, even though I'm a little scared (just gut feeling, no evidence
> whatsoever) that this could add even more complexity and fragility to the
> jenkins
> fleet.
>
> In the long run, when this is reliable, it will help greatly.
> In the short term, I'm scared because this can lead to false positives and
> bogus
> failures.
>
> Let me stress I don't have concrete item to share or specific flaws.
>
> As action item on me, I will find some time next week to check virt
> functional tests,
> to see if they need some fixes, work reliably and so forth
>
> > The patch for those scripts still under review and testing -
> > https://gerrit.ovirt.org/#/c/48268
>
> Will review asap.
>
> --
> Francesco Romani
> RedHat Engineering Virtualization R & D
> Phone: 8261328
> IRC: fromani
>



-- 
Eyal Edri
Supervisor, RHEV CI
EMEA ENG Virtualization R
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Automation CI for vdsm

2015-12-11 Thread Francesco Romani
- Original Message -
> From: "Yaniv Bronheim" 
> To: devel@ovirt.org, "Francesco Romani" , "Nir Soffer" 
> , "Piotr Kliczewski"
> 
> Cc: "danken" , "David Caro" , "Eyal 
> Edri" 
> Sent: Thursday, December 10, 2015 6:46:37 PM
> Subject: Automation CI for vdsm

[...]
> We want to allow developers to trigger the script once reviews and
> verification are ready (last step before merge). To do so we agreed to add
> Continues Integration flag for each vdsm patch. Once this flag will be
> signed with +1 it will trigger Jenkins CI to run the check-merged script
> (adding new button to gerrit is not an option - you can image that flag as
> a trigger button), on success Jenkins CI flag will turn to +2. on fail
> we'll get -1 and once new patchset is ready the developer will remove the
> +1 and add it back to the Continues Integration flag to re-trigger the job.
> 
> Please ack the process before we move on with that

Sounds good, even though I'm a little scared (just gut feeling, no evidence
whatsoever) that this could add even more complexity and fragility to the 
jenkins
fleet.

In the long run, when this is reliable, it will help greatly.
In the short term, I'm scared because this can lead to false positives and bogus
failures.

Let me stress I don't have concrete item to share or specific flaws.

As action item on me, I will find some time next week to check virt functional 
tests,
to see if they need some fixes, work reliably and so forth

> The patch for those scripts still under review and testing -
> https://gerrit.ovirt.org/#/c/48268

Will review asap.

-- 
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


[ovirt-devel] Automation CI for vdsm

2015-12-10 Thread Yaniv Bronheim
Hi all,

We want to run functional tests as part of Vdsm CI for each patch before
merge. Therefore we need to declare how to automate this process without
overloading our jenkins machines.
The functional tests will run using lago (https://github.com/ovirt/lago) -
It will initiate multiply vms, install vdsm and manipulate it by nosetests
or other procedures such as upgrade, removal and so on.

Currently standard CI provides check-patch and check-merged scripts (
http://ovirt-infra-docs.readthedocs.org/en/latest/CI/Build_and_test_standards.html)
the problem with check-merged is that it will run after merge which doesn't
help if something fails.

We want to allow developers to trigger the script once reviews and
verification are ready (last step before merge). To do so we agreed to add
Continues Integration flag for each vdsm patch. Once this flag will be
signed with +1 it will trigger Jenkins CI to run the check-merged script
(adding new button to gerrit is not an option - you can image that flag as
a trigger button), on success Jenkins CI flag will turn to +2. on fail
we'll get -1 and once new patchset is ready the developer will remove the
+1 and add it back to the Continues Integration flag to re-trigger the job.

Please ack the process before we move on with that

The patch for those scripts still under review and testing -
https://gerrit.ovirt.org/#/c/48268

Thanks

-- 
*Yaniv Bronhaim.*
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel