Re: [ovirt-devel] New design for the Gerrit UI

2017-09-06 Thread Jakub Niedermertl
On Wed, Sep 6, 2017 at 4:17 PM, Greg Sheremeta wrote: > > > On Wed, Sep 6, 2017 at 3:14 AM, Barak Korren wrote: > >> On 5 September 2017 at 21:37, Jakub Niedermertl >> wrote: >> > >> > Hi, >> > >> > it looks nice. >> > >> > Is there

Re: [ovirt-devel] New design for the Gerrit UI

2017-09-06 Thread Barak Korren
On 6 September 2017 at 17:17, Greg Sheremeta wrote: > > I can do it. But ... > > >> It a completely new code base, we will need to redo everything from >> scratch. But we probably aught to do that, because it seems like the >> way forward for Gerrit. >> > > Shouldn't we just

Re: [ovirt-devel] New design for the Gerrit UI

2017-09-06 Thread Greg Sheremeta
On Wed, Sep 6, 2017 at 3:14 AM, Barak Korren wrote: > On 5 September 2017 at 21:37, Jakub Niedermertl > wrote: > > > > Hi, > > > > it looks nice. > > > > Is there any plan > > * to actually deploy this skin on gerrit.ovirt.org? > > Given the huge amount

Re: [ovirt-devel] New design for the Gerrit UI

2017-09-06 Thread Barak Korren
On 5 September 2017 at 22:23, Yaniv Lavi (Dary) wrote: > It also doesn't render well on Chrome mobile. Can you fix that? > Gerrit old UI is not meant for mobile devices so no. Try the new (PolyGerrit) UI, there is a link in the bottom-right leading to it. -- Barak Korren

Re: [ovirt-devel] New design for the Gerrit UI

2017-09-06 Thread Barak Korren
On 5 September 2017 at 21:37, Jakub Niedermertl wrote: > > Hi, > > it looks nice. > > Is there any plan > * to actually deploy this skin on gerrit.ovirt.org? Given the huge amount of time that was already invested in this, and the endless list of issues raised on this

Re: [ovirt-devel] New design for the Gerrit UI

2017-09-05 Thread Yaniv Lavi (Dary)
It also doesn't render well on Chrome mobile. Can you fix that? Yaniv Lavi (Dary) Technical Product Manager Red Hat Israel Ltd. 34 Jerusalem Road Building A, 4th floor Ra'anana, Israel 4350109 Tel : +972 (9) 7692306 8272306 Email: yd...@redhat.com IRC : ydary On May 4, 2017 16:26,

Re: [ovirt-devel] New design for the Gerrit UI

2017-09-05 Thread Jakub Niedermertl
Hi, it looks nice. Is there any plan * to actually deploy this skin on gerrit.ovirt.org? * skin new gerrit UI (PolyGerrit) as well? * use blue theme as webadmin recently adopted and VM Portal is going to adopt? Thanks Jakub On Wed, May 10, 2017 at 10:56 PM, Phillip Bailey

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-10 Thread Phillip Bailey
It looks great to me, except for one issue. The contrast between the box around the active item on the second row and the header background color is too low to make the active item easily identifiable. The same goes for the box on the first row, but the underline makes it a non-issue. I recommend

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-08 Thread Eldan Hildesheim
Hi, Can we insert a new css package easily? Perhaps I can merge Patternfly inside which will be very suitable for this case. E. > On May 7, 2017, at 11:41 PM, Roy Golan wrote: > > > The footer links are useful but the footer itself has no presence. Most > dashboards will

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-07 Thread Roy Golan
The footer links are useful but the footer itself has no presence. Most dashboards will fill a page and with such a thin footer nobody is going to look at what is has to offer. So we can make the footer in a different color and noticeable etc or move the links to the header. On Sun, May 7, 2017

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-06 Thread Yaniv Kaul
On Fri, May 5, 2017 at 5:33 PM, Greg Sheremeta wrote: > Here's my take. > > The line on the top is a little thicker than I like, but we have the same > thickness in oVirt (I checked). I'm ok with shrinking it in both places. > > I put in the logo from the oVirt login page. I

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-05 Thread Adam Litke
I really like the colors on the patternfly scheme. Great job! On Thu, May 4, 2017 at 9:25 AM, Evgheni Dereveanchin wrote: > Thanks everyone for the great feedback! > > So there's two options I see now: > 1) keep the default header scheme with white background, just add the

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-05 Thread Roy Golan
Adding UX people +Eldan Hildesheim +Alexander Wels +Greg Sheremeta On Fri, May 5, 2017 at 2:32 AM Martin Perina wrote: > On Thu, May 4, 2017 at 1:13 PM, Nir Soffer wrote: > >> >> >> On Thu, May

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-04 Thread Martin Perina
On Thu, May 4, 2017 at 1:13 PM, Nir Soffer wrote: > > > On Thu, May 4, 2017 at 4:26 PM Evgheni Dereveanchin > wrote: > >> Thanks everyone for the great feedback! >> >> So there's two options I see now: >> 1) keep the default header scheme with white

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-04 Thread Nir Soffer
On Thu, May 4, 2017 at 4:26 PM Evgheni Dereveanchin wrote: > Thanks everyone for the great feedback! > > So there's two options I see now: > 1) keep the default header scheme with white background, just add the > project logo into the corner > 2) try to adapt to the

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-04 Thread Tasdik Rahman
Had quick look and it looks really neat! Just a quick question. [cid:340060F2-0F5B-40E2-8B52-DA77684848A2@cisco.com] Would the alignment of “All” and “Open” (so on) be placed like this or is this specific to my browser? Was curious about it. But great work everyone :) Regards, Tasdik Rahman

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-04 Thread Evgheni Dereveanchin
Thanks everyone for the great feedback! So there's two options I see now: 1) keep the default header scheme with white background, just add the project logo into the corner 2) try to adapt to the Patternfly scheme as used in oVirt's Admin UI currently. I've swapped the header background color to

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-04 Thread Martin Sivak
> It will help if someone can suggest an alternate CSS which we can use or specific color codes, Well.. keep it as it is or make it really dark (like the patternfly menu). I do not care about logos but big area filled with non-neutral color is always going to be an issue. Martin On Thu, May 4,

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-04 Thread Eyal Edri
On Thu, May 4, 2017 at 3:05 PM, Martin Perina wrote: > I agree with Milan and Martin, even after few minutes looking at it, the > green > with combination of white background just made my eyes burning :-( > > Would it be possible to use more darker colors (at least for top >

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-04 Thread Martin Perina
I agree with Milan and Martin, even after few minutes looking at it, the green with combination of white background just made my eyes burning :-( Would it be possible to use more darker colors (at least for top banner/menu)? For example darker colors we use in oVirt engine welcome page ...

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-04 Thread Nir Soffer
בתאריך יום ד׳, 3 במאי 2017, 19:20, מאת Evgheni Dereveanchin ‏< edere...@redhat.com>: > Hi everyone, > > The Infra team is working on customizing the look of Gerrit to make it fit > better with other oVirt services. I want to share the result of this > effort. Hopefully we can gather some feedback

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-04 Thread Martin Sivak
I agree with Milan here. The light green background makes the menu items to be almost unreadable, the search button (slightly different green color) blends with the background and generally the color pulls my eyes away from the content. I wouldn't feel comfortable looking at the screen for a whole

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-04 Thread Milan Zamazal
Evgheni Dereveanchin writes: > The Infra team is working on customizing the look of Gerrit to make it fit > better with other oVirt services. I want to share the result of this > effort. Hopefully we can gather some feedback before applying the design to > oVirt's instance

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-03 Thread Evgheni Dereveanchin
Hi Tasdik, The indentation is there to show that the second row is a context menu of the first one. In fact, arrangement of menu items did not change, just the colors. Check out the default style on our main Gerrit instance to compare: https://gerrit.ovirt.org/#/q/status:open If you have any

Re: [ovirt-devel] New design for the Gerrit UI

2017-05-03 Thread Oved Ourfali
Looks very nice! On May 3, 2017 7:20 PM, "Evgheni Dereveanchin" wrote: > Hi everyone, > > The Infra team is working on customizing the look of Gerrit to make it fit > better with other oVirt services. I want to share the result of this > effort. Hopefully we can gather some

[ovirt-devel] New design for the Gerrit UI

2017-05-03 Thread Evgheni Dereveanchin
Hi everyone, The Infra team is working on customizing the look of Gerrit to make it fit better with other oVirt services. I want to share the result of this effort. Hopefully we can gather some feedback before applying the design to oVirt's instance of Gerrit. Please visit the Staging instance