Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-21 Thread Doron Fediuck
- Original Message - From: Martin Sivak msi...@redhat.com To: Sven Kieske s.kie...@mittwald.de Cc: devel@ovirt.org Sent: Wednesday, September 17, 2014 12:27:29 PM Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug Hi, Why should an incomplete, thus non

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-17 Thread Sven Kieske
Why should an incomplete, thus non working feature get merged? Do you also merge incomplete bugfixes? One commit should contain one feature or one bugfix, imho? I know this can be difficult sometimes, but still, at least in the master branch this rule should get enforced, maybe create a staging

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-17 Thread Francesco Romani
- Original Message - From: Yedidyah Bar David d...@redhat.com To: Sven Kieske s.kie...@mittwald.de Cc: devel@ovirt.org Sent: Wednesday, September 17, 2014 11:08:52 AM Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug That is not a bad idea, but there is one

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-17 Thread Nir Soffer
- Original Message - From: Sven Kieske s.kie...@mittwald.de To: devel@ovirt.org Sent: Wednesday, September 17, 2014 12:01:50 PM Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug Why should an incomplete, thus non working feature get merged? Adding a feature

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-16 Thread David Caro
On Thursday, August 28, 2014 01:37:13 PM David Caro wrote: On 08/27, Martin Sivak wrote: Hi, I would like to ask if it might be possible for the gerrit hook to stop giving -1 to patches that do not have bug-url, but have related-to. The reason for this is that I have a rather large

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-16 Thread Vered Volansky
- Original Message - From: David Caro dcaro...@redhat.com To: Martin Sivak msi...@redhat.com Cc: devel@ovirt.org Sent: Tuesday, September 16, 2014 2:59:03 PM Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug On Thursday, August 28, 2014 01:37:13 PM David

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-16 Thread Martin Sivak
Message - - Original Message - From: David Caro dcaro...@redhat.com To: Martin Sivak msi...@redhat.com Cc: devel@ovirt.org Sent: Tuesday, September 16, 2014 2:59:03 PM Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug On Thursday, August 28, 2014

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-16 Thread Nir Soffer
- Original Message - From: Martin Sivak msi...@redhat.com To: Nir Soffer nsof...@redhat.com Cc: David Caro dcaro...@redhat.com, devel@ovirt.org Sent: Tuesday, September 16, 2014 3:22:40 PM Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug Why can't you put

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-16 Thread Martin Sivak
- - Original Message - From: Martin Sivak msi...@redhat.com To: Nir Soffer nsof...@redhat.com Cc: David Caro dcaro...@redhat.com, devel@ovirt.org Sent: Tuesday, September 16, 2014 3:22:40 PM Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug Why can't you put

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-16 Thread Nir Soffer
- Original Message - From: Martin Sivak msi...@redhat.com To: Nir Soffer nsof...@redhat.com Cc: David Caro dcaro...@redhat.com, devel@ovirt.org Sent: Tuesday, September 16, 2014 3:53:53 PM Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug What if gerrit used

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-16 Thread Martin Sivak
Sivak msi...@redhat.com To: Nir Soffer nsof...@redhat.com Cc: David Caro dcaro...@redhat.com, devel@ovirt.org Sent: Tuesday, September 16, 2014 3:53:53 PM Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug What if gerrit used the dependency info and would not -1

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-16 Thread David Caro
- Original Message - - Original Message - From: Martin Sivak msi...@redhat.com To: Nir Soffer nsof...@redhat.com Cc: David Caro dcaro...@redhat.com, devel@ovirt.org Sent: Tuesday, September 16, 2014 3:53:53 PM Subject: Re: [ovirt-devel] Stable branch gerrit hook

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-09-01 Thread Michal Skrivanek
On Aug 28, 2014, at 16:14 , Martin Sivak msi...@redhat.com wrote: Hi, yeah I think it should be like that. +1 * Should it pass the same checks than a Bug-Url? Most probably yes Right now that is: - Public - Target release - Product * Should it change the bug statuses

Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug

2014-08-28 Thread Martin Sivak
Hi, yeah I think it should be like that. * Should it pass the same checks than a Bug-Url? Most probably yes Right now that is: - Public - Target release - Product * Should it change the bug statuses too? Most probably no * Should it update the external trackers of the