Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Vojtech Szocs]

Hello Martin,

UI plugin API in 4.2 should be generally backwards compatible with 4.1.

Comparing PluginManager.java between master and 4.1.8 - the
exposePluginApi() function is exactly the same for now.

However, we might do some API changes in the future, mainly due to 4.2 UI
redesign. For example:

   - taking out the word "Tab" out of function names, since the UI concept
   of "main tab" is no more
   - as mentioned by Alex, support adding buttons inside kebab drop-down,
   as opposed to adding them directly to the toolbar (UX wise, important
   things should be outside kebab, less important things should go inside it)
   - support adding secondary level menu items when adding new "main tab"
   (this should become "add menu item" function)
   - support customizing the icon for primary menu items

As for the visuals, as Greg wrote, UI plugins should generally follow the
PatternFly styling to ensure consistent looks.

WebAdmin has its own branding infra and UI plugins can use that. Just
inspect the HTML source and see how WebAdmin requests PatternFly & branding
related assets.

Vojtech


On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta  wrote:

> Hey,
>
> We haven't changed the API, so everything should still work. For example,
> I just installed 4.1 versions of dashboard and support-plugin in master,
> and all's well [*]:
>
> API:
>
> api.addSubTab('Template', 'Red Hat Documentation',
> 'my-host-subtab-template', '', {alignRight: true});
> api.setTabAccessible('my-host-subtab-template', true);
>
> [image: Inline image 1]
>
> [*] however, note that "alignRight" is now ignored
>
> And dashboard 4.1.8 installed in master engine:
>
> [image: Inline image 2]
>
>
> That said, we probably should have sent some announcement about making
> sure the plugins actually look good with the new theme. If some plugins are
> greenish, that will look bad.
>
> To help with styling external things, we've started exposing more CSS via
> a new SASS brand module:
> https://github.com/oVirt/ovirt-engine/tree/master/frontend/brands/
> ​​
> ovirt-brand/src/main/sass
> 
> Also, we're heavily relying on base PatternFly styles, and plugins should
> do the same. For example, the new dialog styles are completely PatternFly [
> http://www.patternfly.org/pattern-library/forms-and-
> controls/modal-overlay/] and we don't do anything extra on top of that.
>
> Let us know if something doesn't work, or you need help styling something.
>
> Greg
>
> On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak  wrote:
>
>> Hi,
>>
>> I just got a question from an ovirt-optimizer user about the support
>> in 4.2. And I realized I haven't heard anything about how UI plugins
>> should be updated to work with the new UI.
>>
>> Is there anything special that needs to be done to make the plugin
>> functional? Or will everything still work somehow?
>>
>> Best regards
>>
>> Martin Sivak
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Alexander Wels]

On Thursday, November 30, 2017 10:48:26 AM EST Martin Sivak wrote:
> It stays on a single line with just slightly wider window than I normally
> have. But all plugins will be adding buttons here so the line can
> theoretically get really long.
> 
> Btw, is 1920px the required resolution now? Because I have no screen or
> machine with that :D
> 
> Martin
> 

Right and we have no api option (yet) to allow plugins to put their buttons in 
the kebab menu. The buttons (and kebab as you noticed) will simply wrap to the 
next line if there is not enough space to display them all. You just happened 
to have a width where just the kebab menu wrapped, which looks sort of weird. 
I guess we can try to force the kebab on the top right regardless of if the 
buttons wrap.

Btw there is no resolution requirement. In fact it should be somewhat usable 
on low resolution and mobile type screens now.

> On Thu, Nov 30, 2017 at 4:44 PM, Greg Sheremeta  wrote:
> > How does it look at 1920px wide?
> > 
> > On Thu, Nov 30, 2017 at 10:40 AM, Martin Sivak  wrote:
> >> Hi,
> >> 
> >> I see it working with a small UI glitch:
> >> 
> >> Martin
> >> 
> >> On Wed, Nov 29, 2017 at 6:25 PM, Martin Sivak  wrote:
> >>> I will try finding time tomorrow. Thanks.
> >>> 
> >>> Martin
> >>> 
> >>> On Wed, Nov 29, 2017 at 6:02 PM, Greg Sheremeta 
> >>> 
> >>> wrote:
>  Martin, we've merged the fix. (Thanks to Alexander for the super fast
>  fix.)
>  
>  Care to test with master?
>  
>  On Wed, Nov 29, 2017 at 10:50 AM, Alexander Wels 
>  
>  wrote:
> > On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote:
> > > Thanks to you too for checking.
> > > 
> > > Martin
> > 
> > Fix is pending review [1]. We moved the main views to a different
> > class
> > hierarchy and it wasn't inheriting the methods to add the buttons.
> > 
> > Alexander
> > 
> > [1] https://gerrit.ovirt.org/c/84901/
> > 
> > > On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta
> > > 
> > 
> > wrote:
> > > > Discussed with Alexander, and yep this is an issue.
> > > > I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724
> > > > 
> > > > Thanks for checking and reporting!
> > > > 
> > > > On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta <
> > 
> > gsher...@redhat.com>
> > 
> > > > wrote:
> > > >> +Alexander, can you take a look?
> > > >> 
> > > >> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak 
> > 
> > wrote:
> > > >>> Hi,
> > > >>> 
> > > >>> I think I found one issue.. I do not see the extra menu items
> > 
> > that were
> > 
> > > >>> supposed to be added to VMs (used to be available in context
> > 
> > menu as
> > 
> > > >>> well).
> > > >>> 
> > > >>> You can check it with
> > > >>> 
> > > >>> http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa
> > > >>> tch-el7-x86_64/65/
> > > >>> 
> > > >>> Martin
> > > >>> 
> > > >>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <
> > 
> > gsher...@redhat.com>
> > 
> > > >>> wrote:
> > >  Hey,
> > >  
> > >  We haven't changed the API, so everything should still work.
> > >  For
> > >  example, I just installed 4.1 versions of dashboard and
> > 
> > support-plugin
> > 
> > >  in
> > >  master, and all's well [*]:
> > >  
> > >  API:
> > >  
> > >  api.addSubTab('Template', 'Red Hat Documentation',
> > >  'my-host-subtab-template', '', {alignRight: true});
> > >  api.setTabAccessible('my-host-subtab-template', true);
> > >  
> > >  [image: Inline image 1]
> > >  
> > >  [*] however, note that "alignRight" is now ignored
> > >  
> > >  And dashboard 4.1.8 installed in master engine:
> > >  
> > >  [image: Inline image 2]
> > >  
> > >  
> > >  That said, we probably should have sent some announcement about
> > 
> > making
> > 
> > >  sure the plugins actually look good with the new theme. If some
> > 
> > plugins
> > 
> > >  are
> > >  greenish, that will look bad.
> > >  
> > >  To help with styling external things, we've started exposing
> > 
> > more CSS
> > 
> > >  via a new SASS brand module:
> > >  https://github.com/oVirt/ovirt-engine/tree/master/frontend/b
> > >  rands/ovirt-brand/src/main/sass
> > >  Also, we're heavily relying on base PatternFly styles, and
> > 
> > plugins
> > 
> > >  should do the same. For example, the new dialog styles are
> > 
> > completely
> > 
> > > 

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Martin Sivak]

It stays on a single line with just slightly wider window than I normally
have. But all plugins will be adding buttons here so the line can
theoretically get really long.

Btw, is 1920px the required resolution now? Because I have no screen or
machine with that :D

Martin

On Thu, Nov 30, 2017 at 4:44 PM, Greg Sheremeta  wrote:

> How does it look at 1920px wide?
>
> On Thu, Nov 30, 2017 at 10:40 AM, Martin Sivak  wrote:
>
>> Hi,
>>
>> I see it working with a small UI glitch:
>>
>> Martin
>>
>> On Wed, Nov 29, 2017 at 6:25 PM, Martin Sivak  wrote:
>>
>>> I will try finding time tomorrow. Thanks.
>>>
>>> Martin
>>>
>>> On Wed, Nov 29, 2017 at 6:02 PM, Greg Sheremeta 
>>> wrote:
>>>
 Martin, we've merged the fix. (Thanks to Alexander for the super fast
 fix.)

 Care to test with master?

 On Wed, Nov 29, 2017 at 10:50 AM, Alexander Wels 
 wrote:

> On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote:
> > Thanks to you too for checking.
> >
> > Martin
> >
>
> Fix is pending review [1]. We moved the main views to a different class
> hierarchy and it wasn't inheriting the methods to add the buttons.
>
> Alexander
>
> [1] https://gerrit.ovirt.org/c/84901/
>
> > On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta 
> wrote:
> > > Discussed with Alexander, and yep this is an issue.
> > > I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724
> > >
> > > Thanks for checking and reporting!
> > >
> > > On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta <
> gsher...@redhat.com>
> > >
> > > wrote:
> > >> +Alexander, can you take a look?
> > >>
> > >> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak 
> wrote:
> > >>> Hi,
> > >>>
> > >>> I think I found one issue.. I do not see the extra menu items
> that were
> > >>> supposed to be added to VMs (used to be available in context
> menu as
> > >>> well).
> > >>>
> > >>> You can check it with
> > >>>
> > >>> http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa
> > >>> tch-el7-x86_64/65/
> > >>>
> > >>> Martin
> > >>>
> > >>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <
> gsher...@redhat.com>
> > >>>
> > >>> wrote:
> >  Hey,
> > 
> >  We haven't changed the API, so everything should still work. For
> >  example, I just installed 4.1 versions of dashboard and
> support-plugin
> >  in
> >  master, and all's well [*]:
> > 
> >  API:
> > 
> >  api.addSubTab('Template', 'Red Hat Documentation',
> >  'my-host-subtab-template', '', {alignRight: true});
> >  api.setTabAccessible('my-host-subtab-template', true);
> > 
> >  [image: Inline image 1]
> > 
> >  [*] however, note that "alignRight" is now ignored
> > 
> >  And dashboard 4.1.8 installed in master engine:
> > 
> >  [image: Inline image 2]
> > 
> > 
> >  That said, we probably should have sent some announcement about
> making
> >  sure the plugins actually look good with the new theme. If some
> plugins
> >  are
> >  greenish, that will look bad.
> > 
> >  To help with styling external things, we've started exposing
> more CSS
> >  via a new SASS brand module:
> >  https://github.com/oVirt/ovirt-engine/tree/master/frontend/b
> >  rands/ovirt-brand/src/main/sass
> >  Also, we're heavily relying on base PatternFly styles, and
> plugins
> >  should do the same. For example, the new dialog styles are
> completely
> >  PatternFly [http://www.patternfly.org/pat
> tern-library/forms-and-control
> >  s/modal-overlay/] and we don't do anything extra on top of that.
> > 
> >  Let us know if something doesn't work, or you need help styling
> >  something.
> > 
> >  Greg
> > 
> >  On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak <
> msi...@redhat.com>
> > 
> >  wrote:
> > > Hi,
> > >
> > > I just got a question from an ovirt-optimizer user about the
> support
> > > in 4.2. And I realized I haven't heard anything about how UI
> plugins
> > > should be updated to work with the new UI.
> > >
> > > Is there anything special that needs to be done to make the
> plugin
> > > functional? Or will everything still work somehow?
> > >
> > > Best regards
> > >
> > > Martin Sivak
> > > ___
> > > Devel mailing list
> > > 

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Greg Sheremeta]

How does it look at 1920px wide?

On Thu, Nov 30, 2017 at 10:40 AM, Martin Sivak  wrote:

> Hi,
>
> I see it working with a small UI glitch:
>
> Martin
>
> On Wed, Nov 29, 2017 at 6:25 PM, Martin Sivak  wrote:
>
>> I will try finding time tomorrow. Thanks.
>>
>> Martin
>>
>> On Wed, Nov 29, 2017 at 6:02 PM, Greg Sheremeta 
>> wrote:
>>
>>> Martin, we've merged the fix. (Thanks to Alexander for the super fast
>>> fix.)
>>>
>>> Care to test with master?
>>>
>>> On Wed, Nov 29, 2017 at 10:50 AM, Alexander Wels 
>>> wrote:
>>>
 On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote:
 > Thanks to you too for checking.
 >
 > Martin
 >

 Fix is pending review [1]. We moved the main views to a different class
 hierarchy and it wasn't inheriting the methods to add the buttons.

 Alexander

 [1] https://gerrit.ovirt.org/c/84901/

 > On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta 
 wrote:
 > > Discussed with Alexander, and yep this is an issue.
 > > I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724
 > >
 > > Thanks for checking and reporting!
 > >
 > > On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta <
 gsher...@redhat.com>
 > >
 > > wrote:
 > >> +Alexander, can you take a look?
 > >>
 > >> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak 
 wrote:
 > >>> Hi,
 > >>>
 > >>> I think I found one issue.. I do not see the extra menu items
 that were
 > >>> supposed to be added to VMs (used to be available in context menu
 as
 > >>> well).
 > >>>
 > >>> You can check it with
 > >>>
 > >>> http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa
 > >>> tch-el7-x86_64/65/
 > >>>
 > >>> Martin
 > >>>
 > >>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <
 gsher...@redhat.com>
 > >>>
 > >>> wrote:
 >  Hey,
 > 
 >  We haven't changed the API, so everything should still work. For
 >  example, I just installed 4.1 versions of dashboard and
 support-plugin
 >  in
 >  master, and all's well [*]:
 > 
 >  API:
 > 
 >  api.addSubTab('Template', 'Red Hat Documentation',
 >  'my-host-subtab-template', '', {alignRight: true});
 >  api.setTabAccessible('my-host-subtab-template', true);
 > 
 >  [image: Inline image 1]
 > 
 >  [*] however, note that "alignRight" is now ignored
 > 
 >  And dashboard 4.1.8 installed in master engine:
 > 
 >  [image: Inline image 2]
 > 
 > 
 >  That said, we probably should have sent some announcement about
 making
 >  sure the plugins actually look good with the new theme. If some
 plugins
 >  are
 >  greenish, that will look bad.
 > 
 >  To help with styling external things, we've started exposing
 more CSS
 >  via a new SASS brand module:
 >  https://github.com/oVirt/ovirt-engine/tree/master/frontend/b
 >  rands/ovirt-brand/src/main/sass
 >  Also, we're heavily relying on base PatternFly styles, and
 plugins
 >  should do the same. For example, the new dialog styles are
 completely
 >  PatternFly [http://www.patternfly.org/pat
 tern-library/forms-and-control
 >  s/modal-overlay/] and we don't do anything extra on top of that.
 > 
 >  Let us know if something doesn't work, or you need help styling
 >  something.
 > 
 >  Greg
 > 
 >  On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak 
 > 
 >  wrote:
 > > Hi,
 > >
 > > I just got a question from an ovirt-optimizer user about the
 support
 > > in 4.2. And I realized I haven't heard anything about how UI
 plugins
 > > should be updated to work with the new UI.
 > >
 > > Is there anything special that needs to be done to make the
 plugin
 > > functional? Or will everything still work somehow?
 > >
 > > Best regards
 > >
 > > Martin Sivak
 > > ___
 > > Devel mailing list
 > > Devel@ovirt.org
 > > http://lists.ovirt.org/mailman/listinfo/devel
 > >>
 > >> --
 > >>
 > >> GREG SHEREMETA
 > >>
 > >> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
 > >>
 > >> Red Hat NA
 > >>
 > >> 
 > >>
 > >> gsher...@redhat.comIRC: gshereme
 > >> 
 > >
 > > --
 > >
 > > GREG SHEREMETA
 > >
 > > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
 > >
 > > Red Hat 

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Martin Sivak]

Hi,

I see it working with a small UI glitch:

Martin

On Wed, Nov 29, 2017 at 6:25 PM, Martin Sivak  wrote:

> I will try finding time tomorrow. Thanks.
>
> Martin
>
> On Wed, Nov 29, 2017 at 6:02 PM, Greg Sheremeta 
> wrote:
>
>> Martin, we've merged the fix. (Thanks to Alexander for the super fast
>> fix.)
>>
>> Care to test with master?
>>
>> On Wed, Nov 29, 2017 at 10:50 AM, Alexander Wels 
>> wrote:
>>
>>> On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote:
>>> > Thanks to you too for checking.
>>> >
>>> > Martin
>>> >
>>>
>>> Fix is pending review [1]. We moved the main views to a different class
>>> hierarchy and it wasn't inheriting the methods to add the buttons.
>>>
>>> Alexander
>>>
>>> [1] https://gerrit.ovirt.org/c/84901/
>>>
>>> > On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta 
>>> wrote:
>>> > > Discussed with Alexander, and yep this is an issue.
>>> > > I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724
>>> > >
>>> > > Thanks for checking and reporting!
>>> > >
>>> > > On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta >> >
>>> > >
>>> > > wrote:
>>> > >> +Alexander, can you take a look?
>>> > >>
>>> > >> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak 
>>> wrote:
>>> > >>> Hi,
>>> > >>>
>>> > >>> I think I found one issue.. I do not see the extra menu items that
>>> were
>>> > >>> supposed to be added to VMs (used to be available in context menu
>>> as
>>> > >>> well).
>>> > >>>
>>> > >>> You can check it with
>>> > >>>
>>> > >>> http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa
>>> > >>> tch-el7-x86_64/65/
>>> > >>>
>>> > >>> Martin
>>> > >>>
>>> > >>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <
>>> gsher...@redhat.com>
>>> > >>>
>>> > >>> wrote:
>>> >  Hey,
>>> > 
>>> >  We haven't changed the API, so everything should still work. For
>>> >  example, I just installed 4.1 versions of dashboard and
>>> support-plugin
>>> >  in
>>> >  master, and all's well [*]:
>>> > 
>>> >  API:
>>> > 
>>> >  api.addSubTab('Template', 'Red Hat Documentation',
>>> >  'my-host-subtab-template', '', {alignRight: true});
>>> >  api.setTabAccessible('my-host-subtab-template', true);
>>> > 
>>> >  [image: Inline image 1]
>>> > 
>>> >  [*] however, note that "alignRight" is now ignored
>>> > 
>>> >  And dashboard 4.1.8 installed in master engine:
>>> > 
>>> >  [image: Inline image 2]
>>> > 
>>> > 
>>> >  That said, we probably should have sent some announcement about
>>> making
>>> >  sure the plugins actually look good with the new theme. If some
>>> plugins
>>> >  are
>>> >  greenish, that will look bad.
>>> > 
>>> >  To help with styling external things, we've started exposing more
>>> CSS
>>> >  via a new SASS brand module:
>>> >  https://github.com/oVirt/ovirt-engine/tree/master/frontend/b
>>> >  rands/ovirt-brand/src/main/sass
>>> >  Also, we're heavily relying on base PatternFly styles, and plugins
>>> >  should do the same. For example, the new dialog styles are
>>> completely
>>> >  PatternFly [http://www.patternfly.org/pat
>>> tern-library/forms-and-control
>>> >  s/modal-overlay/] and we don't do anything extra on top of that.
>>> > 
>>> >  Let us know if something doesn't work, or you need help styling
>>> >  something.
>>> > 
>>> >  Greg
>>> > 
>>> >  On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak 
>>> > 
>>> >  wrote:
>>> > > Hi,
>>> > >
>>> > > I just got a question from an ovirt-optimizer user about the
>>> support
>>> > > in 4.2. And I realized I haven't heard anything about how UI
>>> plugins
>>> > > should be updated to work with the new UI.
>>> > >
>>> > > Is there anything special that needs to be done to make the
>>> plugin
>>> > > functional? Or will everything still work somehow?
>>> > >
>>> > > Best regards
>>> > >
>>> > > Martin Sivak
>>> > > ___
>>> > > Devel mailing list
>>> > > Devel@ovirt.org
>>> > > http://lists.ovirt.org/mailman/listinfo/devel
>>> > >>
>>> > >> --
>>> > >>
>>> > >> GREG SHEREMETA
>>> > >>
>>> > >> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
>>> > >>
>>> > >> Red Hat NA
>>> > >>
>>> > >> 
>>> > >>
>>> > >> gsher...@redhat.comIRC: gshereme
>>> > >> 
>>> > >
>>> > > --
>>> > >
>>> > > GREG SHEREMETA
>>> > >
>>> > > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
>>> > >
>>> > > Red Hat NA
>>> > >
>>> > > 
>>> > >
>>> > > gsher...@redhat.comIRC: gshereme
>>> > > 
>>>
>>>
>>>
>>
>>
>> --
>>
>> GREG SHEREMETA
>>
>> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
>>
>> Red Hat NA
>>
>> 
>>
>> 

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Martin Sivak]

I will try finding time tomorrow. Thanks.

Martin

On Wed, Nov 29, 2017 at 6:02 PM, Greg Sheremeta  wrote:

> Martin, we've merged the fix. (Thanks to Alexander for the super fast fix.)
>
> Care to test with master?
>
> On Wed, Nov 29, 2017 at 10:50 AM, Alexander Wels  wrote:
>
>> On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote:
>> > Thanks to you too for checking.
>> >
>> > Martin
>> >
>>
>> Fix is pending review [1]. We moved the main views to a different class
>> hierarchy and it wasn't inheriting the methods to add the buttons.
>>
>> Alexander
>>
>> [1] https://gerrit.ovirt.org/c/84901/
>>
>> > On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta 
>> wrote:
>> > > Discussed with Alexander, and yep this is an issue.
>> > > I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724
>> > >
>> > > Thanks for checking and reporting!
>> > >
>> > > On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta 
>> > >
>> > > wrote:
>> > >> +Alexander, can you take a look?
>> > >>
>> > >> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak 
>> wrote:
>> > >>> Hi,
>> > >>>
>> > >>> I think I found one issue.. I do not see the extra menu items that
>> were
>> > >>> supposed to be added to VMs (used to be available in context menu as
>> > >>> well).
>> > >>>
>> > >>> You can check it with
>> > >>>
>> > >>> http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa
>> > >>> tch-el7-x86_64/65/
>> > >>>
>> > >>> Martin
>> > >>>
>> > >>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <
>> gsher...@redhat.com>
>> > >>>
>> > >>> wrote:
>> >  Hey,
>> > 
>> >  We haven't changed the API, so everything should still work. For
>> >  example, I just installed 4.1 versions of dashboard and
>> support-plugin
>> >  in
>> >  master, and all's well [*]:
>> > 
>> >  API:
>> > 
>> >  api.addSubTab('Template', 'Red Hat Documentation',
>> >  'my-host-subtab-template', '', {alignRight: true});
>> >  api.setTabAccessible('my-host-subtab-template', true);
>> > 
>> >  [image: Inline image 1]
>> > 
>> >  [*] however, note that "alignRight" is now ignored
>> > 
>> >  And dashboard 4.1.8 installed in master engine:
>> > 
>> >  [image: Inline image 2]
>> > 
>> > 
>> >  That said, we probably should have sent some announcement about
>> making
>> >  sure the plugins actually look good with the new theme. If some
>> plugins
>> >  are
>> >  greenish, that will look bad.
>> > 
>> >  To help with styling external things, we've started exposing more
>> CSS
>> >  via a new SASS brand module:
>> >  https://github.com/oVirt/ovirt-engine/tree/master/frontend/b
>> >  rands/ovirt-brand/src/main/sass
>> >  Also, we're heavily relying on base PatternFly styles, and plugins
>> >  should do the same. For example, the new dialog styles are
>> completely
>> >  PatternFly [http://www.patternfly.org/pat
>> tern-library/forms-and-control
>> >  s/modal-overlay/] and we don't do anything extra on top of that.
>> > 
>> >  Let us know if something doesn't work, or you need help styling
>> >  something.
>> > 
>> >  Greg
>> > 
>> >  On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak 
>> > 
>> >  wrote:
>> > > Hi,
>> > >
>> > > I just got a question from an ovirt-optimizer user about the
>> support
>> > > in 4.2. And I realized I haven't heard anything about how UI
>> plugins
>> > > should be updated to work with the new UI.
>> > >
>> > > Is there anything special that needs to be done to make the plugin
>> > > functional? Or will everything still work somehow?
>> > >
>> > > Best regards
>> > >
>> > > Martin Sivak
>> > > ___
>> > > Devel mailing list
>> > > Devel@ovirt.org
>> > > http://lists.ovirt.org/mailman/listinfo/devel
>> > >>
>> > >> --
>> > >>
>> > >> GREG SHEREMETA
>> > >>
>> > >> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
>> > >>
>> > >> Red Hat NA
>> > >>
>> > >> 
>> > >>
>> > >> gsher...@redhat.comIRC: gshereme
>> > >> 
>> > >
>> > > --
>> > >
>> > > GREG SHEREMETA
>> > >
>> > > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
>> > >
>> > > Red Hat NA
>> > >
>> > > 
>> > >
>> > > gsher...@redhat.comIRC: gshereme
>> > > 
>>
>>
>>
>
>
> --
>
> GREG SHEREMETA
>
> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
>
> Red Hat NA
>
> 
>
> gsher...@redhat.comIRC: gshereme
> 
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Greg Sheremeta]

Martin, we've merged the fix. (Thanks to Alexander for the super fast fix.)

Care to test with master?

On Wed, Nov 29, 2017 at 10:50 AM, Alexander Wels  wrote:

> On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote:
> > Thanks to you too for checking.
> >
> > Martin
> >
>
> Fix is pending review [1]. We moved the main views to a different class
> hierarchy and it wasn't inheriting the methods to add the buttons.
>
> Alexander
>
> [1] https://gerrit.ovirt.org/c/84901/
>
> > On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta 
> wrote:
> > > Discussed with Alexander, and yep this is an issue.
> > > I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724
> > >
> > > Thanks for checking and reporting!
> > >
> > > On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta 
> > >
> > > wrote:
> > >> +Alexander, can you take a look?
> > >>
> > >> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak 
> wrote:
> > >>> Hi,
> > >>>
> > >>> I think I found one issue.. I do not see the extra menu items that
> were
> > >>> supposed to be added to VMs (used to be available in context menu as
> > >>> well).
> > >>>
> > >>> You can check it with
> > >>>
> > >>> http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa
> > >>> tch-el7-x86_64/65/
> > >>>
> > >>> Martin
> > >>>
> > >>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta  >
> > >>>
> > >>> wrote:
> >  Hey,
> > 
> >  We haven't changed the API, so everything should still work. For
> >  example, I just installed 4.1 versions of dashboard and
> support-plugin
> >  in
> >  master, and all's well [*]:
> > 
> >  API:
> > 
> >  api.addSubTab('Template', 'Red Hat Documentation',
> >  'my-host-subtab-template', '', {alignRight: true});
> >  api.setTabAccessible('my-host-subtab-template', true);
> > 
> >  [image: Inline image 1]
> > 
> >  [*] however, note that "alignRight" is now ignored
> > 
> >  And dashboard 4.1.8 installed in master engine:
> > 
> >  [image: Inline image 2]
> > 
> > 
> >  That said, we probably should have sent some announcement about
> making
> >  sure the plugins actually look good with the new theme. If some
> plugins
> >  are
> >  greenish, that will look bad.
> > 
> >  To help with styling external things, we've started exposing more
> CSS
> >  via a new SASS brand module:
> >  https://github.com/oVirt/ovirt-engine/tree/master/frontend/b
> >  rands/ovirt-brand/src/main/sass
> >  Also, we're heavily relying on base PatternFly styles, and plugins
> >  should do the same. For example, the new dialog styles are
> completely
> >  PatternFly [http://www.patternfly.org/pattern-library/forms-and-
> control
> >  s/modal-overlay/] and we don't do anything extra on top of that.
> > 
> >  Let us know if something doesn't work, or you need help styling
> >  something.
> > 
> >  Greg
> > 
> >  On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak 
> > 
> >  wrote:
> > > Hi,
> > >
> > > I just got a question from an ovirt-optimizer user about the
> support
> > > in 4.2. And I realized I haven't heard anything about how UI
> plugins
> > > should be updated to work with the new UI.
> > >
> > > Is there anything special that needs to be done to make the plugin
> > > functional? Or will everything still work somehow?
> > >
> > > Best regards
> > >
> > > Martin Sivak
> > > ___
> > > Devel mailing list
> > > Devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/devel
> > >>
> > >> --
> > >>
> > >> GREG SHEREMETA
> > >>
> > >> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
> > >>
> > >> Red Hat NA
> > >>
> > >> 
> > >>
> > >> gsher...@redhat.comIRC: gshereme
> > >> 
> > >
> > > --
> > >
> > > GREG SHEREMETA
> > >
> > > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
> > >
> > > Red Hat NA
> > >
> > > 
> > >
> > > gsher...@redhat.comIRC: gshereme
> > > 
>
>
>


-- 

GREG SHEREMETA

SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX

Red Hat NA



gsher...@redhat.comIRC: gshereme

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Alexander Wels]

On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote:
> Thanks to you too for checking.
> 
> Martin
> 

Fix is pending review [1]. We moved the main views to a different class 
hierarchy and it wasn't inheriting the methods to add the buttons.

Alexander

[1] https://gerrit.ovirt.org/c/84901/

> On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta  wrote:
> > Discussed with Alexander, and yep this is an issue.
> > I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724
> > 
> > Thanks for checking and reporting!
> > 
> > On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta 
> > 
> > wrote:
> >> +Alexander, can you take a look?
> >> 
> >> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak  wrote:
> >>> Hi,
> >>> 
> >>> I think I found one issue.. I do not see the extra menu items that were
> >>> supposed to be added to VMs (used to be available in context menu as
> >>> well).
> >>> 
> >>> You can check it with
> >>> 
> >>> http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa
> >>> tch-el7-x86_64/65/
> >>> 
> >>> Martin
> >>> 
> >>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta 
> >>> 
> >>> wrote:
>  Hey,
>  
>  We haven't changed the API, so everything should still work. For
>  example, I just installed 4.1 versions of dashboard and support-plugin
>  in
>  master, and all's well [*]:
>  
>  API:
>  
>  api.addSubTab('Template', 'Red Hat Documentation',
>  'my-host-subtab-template', '', {alignRight: true});
>  api.setTabAccessible('my-host-subtab-template', true);
>  
>  [image: Inline image 1]
>  
>  [*] however, note that "alignRight" is now ignored
>  
>  And dashboard 4.1.8 installed in master engine:
>  
>  [image: Inline image 2]
>  
>  
>  That said, we probably should have sent some announcement about making
>  sure the plugins actually look good with the new theme. If some plugins
>  are
>  greenish, that will look bad.
>  
>  To help with styling external things, we've started exposing more CSS
>  via a new SASS brand module:
>  https://github.com/oVirt/ovirt-engine/tree/master/frontend/b
>  rands/ovirt-brand/src/main/sass
>  Also, we're heavily relying on base PatternFly styles, and plugins
>  should do the same. For example, the new dialog styles are completely
>  PatternFly [http://www.patternfly.org/pattern-library/forms-and-control
>  s/modal-overlay/] and we don't do anything extra on top of that.
>  
>  Let us know if something doesn't work, or you need help styling
>  something.
>  
>  Greg
>  
>  On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak 
>  
>  wrote:
> > Hi,
> > 
> > I just got a question from an ovirt-optimizer user about the support
> > in 4.2. And I realized I haven't heard anything about how UI plugins
> > should be updated to work with the new UI.
> > 
> > Is there anything special that needs to be done to make the plugin
> > functional? Or will everything still work somehow?
> > 
> > Best regards
> > 
> > Martin Sivak
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> >> 
> >> --
> >> 
> >> GREG SHEREMETA
> >> 
> >> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
> >> 
> >> Red Hat NA
> >> 
> >> 
> >> 
> >> gsher...@redhat.comIRC: gshereme
> >> 
> > 
> > --
> > 
> > GREG SHEREMETA
> > 
> > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
> > 
> > Red Hat NA
> > 
> > 
> > 
> > gsher...@redhat.comIRC: gshereme
> > 


___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Greg Sheremeta]

Discussed with Alexander, and yep this is an issue.
I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724

Thanks for checking and reporting!

On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta  wrote:

> +Alexander, can you take a look?
>
> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak  wrote:
>
>> Hi,
>>
>> I think I found one issue.. I do not see the extra menu items that were
>> supposed to be added to VMs (used to be available in context menu as well).
>>
>> You can check it with
>>
>> http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa
>> tch-el7-x86_64/65/
>>
>> Martin
>>
>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta 
>> wrote:
>>
>>> Hey,
>>>
>>> We haven't changed the API, so everything should still work. For
>>> example, I just installed 4.1 versions of dashboard and support-plugin in
>>> master, and all's well [*]:
>>>
>>> API:
>>>
>>> api.addSubTab('Template', 'Red Hat Documentation',
>>> 'my-host-subtab-template', '', {alignRight: true});
>>> api.setTabAccessible('my-host-subtab-template', true);
>>>
>>> [image: Inline image 1]
>>>
>>> [*] however, note that "alignRight" is now ignored
>>>
>>> And dashboard 4.1.8 installed in master engine:
>>>
>>> [image: Inline image 2]
>>>
>>>
>>> That said, we probably should have sent some announcement about making
>>> sure the plugins actually look good with the new theme. If some plugins are
>>> greenish, that will look bad.
>>>
>>> To help with styling external things, we've started exposing more CSS
>>> via a new SASS brand module:
>>> https://github.com/oVirt/ovirt-engine/tree/master/frontend/b
>>> rands/ovirt-brand/src/main/sass
>>> Also, we're heavily relying on base PatternFly styles, and plugins
>>> should do the same. For example, the new dialog styles are completely
>>> PatternFly [http://www.patternfly.org/pattern-library/forms-and-control
>>> s/modal-overlay/] and we don't do anything extra on top of that.
>>>
>>> Let us know if something doesn't work, or you need help styling
>>> something.
>>>
>>> Greg
>>>
>>> On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak  wrote:
>>>
 Hi,

 I just got a question from an ovirt-optimizer user about the support
 in 4.2. And I realized I haven't heard anything about how UI plugins
 should be updated to work with the new UI.

 Is there anything special that needs to be done to make the plugin
 functional? Or will everything still work somehow?

 Best regards

 Martin Sivak
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel

>>>
>>>
>>>
>>
>
>
> --
>
> GREG SHEREMETA
>
> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
>
> Red Hat NA
>
> 
>
> gsher...@redhat.comIRC: gshereme
> 
>



-- 

GREG SHEREMETA

SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX

Red Hat NA



gsher...@redhat.comIRC: gshereme

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Greg Sheremeta]

+Alexander, can you take a look?

On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak  wrote:

> Hi,
>
> I think I found one issue.. I do not see the extra menu items that were
> supposed to be added to VMs (used to be available in context menu as well).
>
> You can check it with
>
> http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-
> patch-el7-x86_64/65/
>
> Martin
>
> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta 
> wrote:
>
>> Hey,
>>
>> We haven't changed the API, so everything should still work. For example,
>> I just installed 4.1 versions of dashboard and support-plugin in master,
>> and all's well [*]:
>>
>> API:
>>
>> api.addSubTab('Template', 'Red Hat Documentation',
>> 'my-host-subtab-template', '', {alignRight: true});
>> api.setTabAccessible('my-host-subtab-template', true);
>>
>> [image: Inline image 1]
>>
>> [*] however, note that "alignRight" is now ignored
>>
>> And dashboard 4.1.8 installed in master engine:
>>
>> [image: Inline image 2]
>>
>>
>> That said, we probably should have sent some announcement about making
>> sure the plugins actually look good with the new theme. If some plugins are
>> greenish, that will look bad.
>>
>> To help with styling external things, we've started exposing more CSS via
>> a new SASS brand module:
>> https://github.com/oVirt/ovirt-engine/tree/master/frontend/
>> brands/ovirt-brand/src/main/sass
>> Also, we're heavily relying on base PatternFly styles, and plugins should
>> do the same. For example, the new dialog styles are completely PatternFly [
>> http://www.patternfly.org/pattern-library/forms-and-control
>> s/modal-overlay/] and we don't do anything extra on top of that.
>>
>> Let us know if something doesn't work, or you need help styling something.
>>
>> Greg
>>
>> On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak  wrote:
>>
>>> Hi,
>>>
>>> I just got a question from an ovirt-optimizer user about the support
>>> in 4.2. And I realized I haven't heard anything about how UI plugins
>>> should be updated to work with the new UI.
>>>
>>> Is there anything special that needs to be done to make the plugin
>>> functional? Or will everything still work somehow?
>>>
>>> Best regards
>>>
>>> Martin Sivak
>>> ___
>>> Devel mailing list
>>> Devel@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>
>>
>>
>>
>


-- 

GREG SHEREMETA

SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX

Red Hat NA



gsher...@redhat.comIRC: gshereme

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Martin Sivak]

Hi,

I think I found one issue.. I do not see the extra menu items that were
supposed to be added to VMs (used to be available in context menu as well).

You can check it with

http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-patch-el7-x86_64/65/

Martin

On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta  wrote:

> Hey,
>
> We haven't changed the API, so everything should still work. For example,
> I just installed 4.1 versions of dashboard and support-plugin in master,
> and all's well [*]:
>
> API:
>
> api.addSubTab('Template', 'Red Hat Documentation',
> 'my-host-subtab-template', '', {alignRight: true});
> api.setTabAccessible('my-host-subtab-template', true);
>
> [image: Inline image 1]
>
> [*] however, note that "alignRight" is now ignored
>
> And dashboard 4.1.8 installed in master engine:
>
> [image: Inline image 2]
>
>
> That said, we probably should have sent some announcement about making
> sure the plugins actually look good with the new theme. If some plugins are
> greenish, that will look bad.
>
> To help with styling external things, we've started exposing more CSS via
> a new SASS brand module:
> https://github.com/oVirt/ovirt-engine/tree/master/
> frontend/brands/ovirt-brand/src/main/sass
> Also, we're heavily relying on base PatternFly styles, and plugins should
> do the same. For example, the new dialog styles are completely PatternFly [
> http://www.patternfly.org/pattern-library/forms-and-
> controls/modal-overlay/] and we don't do anything extra on top of that.
>
> Let us know if something doesn't work, or you need help styling something.
>
> Greg
>
> On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak  wrote:
>
>> Hi,
>>
>> I just got a question from an ovirt-optimizer user about the support
>> in 4.2. And I realized I haven't heard anything about how UI plugins
>> should be updated to work with the new UI.
>>
>> Is there anything special that needs to be done to make the plugin
>> functional? Or will everything still work somehow?
>>
>> Best regards
>>
>> Martin Sivak
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Greg Sheremeta]

Hey,

We haven't changed the API, so everything should still work. For example, I
just installed 4.1 versions of dashboard and support-plugin in master, and
all's well [*]:

API:

api.addSubTab('Template', 'Red Hat Documentation',
'my-host-subtab-template', '', {alignRight: true});
api.setTabAccessible('my-host-subtab-template', true);

[image: Inline image 1]

[*] however, note that "alignRight" is now ignored

And dashboard 4.1.8 installed in master engine:

[image: Inline image 2]


That said, we probably should have sent some announcement about making sure
the plugins actually look good with the new theme. If some plugins are
greenish, that will look bad.

To help with styling external things, we've started exposing more CSS via a
new SASS brand module:
https://github.com/oVirt/ovirt-engine/tree/master/frontend/brands/ovirt-brand/src/main/sass
Also, we're heavily relying on base PatternFly styles, and plugins should
do the same. For example, the new dialog styles are completely PatternFly [
http://www.patternfly.org/pattern-library/forms-and-controls/modal-overlay/]
and we don't do anything extra on top of that.

Let us know if something doesn't work, or you need help styling something.

Greg

On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak  wrote:

> Hi,
>
> I just got a question from an ovirt-optimizer user about the support
> in 4.2. And I realized I haven't heard anything about how UI plugins
> should be updated to work with the new UI.
>
> Is there anything special that needs to be done to make the plugin
> functional? Or will everything still work somehow?
>
> Best regards
>
> Martin Sivak
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] oVirt 4.2 and UI plugin infrastructure

[Martin Sivak]

Hi,

I just got a question from an ovirt-optimizer user about the support
in 4.2. And I realized I haven't heard anything about how UI plugins
should be updated to work with the new UI.

Is there anything special that needs to be done to make the plugin
functional? Or will everything still work somehow?

Best regards

Martin Sivak
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel