On 13-08-18 10:04, Vincent Dupont wrote:
Hi Kees,
Le dimanche 12 août 2018 à 14:44 +0200, Kees Bakker a écrit :
On 10-08-18 09:10, Kaspar Schleiser wrote:
He Kees,
On 08/05/2018 01:20 PM, Kees Bakker wrote:
First of all, who is the maintainer of driver_at? In other words,
who should I be asking questions about this driver?
As I'm the original author, I'd consider myself the author, but
Vincent
has contributed a lot. Asking on this mailing list was probably the
best.
Sorry for the delayed answer.
Sorry for the late answer!
I also contributed to this driver indeed, and wrote this part
originally. The idea was to find a simple way to parse URC and let the
user code decide when to parse them. The design is inspired by the AT
parser from MBED.
My understanding of the documentations from u-blox is that in between
the command echo and OK, there should not be any URC other than for the
given command. So parsing them in background while not doing anything
else should be fine.
The use-case and design have been discussed in [1] with @maxvankessel
who use this code in combination with the ring indicator interrupt.
As Kaspar said before, I'm also sure URC handling could be improved but
this might need a big rework of the UART interface and would involve
threads, which so far are kept out of this driver.
Anyway, do not hesitate to open an issue or a PR if the current code is
not good enough for you.
[1]: https://github.com/RIOT-OS/RIOT/pull/8542
I started an issue [1]. Let me know if this is a good way to approach
this.
[1]: https://github.com/RIOT-OS/RIOT/issues/9785
--
Kees
_______________________________________________
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel
