Re: [riot-devel] Byte array should be uint8_t, not char

Hi Joakim, I've done a PR for SPI. https://github.com/RIOT-OS/RIOT/pull/5901 If you have a chance, can you have a look at it/ What this set of changes shows is that several developers have been inserting casts to be able to get SPI code compile without errors. These casts (from uint8_t to

Re: [riot-devel] Byte array should be uint8_t, not char

Hi Kees, Do you have the time/energy to resume the effort of updating the periph/spi interface in where Hauke left off in https://github.com/RIOT-OS/RIOT/pull/4780? There are a lot of device drivers which need updating, and also some existing comments on the PR. I can assist in reviewing the

Re: [riot-devel] Byte array should be uint8_t, not char

Hi Kees, I assume there are more violations than the ones in the SPI drivers... But of course every step forward is great! Testing can be done by the community. We have plans to create a distributed test system with actual hardware attached, but sadly that has not become reality yet.

Re: [riot-devel] Byte array should be uint8_t, not char

Hi, gebart is Joakim ;) Cheers, Ludwig Am 5. Juli 2016 21:11:44 MESZ, schrieb Kees Bakker : >Thank you for the info. It seems that gebart noticed it too :-) There >is >a fresh reply in #4780. > > >On 04-07-16 19:49, Joakim Nohlgård wrote: >> Hi Kees, >> Like Ludwig wrote, there

Re: [riot-devel] Byte array should be uint8_t, not char

Hi Ludwig, Well, it will be a challenge to smootly correct this. There are 16 CPU's that use spi_transfer_byte(s) and 6 drivers. I won't mind creating a PR, but of course I can only test it by building examples for all boards that support SPI. And look at compile errors. Or are there other

Re: [riot-devel] Byte array should be uint8_t, not char

Hi Kees, Like Ludwig wrote, there are some places which haven't followed the coding conventions because the CC weren't as clear before as they are now with regards to this. Since RIOT is relying on its community for code contributions, these kinds of clean ups may take a long time after the

Re: [riot-devel] Byte array should be uint8_t, not char

Hi Kees, Unless there is a good reason to deviate from this guideline all violations should be corrected. This particular rule was added relatively recently, so it would not surprise me if not all occurrences in RIOT have been adapted yet. Cheers, Ludwig Am 3. Juli 2016 22:50:10 MESZ, schrieb

[riot-devel] Byte array should be uint8_t, not char

Hi, The Coding Convention is clear about it. "Guidelines for pointer types (as long as it is reasonable): * use |char *| for strings and only for strings * use |uint8_t[]| as type for arbitrary byte buffers, but use |void *| to pass them around. |uint8_t[]| because we're dealing with