Hi all,
It seems there's a trend with storing the img files close to the code
instead of using an external repo (wiki, etc). I will refactor [1] and
continue the discussion there.
All comments and feedback are appreciated.
Cheers,
José
[1]: https://github.com/RIOT-OS/RIOT/pull/9818
On
Gunar, Joakim
>>
>> Would it also be possible with git-lfs to give the board developers
>> access rights to upload pictures?
>>
With LFS it will work as with a regular file, and one would need to open
a PR to add/change a picture. I would expect such PRs to be approved
almost immediately.
Hi all,
Ideally, the pictures and figures should be part of the pull request
to add the board configuration, to make reviewing easier for
maintainers. Having the maintainers to upload the pictures manually of
a proposed board is too much extra administration and will steal
maintainer focus from
Hi Juan,
every approach which is not bloating a git repository is surely the best
one. IMHO, it is important that the approach gives the board developer
the possibility to upload/update pictures without involving maintainers.
Would it also be possible with git-lfs to give the board developers
Gunar, Jose
>
> In the end, it should not matter which git repository is bloated.
>
What about NO repository gets bloated?
This was already discussed with some other maintainers offline, but I
want to reinstate it here:
We are not *special* in any way. Compared to other projects, RIOT OS
Hi Jose,
last week, when I wrote the documentation for the ESP8266 boards, I had
to realize, that I had to change some pictures several times during the
documentation process.
I think the wiki approach to ask the maintainers everytime is quite
impractical:
1. Maintainers are additionally
Hi all,
I just discovered users cannot push directly in the RIOT.wiki repository
(only via the web interface, which doesn't allow to push images unless a
new entry is created).
This adds some complexity because maintainers would need to put the
pictures there (and ask users to hardcode
Hi all,
Check this attempt [1] using git-lfs. It also uses "a hidden repo" like
the wiki, but it's transparent to the developer.
Cheers,
José
[1]: https://github.com/RIOT-OS/RIOT/pull/9818
On 08/22/2018 02:14 PM, Alexandre Abadie wrote:
Hi,
- Le 22 Aoû 18, à 12:31, Kaspar
Hi,
- Le 22 Aoû 18, à 12:31, Kaspar Schleiser kas...@schleiser.de a écrit :
> On 8/21/18 11:28 AM, Jose wrote:
>> I personally think 2. (put them in the RIOT wiki) is the fastest way to
>> go and doesn't bloat the RIOT repository. But I would like to hear some
>> comments about this topic.
>
He,
On 8/21/18 11:28 AM, Jose wrote:
> I personally think 2. (put them in the RIOT wiki) is the fastest way to
> go and doesn't bloat the RIOT repository. But I would like to hear some
> comments about this topic.
+1. Don't forget, the Wiki is a git repo, too.
Kaspar
On 8/21/18 4:23 PM, Jose wrote:
The only issue is the fact
git-lfs has to be installed in order to interact with the files
(commands like `make doc`) won't pick the images because they will be
sort of symlinks.
Most users don't run make doc. It's run by the static checks, but only
to
Hi all,
git-lfs looks promising and seems to be used by other projects. It would
really help with a not-bloated RIOT repo. The only issue is the fact
git-lfs has to be installed in order to interact with the files
(commands like `make doc`) won't pick the images because they will be
sort of
Hi all,
Thank you for your responses!
So, it seems we are converging to have them close to the code (RIOT
repo). I will give a look to git-lfs in the meantime.
How problematic/complicated is it to ask the owners of the pictures if we
can use them? (I have no idea, so maybe my question is
Hi!
On 21 August 2018 at 11:31:37, Jose (jose.ala...@haw-hamburg.de) wrote:
> Hi all,
>
>
> After some time since the board entries were moved to the doxygen
> documentation [1], we are facing the problem on where to put board pictures.
>
> I see 2 cases:
>
> 1. We don't have the rights
On 08/21/2018 11:28 AM, Jose wrote:
I personally think 2. (put them in the RIOT wiki) is the fastest way to
go and doesn't bloat the RIOT repository. But I would like to hear some
comments about this topic.
If we put them in the RIOT wiki we can always choose to move them to the
repo
15 matches
Mail list logo
