Re: Fwd: [PATCH] Add const qualifier in

2014-07-10 Thread Chris Johns
On 9/07/2014 2:40 am, Joel Sherrill wrote: On 7/8/2014 9:59 AM, Sebastian Huber wrote: On 2014-07-07 23:27, Joel Sherrill wrote: Hi Chris, I added this patch to rtems-tools. Attached is a patch to RSB to use it for the sparc tools. If this looks OK, should I make a similar update to all appli

Re: [PATCH 3/4] capture: Remove nested rtems_interrupt_lock_acquire calls.

2014-07-10 Thread Chris Johns
On 10/07/2014 11:44 pm, Jennifer Averett wrote: Use of the cenable command was resulting in a lock in rtems_interrupt_lock_acquire due to nesting. I am rejecting this change. RTEMS as an RTOS should provide support to handle this case in a consistent manner in SMP and non-SMP builds of the co

Re: [PATCH 2/4] capture: Fix capture engine to handle new extensions.

2014-07-10 Thread Chris Johns
On 10/07/2014 11:44 pm, Jennifer Averett wrote: --- cpukit/libmisc/capture/capture.c | 96 cpukit/libmisc/capture/capture.h | 17 --- 2 files changed, 78 insertions(+), 35 deletions(-) diff --git a/cpukit/libmisc/capture/capture.c b/cpukit/libmi

Re: Adding capture support to score

2014-07-10 Thread Chris Johns
On 10/07/2014 6:09 pm, Sebastian Huber wrote: Hello Jennifer, I am about to go on vacation so I can only give some short comments. Have fun. This patch looks a bit like approach of the Timeline Tool from Edisoft: http://lists.rtems.org/pipermail/users/2007-October/017112.html I am more in

Performance Impact of Thread Queue Priority Change

2014-07-10 Thread Joel Sherrill
I added variants of tm02 and tm03 for counting/priority, binary/FIFO, and binary/priority. These tests are for an operation count of 100 on sis. I have attached the patch and the files. The "0" times are because I just repurposed an existing test and when it blocks the middle tasks in FIFO order

[PATCH 08/11] capture: Update comment block style in capture engine.

2014-07-10 Thread Jennifer Averett
Doxygen added and comment blocks standardized. --- cpukit/libmisc/capture/capture.c | 229 ++-- cpukit/libmisc/capture/capture.h | 565 --- 2 files changed, 378 insertions(+), 416 deletions(-) diff --git a/cpukit/libmisc/capture/capture.c b/cpukit/l

[PATCH 4/4] capture01: New non-interactive test for capture engine.

2014-07-10 Thread Jennifer Averett
--- testsuites/libtests/Makefile.am | 1 + testsuites/libtests/capture01/Makefile.am | 20 +++ testsuites/libtests/capture01/capture01.doc | 19 +++ testsuites/libtests/capture01/capture01.scn | 35 testsuites/libtests/capture01/init.c| 253 +

[PATCH 08/11] capture: Update comment block style in capture engine.

2014-07-10 Thread Jennifer Averett
Doxygen added and comment blocks standardized. --- cpukit/libmisc/capture/capture.c | 229 ++-- cpukit/libmisc/capture/capture.h | 565 --- 2 files changed, 378 insertions(+), 416 deletions(-) diff --git a/cpukit/libmisc/capture/capture.c b/cpukit/l

[PATCH 1/4] capture: Update comment block style in capture engine.

2014-07-10 Thread Jennifer Averett
Doxygen added and comment blocks standardized. --- cpukit/libmisc/capture/capture.c | 229 ++-- cpukit/libmisc/capture/capture.h | 565 --- 2 files changed, 378 insertions(+), 416 deletions(-) diff --git a/cpukit/libmisc/capture/capture.c b/cpukit/l

[PATCH 3/4] capture: Remove nested rtems_interrupt_lock_acquire calls.

2014-07-10 Thread Jennifer Averett
Use of the cenable command was resulting in a lock in rtems_interrupt_lock_acquire due to nesting. --- cpukit/libmisc/capture/capture.c | 39 ++- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/cpukit/libmisc/capture/capture.c b/cpukit/libmisc/ca

[no subject]

2014-07-10 Thread Jennifer Averett
Of the 4 patches the patches 1/4 and 2/4 were reviewed and comments merged. However they slipped through the cracks on committing them. If there are no new comments I'll commit those. I'm not sure patch 3/4 is the correct answer to the issue, but it gets the interactive capture engine test worki

TEST EMAIL -- IGNORE

2014-07-10 Thread Joel Sherrill
--- IGNORE ME -- 1.7.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

[PATCH 08/11] capture: Update comment block style in capture engine.

2014-07-10 Thread Jennifer Averett
Doxygen added and comment blocks standardized. --- cpukit/libmisc/capture/capture.c | 229 ++-- cpukit/libmisc/capture/capture.h | 565 --- 2 files changed, 378 insertions(+), 416 deletions(-) diff --git a/cpukit/libmisc/capture/capture.c b/cpukit/l

[PATCH 2/4] capture: Fix capture engine to handle new extensions.

2014-07-10 Thread Jennifer Averett
--- cpukit/libmisc/capture/capture.c | 96 cpukit/libmisc/capture/capture.h | 17 --- 2 files changed, 78 insertions(+), 35 deletions(-) diff --git a/cpukit/libmisc/capture/capture.c b/cpukit/libmisc/capture/capture.c index 6f8e0a2..ec5e408 100644 ---

TEST EMAIL -- IGNORE

2014-07-10 Thread Joel Sherrill
--- IGNORE ME -- 1.7.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

[PATCH 08/11] capture: Update comment block style in capture engine.

2014-07-10 Thread Jennifer Averett
Doxygen added and comment blocks standardized. --- cpukit/libmisc/capture/capture.c | 229 ++-- cpukit/libmisc/capture/capture.h | 565 --- 2 files changed, 378 insertions(+), 416 deletions(-) diff --git a/cpukit/libmisc/capture/capture.c b/cpukit/l

TEST EMAIL -- IGNORE

2014-07-10 Thread Jennifer Averett
From: Joel Sherrill --- IGNORE ME -- 1.7.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

TEST EMAIL -- IGNORE

2014-07-10 Thread Jennifer Averett
From: Joel Sherrill --- IGNORE ME -- 1.7.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

TEST EMAIL -- IGNORE

2014-07-10 Thread Joel Sherrill
--- IGNORE ME -- 1.7.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: _Configuration_Scheduler_priority_dflt

2014-07-10 Thread Joel Sherrill
On 7/10/2014 9:53 AM, Sebastian Huber wrote: > On 2014-07-10 16:43, Gabriel Ibarra wrote: >> Hello, I'm working with a board with a few amount of RAM (lpc1768- 32k), I >> recently updated the last version of RTEMS and now I have more overhead, I >> found that the responsible of this new overhead i

Re: _Configuration_Scheduler_priority_dflt

2014-07-10 Thread Gabriel Ibarra
OK Sebastian, Thank you very much! On Thu, Jul 10, 2014 at 11:53 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 2014-07-10 16:43, Gabriel Ibarra wrote: > >> Hello, I'm working with a board with a few amount of RAM (lpc1768- 32k), I >> recently updated the last version of R

Re: _Configuration_Scheduler_priority_dflt

2014-07-10 Thread Sebastian Huber
On 2014-07-10 16:43, Gabriel Ibarra wrote: Hello, I'm working with a board with a few amount of RAM (lpc1768- 32k), I recently updated the last version of RTEMS and now I have more overhead, I found that the responsible of this new overhead is an object in the bss section: "_Configuration_Schedu

_Configuration_Scheduler_priority_dflt

2014-07-10 Thread Gabriel Ibarra
Hello, I'm working with a board with a few amount of RAM (lpc1768- 32k), I recently updated the last version of RTEMS and now I have more overhead, I found that the responsible of this new overhead is an object in the bss section: "_Configuration_Scheduler_priority_dflt"; So, I want to know what i

_Configuration_Scheduler_priority_dflt

2014-07-10 Thread Gabriel Ibarra
Hello, I'm working with a board with a few amount of RAM (lpc1768- 32k), I recently updated the last version of RTEMS and now I have more overhead, I found that the responsible of this new overhead is an object in the bss section: "_Configuration_Scheduler_priority_dflt"; So, I want to know what i

Re: [PATCH 4/6] spintrcritical20: Fix incorrect assumption

2014-07-10 Thread Joel Sherrill
On Jul 10, 2014 2:14 AM, Sebastian Huber wrote: > > On 2014-07-09 16:37, Joel Sherrill wrote: > > I think this patch is wrong. Subsequent changes to the thread queue after I > > posted this resulted in the test breaking again. > > > > What is the test trying to do? I think sometimes through the

Re: Adding capture support to score

2014-07-10 Thread Sebastian Huber
Hello Jennifer, I am about to go on vacation so I can only give some short comments. This patch looks a bit like approach of the Timeline Tool from Edisoft: http://lists.rtems.org/pipermail/users/2007-October/017112.html I am more in favor of linker based versions like: http://www.rtems.org/w

Re: [PATCH 4/5 v2] SPARC: Fatal_halt use source and exit codes

2014-07-10 Thread Sebastian Huber
On 2014-07-04 22:07, Daniel Hellstrom wrote: On 07/04/2014 04:20 PM, Joel Sherrill wrote: On Jul 4, 2014 3:47 AM, Daniel Hellstrom wrote: > > On 07/03/2014 04:55 PM, Joel Sherrill wrote: > > I am wondering if I don't have a vision for what this > > series of patches is trying to accomplish i

Re: Misc on RBTree Thread Queue Priority Discipline Changes

2014-07-10 Thread Sebastian Huber
Hello Joel, I think it is good approach to use a RB tree for the priority queues. Reducing the size of non-thread objects is always beneficial, since you usually have a lot of them. The new network stack uses for example more than 2000 semaphores, but only a hand full of tasks. It might be

Re: [PATCH 4/6] spintrcritical20: Fix incorrect assumption

2014-07-10 Thread Sebastian Huber
On 2014-07-09 16:37, Joel Sherrill wrote: I think this patch is wrong. Subsequent changes to the thread queue after I posted this resulted in the test breaking again. What is the test trying to do? I think sometimes through the loop, the condition the test expects is not occurring and it fails.

Re: [rtems commit] bsps: Basic console driver for Termios devices

2014-07-10 Thread Sebastian Huber
On 2014-07-09 22:34, Joel Sherrill wrote: This is duplicative of the following files in libbsp/shared: console_control.c console_read.c console_write.c This is not a duplicate, it is an easy to use replacement for all this complicated shared console driver stuff. Please just add individua