On 07/21/2014 10:23 PM, Gedare Bloom wrote:
One issue with rbtree formatting is in some places if/while conditional
expressions are put on the same line as the conditional statement. We
should prefer to put them explicitly on separate lines, since that is the
prevailing style of score and I have
On 07/21/2014 10:23 PM, Gedare Bloom wrote:
/* TODO: Error message? */
- if (!the_rbtree) return;
+ if ( !the_rbtree ) return;
Like here.
Ok, this is not an uncrustify bug. It was already a one-liner (like the
other). Unfortunately there is no option to wipe out one-liner.
--
The test sptests/sp35 showed a NULL pointer access due to an invalid
maximum node field (e.g. a tree with one element and NULL as the maximum
node).
---
cpukit/score/include/rtems/score/rbtree.h| 16 ++--
cpukit/score/src/rbtreeinsert.c | 4 +-
Thanks, I have added a section at
http://www.rtems.org/wiki/index.php/Coding_Conventions#Tools and
uploaded/linked to your configuration.
-Gedare
On Tue, Jul 22, 2014 at 6:32 AM, Sebastian Huber
sebastian.hu...@embedded-brains.de wrote:
On 07/22/2014 12:22 PM, Sebastian Huber wrote:
On
Hi,
we are working in a very RAM constrained board, and noticed that
some symbols could be moved to ROM by declaring them const.
I have a slight idea about creating a consts-candidate detector tool
KICS! (Keep It Const, St.! :) ), and wanted to hear some other
people ideas.
Initial thoughts:
On 7/22/2014 1:05 PM, Daniel Gutson wrote:
Hi,
we are working in a very RAM constrained board, and noticed that
some symbols could be moved to ROM by declaring them const.
Have you been through the configure options like switching scheduler,
lowering
stack sizes, etc.?
I have a slight
Please review before I send to gcc.
Thanks.
2014-07-17 Sebastian Huber sebastian.hu...@embedded-brains.de
Chris Johns chr...@rtems.org
Joel Sherrill joel.sherr...@oarcorp.com
* config.gcc: Add nios2-*-rtems*.
* config/nios2/rtems.h: New file.
*
