Re: [PATCH-V2] smptests/smpcache01: Remove invalidation of data cache lines from test

2014-09-16 Thread Sebastian Huber
On 11/09/14 17:55, Daniel Cederman wrote: Invalidation of entire data cache might cause data written to the stack to get lost. --- testsuites/smptests/smpcache01/init.c | 47 +++ testsuites/smptests/smpcache01/smpcache01.doc | 1 -

Cache Manager Functions with Processor Set

2014-09-16 Thread Sebastian Huber
Hello, what is the use case for the following functions: rtems_cache_flush_multiple_data_lines_processor_set() rtems_cache_invalidate_multiple_data_lines_processor_set() rtems_cache_flush_entire_data_processor_set() rtems_cache_invalidate_entire_data_processor_set() ? Makes it sense on an

Re: Cache Manager Functions with Processor Set

2014-09-16 Thread Daniel Hellstrom
On 09/16/2014 01:49 PM, Sebastian Huber wrote: On 16/09/14 13:42, Daniel Hellstrom wrote: Hello, what is the use case for the following functions: rtems_cache_flush_multiple_data_lines_processor_set() rtems_cache_invalidate_multiple_data_lines_processor_set()

Re: Cache Manager Functions with Processor Set

2014-09-16 Thread Sebastian Huber
On 16/09/14 14:10, Daniel Hellstrom wrote: On 09/16/2014 01:49 PM, Sebastian Huber wrote: On 16/09/14 13:42, Daniel Hellstrom wrote: Hello, what is the use case for the following functions: rtems_cache_flush_multiple_data_lines_processor_set()

Re: [PATCH 5/6] or1k: New cache manager.

2014-09-16 Thread Joel Sherrill
I pushed the rest but this (#5) does not apply cleanly. Please rebase your tree, make sure I merged the others ok, and recut the patch.. Thanks. --joel On 9/15/2014 5:33 PM, Hesham ALMatary wrote: Implement new cache functions for or1k and create new bspstart function for or1ksim to

Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Joel Sherrill
I am not sure what it up. Chris committed a patch that changed the sort order to be more uniform. But your preinstall.am's don't match. Maybe you should try regenerating them. Perhaps they are from before his change being committed. $ git am /media/sf_jrs007/patches/\[PATCH\]\ or1k\ \ New\

capture engine _States_Is_dormant check

2014-09-16 Thread Jennifer Averett
I am converting the capture engine to remove capture tasks and use a combination of a special capture record and data moved to the tcb to replace it. I have a question on the rtems_capture_switch_task method where it is using a check for dormant state of the current task. I spoke with Joel on

Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Hesham Moustafa
On Tue, Sep 16, 2014 at 5:59 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: I am not sure what it up. Chris committed a patch that changed the sort order to be more uniform. But your preinstall.am's don't match. I generated an updated one in a separate commit before (after Chris change),

[PATCH] or1k: New cache manager.

2014-09-16 Thread Hesham ALMatary
Implement new cache functions for or1k and create new bspstart function for or1ksim to initialize instruction and data caches. Also, sim.cfg is modified to enable/confiure cache units. --- c/src/lib/libbsp/or1k/or1ksim/Makefile.am| 9 +- c/src/lib/libbsp/or1k/or1ksim/preinstall.am

Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Joel Sherrill
I don't understand this but I got it applied. I manually edited the saved email to delete the preinstall.am changes. I committed the rest. Then I ran bootstrap -p myself and folded that into the rest of your patch. It should all be committed now. How about some new test results. :) --joel On

Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Joel Sherrill
On 9/16/2014 12:54 PM, Hesham Moustafa wrote: Hi On Tue, Sep 16, 2014 at 7:47 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: I don't understand this but I got it applied. I manually edited the saved email to delete the preinstall.am changes. I committed the rest. Then I ran bootstrap

Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Hesham Moustafa
On Tue, Sep 16, 2014 at 8:15 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 9/16/2014 12:54 PM, Hesham Moustafa wrote: Hi On Tue, Sep 16, 2014 at 7:47 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: I don't understand this but I got it applied. I manually edited the saved email

Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Hesham Moustafa
On Tue, Sep 16, 2014 at 8:15 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 9/16/2014 12:54 PM, Hesham Moustafa wrote: Hi On Tue, Sep 16, 2014 at 7:47 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: I don't understand this but I got it applied. I manually edited the saved email

or1k test was .. Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Joel Sherrill
On 9/16/2014 1:34 PM, Hesham Moustafa wrote: On Tue, Sep 16, 2014 at 8:15 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 9/16/2014 12:54 PM, Hesham Moustafa wrote: Hi On Tue, Sep 16, 2014 at 7:47 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: I don't understand this but I got it

Re: or1k test was .. Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Hesham Moustafa
On Tue, Sep 16, 2014 at 8:42 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 9/16/2014 1:34 PM, Hesham Moustafa wrote: On Tue, Sep 16, 2014 at 8:15 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 9/16/2014 12:54 PM, Hesham Moustafa wrote: Hi On Tue, Sep 16, 2014 at 7:47 PM,

Re: or1k test was .. Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Joel Sherrill
On 9/16/2014 2:17 PM, Hesham Moustafa wrote: On Tue, Sep 16, 2014 at 8:42 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 9/16/2014 1:34 PM, Hesham Moustafa wrote: On Tue, Sep 16, 2014 at 8:15 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 9/16/2014 12:54 PM, Hesham Moustafa

Re: or1k test was .. Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Hesham Moustafa
Breakpoint 2, 0x0600 in _unalign () (gdb) bt #0 0x0600 in _unalign () #1 0x0002ec4c in _RBTree_Next ( node=0x40890, dir=RBT_RIGHT) at ../../../../../../rtems/c/src/../../cpukit/score/src/rbtreenext.c:35 #2 0x0002e2f4 in _RBTree_Successor ( node=0x40890) at

Re: or1k test was .. Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Hesham Moustafa
Breakpoint 1, _RBTree_Next (node=0x40890, dir=RBT_RIGHT) at ../../../../../../rtems/c/src/../../cpukit/score/src/rbtreenext.c:35 35 RBTree_Direction opp_dir = _RBTree_Opposite_direction( dir ); (gdb) n 36 RBTree_Node *current = node-child[ dir ]; (gdb) n 37 RBTree_Node *next = NULL;

Re: or1k test was .. Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Joel Sherrill
Gedare.. cc'ed you for help in spotting an empty rbtree in gdb. See below. On 9/16/2014 2:45 PM, Hesham Moustafa wrote: Breakpoint 2, 0x0600 in _unalign () (gdb) bt #0 0x0600 in _unalign () #1 0x0002ec4c in _RBTree_Next ( node=0x40890, dir=RBT_RIGHT) at

Re: or1k test was .. Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Gedare Bloom
On Tue, Sep 16, 2014 at 5:08 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: Gedare.. cc'ed you for help in spotting an empty rbtree in gdb. See below. On 9/16/2014 2:45 PM, Hesham Moustafa wrote: Breakpoint 2, 0x0600 in _unalign () (gdb) bt #0 0x0600 in _unalign () #1

Re: capture engine _States_Is_dormant check

2014-09-16 Thread Chris Johns
On 17/09/2014 3:22 am, Jennifer Averett wrote: I am converting the capture engine to remove capture tasks and use a combination of a special capture record and data moved to the tcb to replace it. I have a question on the rtems_capture_switch_task method where it is using a check for dormant

Re: capture engine _States_Is_dormant check

2014-09-16 Thread Joel Sherrill
On 9/16/2014 4:28 PM, Chris Johns wrote: On 17/09/2014 3:22 am, Jennifer Averett wrote: I am converting the capture engine to remove capture tasks and use a combination of a special capture record and data moved to the tcb to replace it. I have a question on the rtems_capture_switch_task

[PATCH] cpukit: Move zlib into librtemcpu.a and do not install libz.a.

2014-09-16 Thread Chris Johns
The JFFS2 file system can optionally use zlib as a compressor and if this is the only reference to zlib the application will not link. Adding -lz does not work because librtemscpu.a is added to the end of ld's command line via the bsp_specs hack and user added libraries appear before this. ---

Re: [PATCH] redirector: Rename rtems_stdio_redirect_t

2014-09-16 Thread Chris Johns
On 17/09/2014 3:24 pm, Sebastian Huber wrote: Rename rtems_stdio_redirect_t to rtems_stdio_redirect since the namespace *_t is reserved by POSIX, see also The Open Group Base Specifications Issue 6 IEEE Std 1003.1, 2004 Edition, 2.2.2 The Name Space. Thanks. Please commit. Chris

Re: [PATCH] cpukit: Move zlib into librtemcpu.a and do not install libz.a.

2014-09-16 Thread Sebastian Huber
On 17/09/14 02:26, Chris Johns wrote: The JFFS2 file system can optionally use zlib as a compressor and if this is the only reference to zlib the application will not link. Adding -lz does not work because librtemscpu.a is added to the end of ld's command line via the bsp_specs hack and user

Re: Cache Manager Functions with Processor Set

2014-09-16 Thread Sebastian Huber
On 16/09/14 16:00, Daniel Hellstrom wrote: On 09/16/2014 02:23 PM, Sebastian Huber wrote: On 16/09/14 14:10, Daniel Hellstrom wrote: On 09/16/2014 01:49 PM, Sebastian Huber wrote: On 16/09/14 13:42, Daniel Hellstrom wrote: Hello, what is the use case for the following functions: