Re: [PATCH v3 2/2] Subject: Update PWM driver imported from BBBIO

2016-07-01 Thread Martin Galvan
Also, I think git send-email has an option to send all the patches in the same series as replies to a single thread. See if you can use it in the future. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v3 2/2] Subject: Update PWM driver imported from BBBIO

2016-07-01 Thread Martin Galvan
On Fri, Jul 1, 2016 at 6:12 PM, Martin Galvan wrote: > const uint32_t is_idle = AM335X_CM_PER_EPWMSS0_CLKCTRL_IDLEST_FUNC << > AM335X_CM_PER_EPWMSS0_CLKCTRL_IDLEST_SHIFT; My bad: this actually signals that the module is *not* idle. Maybe it could be called is_functional i

Re: [PATCH v3 2/2] Subject: Update PWM driver imported from BBBIO

2016-07-01 Thread Martin Galvan
Hi Punit, thanks for the patch. As we spoke in the group chat with the other mentors, this seems to be good for a first version. I'll be pointing out the required changes for the next version, but unless somebody sees anything blocking this should be good to merge. Besides improving the code its

[PATCH v3 2/2] Subject: Update PWM driver imported from BBBIO

2016-07-01 Thread Punit Vara
This patch performs following things: - adds registers to appropriate header file - Changes APIs to build RTEMS successful I have tested PWM driver with RGB LED and multimeter https://youtu.be/jhjZO9amdSA This code generate m

[PATCH v3 1/2] Subject: Add original BBBIO PWM driver to BBB BSP

2016-07-01 Thread Punit Vara
This patch perform following things: - adds original BBBIO PWM code as it is. - not added to Makefile otherwise it will break build This code is added from https://github.com/VegetableAvenger/BBBIOlib/blob/master/BBBio_lib/BBBiolib_PWMSS.c --- c/src/lib/li