Ok, that's very kind of you.
Sichen Zhao
From: Joel Sherrill
Sent: Sunday, May 14, 2017 9:17 PM
To: 赵 思晨
Cc: rtems-de...@rtems.org; punit vara; Christian Mauderer
Subject: Re: [PATCH 2/2] Beagle i2c: Update Beaglebone i2c driver code
If something isn't clear
If something isn't clear from the coding conventions wiki page, please feel
free to ask.
--joel
On May 14, 2017 8:12 AM, "Sichen Zhao" wrote:
> Hi Christian,
>
> I will read the coding conventions and modify the patch as soon as
> possible.
>
>
> Thank you
>
> Sichen Zhao
>
>
>
Hi Christian,
I will read the coding conventions and modify the patch as soon as possible.
Thank you
Sichen Zhao
From: devel on behalf of Christian Mauderer
Sent: Sunday, May 14, 2017 8:42 PM
To: Sichen Zhao
Cc: punit vara; devel@rtems.org
Subject: Re: [PAT
Hello Sichen Zhao,
I haven't tested the code yet. But on a first look, I noted some points
regarding the style:
- If I apply the patches, there are a lot of "trailing whitespace" warnings
- There are some // comments in the code
- Quite a number of lines is longer than 80 characters
- There are
