GSoC Project | Basic Support for Trace Compass

2019-07-17 Thread Ravindra Kumar Meena
Hi, I am facing difficulty in adding event.header in client-side. struct event_header_compact { enum : uint5_t { compact = 0 ... 30, extended = 31 } id; variant { struct { uint27_clock_monotonic_t timestamp; } compact; struct { uint32_t id; uint64_clock_monotonic_t timestamp; } extended; } v; }

Re: build of libbsd for powerpc fails with error: redefinition of 'eieio'

2019-07-17 Thread Sebastian Huber
On 17/07/2019 23:42, dufa...@hda.com wrote: On Jul 17, 2019, at 01:48 , Sebastian Huber wrote: Hello Peter, On 16/07/2019 19:58, Peter Dufault wrote: I have a build failure with the MVME5500 “beatnik” BSP. Therefore I tried to build the “psim” BSP and have the same failure: the FreeBSD

Re: [PATCH v4] Add mmap

2019-07-17 Thread Sebastian Huber
On 17/07/2019 22:28, Vijay Kumar Banerjee wrote: +static int +testmmap(struct cdev *dev, vm_ooffset_t offset, vm_paddr_t *paddr, + int nprot, vm_memattr_t *memattr) +{ + test_state *state = dev->si_drv1; + + assert(memattr == VM_MEMATTR_DEFAULT); + assert(paddr !=

Re: Sources for fenv (ARM, PPC, x86, SPARC and RISC5)

2019-07-17 Thread Vaibhav Gupta
On Wed, Jul 17, 2019 at 11:42 PM Gedare Bloom wrote: > On Tue, Jul 16, 2019 at 6:57 AM Joel Sherrill wrote: > > > > Let's give preference to FreeBSD sources. Notes below. > > > > On Wed, Jul 3, 2019 at 1:08 PM Vaibhav Gupta > wrote: > >> > >> Hello, > >> I have found sources for fenv. > >> >

Re: Sources for fenv (ARM, PPC, x86, SPARC and RISC5)

2019-07-17 Thread Vaibhav Gupta
On Tue, Jul 16, 2019 at 6:26 PM Joel Sherrill wrote: > Let's give preference to FreeBSD sources. Notes below. > > On Wed, Jul 3, 2019 at 1:08 PM Vaibhav Gupta > wrote: > >> Hello, >> I have found sources for fenv. >> >> 1.1) - ARM FreeBSD Source: >> -

Re: Sources for fenv (ARM, PPC, x86, SPARC and RISC5)

2019-07-17 Thread Joel Sherrill
On Wed, Jul 17, 2019, 1:12 PM Gedare Bloom wrote: > On Tue, Jul 16, 2019 at 6:57 AM Joel Sherrill wrote: > > > > Let's give preference to FreeBSD sources. Notes below. > > > > On Wed, Jul 3, 2019 at 1:08 PM Vaibhav Gupta > wrote: > >> > >> Hello, > >> I have found sources for fenv. > >> > >>

Re: build of libbsd for powerpc fails with error: redefinition of 'eieio'

2019-07-17 Thread dufault
> On Jul 17, 2019, at 01:48 , Sebastian Huber > wrote: > > Hello Peter, > > On 16/07/2019 19:58, Peter Dufault wrote: >> I have a build failure with the MVME5500 “beatnik” BSP. Therefore I tried to >> build the “psim” BSP and have the same failure: the FreeBSD PowerPC >> “cpufunc.h” and the

[PATCH v4] Add mmap

2019-07-17 Thread Vijay Kumar Banerjee
--- freebsd/sys/kern/kern_conf.c | 8 +++ freebsd/sys/sys/conf.h | 2 +- rtemsbsd/include/machine/vm.h | 2 ++ rtemsbsd/sys/fs/devfs/devfs_devs.c | 38 ++ testsuite/cdev01/test_cdev.c | 21 -

Re: [PATCH v3] Add mmap

2019-07-17 Thread Christian Mauderer
On 17/07/2019 11:10, Nils Hölscher wrote: >  Hi, > > +#define VM_MEMATTR_DEFAULT 0 > +#define VM_MEMATTR_UNCACHEABLE 1 > > > Are you sure that these values are correct in general? > BSD defines this only for ARM versions smaller 6. >

Re: [PATCH v3] ndbm test suite

2019-07-17 Thread Vaibhav Gupta
On Wed, Jul 17, 2019, 11:46 PM Gedare Bloom wrote: > On Wed, Jul 17, 2019 at 11:09 AM Vaibhav Gupta > wrote: > > > > Thanks for the review! > > I will re generate the patch with corrections > > > > On Wed, Jul 17, 2019 at 10:12 PM Gedare Bloom wrote: > >> > >> On Wed, Jul 10, 2019 at 1:49 AM

Re: [PATCH v3] ndbm test suite

2019-07-17 Thread Gedare Bloom
On Wed, Jul 17, 2019 at 11:09 AM Vaibhav Gupta wrote: > > Thanks for the review! > I will re generate the patch with corrections > > On Wed, Jul 17, 2019 at 10:12 PM Gedare Bloom wrote: >> >> On Wed, Jul 10, 2019 at 1:49 AM Vaibhav Gupta >> wrote: >> > >> > --- >> >

Re: Sources for fenv (ARM, PPC, x86, SPARC and RISC5)

2019-07-17 Thread Gedare Bloom
On Tue, Jul 16, 2019 at 6:57 AM Joel Sherrill wrote: > > Let's give preference to FreeBSD sources. Notes below. > > On Wed, Jul 3, 2019 at 1:08 PM Vaibhav Gupta wrote: >> >> Hello, >> I have found sources for fenv. >> >> 1.1) - ARM FreeBSD Source: >> -

Re: [PATCH v3] ndbm test suite

2019-07-17 Thread Vaibhav Gupta
Thanks for the review! I will re generate the patch with corrections On Wed, Jul 17, 2019 at 10:12 PM Gedare Bloom wrote: > On Wed, Jul 10, 2019 at 1:49 AM Vaibhav Gupta > wrote: > > > > --- > > testsuites/psxtests/Makefile.am | 7 + > > testsuites/psxtests/configure.ac | 1 + > >

Re: [PATCH v3] ndbm test suite

2019-07-17 Thread Gedare Bloom
On Wed, Jul 10, 2019 at 1:49 AM Vaibhav Gupta wrote: > > --- > testsuites/psxtests/Makefile.am | 7 + > testsuites/psxtests/configure.ac | 1 + > testsuites/psxtests/psxndbm01/init.c | 260 +++ > 3 files changed, 268 insertions(+) > create mode 100644

Re: GSoC Linux UIO driver for PRU

2019-07-17 Thread Nils Hölscher
Hi, I applied the patch and now all compiles. But I haven't tested anything yet, I am currently working on an application for testing. I will keep in contact concerning the mmap patch. Best, Nils On Tue, 16 Jul 2019 at 15:47, Christian Mauderer < christian.maude...@embedded-brains.de> wrote: >

Re: [PATCH v3] Add mmap

2019-07-17 Thread Nils Hölscher
On Wed, 17 Jul 2019 at 09:03, Vijay Kumar Banerjee wrote: > --- > freebsd/sys/kern/kern_conf.c | 8 +++ > freebsd/sys/sys/conf.h | 2 +- > rtemsbsd/include/machine/vm.h | 2 ++ > rtemsbsd/sys/fs/devfs/devfs_devs.c | 34 ++ >

Re: [PATCH v3] Add mmap

2019-07-17 Thread Sebastian Huber
On 17/07/2019 09:02, Vijay Kumar Banerjee wrote: +static int +testmmap(struct cdev *dev, vm_ooffset_t offset, vm_paddr_t *paddr, + int nprot, vm_memattr_t *memattr) +{ + test_state *state = dev->si_drv1; + Please add assertions for all parameters. + assert(*state ==

Re: [PATCH v3] Add mmap

2019-07-17 Thread Sebastian Huber
On 17/07/2019 09:02, Vijay Kumar Banerjee wrote: + if (td != 0) { + if (cdev == NULL) { + error = ENXIO; + } Suppose cdev == NULL, then you have a NULL pointer access here: + if (cdev->si_flags & SI_ALIAS) { +

Re: [PATCH v2] Add mmap

2019-07-17 Thread Vijay Kumar Banerjee
On Wed, Jul 17, 2019 at 10:26 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 16/07/2019 21:47, Vijay Kumar Banerjee wrote: > > + rv = mmap(NULL, 1, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); > > + assert(rv != MAP_FAILED); > > + > > Please change this to: > >

[PATCH v3] Add mmap

2019-07-17 Thread Vijay Kumar Banerjee
--- freebsd/sys/kern/kern_conf.c | 8 +++ freebsd/sys/sys/conf.h | 2 +- rtemsbsd/include/machine/vm.h | 2 ++ rtemsbsd/sys/fs/devfs/devfs_devs.c | 34 ++ testsuite/cdev01/test_cdev.c | 17 ++-