Re: [PATCH v3] Raspberrypi: updated the console interface.

2019-12-29 Thread Niteesh
On Mon, 30 Dec, 2019, 2:07 AM Christian Mauderer, wrote: > I assume you want suggestions regarding this code rather than the > original patch? > > One suggestion: If you post code please try to use a mail program that > keeps the indentation. It's hard to read in this form. But that's most >

Re: What do you want to study in GSOC 2020?

2019-12-29 Thread Niteesh
On Mon, Dec 30, 2019 at 4:44 AM Peter Dufault wrote: > > Niteesh, what do you want to study? Go over what most interests you most > about working in a real-time environment like RTEMS, and not about working > on the RPI, and look at the earlier GSOC projects. Propose an ideal project > for

What do you want to study in GSOC 2020?

2019-12-29 Thread Peter Dufault
Niteesh, what do you want to study? Go over what most interests you most about working in a real-time environment like RTEMS, and not about working on the RPI, and look at the earlier GSOC projects. Propose an ideal project for yourself and get some feedback. > On Dec 28, 2019, at 05:12 ,

Re: [PATCH v3] Raspberrypi: updated the console interface.

2019-12-29 Thread Christian Mauderer
I assume you want suggestions regarding this code rather than the original patch? One suggestion: If you post code please try to use a mail program that keeps the indentation. It's hard to read in this form. But that's most likely not the suggestion you searched for ;-) On 29/12/2019 19:48,

Re: [PATCH v3] Raspberrypi: updated the console interface.

2019-12-29 Thread Christian Mauderer
On 29/12/2019 18:44, Niteesh wrote: > Where does RTEMS except the DTB file to be present? See my mail in the other thread regarding that. You might have to add a define in the configure.ac. > > On Sun, Dec 29, 2019 at 8:27 PM Niteesh > wrote: > > I am sorry, I

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-29 Thread Christian Mauderer
On 29/12/2019 15:23, Niteesh wrote: > Where does qemu place the dtb file? we can pass the dtb file to the kernel > using -dtb, but not sure where it puts it? googled a lot but couldn't > find it. I'm not really sure where qemu places a dtb. Maybe it helps if I describe roughly how it would work

Re: [PATCH v3] Raspberrypi: updated the console interface.

2019-12-29 Thread Niteesh
I am not happy with my code at all, I can please provide some suggestions. On Mon, Dec 30, 2019 at 12:17 AM Niteesh wrote: > arm_pl011_context pl011_context; > rpi_fb_context fb_context; > char uart_instance[20]; > > > static void output_char_serial(char c) > { >

Re: [PATCH v3] Raspberrypi: updated the console interface.

2019-12-29 Thread Niteesh
arm_pl011_context pl011_context; rpi_fb_context fb_context; char uart_instance[20]; static void output_char_serial(char c) { arm_pl011_write_polled(_context.base, c); } void output_char_fb(char c) { fbcons_write_polled(_context.base, c); } static void *get_reg_of_node(const void *fdt, int

Re: [PATCH v3] Raspberrypi: updated the console interface.

2019-12-29 Thread Niteesh
Where does RTEMS except the DTB file to be present? On Sun, Dec 29, 2019 at 8:27 PM Niteesh wrote: > I am sorry, I sent the previous without testing and building, so it might > contain some errors. > Just tell me if you are happy with the code, I will fix all the error's > and send in a new

Re: [PATCH v3] Raspberrypi: updated the console interface.

2019-12-29 Thread Niteesh
I am sorry, I sent the previous without testing and building, so it might contain some errors. Just tell me if you are happy with the code, I will fix all the error's and send in a new patch. On Sun, Dec 29, 2019 at 8:04 PM G S Niteesh wrote: > The patch updates the older console interface used

[PATCH v3] Raspberrypi: updated the console interface.

2019-12-29 Thread G S Niteesh
The patch updates the older console interface used by the BSP, to newer one. It also replaces the custom usart(PL011) driver with arm-pl011. The fb function's signatures where also changed to accommodate with interface update. Update #3034 --- bsps/arm/raspberrypi/console/console-config.c | 182

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-29 Thread Niteesh
Where does qemu place the dtb file? we can pass the dtb file to the kernel using -dtb, but not sure where it puts it? googled a lot but couldn't find it. I also tried running u-boot, it successfully ran on raspi3 in 64bit mode. I couldn't get it running on raspi2. The qemu raspi3 doesn't support

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-29 Thread Christian Mauderer
On 29/12/2019 11:04, Niteesh wrote: > On Sun, Dec 29, 2019 at 2:33 PM Christian Mauderer > wrote: > > On 29/12/2019 07:09, Niteesh wrote: > > Is there any way to test and debug this? Maybe using GDB to > > see if a proper node is getting selected or not?

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-29 Thread Christian Mauderer
On 29/12/2019 07:09, Niteesh wrote: > Is there any way to test and debug this? Maybe using GDB to > see if a proper node is getting selected or not? Without a debugger debugging code that is started before the console is initialized is always a bit hard. - You can try to use your qemu setup.