Re: Project proposal for GSOC 2020

2020-03-15 Thread Eshan Dhawan
Hello everyone, I have applied all the changes as suggested by dr gedare, I also wanted if you all could look into the proposal, and help me prioritize the headers and the tasks to be done, as well as also look into the deliverables of the project so it could be fruitful for rtems also link to

Re: RTEMS Python Standardization (ticket #3892)

2020-03-15 Thread Anmol Mishra
Hello, I put your email in cc, Did you get a chance to take a quick read of my shared proposal? In case you missed it, https://docs.google.com/document/d/1_G0-q7J2b-5kJzZGI32a-KpC6gMzJ1FcNFFTdMCw1c4/edit?usp=sharing (This is the link for the first draft). I just need a direction about the point of

[PATCH v2] Start conversion tests to using pytest.

2020-03-15 Thread Amar Takhar
error.py: - Check for exceptions and error messages. path.py: - Test params and setting module variables. macros.py: - Test class with setup and shared module access. host.py: - Check host specific settings using simple regex for formatting. - String check on exception. ---

Re: [PATCH 1/2] Convert host checking to pytest.

2020-03-15 Thread Amar Takhar
On 2020-03-15 21:18 -0600, Gedare Bloom wrote: > > I found what I was thinking about: > http://google.github.io/styleguide/pyguide.html#313-imports-formatting > > PEP has similar guidance: > https://www.python.org/dev/peps/pep-0008/#imports PEP8 is so old that even the Python project breaks

Re: [PATCH] Start conversion tests to using pytest.

2020-03-15 Thread Amar Takhar
On 2020-03-15 21:28 -0600, Gedare Bloom wrote: > > +# Always find the parent directory of rtemstoolkit/ no matter where > > +# pytest is run. > > +def pytest_runtest_setup(item): > > +path_toolkit = os.path.dirname(os.path.abspath(__file__)) > > +

Re: [PATCH] Start conversion tests to using pytest.

2020-03-15 Thread Amar Takhar
On 2020-03-15 21:28 -0600, Gedare Bloom wrote: > For new files, we should try to use the boilerplate recently suggested: > https://docs.rtems.org/branches/master/eng/coding-file-hdr.html#python-file-template I'll fix this before pushing thanks. > If that should be tweaked, now is the time to

Re: [PATCH] Start conversion tests to using pytest.

2020-03-15 Thread Gedare Bloom
On Sun, Mar 15, 2020 at 8:13 PM Amar Takhar wrote: > > error.py: > - Check for exceptions and error messages. > > path.py: > - Test params and setting module variables. > > macros.py: > - Test class with setup and shared module access. > > host.py: > - Check host specific

Improve the Raspberry Pi BSP

2020-03-15 Thread Denil Verghese
Hi, I would like to know whether the projects shown in this https://devel.rtems.org/ticket/2899 ticket is completed or not. If the ideas are yet to implement I could work on it. It will more interesting to work those projects rather than my currently selected project which is Release Note

Re: [PATCH 1/2] Convert host checking to pytest.

2020-03-15 Thread Gedare Bloom
On Sun, Mar 15, 2020 at 9:09 PM Gedare Bloom wrote: > > On Sun, Mar 15, 2020 at 5:54 PM Amar Takhar wrote: > > > > On 2020-03-15 17:26 -0600, Gedare Bloom wrote: > > > > > Make blank lines consistent, 1 or 2, between top-level definitions. (I > > > know, we still haven't settled on a style, but

Re: [PATCH 1/2] Convert host checking to pytest.

2020-03-15 Thread Gedare Bloom
On Sun, Mar 15, 2020 at 5:54 PM Amar Takhar wrote: > > On 2020-03-15 17:26 -0600, Gedare Bloom wrote: > > > Make blank lines consistent, 1 or 2, between top-level definitions. (I > > know, we still haven't settled on a style, but let's aim for > > consistency.) > > Okay. > > > > I think all

[PATCH] Start conversion tests to using pytest.

2020-03-15 Thread Amar Takhar
error.py: - Check for exceptions and error messages. path.py: - Test params and setting module variables. macros.py: - Test class with setup and shared module access. host.py: - Check host specific settings using simple regex for formatting. - String check on exception.

Re: [PATCH 1/2] Convert host checking to pytest.

2020-03-15 Thread Amar Takhar
On 2020-03-16 11:48 +1100, Chris Johns wrote: > > That is understandable. Are the patches available in your personal repo? They are not. > I am fine with pieces being pushed after RTEMS 5 has branched. My concern is > only related to the pending release. It is only a couple of weeks away if >

Re: [PATCH 1/2] Convert host checking to pytest.

2020-03-15 Thread Chris Johns
On 16/3/20 11:02 am, Amar Takhar wrote: > On 2020-03-16 09:30 +1100, Chris Johns wrote: >> Hi, >> >> This looks good. Thank you for making the switch to pytest. >> >> Are you planning on moving all the exist "chris hacked" tests to pytest? > > I don't know probably not I don't have the time this

Re: [PATCH 1/2] Convert host checking to pytest.

2020-03-15 Thread Amar Takhar
On 2020-03-16 09:30 +1100, Chris Johns wrote: > Hi, > > This looks good. Thank you for making the switch to pytest. > > Are you planning on moving all the exist "chris hacked" tests to pytest? I don't know probably not I don't have the time this was to get someone started. > If so I am

Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-15 Thread Amar Takhar
On 2020-03-14 11:12 +1100, Chris Johns wrote: > > I would like to hear what Sebastian is considering for the ESA work. I think > we > should follow what will be done there and ends up in the engineering manual. If this is in regard to pytests that are being done for ESA work I agree I would

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-15 Thread Amar Takhar
On 2020-03-16 09:20 +1100, Chris Johns wrote: > > Is pytest installed by default? No. It's a separate package the Python has 'unittest' which is shipped by default. For our usage pyttest is more flexible and will create concise code that is easy to contribute to. The biggest reason is that

Re: [PATCH 1/2] Convert host checking to pytest.

2020-03-15 Thread Amar Takhar
On 2020-03-15 17:26 -0600, Gedare Bloom wrote: > Make blank lines consistent, 1 or 2, between top-level definitions. (I > know, we still haven't settled on a style, but let's aim for > consistency.) Okay. > I think all imports should go at the top? This is scoped it only runs under certain

Re: [PATCH 1/2] Convert host checking to pytest.

2020-03-15 Thread Chris Johns
On 16/3/20 10:26 am, Gedare Bloom wrote: > On Fri, Mar 13, 2020 at 5:28 PM Amar Takhar wrote: >> +def test_label_error(): >> + from rtemstoolkit.error import general > I think all imports should go at the top? This is done in a number of places. It means the import only happens when the

Re: [PATCH 1/2] Convert host checking to pytest.

2020-03-15 Thread Gedare Bloom
On Fri, Mar 13, 2020 at 5:28 PM Amar Takhar wrote: > > --- > rtemstoolkit/darwin.py | 5 - > rtemstoolkit/freebsd.py | 5 - > rtemstoolkit/host.py| 14 -- > rtemstoolkit/linux.py | 5 - > rtemstoolkit/netbsd.py | 5 -

Re: [PATCH 1/2] Convert host checking to pytest.

2020-03-15 Thread Chris Johns
Hi, This looks good. Thank you for making the switch to pytest. Are you planning on moving all the exist "chris hacked" tests to pytest? If so I am wondering how you will stage the change? This size patch is perfect but I am concerned we may have some done and others not when the release branch

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-15 Thread Chris Johns
On 14/3/20 8:35 am, Amar Takhar wrote: > Also check for 'pytest' during configure if not installed print a warning > about installing it to run new test suite. Is pytest installed by default? > --- > wscript | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/wscript b/wscript >

Re: [PATCH] rtems: Add support for building with Clang/LLVM

2020-03-15 Thread Chris Johns
Hi Hesham, This is a great addition to rtems_waf, some comments below. On 16/3/20 2:56 am, Hesham Almatary wrote: > --- > rtems.py | 85 +--- > 1 file changed, 62 insertions(+), 23 deletions(-) > > diff --git a/rtems.py b/rtems.py > index

Re: [PATCH] bsp/beagle: Update console to new Termios device API.

2020-03-15 Thread Niteesh G. S.
Please discard this patch. This patch has been sent without testing. Thank you. Niteesh ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

[PATCH v2] bsp/beagle: Update console to new Termios device API.

2020-03-15 Thread G S Niteesh Babu
This patch updates the console to use new Termios device API. Update #3034 --- bsps/arm/beagle/console/console-config.c | 66 +++- 1 file changed, 41 insertions(+), 25 deletions(-) diff --git a/bsps/arm/beagle/console/console-config.c

[PATCH] bsp/beagle: Update console to new Termios device API.

2020-03-15 Thread G S Niteesh Babu
This patch updates the console to use new Termios device API. Update #3034 --- bsps/arm/beagle/console/console-config.c | 66 +++- 1 file changed, 41 insertions(+), 25 deletions(-) diff --git a/bsps/arm/beagle/console/console-config.c

Covid Code-In Announcement

2020-03-15 Thread Joel Sherrill
Hi I hope we all weather this pandemic with no one getting ill. That is obviously the first concern and priority. It is important that we all follow the guidance of our health officials and governments. This will certainly require physical social distancing, proper sanitation, and possibly self

What sanitizers preferred?

2020-03-15 Thread suyash singh
Hello, Out of AddressSanitizer , ThreadSanitizer , MemorySanitizer , and DataFlowSanitizer . Are

Re: BSP Wiki Clean Up

2020-03-15 Thread Joel Sherrill
On Sun, Mar 15, 2020 at 11:12 AM Joel Sherrill wrote: > > > On Sat, Mar 14, 2020 at 10:55 PM Gedare Bloom wrote: > >> On Sat, Mar 14, 2020 at 2:05 PM Joel Sherrill wrote: >> > >> > I put devel@ back on >> > >> > On Sat, Mar 14, 2020, 2:23 PM Mritunjay Sharma < >> mritunjaysharma...@gmail.com>

Re: BSP Wiki Clean Up

2020-03-15 Thread Joel Sherrill
On Sat, Mar 14, 2020 at 10:55 PM Gedare Bloom wrote: > On Sat, Mar 14, 2020 at 2:05 PM Joel Sherrill wrote: > > > > I put devel@ back on > > > > On Sat, Mar 14, 2020, 2:23 PM Mritunjay Sharma < > mritunjaysharma...@gmail.com> wrote: > >> > >> Hi, > >> > >> I am very much willing to help with

[PATCH] rtems: Add support for building with Clang/LLVM

2020-03-15 Thread Hesham Almatary
--- rtems.py | 85 +--- 1 file changed, 62 insertions(+), 23 deletions(-) diff --git a/rtems.py b/rtems.py index ffb386f..f1ef4de 100644 --- a/rtems.py +++ b/rtems.py @@ -1,4 +1,5 @@ +# Copyright 2020 Hesham Almatary # Copyright 2012-2016

Re: GSoC 2020 Proposal | Beagle BSP: Add a flattened device tree based initialization

2020-03-15 Thread G. S. Niteesh
Hii, I have modified the proposal as per your suggestions. Please have a look again. Thank you, Niteesh. On Mon, Feb 17, 2020 at 11:46 PM Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > > > On Mon, Feb 17, 2020 at 1:32 PM G. S. Niteesh wrote: > >> Hi everyone, >> I have completed my