Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-16 Thread Sebastian Huber
On 16/03/2020 20:26, Amar Takhar wrote: I should have also added some of my own reasons why pytest is better for writing tests in Python: - Fantastic exception handling makes it far easier to debug test and code. PDB works seamlessly. - Far less overhead in creating initial tests.

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-16 Thread Sebastian Huber
On 16/03/2020 21:49, Amar Takhar wrote: On 2020-03-16 21:21 +0100, Sebastian Huber wrote: https://lists.rtems.org/pipermail/devel/2020-March/058289.html I converted an example test from unittest to pytest: There's no reason to use classes here you should use simple functions. Classes are

Re: [PATCH] rtems: Add support for building with Clang/LLVM

2020-03-16 Thread Sebastian Huber
On 17/03/2020 03:09, Chris Johns wrote: That follows the rtems/waf (new build system) convention by default. Do you mean the work Sebastian is doing? If you are, it currently might but that work is not finished and it may change, partially to make it consistent with this package. This has not

Is there a way to modify PHY register in libBSD?

2020-03-16 Thread jameszxj
Hi, I usedukphy driver in project, now I want to tune some PHY registers. Is there a way to modify PHY registers like *phy_fixup in Linux? Or other ways? I think that modify the driver source directly is not a good way.___ devel mailing list

Re: [PATCH] rtems: Add support for building with Clang/LLVM

2020-03-16 Thread Chris Johns
On 17/3/20 7:30 am, Hesham Almatary wrote: > Hi Chris, > > On Sun, 15 Mar 2020 at 21:09, Chris Johns > wrote: > > Hi Hesham, > > This is a great addition to rtems_waf, some comments below. > > On 16/3/20 2:56 am, Hesham Almatary wrote: > > --- > > 

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-16 Thread Amar Takhar
On 2020-03-17 10:55 +1100, Chris Johns wrote: > On 17/3/20 7:21 am, Sebastian Huber wrote: > > Chris, what do you think about using pytest in favour of the standard Python > > unitttest? > > I am fine with pytest. Testing is a development feature and so we can have a > different criteria for the

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-16 Thread Chris Johns
On 17/3/20 7:21 am, Sebastian Huber wrote: > Chris, what do you think about using pytest in favour of the standard Python > unitttest? I am fine with pytest. Testing is a development feature and so we can have a different criteria for the needed dependencies. Chris

Re: BSP Wiki Clean Up

2020-03-16 Thread Joel Sherrill
On Mon, Mar 16, 2020 at 1:35 PM Mritunjay Sharma < mritunjaysharma...@gmail.com> wrote: > The updated list of to be removed BSPs. Please check: > One of us should have mentioned that there is a script at the top of the RTEMS source tree named "rtems-bsps which prints a report with all BSPs.

Re: RTEMS Docs: Adding GSoC Getting Started Instructions

2020-03-16 Thread Gedare Bloom
On Mon, Mar 16, 2020 at 12:56 PM Niteesh G. S. wrote: > > I am interested in taking up #3907. I'll mostly be copying and updating the > contents from the old wiki site. > > I have the following plan in mind. I'll start working on it if you are happy > with it. > > Add a new gsoc section in the

Re: [PATCH rtems_littlevgl 1/2] waf: Remove unnecessary code.

2020-03-16 Thread Vijay Kumar Banerjee
Hi! On Wed, Mar 11, 2020 at 7:59 PM Christian Mauderer < christian.maude...@embedded-brains.de> wrote: > --- > lvgl.py | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/lvgl.py b/lvgl.py > index 5452ed0..d6584f7 100644 > --- a/lvgl.py > +++ b/lvgl.py > @@ -77,12 +77,6 @@ def

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-16 Thread Amar Takhar
On 2020-03-16 21:21 +0100, Sebastian Huber wrote: > > > > https://lists.rtems.org/pipermail/devel/2020-March/058289.html > > I converted an example test from unittest to pytest: There's no reason to use classes here you should use simple functions. Classes are only useful if you want to

Re: [PATCH] rtems: Add support for building with Clang/LLVM

2020-03-16 Thread Hesham Almatary
Hi Chris, On Sun, 15 Mar 2020 at 21:09, Chris Johns wrote: > Hi Hesham, > > This is a great addition to rtems_waf, some comments below. > > On 16/3/20 2:56 am, Hesham Almatary wrote: > > --- > > rtems.py | 85 +--- > > 1 file changed, 62

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-16 Thread Sebastian Huber
On 16/03/2020 21:01, Sebastian Huber wrote: On 16/03/2020 20:26, Amar Takhar wrote: I should have also added some of my own reasons why pytest is better for writing tests in Python:    - Fantastic exception handling makes it far easier to debug test and code. PDB works seamlessly.   

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-16 Thread Sebastian Huber
On 16/03/2020 20:26, Amar Takhar wrote: I should have also added some of my own reasons why pytest is better for writing tests in Python: - Fantastic exception handling makes it far easier to debug test and code. PDB works seamlessly. - Far less overhead in creating initial tests.

Re: [PATCH 1/1] eng: Add Python development guidelines

2020-03-16 Thread Gedare Bloom
On Mon, Mar 16, 2020 at 9:11 AM Sebastian Huber wrote: > > --- > eng/management.rst | 1 + > eng/python-devel.rst | 136 > +++ > 2 files changed, 137 insertions(+) > create mode 100644 eng/python-devel.rst > > diff --git a/eng/management.rst

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-16 Thread Amar Takhar
I should have also added some of my own reasons why pytest is better for writing tests in Python: - Fantastic exception handling makes it far easier to debug test and code. PDB works seamlessly. - Far less overhead in creating initial tests. - Trivial fixture support -

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-16 Thread Amar Takhar
On 2020-03-16 09:34 +0100, Sebastian Huber wrote: > On 16/03/2020 00:57, Amar Takhar wrote: > > On 2020-03-16 09:20 +1100, Chris Johns wrote: > > Is pytest installed by default? > > No. It's a separate package the Python has 'unittest' which is shipped by > default. For

RTEMS Docs: Adding GSoC Getting Started Instructions

2020-03-16 Thread Niteesh G. S.
I am interested in taking up #3907 . I'll mostly be copying and updating the contents from the old wiki site. I have the following plan in mind. I'll start working on it if you are happy with it. Add a new gsoc section in the user manual

Re: BSP Wiki Clean Up

2020-03-16 Thread Mritunjay Sharma
The updated list of to be removed BSPs. Please check: To be removed BSPs ARM BSPs 1) Cogent CSB637 --csb637 2) Cogent Kit637_v6 -- kit637 v6 3) GamePark? Holdings GP2X -- gp2x Motorola M68xxx and Coldfire BSPs 1) Generic MC68302 -- gen68302 2) ods68302 MIPS BSPs 1) Generic IDT 4600 -- p4000 2)

Re: What sanitizers preferred?

2020-03-16 Thread Gedare Bloom
On Mon, Mar 16, 2020 at 10:55 AM Joel Sherrill wrote: > > > > On Mon, Mar 16, 2020 at 11:05 AM Sebastian Huber > wrote: >> >> On 15/03/2020 17:52, suyash singh wrote: >> >> Hello, >> Out of >> AddressSanitizer, ThreadSanitizer, MemorySanitizer, and DataFlowSanitizer. >> >> Are all of them

Re: [PATCH 1/1] eng: Add Python development guidelines

2020-03-16 Thread Gedare Bloom
On Mon, Mar 16, 2020 at 9:11 AM Sebastian Huber wrote: > > --- > eng/management.rst | 1 + > eng/python-devel.rst | 136 > +++ > 2 files changed, 137 insertions(+) > create mode 100644 eng/python-devel.rst > > diff --git a/eng/management.rst

Re: BSP Wiki Clean Up

2020-03-16 Thread Mritunjay Sharma
Okay, actually I looked only under https://git.rtems.org/rtems/tree/bsps/arm/ (and others like i386) and now that I know that I have to look deeper, will make a correction and send it here. On Mon, Mar 16, 2020 at 11:23 PM Joel Sherrill

Re: BSP Wiki Clean Up

2020-03-16 Thread Joel Sherrill
On Mon, Mar 16, 2020, 12:01 PM Mritunjay Sharma < mritunjaysharma...@gmail.com> wrote: > Working on #3905 (Clean up BSP Wiki Pages), I have made a list of BSPs > that are not now part of the source tree and recommending them to delete > them and I would like to @rtems-de...@rtems.org to have > a

Re: BSP Wiki Clean Up

2020-03-16 Thread Mritunjay Sharma
Working on #3905 (Clean up BSP Wiki Pages), I have made a list of BSPs that are not now part of the source tree and recommending them to delete them and I would like to @rtems-de...@rtems.org to have a look of it : To be removed BSPs ARM BSPs 1) Cogent CSB637 --csb637 2) Cogent Kit637_v6 --

Re: What sanitizers preferred?

2020-03-16 Thread Joel Sherrill
On Mon, Mar 16, 2020 at 11:05 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 15/03/2020 17:52, suyash singh wrote: > > Hello, > Out of > AddressSanitizer , > ThreadSanitizer ,

Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-16 Thread Amar Takhar
On 2020-03-16 09:40 +0100, Sebastian Huber wrote: > > I work currently on a draft for the Python development guidelines for the > engineering manual. I hope to have something ready for review in the next > days. > > Documenting the tests with with pydoc strings in general would be overkill >

Re: What sanitizers preferred?

2020-03-16 Thread Sebastian Huber
On 15/03/2020 17:52, suyash singh wrote: Hello, Out of AddressSanitizer , ThreadSanitizer , MemorySanitizer , and DataFlowSanitizer

Re: [RFC] RTEMS Waf Clang support

2020-03-16 Thread Sebastian Huber
On 16/03/2020 14:59, Hesham Almatary wrote: On Mon, 16 Mar 2020 at 13:35, Sebastian Huber wrote: On 16/03/2020 14:33, Hesham Almatary wrote: Sebastian, I modified my patch set to properly add the XLEN option. This should make it generic enough for other architectures to be built with

Re: Issues when adding a multi-port PCI serial card

2020-03-16 Thread Sebastian Huber
On 13/03/2020 20:16, dufa...@hda.com wrote: On Mar 13, 2020, at 08:42 , Sebastian Huber wrote: Thanks for replying. On 12/03/2020 21:44, Peter Dufault wrote: I've added an 8-port RS232 PCI Mezzanine Card to the "beatnik" BSP. The console (aka serial port) code is confusing. I

[PATCH 1/1] eng: Add Python development guidelines

2020-03-16 Thread Sebastian Huber
--- eng/management.rst | 1 + eng/python-devel.rst | 136 +++ 2 files changed, 137 insertions(+) create mode 100644 eng/python-devel.rst diff --git a/eng/management.rst b/eng/management.rst index 064559c..6eb4217 100644 ---

[PATCH 0/1] Add Python development guidelines

2020-03-16 Thread Sebastian Huber
This is a first draft of the Python development guildelines for the RTEMS Software Engineering manual. For the static analysis tools flake8, pylint, and mypy you can use configuration files. I would start with the default configuration. For pylint, you can dump the default configuration with

[PATCH rtems-docs] user/raspberrypi: Fix typo

2020-03-16 Thread G S Niteesh Babu
enable-uart should be enable_uart in config.txt --- user/bsps/arm/raspberrypi.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/user/bsps/arm/raspberrypi.rst b/user/bsps/arm/raspberrypi.rst index 72889a5..c26f4b5 100644 --- a/user/bsps/arm/raspberrypi.rst +++

Re: Project Query for #3855 (BSP Buildset for EPICS)

2020-03-16 Thread Mritunjay Sharma
On Mon, Mar 9, 2020 at 9:17 PM Gedare Bloom wrote: > On Mon, Mar 9, 2020 at 7:31 AM Mritunjay Sharma > wrote: > > > > Thank you, Chris, for such a detailed description of my query. > > Yes, sure. I would be more than happy to help with this fantastic idea > proposed by Joel. I think I need to

Re: [RFC] RTEMS Waf Clang support

2020-03-16 Thread Hesham Almatary
On Mon, 16 Mar 2020 at 13:35, Sebastian Huber wrote: > > On 16/03/2020 14:33, Hesham Almatary wrote: > > > Sebastian, I modified my patch set to properly add the XLEN option. > > This should make it generic enough for other architectures to be built > > with Clang/LLVM, but I have only tested

Re: [RFC] RTEMS Waf Clang support

2020-03-16 Thread Sebastian Huber
On 16/03/2020 14:33, Hesham Almatary wrote: Sebastian, I modified my patch set to properly add the XLEN option. This should make it generic enough for other architectures to be built with Clang/LLVM, but I have only tested RISC-V. I can git send-email if you want me to.

Re: [RFC] RTEMS Waf Clang support

2020-03-16 Thread Hesham Almatary
Sebastian, I modified my patch set to properly add the XLEN option. This should make it generic enough for other architectures to be built with Clang/LLVM, but I have only tested RISC-V. I can git send-email if you want me to. [1]

Re: [RFC] RTEMS Waf Clang support

2020-03-16 Thread Hesham Almatary
On Mon, 16 Mar 2020 at 12:54, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > On 16/03/2020 13:51, Hesham Almatary wrote: > > Thanks Sebastian! > > I tried to follow your instructions for adding this as a new option, but > unfortunately, XLEN didn't evaluate for

Re: [RFC] RTEMS Waf Clang support

2020-03-16 Thread Sebastian Huber
On 16/03/2020 13:51, Hesham Almatary wrote: Thanks Sebastian! I tried to follow your instructions for adding this as a new option, but unfortunately, XLEN didn't evaluate for RTEMS-BUILD-CPUKIT-OPTCLANG to use. Here's the diff: diff --git

Re: [RFC] RTEMS Waf Clang support

2020-03-16 Thread Hesham Almatary
Thanks Sebastian! I tried to follow your instructions for adding this as a new option, but unfortunately, XLEN didn't evaluate for RTEMS-BUILD-CPUKIT-OPTCLANG to use. Here's the diff: diff --git a/spec/build/cpukit/RTEMS-BUILD-CPUKIT-OPTXLEN.yml >

Re: [RFC] RTEMS Waf Clang support

2020-03-16 Thread Sebastian Huber
On 16/03/2020 13:09, Hesham Almatary wrote: On Mon, 16 Mar 2020 at 11:53, Sebastian Huber wrote: On 16/03/2020 12:39, Hesham Almatary wrote: Hi Sebastian, I have pushed a few commits to my repo to support building RTEMS with Clang/LLVM for RISC-V. Here are the changes [1]. Since I'm still

Re: [RFC] RTEMS Waf Clang support

2020-03-16 Thread Hesham Almatary
On Mon, 16 Mar 2020 at 11:53, Sebastian Huber wrote: > > On 16/03/2020 12:39, Hesham Almatary wrote: > > > Hi Sebastian, > > > > I have pushed a few commits to my repo to support building RTEMS with > > Clang/LLVM for RISC-V. Here are the changes [1]. Since I'm still > > learning about Waf and

Re: [RFC] RTEMS Waf Clang support

2020-03-16 Thread Sebastian Huber
On 16/03/2020 12:39, Hesham Almatary wrote: Hi Sebastian, I have pushed a few commits to my repo to support building RTEMS with Clang/LLVM for RISC-V. Here are the changes [1]. Since I'm still learning about Waf and the build system, I'd appreciate your input. Most importantly, I want to know

[RFC] RTEMS Waf Clang support

2020-03-16 Thread Hesham Almatary
Hi Sebastian, I have pushed a few commits to my repo to support building RTEMS with Clang/LLVM for RISC-V. Here are the changes [1]. Since I'm still learning about Waf and the build system, I'd appreciate your input. Most importantly, I want to know what's the right way to set "target" and "xlen"

[PATCH 08/12] record: Add base64 filter class

2020-03-16 Thread Sebastian Huber
Update #3904. --- trace/record/client.h| 20 +++ trace/record/record-filter-base64.cc | 103 +++ trace/wscript| 1 + 3 files changed, 124 insertions(+) create mode 100644 trace/record/record-filter-base64.cc diff

[PATCH 12/12] record: Increase input buffer and alignment

2020-03-16 Thread Sebastian Huber
Update #3904. --- trace/record/record-client-base.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace/record/record-client-base.cc b/trace/record/record-client-base.cc index f022db4..fa75f53 100644 --- a/trace/record/record-client-base.cc +++

[PATCH 00/12] record: Add support for base64 and zlib compressed input

2020-03-16 Thread Sebastian Huber
Sebastian Huber (12): record: Fix format record: Guard config.h include record: Format file header record: Add INI file parser record: Add support for user defined event names record: Add option to print config default values record: Add filter base class record: Add base64 filter

[PATCH 03/12] record: Format file header

2020-03-16 Thread Sebastian Huber
Update #3904. --- trace/record/client.h | 6 +++--- trace/record/record-client-base.cc | 6 +++--- trace/record/record-main-lttng.cc | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/trace/record/client.h b/trace/record/client.h index a865a18..fc240ca 100644

[PATCH 11/12] record: Add support for zlib compressed input

2020-03-16 Thread Sebastian Huber
Update #3904. --- trace/record/record-main-lttng.cc | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/trace/record/record-main-lttng.cc b/trace/record/record-main-lttng.cc index 7d974af..7cfa48c 100644 --- a/trace/record/record-main-lttng.cc +++

[PATCH 10/12] record: Add zlib filter class

2020-03-16 Thread Sebastian Huber
Update #3904. --- trace/record/client.h | 24 trace/record/record-filter-zlib.cc | 77 ++ trace/wscript | 5 +++ 3 files changed, 106 insertions(+) create mode 100644 trace/record/record-filter-zlib.cc diff

[PATCH 09/12] record: Add support for base64 encoded input

2020-03-16 Thread Sebastian Huber
Update #3904. --- trace/record/record-main-lttng.cc | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/trace/record/record-main-lttng.cc b/trace/record/record-main-lttng.cc index 15536f4..7d974af 100644 --- a/trace/record/record-main-lttng.cc +++

[PATCH 04/12] record: Add INI file parser

2020-03-16 Thread Sebastian Huber
Import from: https://github.com/benhoyt/inih commit 351217124ddb3e3fe2b982248a04c672350bb0af Author: Stephan Lachnit Date: Sun Mar 1 07:31:28 2020 +0100 r48 release (#100) * Bump copyright to 2020 * Remove makefile for static library * meson: version 48 Signed-off-by:

[PATCH 07/12] record: Add filter base class

2020-03-16 Thread Sebastian Huber
Update #3904. --- trace/record/client.h | 21 - trace/record/record-client-base.cc | 33 +++-- 2 files changed, 51 insertions(+), 3 deletions(-) diff --git a/trace/record/client.h b/trace/record/client.h index 2fe8d51..636fb0b 100644

[PATCH 06/12] record: Add option to print config default values

2020-03-16 Thread Sebastian Huber
Update #3904. --- trace/record/record-main-lttng.cc | 35 ++- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/trace/record/record-main-lttng.cc b/trace/record/record-main-lttng.cc index 891281e..15536f4 100644 --- a/trace/record/record-main-lttng.cc

[PATCH 05/12] record: Add support for user defined event names

2020-03-16 Thread Sebastian Huber
--- trace/record/client.h | 29 trace/record/record-client-base.cc | 40 ++ trace/record/record-main-lttng.cc | 145 - 3 files changed, 164 insertions(+), 50 deletions(-) diff --git a/trace/record/client.h

[PATCH 01/12] record: Fix format

2020-03-16 Thread Sebastian Huber
Update #3904. --- trace/record/record-main-lttng.cc | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/trace/record/record-main-lttng.cc b/trace/record/record-main-lttng.cc index c84f40b..a28de8e 100644 --- a/trace/record/record-main-lttng.cc +++

Re: [PATCH 1/2] Start converting tests to pytest.

2020-03-16 Thread Sebastian Huber
On 16/03/2020 00:58, Amar Takhar wrote: On 2020-03-14 11:12 +1100, Chris Johns wrote: I would like to hear what Sebastian is considering for the ESA work. I think we should follow what will be done there and ends up in the engineering manual. If this is in regard to pytests that are being

Re: [PATCH 2/2] Add a message to run 'pytest' to run rest of test suite.

2020-03-16 Thread Sebastian Huber
On 16/03/2020 00:57, Amar Takhar wrote: On 2020-03-16 09:20 +1100, Chris Johns wrote: Is pytest installed by default? No. It's a separate package the Python has 'unittest' which is shipped by default. For our usage pyttest is more flexible and will create concise code that is easy to

Re: [PATCH v2] Start conversion tests to using pytest.

2020-03-16 Thread Gedare Bloom
Thanks On Sun, Mar 15, 2020 at 10:21 PM Amar Takhar wrote: > > error.py: > - Check for exceptions and error messages. > > path.py: > - Test params and setting module variables. > > macros.py: > - Test class with setup and shared module access. > > host.py: > - Check host specific