Re: qemu5 and zynq console input

2020-12-01 Thread Joel Sherrill
On Tue, Dec 1, 2020 at 3:06 PM Chris Johns wrote: > On 2/12/20 3:29 am, Gedare Bloom wrote: > On Mon, Nov 30, 2020 at 4:59 PM Chris Johns > > wrote: > > > > On 1/12/20 10:25 am, Joel Sherrill wrote: > > > Does this combination work for anyone? I am suspicious

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-12-01 Thread Chris Johns
On 2/12/20 3:39 am, Gedare Bloom wrote: > > > On Tue, Dec 1, 2020 at 12:33 AM Sebastian Huber > > > wrote: > > On 01/12/2020 07:49, Chris Johns wrote: > > > On 1/12/20 5:31 pm, Sebastian Huber wrote: > >> On 30/11/2020 21:43, Joel

Re: qemu5 and zynq console input

2020-12-01 Thread Chris Johns
On 2/12/20 3:29 am, Gedare Bloom wrote: On Mon, Nov 30, 2020 at 4:59 PM Chris Johns > wrote: > > On 1/12/20 10:25 am, Joel Sherrill wrote: > > Does this combination work for anyone? I am suspicious that this broke > with the > > qemu version bump in the

[PATCH v1 3/3] Add AArch64 ZynpMP BSP

2020-12-01 Thread Kinsey Moore
This adds a BSP family that runs on the Xilinx Ultrascale+ MPSOC (ZynqMP) family of chips. It is configured to be usable on the Qemu ZCU102 machine definition and should be almost trivially portable to ZynqMP development boards and custom hardware. It is also configured to be usable with libbsd.

[PATCH v1 2/3] bsps: Move ARM GICv2 driver to bsps/shared

2020-12-01 Thread Kinsey Moore
This moves the ARM GICv2 driver to bsps/shared to be usable by AArch64 code. --- ...-gicv3-aarch64.c => irq-arm-gicvx-aarch64.c} | 2 +- ...-gicv3-aarch32.c => irq-arm-gicvx-aarch32.c} | 2 +- bsps/include/dev/irq/arm-gic-irq.h | 4 ++-- .../irq-gic.c =>

[PATCH v1 1/3] bsps: Move zynq-uart to bsps/shared

2020-12-01 Thread Kinsey Moore
This moves the zynq-uart driver from bsps/arm/shared to bsps/shared to accomodate use by AArch64 BSPs. --- bsps/arm/headers.am| 2 -- bsps/arm/xilinx-zynq/console/console-config.c | 2 +- bsps/arm/xilinx-zynq/console/console-init.c

Re: [PATCH 08/12] score: Always define RTEMSScoreMRSP group

2020-12-01 Thread Sebastian Huber
On 01/12/2020 17:48, Gedare Bloom wrote: I never realized the Doxygen picks up the CPP feature checks. That's really interesting. Yes, and there are some configuration options which control the pre-processing done by Doxygen. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178

Re: [PATCH] c-user: Clarify rtems_partition_delete()

2020-12-01 Thread Gedare Bloom
ok On Tue, Dec 1, 2020 at 8:50 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Move the PTCB sentence to the notes to be in line with > rtems_partition_create(). > > Update #3993. > --- > c-user/partition/directives.rst | 5 +++-- > 1 file changed, 3 insertions(+), 2

Re: [PATCH 00/12] Canonicalize @defgroup and @file comments

2020-12-01 Thread Gedare Bloom
I spot-checked, the set looks fine to me (and appears quite boring indeed). On Tue, Dec 1, 2020 at 1:10 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > This patch set removes some unused stuff and cleans up some minor things > which I noticed during the review. > > The main

Re: [PATCH 08/12] score: Always define RTEMSScoreMRSP group

2020-12-01 Thread Gedare Bloom
I never realized the Doxygen picks up the CPP feature checks. That's really interesting. On Tue, Dec 1, 2020 at 1:10 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > This fixes a Doxygen warning. > --- > cpukit/include/rtems/score/mrsp.h | 9 - > 1 file changed, 4

Re: qemu5 and zynq console input

2020-12-01 Thread Gedare Bloom
On Tue, Dec 1, 2020 at 9:37 AM Joel Sherrill wrote: > > > On Tue, Dec 1, 2020, 10:30 AM Gedare Bloom wrote: > >> >> >> On Mon, Nov 30, 2020 at 4:59 PM Chris Johns wrote: >> >>> On 1/12/20 10:25 am, Joel Sherrill wrote: >>> > Does this combination work for anyone? I am suspicious that this

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-12-01 Thread Gedare Bloom
On Tue, Dec 1, 2020 at 12:33 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 01/12/2020 07:49, Chris Johns wrote: > > > On 1/12/20 5:31 pm, Sebastian Huber wrote: > >> On 30/11/2020 21:43, Joel Sherrill wrote: > >>> On Mon, Nov 30, 2020 at 1:06 PM Sebastian Huber > >>> >>>

Re: qemu5 and zynq console input

2020-12-01 Thread Joel Sherrill
On Tue, Dec 1, 2020, 10:30 AM Gedare Bloom wrote: > > > On Mon, Nov 30, 2020 at 4:59 PM Chris Johns wrote: > >> On 1/12/20 10:25 am, Joel Sherrill wrote: >> > Does this combination work for anyone? I am suspicious that this broke >> with the >> > qemu version bump in the RSB. >> >> I did not

Re: qemu5 and zynq console input

2020-12-01 Thread Gedare Bloom
On Mon, Nov 30, 2020 at 4:59 PM Chris Johns wrote: > On 1/12/20 10:25 am, Joel Sherrill wrote: > > Does this combination work for anyone? I am suspicious that this broke > with the > > qemu version bump in the RSB. > > I did not test input. The tester does not have the ability to test input. > >

[PATCH] c-user: Clarify rtems_partition_delete()

2020-12-01 Thread Sebastian Huber
Move the PTCB sentence to the notes to be in line with rtems_partition_create(). Update #3993. --- c-user/partition/directives.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/c-user/partition/directives.rst b/c-user/partition/directives.rst index 9579877..8bccb09

[PATCH] c-user: Clarify rtems_partition_create()

2020-12-01 Thread Sebastian Huber
The rtems_partition_create() returns an object identifier and not just a partition identifier. Update #3993. --- c-user/partition/directives.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/c-user/partition/directives.rst b/c-user/partition/directives.rst index

Re: [PATCH rtems-docs] shell: Document i2c and spi commands.

2020-12-01 Thread Christian MAUDERER
Am 01.12.20 um 13:45 schrieb Peter Dufault: On Nov 30, 2020, at 18:07 , Gedare Bloom wrote: Aren't nearly all shell commands at least a bit unsafe? And we don't have a lot of commands that have to be explicitly turned on if CONFIGURE_SHELL_COMMANDS_ALL is already set. I found only

Re: [PATCH rtems-docs] shell: Document i2c and spi commands.

2020-12-01 Thread Peter Dufault
> On Nov 30, 2020, at 18:07 , Gedare Bloom wrote: > > Aren't nearly all shell commands at least a bit unsafe? And we don't > have a lot of commands that have to be explicitly turned on if > CONFIGURE_SHELL_COMMANDS_ALL is already set. I found only networking > commands. > > That seems

[PATCH rtems-docs v2] shell: Document i2c and spi commands.

2020-12-01 Thread Christian Mauderer
--- shell/general_commands.rst | 215 + 1 file changed, 215 insertions(+) diff --git a/shell/general_commands.rst b/shell/general_commands.rst index c74ae45..5913f54 100644 --- a/shell/general_commands.rst +++ b/shell/general_commands.rst @@ -44,6 +44,14 @@

[PATCH 09/12] rtems: Canonicalize Doxygen @file comments

2020-12-01 Thread Sebastian Huber
Use common phrases for the file brief descriptions. Update #3706. --- cpukit/include/rtems/rtems/asrimpl.h| 3 ++- cpukit/include/rtems/rtems/attrimpl.h | 3 ++- cpukit/include/rtems/rtems/barrierimpl.h| 3 ++- cpukit/include/rtems/rtems/clockimpl.h | 4

[PATCH 11/12] sapi: Canonicalize @defgroup and @file comments

2020-12-01 Thread Sebastian Huber
Adjust group identifier and names to be in line with a common pattern. Use common phrases for the group and file brief descriptions. Update #3706. --- cpukit/include/rtems/chain.h | 12 cpukit/include/rtems/counter.h | 4 ++-- cpukit/include/rtems/extension.h | 10

[PATCH 12/12] config: Canonicalize @defgroup and @file comments

2020-12-01 Thread Sebastian Huber
Adjust group identifier and names to be in line with a common pattern. Use common phrases for the group and file brief descriptions. Update #3706. --- cpukit/include/rtems/confdefs.h| 17 - cpukit/include/rtems/confdefs/bdbuf.h | 5 +++--

[PATCH 07/12] score: Canonicalize Doxygen groups

2020-12-01 Thread Sebastian Huber
Adjust group identifier and names to be in line with a common pattern. Use common phrases for the group brief descriptions. Update #3706. --- cpukit/include/rtems/score/address.h | 2 +- cpukit/include/rtems/score/apimutex.h | 5 -

[PATCH 06/12] rtems: Canonicalize implementation Doxygen groups

2020-12-01 Thread Sebastian Huber
Rename Classic API top-level group from Classic to RTEMSImplClassic. Use RTEMSImplClassic as a prefix for the subgroups. Change the group names to be in line with the API group names. Use common phrases for the group brief descriptions. Update #3706. --- cpukit/doxygen.h

[PATCH 08/12] score: Always define RTEMSScoreMRSP group

2020-12-01 Thread Sebastian Huber
This fixes a Doxygen warning. --- cpukit/include/rtems/score/mrsp.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/cpukit/include/rtems/score/mrsp.h b/cpukit/include/rtems/score/mrsp.h index e42c3a400c..678a678b14 100644 --- a/cpukit/include/rtems/score/mrsp.h +++

[PATCH 00/12] Canonicalize @defgroup and @file comments

2020-12-01 Thread Sebastian Huber
This patch set removes some unused stuff and cleans up some minor things which I noticed during the review. The main part is a canonicalization of the @defgroup and @file comments in rtems, sapi, and score. This was a quite mechancial and boaring task which coveres more than 600 files.

[PATCH 03/12] rtems: Simplify includes in version.c

2020-12-01 Thread Sebastian Huber
--- cpukit/sapi/src/version.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/sapi/src/version.c b/cpukit/sapi/src/version.c index 1afaf7fad9..9c10ff3823 100644 --- a/cpukit/sapi/src/version.c +++ b/cpukit/sapi/src/version.c @@ -24,8 +24,8 @@ #include "config.h"

[PATCH 05/12] rtems: Add

2020-12-01 Thread Sebastian Huber
--- bsps/arm/altera-cyclone-v/rtc/rtc.c| 1 + bsps/arm/lpc32xx/rtc/rtc-config.c | 1 + bsps/bfin/shared/dev/rtc.c | 1 + bsps/shared/dev/rtc/ds1375.c | 1 + bsps/shared/dev/rtc/rtc-support.c | 1 + cpukit/include/rtems/rtems/clock.h | 30 ---

[PATCH 01/12] score: Delete empty pheapinit.c

2020-12-01 Thread Sebastian Huber
--- cpukit/Makefile.am| 1 - cpukit/score/src/pheapinit.c | 24 spec/build/cpukit/librtemscpu.yml | 1 - 3 files changed, 26 deletions(-) delete mode 100644 cpukit/score/src/pheapinit.c diff --git a/cpukit/Makefile.am b/cpukit/Makefile.am index

[PATCH 04/12] shell: Rename "IO" typedef for better Doxygen

2020-12-01 Thread Sebastian Huber
An automatic link from every place in the documentation which mentions "IO" to this dd command internal "IO" typedef is not really nice. --- cpukit/libmisc/shell/dd.h| 4 ++-- cpukit/libmisc/shell/extern-dd.h | 4 ++-- cpukit/libmisc/shell/main_dd.c | 4 ++-- 3 files changed, 6

[PATCH 02/12] posix: Delete unused _POSIX_Fatal_error()

2020-12-01 Thread Sebastian Huber
--- cpukit/Makefile.am| 1 - cpukit/include/rtems/posix/posixapi.h | 18 --- cpukit/sapi/src/posixapi.c| 179 -- spec/build/cpukit/librtemscpu.yml | 1 - 4 files changed, 199 deletions(-) delete mode 100644