Re: [6-freebsd-12 PATCH v2 2/2] bsp/motorola_powerpc: Add dc and ukphy support

2021-02-15 Thread Chris Johns
On 16/2/21 5:06 pm, Sebastian Huber wrote: > On 16/02/2021 03:10, chr...@rtems.org wrote: > >> diff --git a/freebsd/sys/dev/dc/if_dcreg.h b/freebsd/sys/dev/dc/if_dcreg.h >> index 9ae26cc6..836e70f8 100644 >> --- a/freebsd/sys/dev/dc/if_dcreg.h >> +++ b/freebsd/sys/dev/dc/if_dcreg.h >> @@ -824,6

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-02-15 Thread Chris Johns
Hi Sebastian, Thank you for the review. On 16/2/21 5:05 pm, Sebastian Huber wrote: > > On 16/02/2021 03:02, chr...@rtems.org wrote: >> +/* >> + * Values for the bus space tag, not to be used directly by MI code. >> + */ >> +#define    BSP_BUS_SPACE_IO    0    /* space is i/o space */ >>

Re: [PATCH 3/4 v2] bsp/riscv: work area size based on stack pointer

2021-02-15 Thread Sebastian Huber
On 12/02/2021 09:50, Daniel Hellstrom wrote: From: Martin Aberg Remember the initial stack pointer in start.S. It can later be used to determine top of RAM. --- bsps/riscv/include/bsp/start.h | 65 ++

Re: [6-freebsd-12 PATCH v2 2/2] bsp/motorola_powerpc: Add dc and ukphy support

2021-02-15 Thread Sebastian Huber
On 16/02/2021 03:10, chr...@rtems.org wrote: diff --git a/freebsd/sys/dev/dc/if_dcreg.h b/freebsd/sys/dev/dc/if_dcreg.h index 9ae26cc6..836e70f8 100644 --- a/freebsd/sys/dev/dc/if_dcreg.h +++ b/freebsd/sys/dev/dc/if_dcreg.h @@ -824,6 +824,13 @@ struct dc_softc { */ #define

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-02-15 Thread Sebastian Huber
On 16/02/2021 03:02, chr...@rtems.org wrote: +/* + * Values for the bus space tag, not to be used directly by MI code. + */ +#defineBSP_BUS_SPACE_IO0 /* space is i/o space */ +#defineBSP_BUS_SPACE_MEM 1 /* space is mem space */ + +/* + * BSP PCI Support

Re: [PATCH v2] tests/validation: Fix 64bit test failure

2021-02-15 Thread Sebastian Huber
On 15/02/2021 22:34, Martin Erik Werner wrote: [...] I'm however wondering if this is the right way to fix this... I'm guessing that the failure mentioned is based on this specification in rtems-central : spec/rtems/message/req/construct-errors.yml 393 - enabled-by: true 394   

Re: [PATCH 0/1] misc: tools: fix mkimage.py script type processing

2021-02-15 Thread Chris Johns
On 12/2/21 3:23 am, Jan Sommer wrote: > Here is the patch from Andre also in git send-email format. Thanks. Pushed. > It would be great if we could integrate it in master and the 5 braches. I have created a ticket and pushed the change to the 5 branch. It would be a help if a ticket and tested

[5 PATCH] Update motorola_power to irq-generic interrupt management

2021-02-15 Thread chrisj
From: Chris Johns - Add support to the BSP to enable irq-generic management - Update the powerpc shared irq code to support irq-generic. This is an opt in option for existing powerpc bsps. This change should be simpler now - Fix a number of issues in ISA IRQ controller handling by porting

[6-freebsd-12 PATCH v2 2/2] bsp/motorola_powerpc: Add dc and ukphy support

2021-02-15 Thread chrisj
From: Chris Johns - Add the dc net dev to the BSP - Add the ukphy support Closes # 4246 --- freebsd/sys/dev/dc/if_dc.c| 7 freebsd/sys/dev/dc/if_dcreg.h | 7 rtemsbsd/include/bsp/nexus-devices.h | 4 +++

[6-freebsd-12 PATCH v2 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-02-15 Thread chrisj
From: Chris Johns - Add PCI IO region support - Add support map buffers to PCI address space Closes #4245 --- rtemsbsd/include/machine/bus.h| 124 ++ rtemsbsd/rtems/rtems-kernel-bus-dma.c | 5 +- rtemsbsd/rtems/rtems-kernel-nexus.c | 23 +++-- 3 files

Re: [6-freebsd-12 PATCH 2/2] bsp/motorola_powerpc: Add dc and ukphy support

2021-02-15 Thread Chris Johns
On 16/2/21 1:02 pm, chr...@rtems.org wrote: > From: Chris Johns > > - Add the dc net dev to the BSP > > - Add the ukphy support > > Closes # 4246 > --- > freebsd/sys/dev/dc/if_dc.c| 10 -- > freebsd/sys/dev/dc/if_dcreg.h | 7 >

[6-freebsd-12 PATCH 2/2] bsp/motorola_powerpc: Add dc and ukphy support

2021-02-15 Thread chrisj
From: Chris Johns - Add the dc net dev to the BSP - Add the ukphy support Closes # 4246 --- freebsd/sys/dev/dc/if_dc.c| 10 -- freebsd/sys/dev/dc/if_dcreg.h | 7 rtemsbsd/include/bsp/nexus-devices.h | 4 +++

[6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

2021-02-15 Thread chrisj
From: Chris Johns - Add PCI IO region support - Add support map buffers to PCI address space Closes #4245 --- rtemsbsd/include/machine/bus.h| 124 ++ rtemsbsd/rtems/rtems-kernel-bus-dma.c | 5 +- rtemsbsd/rtems/rtems-kernel-nexus.c | 23 +++-- 3 files

[PATCH 3/4] powerpc/motorola_powerpc: Enable bus PCI support in LibBSD

2021-02-15 Thread chrisj
From: Chris Johns Updates #4245 --- bsps/powerpc/motorola_powerpc/include/bsp.h | 4 1 file changed, 4 insertions(+) diff --git a/bsps/powerpc/motorola_powerpc/include/bsp.h b/bsps/powerpc/motorola_powerpc/include/bsp.h index 62e740272a..af0e71471e 100644 ---

[PATCH 4/4] powerpc/motorola_powerpc: Add cache coherent memory to the allocator

2021-02-15 Thread chrisj
From: Chris Johns Updates #4245 Updates #4243 --- bsps/powerpc/motorola_powerpc/start/bspstart.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/bsps/powerpc/motorola_powerpc/start/bspstart.c b/bsps/powerpc/motorola_powerpc/start/bspstart.c index ef8418e2c6..a781297565 100644 ---

[PATCH 2/4] powerpc/io: Make [out/in] le and be calls conditional

2021-02-15 Thread chrisj
From: Chris Johns - These calls clash with the Linux IO header in LibBSD. Making these conditional here means BSPs build and the imported Linux header is untouched. Updates #4245 --- bsps/powerpc/include/libcpu/io.h | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 1/4] powerpc/shared: Fix warnings in i8259 PIC code.

2021-02-15 Thread chrisj
From: Chris Johns --- bsps/powerpc/shared/irq/i8259.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/bsps/powerpc/shared/irq/i8259.c b/bsps/powerpc/shared/irq/i8259.c index 6a80e24946..37cbc360de 100644 --- a/bsps/powerpc/shared/irq/i8259.c +++ b/bsps/powerpc/shared/irq/i8259.c @@

RE: [PATCH v2] tests/validation: Fix 64bit test failure

2021-02-15 Thread Kinsey Moore
On Mon, 2021-02-15 at 3:35pm, Martin Erik Werner wrote: > On Mon, 2021-02-15 at 09:19 -0600, Kinsey Moore wrote: >> From: Ryan Long >> >> The ts-validation-0 test currently fails on 64bit BSPs due to a >> limitation of the message structure. Changing the max message size to a >> size_t type and

Re: [PATCH v2] tests/validation: Fix 64bit test failure

2021-02-15 Thread Martin Erik Werner
On Mon, 2021-02-15 at 09:19 -0600, Kinsey Moore wrote: > From: Ryan Long > > The ts-validation-0 test currently fails on 64bit BSPs due to a > limitation of the message structure. Changing the max message size to a > size_t type and adjusting the expected value in the test resolves this. This

RE: [PATCH v2] tests/validation: Fix 64bit test failure

2021-02-15 Thread Kinsey Moore
The email address got fixed here in v2. We were just responding on the original one. Kinsey -Original Message- From: devel On Behalf Of Kinsey Moore Sent: Monday, February 15, 2021 09:20 To: devel@rtems.org Subject: [PATCH v2] tests/validation: Fix 64bit test failure From: Ryan Long

Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-02-15 Thread Joel Sherrill
Christian submitted a series of patches to eliminate unicode. I'd prefer if we avoided it On Mon, Feb 15, 2021, 8:20 AM Peter Dufault wrote: > An international project should allow UTF in source code. You might need > to hunt what setting you need (for gnome-terminal "export LANG=en_US.UTF-8"

Re: [PATCH] tests/validation: Fix 64bit test failure

2021-02-15 Thread Chris Johns
On 16/2/21 2:12 am, Kinsey Moore wrote: > From: ryan long The email address looks wrong to me. Chris > > The ts-validation-0 test currently fails on 64bit BSPs due to a > limitation of the message structure. Changing the max message size to a > size_t type and adjusting the expected value in

RE: [PATCH] tests/validation: Fix 64bit test failure

2021-02-15 Thread Kinsey Moore
I’m not sure this patch reasonably backports to 5. There have been some changes in the organization of the message code and the modifications here are relevant to the message queue config structure that was added. The function signatures could be updated, but the remainder does not apply.

Re: [PATCH] tests/validation: Fix 64bit test failure

2021-02-15 Thread Joel Sherrill
Should this have a ticket and be applied to 5 also? There are other 64 bit architectures but they don't get tested as often and thoroughly. On Mon, Feb 15, 2021, 9:12 AM Kinsey Moore wrote: > From: ryan long > > The ts-validation-0 test currently fails on 64bit BSPs due to a > limitation of

[PATCH v2] tests/validation: Fix 64bit test failure

2021-02-15 Thread Kinsey Moore
From: Ryan Long The ts-validation-0 test currently fails on 64bit BSPs due to a limitation of the message structure. Changing the max message size to a size_t type and adjusting the expected value in the test resolves this. Closes #4179. --- cpukit/include/rtems/rtems/message.h

[PATCH] tests/validation: Fix 64bit test failure

2021-02-15 Thread Kinsey Moore
From: ryan long The ts-validation-0 test currently fails on 64bit BSPs due to a limitation of the message structure. Changing the max message size to a size_t type and adjusting the expected value in the test resolves this. Closes #4179. --- cpukit/include/rtems/rtems/message.h

Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-02-15 Thread Peter Dufault
An international project should allow UTF in source code. You might need to hunt what setting you need (for gnome-terminal "export LANG=en_US.UTF-8" works for me in the US). I'm surprised if anyone is working on a system that can't at least display UTF-8. > On Feb 15, 2021, at 03:21 ,

RE: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-02-15 Thread Jan.Sommer
Hi Chris, > -Original Message- > From: Chris Johns > Sent: Sunday, February 14, 2021 10:20 PM > To: Sommer, Jan ; devel@rtems.org > Subject: Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi > > Hi Jan, > > Thank you for the changes. I have one question inlined below