Re: [PATCH v8] rtems-debugger: Fixed 32bit pointers

looks good to me On Fri, May 14, 2021 at 11:57 AM Stephen Clark wrote: > > Using 32bit types like uint32_t for pointers creates issues on 64 bit > architectures like AArch64. Replaced occurrences of these with > uintptr_t, which will work for both 32 and 64 bit architectures. Added >

Re: [PATCH] score: Add and use _Per_CPU_Is_ISR_in_progress()

ok On Fri, May 14, 2021 at 9:36 AM Sebastian Huber wrote: > > Add _Per_CPU_Is_ISR_in_progress() as an optimized version of > _ISR_Is_in_progress(). > --- > cpukit/include/rtems/score/isr.h | 12 > cpukit/include/rtems/score/isrlevel.h | 11 +++ >

Re: [PATCH] score: Improve parameters in _Thread_Change_life()

thanks, looks good On Fri, May 14, 2021 at 9:05 AM Sebastian Huber wrote: > > --- > cpukit/include/rtems/score/threadimpl.h | 22 ++- > cpukit/score/src/threadrestart.c| 29 +++-- > 2 files changed, 29 insertions(+), 22 deletions(-) > > diff --git

[PATCH v8] rtems-debugger: Fixed 32bit pointers

Using 32bit types like uint32_t for pointers creates issues on 64 bit architectures like AArch64. Replaced occurrences of these with uintptr_t, which will work for both 32 and 64 bit architectures. Added hex_decode_addr function to rtems-debugger. --- cpukit/libdebugger/rtems-debugger-server.c |

[PATCH v4 4/5] psx13: Added tests for utimensat() and futimens()

Improved tests for utime() and utimes() and update license. Close #4399 --- testsuites/psxtests/psx13/main.c | 5 +- testsuites/psxtests/psx13/test.c | 499 +-- 2 files changed, 481 insertions(+), 23 deletions(-) diff --git

[PATCH v4 5/5] Change filesystem utime_h handler to utimens_h

Also updated licenses. Closes #4400 --- bsps/arm/csb337/umon/tfsDriver.c| 2 +- cpukit/Makefile.am | 4 +- cpukit/include/rtems/confdefs/libio.h | 4 +- cpukit/include/rtems/imfs.h | 35 - cpukit/include/rtems/libio.h

[PATCH v4 1/5] libcsupport: Added futimens() and utimensat()

Created futimens.c and utimensat.c to add support for the POSIX methods futimens() and utimensat(). utime() and utimes() are considered obsolote by POSIX, but RTEMS will continue to support them. Closes #4396 --- cpukit/Makefile.am | 2 + cpukit/include/rtems/libio_.h

[PATCH v4 3/5] libcsupport: Implement utimes() in terms of utimensat()

utimes() now calls utimensat() to update file access and modification timestamps. Updated license. Closes #4398 --- cpukit/libcsupport/src/utimes.c | 62 - 1 file changed, 49 insertions(+), 13 deletions(-) diff --git a/cpukit/libcsupport/src/utimes.c

[PATCH v4 0/5] Add nanosecond support patch

Hi, Here are the patches with the requested changes. In this iteration, I: - Used timespec macros and defined constants - Updated more file copyrights - Fixed some wording - changed rtems_filesystem_utime_check_times() to rtems_filesystem_utime_update() Thanks, Ryan Ryan Long (5):

[PATCH v4 2/5] libcsupport: Implement utime() in terms of utimensat()

utime() now calls utimensat() to update file access and modification timestamps. Updated license. Closes #4397 --- cpukit/libcsupport/src/utime.c | 75 +++--- 1 file changed, 42 insertions(+), 33 deletions(-) diff --git a/cpukit/libcsupport/src/utime.c

[PATCH] score: Add and use _Per_CPU_Is_ISR_in_progress()

Add _Per_CPU_Is_ISR_in_progress() as an optimized version of _ISR_Is_in_progress(). --- cpukit/include/rtems/score/isr.h | 12 cpukit/include/rtems/score/isrlevel.h | 11 +++ cpukit/include/rtems/score/percpu.h | 10 ++ cpukit/score/src/threadrestart.c |

[PATCH] score: Improve parameters in _Thread_Change_life()

--- cpukit/include/rtems/score/threadimpl.h | 22 ++- cpukit/score/src/threadrestart.c| 29 +++-- 2 files changed, 29 insertions(+), 22 deletions(-) diff --git a/cpukit/include/rtems/score/threadimpl.h b/cpukit/include/rtems/score/threadimpl.h index

Re: [PATCH v3 1/5] libcsupport: Added futimens() and utimensat()

On Fri, May 14, 2021 at 8:49 AM Ryan Long wrote: > > Reply is below. > > -Original Message- > From: Gedare Bloom > Sent: Wednesday, May 12, 2021 12:34 PM > To: Ryan Long > Cc: devel@rtems.org > Subject: Re: [PATCH v3 1/5] libcsupport: Added futimens() and utimensat() > > On Wed, May 12,

Re: [PATCH 2/2] rtems: Fix task restart within interrupt context

These 2 patches are fine. Although it is an internal interface, you might make the 'ignore' parameter 'ignore_mask' maybe. My initial thought when I see 'ignore' is that variable is ignored/unused, not that it contains the states to ignore. Since the function is internal and has no documentation,

RE: [PATCH v3 1/5] libcsupport: Added futimens() and utimensat()

Reply is below. -Original Message- From: Gedare Bloom Sent: Wednesday, May 12, 2021 12:34 PM To: Ryan Long Cc: devel@rtems.org Subject: Re: [PATCH v3 1/5] libcsupport: Added futimens() and utimensat() On Wed, May 12, 2021 at 7:33 AM Ryan Long wrote: > > Created futimens.c and

Re: Inconsistent behaviour with respect to the ticks in the *_when() directives

On Fri, May 14, 2021 at 12:26 AM Sebastian Huber wrote: > > Hello, > > I noticed that we have an inconsistent behaviour with respect to the > handling of the ticks member in the *_when() directives. In all *_when() > directives the ticks member is not used to calculate the watchdog > expiration

[PATCH 1/2] rtems: Always set the real priority during restart

Unconditionally set the real priority of the task to its initial priority during a task restart. Close #4411. --- cpukit/score/src/threadrestart.c | 58 ++-- 1 file changed, 32 insertions(+), 26 deletions(-) diff --git a/cpukit/score/src/threadrestart.c

[PATCH 2/2] rtems: Fix task restart within interrupt context

rtems_task_restart() may be called from within interrupt context. So checking only that the thread to restart is equal to the executing thread is insufficient to determine a self restart. We have to also check that no ISR is in progress. Merge _Thread_Restart_other() and _Thread_Restart_self()

[PATCH 0/2] Fix two rtems_task_restart() issues

Sebastian Huber (2): rtems: Always set the real priority during restart rtems: Fix task restart within interrupt context cpukit/include/rtems/score/threadimpl.h | 15 +--- cpukit/rtems/src/taskrestart.c | 8 +- cpukit/score/src/threadrestart.c| 114

Inconsistent behaviour with respect to the ticks in the *_when() directives

Hello, I noticed that we have an inconsistent behaviour with respect to the handling of the ticks member in the *_when() directives. In all *_when() directives the ticks member is not used to calculate the watchdog expiration time, see also: