Re: [PATCH v3] score/aarch64: Align context validation frame

2021-05-18 Thread Sebastian Huber
On 18/05/2021 22:18, Kinsey Moore wrote: Looks like this fell through the cracks last month and I totally forgot about it. The patch looks good. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741

Re: Heavy SysInit Dependency

2021-05-18 Thread Sebastian Huber
Hello Joel, On 18/05/2021 23:40, Joel Sherrill wrote: Hi In working with Alex to reduce the minimum on his new BSP, we noticed that it is easy for a BSP to accidentally trip up and end up with a minimum.exe that is as much as 2x over what it should be. I have looked at a few BSPs and seen a

Re: [PATCH] tester: Avoid TFTP race condition

2021-05-18 Thread Chris Johns
Ok to push. On 18/5/21 6:29 am, Kinsey Moore wrote: > The u-boot TFTP client will fail a fully completed file retrieval if the > final ACK gets an ICMP response that the port is unavailable which can > occur if the port is closed before the ACK arrives from the client. This > change causes the

[PATCH v7 5/5] Change filesystem utime_h handler to utimens_h

2021-05-18 Thread Ryan Long
Also updated licenses. Closes #4400 Updates #3899 --- bsps/arm/csb337/umon/tfsDriver.c| 2 +- cpukit/Makefile.am | 4 +- cpukit/include/rtems/confdefs/libio.h | 4 +- cpukit/include/rtems/imfs.h | 35 -

[PATCH v7 4/5] psx13: Added tests for utimensat() and futimens()

2021-05-18 Thread Ryan Long
Improved tests for utime() and utimes() and update license. Close #4399 --- testsuites/psxtests/psx13/main.c | 5 +- testsuites/psxtests/psx13/test.c | 499 +-- 2 files changed, 482 insertions(+), 22 deletions(-) diff --git

[PATCH v7 3/5] libcsupport: Implement utimes() in terms of utimensat()

2021-05-18 Thread Ryan Long
utimes() now calls utimensat() to update file access and modification timestamps. Updated license. Closes #4398 --- cpukit/libcsupport/src/utimes.c | 63 - 1 file changed, 49 insertions(+), 14 deletions(-) diff --git a/cpukit/libcsupport/src/utimes.c

[PATCH v7 2/5] libcsupport: Implement utime() in terms of utimensat()

2021-05-18 Thread Ryan Long
utime() now calls utimensat() to update file access and modification timestamps. Updated license. Closes #4397 --- cpukit/libcsupport/src/utime.c | 72 +++--- 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/cpukit/libcsupport/src/utime.c

[PATCH v7 0/5] Add nanosecond support patch

2021-05-18 Thread Ryan Long
Hi, For this series of patches, I - Added the SPDX clause that had been accidentally removed in main.c - Removed the extra space in the clause Thanks, Ryan Ryan Long (5): libcsupport: Added futimens() and utimensat() libcsupport: Implement utime() in terms of utimensat() libcsupport:

[PATCH v7 1/5] libcsupport: Added futimens() and utimensat()

2021-05-18 Thread Ryan Long
Created futimens.c and utimensat.c to add support for the POSIX methods futimens() and utimensat(). utime() and utimes() are considered obsolote by POSIX, but RTEMS will continue to support them. Closes #4396 --- cpukit/Makefile.am | 2 + cpukit/include/rtems/libio_.h

RE: [PATCH v6 4/5] psx13: Added tests for utimensat() and futimens()

2021-05-18 Thread Ryan Long
-Original Message- From: Gedare Bloom Sent: Tuesday, May 18, 2021 3:15 PM To: Ryan Long Cc: devel@rtems.org Subject: Re: [PATCH v6 4/5] psx13: Added tests for utimensat() and futimens() On Tue, May 18, 2021 at 2:03 PM Ryan Long wrote: > > Improved tests for utime() and utimes() and

Heavy SysInit Dependency

2021-05-18 Thread Joel Sherrill
Hi In working with Alex to reduce the minimum on his new BSP, we noticed that it is easy for a BSP to accidentally trip up and end up with a minimum.exe that is as much as 2x over what it should be. I have looked at a few BSPs and seen a handful of issues so far. I have patches pending for some.

Re: [PATCH v3] score/aarch64: Align context validation frame

2021-05-18 Thread Gedare Bloom
On Tue, May 18, 2021 at 3:05 PM Gedare Bloom wrote: > > On Tue, May 18, 2021 at 2:18 PM Kinsey Moore wrote: > > > > Looks like this fell through the cracks last month and I totally forgot > > about it. > > > > -Original Message- > > From: Kinsey Moore > > Sent: Tuesday, April 13, 2021

Re: [PATCH v3] score/aarch64: Align context validation frame

2021-05-18 Thread Gedare Bloom
On Tue, May 18, 2021 at 2:18 PM Kinsey Moore wrote: > > Looks like this fell through the cracks last month and I totally forgot about > it. > > -Original Message- > From: Kinsey Moore > Sent: Tuesday, April 13, 2021 10:15 > To: devel@rtems.org > Cc: Kinsey Moore > Subject: [PATCH v3]

Re: [PATCH v6 4/5] psx13: Added tests for utimensat() and futimens()

2021-05-18 Thread Gedare Bloom
On Tue, May 18, 2021 at 2:21 PM Joel Sherrill wrote: > > > > On Tue, May 18, 2021 at 3:03 PM Ryan Long wrote: >> >> Improved tests for utime() and utimes() and update license. >> >> Close #4399 >> --- >> testsuites/psxtests/psx13/main.c | 5 +- >> testsuites/psxtests/psx13/test.c | 499 >>

Re: [PATCH v6 4/5] psx13: Added tests for utimensat() and futimens()

2021-05-18 Thread Joel Sherrill
On Tue, May 18, 2021 at 3:03 PM Ryan Long wrote: > Improved tests for utime() and utimes() and update license. > > Close #4399 > --- > testsuites/psxtests/psx13/main.c | 5 +- > testsuites/psxtests/psx13/test.c | 499 > +-- > 2 files changed, 481

RE: [PATCH v3] score/aarch64: Align context validation frame

2021-05-18 Thread Kinsey Moore
Looks like this fell through the cracks last month and I totally forgot about it. -Original Message- From: Kinsey Moore Sent: Tuesday, April 13, 2021 10:15 To: devel@rtems.org Cc: Kinsey Moore Subject: [PATCH v3] score/aarch64: Align context validation frame Ensure the stack remains

Re: [PATCH v6 4/5] psx13: Added tests for utimensat() and futimens()

2021-05-18 Thread Gedare Bloom
On Tue, May 18, 2021 at 2:03 PM Ryan Long wrote: > > Improved tests for utime() and utimes() and update license. > > Close #4399 > --- > testsuites/psxtests/psx13/main.c | 5 +- > testsuites/psxtests/psx13/test.c | 499 > +-- > 2 files changed, 481

[PATCH v6 3/5] libcsupport: Implement utimes() in terms of utimensat()

2021-05-18 Thread Ryan Long
utimes() now calls utimensat() to update file access and modification timestamps. Updated license. Closes #4398 --- cpukit/libcsupport/src/utimes.c | 63 - 1 file changed, 49 insertions(+), 14 deletions(-) diff --git a/cpukit/libcsupport/src/utimes.c

[PATCH v6 2/5] libcsupport: Implement utime() in terms of utimensat()

2021-05-18 Thread Ryan Long
utime() now calls utimensat() to update file access and modification timestamps. Updated license. Closes #4397 --- cpukit/libcsupport/src/utime.c | 72 +++--- 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/cpukit/libcsupport/src/utime.c

[PATCH v6 5/5] Change filesystem utime_h handler to utimens_h

2021-05-18 Thread Ryan Long
Also updated licenses. Closes #4400 Updates #3899 --- bsps/arm/csb337/umon/tfsDriver.c| 2 +- cpukit/Makefile.am | 4 +- cpukit/include/rtems/confdefs/libio.h | 4 +- cpukit/include/rtems/imfs.h | 35 -

[PATCH v6 4/5] psx13: Added tests for utimensat() and futimens()

2021-05-18 Thread Ryan Long
Improved tests for utime() and utimes() and update license. Close #4399 --- testsuites/psxtests/psx13/main.c | 5 +- testsuites/psxtests/psx13/test.c | 499 +-- 2 files changed, 481 insertions(+), 23 deletions(-) diff --git

[PATCH v6 0/5] Add nanosecond support patch

2021-05-18 Thread Ryan Long
Hi, For this series of patches, I - Removed extra whitespace - Removed some changes made to licenses Thanks, Ryan Ryan Long (5): libcsupport: Added futimens() and utimensat() libcsupport: Implement utime() in terms of utimensat() libcsupport: Implement utimes() in terms of utimensat()

[PATCH v6 1/5] libcsupport: Added futimens() and utimensat()

2021-05-18 Thread Ryan Long
Created futimens.c and utimensat.c to add support for the POSIX methods futimens() and utimensat(). utime() and utimes() are considered obsolote by POSIX, but RTEMS will continue to support them. Closes #4396 --- cpukit/Makefile.am | 2 + cpukit/include/rtems/libio_.h

[PATCH - RTEMS 5] posix: Fix use of clock for relative times

2021-05-18 Thread Sebastian Huber
Close #4429. --- cpukit/posix/src/nanosleep.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/cpukit/posix/src/nanosleep.c b/cpukit/posix/src/nanosleep.c index 8d1a4b84e4..792d222e2b 100644 --- a/cpukit/posix/src/nanosleep.c +++

Re: [PATCH] riscv/console: console-config.c update

2021-05-18 Thread Sebastian Huber
On 05/05/2021 19:55, Somesh Deshmukh wrote: - Parsing the sub-node should be available generic not specific to Freedom Arty310 board. If we remove the Freedom Arty macro now, it will lose backward compatibility.The proposed change will retain the backward compatibility and also adds the

Re: [PATCH] tester: Avoid TFTP race condition

2021-05-18 Thread Gedare Bloom
On Tue, May 18, 2021 at 12:28 PM Kinsey Moore wrote: > > The socket timeout is already configured just above the while loop for > sending the bulk > of the data and applies to all blocking operations. It defaults to 1s locally > if not set. > ok, thanks, go ahead > Kinsey > > -Original

Re: [PATCH v5 5/5] Change filesystem utime_h handler to utimens_h

2021-05-18 Thread Gedare Bloom
On Mon, May 17, 2021 at 7:25 AM Ryan Long wrote: > > Also updated licenses. > > Closes #4400 Need: Updates #3899. > --- > bsps/arm/csb337/umon/tfsDriver.c| 2 +- > cpukit/Makefile.am | 4 +- > cpukit/include/rtems/confdefs/libio.h | 4 +- >

RE: [PATCH] tester: Avoid TFTP race condition

2021-05-18 Thread Kinsey Moore
The socket timeout is already configured just above the while loop for sending the bulk of the data and applies to all blocking operations. It defaults to 1s locally if not set. Kinsey -Original Message- From: Gedare Bloom Sent: Tuesday, May 18, 2021 10:54 To: Kinsey Moore Cc:

Re: [PATCH v5 1/5] libcsupport: Added futimens() and utimensat()

2021-05-18 Thread Gedare Bloom
On Mon, May 17, 2021 at 7:25 AM Ryan Long wrote: > > Created futimens.c and utimensat.c to add support for the POSIX > methods futimens() and utimensat(). > > utime() and utimes() are considered obsolote by POSIX, but RTEMS > will continue to support them. > > Closes #4396 > --- >

Re: [PATCH v2 2/2] score: Simplify thread queue timeout handling

2021-05-18 Thread Gedare Bloom
v2 set looks good to me On Tue, May 18, 2021 at 10:49 AM Sebastian Huber wrote: > > Add Thread_queue_Context::timeout_absolute to specify an absolute or > relative timeout. This avoid having to get the current time twice for > timeouts relative to the current time. It moves also functionality

Re: [PATCH 2/2] score: Simplify thread queue timeout handling

2021-05-18 Thread Peter Dufault
Good fix. > On May 18, 2021, at 09:04 , Sebastian Huber > wrote: > > Add Thread_queue_Context::timeout_absolute to specify an absolute or > relative timeout. This avoid having to get the current time twice for > timeouts relative to the current time. It moves also functionality to > common

[PATCH v2 2/2] score: Simplify thread queue timeout handling

2021-05-18 Thread Sebastian Huber
Add Thread_queue_Context::timeout_absolute to specify an absolute or relative timeout. This avoid having to get the current time twice for timeouts relative to the current time. It moves also functionality to common code. --- cpukit/include/rtems/score/threadq.h | 9 +-

[PATCH v2 1/2] posix: Fix use of clock for relative times

2021-05-18 Thread Sebastian Huber
Close #4426. --- cpukit/posix/src/clocknanosleep.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/cpukit/posix/src/clocknanosleep.c b/cpukit/posix/src/clocknanosleep.c index 951268bc1f..588f67a60a 100644 ---

Re: [PATCH 1/2] posix: Fix use of clock for relative times

2021-05-18 Thread Sebastian Huber
On 18/05/2021 18:05, Gedare Bloom wrote: } else { _Timecounter_Nanouptime( ); Shouldn't this also be _Timecounter_Nanotime( ) in case of using CLOCK_REALTIME? Yes, I will fix this. I didn't notice this, due to the changes in patch 2/2. -- embedded brains GmbH Herr Sebastian HUBER

Re: [PATCH 1/2] posix: Fix use of clock for relative times

2021-05-18 Thread Gedare Bloom
On Tue, May 18, 2021 at 7:05 AM Sebastian Huber wrote: > > Close #4426. > --- > cpukit/posix/src/clocknanosleep.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/cpukit/posix/src/clocknanosleep.c > b/cpukit/posix/src/clocknanosleep.c > index

Re: [PATCH] tester: Avoid TFTP race condition

2021-05-18 Thread Gedare Bloom
seems ok, but is there a way to set a timeout in case the client doesn't send a final ACK? Typical kind of network problem. On Mon, May 17, 2021 at 12:29 PM Kinsey Moore wrote: > > The u-boot TFTP client will fail a fully completed file retrieval if the > final ACK gets an ICMP response that

[PATCH 2/2] score: Simplify thread queue timeout handling

2021-05-18 Thread Sebastian Huber
Add Thread_queue_Context::timeout_absolute to specify an absolute or relative timeout. This avoid having to get the current time twice for timeouts relative to the current time. It moves also functionality to common code. --- cpukit/include/rtems/score/threadq.h | 9 +-

[PATCH 1/2] posix: Fix use of clock for relative times

2021-05-18 Thread Sebastian Huber
Close #4426. --- cpukit/posix/src/clocknanosleep.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/cpukit/posix/src/clocknanosleep.c b/cpukit/posix/src/clocknanosleep.c index 951268bc1f..eb7f231e86 100644 --- a/cpukit/posix/src/clocknanosleep.c

AW: question about posix timer expiration

2021-05-18 Thread Gabriel.Moyano
>From further investigation I've found that when a timer expires, >_POSIX_Timer_TSR() is called and this uses pthread_kill() to send a signal. >Shouldn't ptimer->inf.sigev_value be used here in order to create a siginfo_t >object with the right value? Did anyone have to deal with this while